Re: [U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-12 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message 4d562d0a.9060...@free.fr you wrote: I might argue that this is kind of a hack, and that rather than trying to prune the U_BOOT_VERSION string, one should define two macros, for instance: #define PLAIN_VERSION whatever #define U_BOOT_VERSION

Re: [U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-12 Thread Wolfgang Denk
Dear Kim Phillips, In message 20110211171117.b9b05b01.kim.phill...@freescale.com you wrote: On Fri, 11 Feb 2011 23:41:43 +0100 Wolfgang Denk w...@denx.de wrote: + case 'V': + /* +* Skip the U-Boot part in +

Re: [U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-12 Thread Kim Phillips
On Sat, 12 Feb 2011 10:37:16 +0100 Wolfgang Denk w...@denx.de wrote: Dear Kim Phillips, In message 20110211171117.b9b05b01.kim.phill...@freescale.com you wrote: On Fri, 11 Feb 2011 23:41:43 +0100 Wolfgang Denk w...@denx.de wrote: + case 'V': +

Re: [U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-12 Thread Kim Phillips
On Sat, 12 Feb 2011 07:47:38 +0100 Albert ARIBAUD albert.arib...@free.fr wrote: Le 12/02/2011 00:11, Kim Phillips a écrit : I'd have done it without magic nor comments as U_BOOT_VERSION[sizeof(U-Boot ) + 1] or even U_BOOT_VERSION[strlen(U-Boot )] The second one calls strlen() at

[U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-11 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk w...@denx.de --- v2: fix missing argument to printf() call. v3: explain the magic + 7 offset into the version string tools/mkimage.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/tools/mkimage.c b/tools/mkimage.c index

Re: [U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-11 Thread Kim Phillips
On Fri, 11 Feb 2011 23:41:43 +0100 Wolfgang Denk w...@denx.de wrote: + case 'V': + /* + * Skip the U-Boot part in + * U_BOOT_VERSION by adding 7 + */ +

Re: [U-Boot] [PATCH v3] mkimage: add -V option to print version information

2011-02-11 Thread Albert ARIBAUD
Le 12/02/2011 00:11, Kim Phillips a écrit : On Fri, 11 Feb 2011 23:41:43 +0100 Wolfgang Denkw...@denx.de wrote: +case 'V': +/* + * Skip the U-Boot part in + * U_BOOT_VERSION by adding 7