Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Wolfgang Denk
Dear Joe Hershberger, In message 1337108353-28086-2-git-send-email-joe.hershber...@ni.com you wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Remove volatile from eth driver API - Not using global

Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 21, 2012 at 2:05 AM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger, In message 1337108353-28086-2-git-send-email-joe.hershber...@ni.com you wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com ---

Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Wolfgang Denk
Dear Joe Hershberger, In message CANr=Z=zimqvn2vxp0_kma76o091tjfu4ck6wvf7re3hefmo...@mail.gmail.com you wrote: While getting rid of volatile is a good thing in general, I am worried about the test scope of this patch. I was too. That's why I asked for guidance: Sorry, this was a

Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 21, 2012 at 2:05 PM, Wolfgang Denk w...@denx.de wrote: Dear Joe Hershberger, In message CANr=Z=zimqvn2vxp0_kma76o091tjfu4ck6wvf7re3hefmo...@mail.gmail.com you wrote: While getting rid of volatile is a good thing in general, I am worried about the test scope of

Re: [U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-21 Thread Wolfgang Denk
Dear Joe Hershberger, In message CANr=Z=bmuwyjiDmXj1qjJ5hsKCfm15gbK2GbZNp8X2E=1km...@mail.gmail.com you wrote: The rule is that he who breaks the code is also responsible to fix it. Please make the code at least compile-clean again. Board maintainers will have to help with actual

[U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

2012-05-15 Thread Joe Hershberger
Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Changes for v2: - Remove volatile from eth driver API - Not using global NetRxPacket (since not casting away volatile) Changes for v3: include/net.h | 25 +