Re: [U-Boot] [PATCH v3 04/11] spi: cadence_qspi: Use #define for bits instead of bit shifts

2016-12-02 Thread Jagan Teki
On Wed, Nov 30, 2016 at 1:02 PM, Phil Edworthy wrote: > Hi Jagan, > > On 30 November 2016 04:59, Jagan Teki wrote: >> On Tue, Nov 29, 2016 at 6:28 PM, Phil Edworthy >> wrote: >> > Most of the code already uses #defines for the bit value,

Re: [U-Boot] [PATCH v3 04/11] spi: cadence_qspi: Use #define for bits instead of bit shifts

2016-11-29 Thread Phil Edworthy
Hi Jagan, On 30 November 2016 04:59, Jagan Teki wrote: > On Tue, Nov 29, 2016 at 6:28 PM, Phil Edworthy > wrote: > > Most of the code already uses #defines for the bit value, rather > > than the shift required to get the value. This changes the remaining > > code over.

Re: [U-Boot] [PATCH v3 04/11] spi: cadence_qspi: Use #define for bits instead of bit shifts

2016-11-29 Thread Jagan Teki
On Tue, Nov 29, 2016 at 6:28 PM, Phil Edworthy wrote: > Most of the code already uses #defines for the bit value, rather > than the shift required to get the value. This changes the remaining > code over. > > Whislt at it, fix the names of the "Rd Data Capture" register

[U-Boot] [PATCH v3 04/11] spi: cadence_qspi: Use #define for bits instead of bit shifts

2016-11-29 Thread Phil Edworthy
Most of the code already uses #defines for the bit value, rather than the shift required to get the value. This changes the remaining code over. Whislt at it, fix the names of the "Rd Data Capture" register defs. Signed-off-by: Phil Edworthy Acked-by: Marek Vasut