Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-19 Thread Codrin Constantin Ciubotariu
To: Ciubotariu Codrin Constantin-B43658 Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address On 08/13/2015 08:42 AM, Ciubotariu Codrin Constantin-B43658 wrote: Hi Joe, York, -Original

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-17 Thread Joe Hershberger
Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address On 08/13/2015 08:42 AM, Ciubotariu Codrin Constantin-B43658 wrote: Hi Joe, York, -Original Message- From: Sun York-R58495 Sent

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-17 Thread York Sun
To: Ciubotariu Codrin Constantin-B43658 Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address On 08/13/2015 08:42 AM, Ciubotariu Codrin Constantin-B43658 wrote: Hi Joe, York, -Original

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-14 Thread Codrin Constantin Ciubotariu
...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address +Codrin Somehow I dropped Codrin in last reply. On 08/10/2015 01:45 PM, York Sun wrote: On 08/10/2015 01:05 PM, Joe Hershberger wrote: Hi York, On Mon, Aug 10, 2015 at 3:03 PM

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-14 Thread York Sun
Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address +Codrin Somehow I dropped Codrin in last reply. On 08/10/2015 01:45 PM, York Sun wrote: On 08/10/2015 01:05 PM, Joe Hershberger wrote

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-13 Thread Codrin Constantin Ciubotariu
-B43658 Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address +Codrin Somehow I dropped Codrin in last reply. On 08/10/2015 01:45 PM, York Sun wrote: On 08/10/2015 01:05 PM, Joe

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-13 Thread Codrin Constantin Ciubotariu
Hi Joe, York, -Original Message- From: Sun York-R58495 Sent: Wednesday, August 12, 2015 10:59 PM To: Ciubotariu Codrin Constantin-B43658 Cc: Joe Hershberger; u-boot@lists.denx.de; joe.hershber...@ni.com Subject: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-13 Thread York Sun
: Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address +Codrin Somehow I dropped Codrin in last reply. On 08/10/2015 01:45 PM, York Sun wrote: On 08/10/2015 01:05 PM, Joe Hershberger wrote: Hi York, On Mon, Aug 10, 2015 at 3:03 PM, York Sun york

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-12 Thread York Sun
+Codrin Somehow I dropped Codrin in last reply. On 08/10/2015 01:45 PM, York Sun wrote: On 08/10/2015 01:05 PM, Joe Hershberger wrote: Hi York, On Mon, Aug 10, 2015 at 3:03 PM, York Sun york...@freescale.com wrote: On 08/10/2015 12:57 PM, Joe Hershberger wrote: Too much top-posting.

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-10 Thread Joe Hershberger
Too much top-posting. On Mon, Aug 10, 2015 at 2:41 PM, York Sun york...@freescale.com wrote: SPL doesn't use net/eth.c. You add a call in env_flags.c. I think you can put it in header file and use static inline, or keep it in the same file where it is called. That is probably fine. Another

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-10 Thread York Sun
On 08/10/2015 12:57 PM, Joe Hershberger wrote: Too much top-posting. On Mon, Aug 10, 2015 at 2:41 PM, York Sun york...@freescale.com wrote: SPL doesn't use net/eth.c. You add a call in env_flags.c. I think you can put it in header file and use static inline, or keep it in the same file

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-10 Thread York Sun
SPL doesn't use net/eth.c. You add a call in env_flags.c. I think you can put it in header file and use static inline, or keep it in the same file where it is called. Another way is to undef CONFIG_CMD_NET for SPL part. It is default to 'y' in Kconfig. Joe may have some good suggestion. York

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-10 Thread Joe Hershberger
Hi York, On Mon, Aug 10, 2015 at 3:03 PM, York Sun york...@freescale.com wrote: On 08/10/2015 12:57 PM, Joe Hershberger wrote: Too much top-posting. On Mon, Aug 10, 2015 at 2:41 PM, York Sun york...@freescale.com wrote: SPL doesn't use net/eth.c. You add a call in env_flags.c. I think

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-10 Thread York Sun
On 08/10/2015 01:05 PM, Joe Hershberger wrote: Hi York, On Mon, Aug 10, 2015 at 3:03 PM, York Sun york...@freescale.com wrote: On 08/10/2015 12:57 PM, Joe Hershberger wrote: Too much top-posting. On Mon, Aug 10, 2015 at 2:41 PM, York Sun york...@freescale.com wrote: SPL doesn't use

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-10 Thread Codrin Constantin Ciubotariu
Hi York, I didn't know that SPL uses net/eth.c . Could you please suggest a place for eth_validate_ethaddr_str()? Thanks and best regards, Codrin -Original Message- From: Sun York-R58495 Sent: Saturday, August 08, 2015 3:31 AM To: Ciubotariu Codrin Constantin-B43658;

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-07 Thread Joe Hershberger
Hi Codrin, On Fri, Jul 24, 2015 at 8:55 AM, Codrin Ciubotariu codrin.ciubota...@freescale.com wrote: The code from common/env_flags.c that checks if a string has the format of a MAC address has been moved in net/eth.c as a separate function called eth_validate_ethaddr_str(). Signed-off-by:

Re: [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-08-07 Thread York Sun
On 07/24/2015 06:55 AM, Codrin Ciubotariu wrote: The code from common/env_flags.c that checks if a string has the format of a MAC address has been moved in net/eth.c as a separate function called eth_validate_ethaddr_str(). Signed-off-by: Codrin Ciubotariu codrin.ciubota...@freescale.com

[U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address

2015-07-24 Thread Codrin Ciubotariu
The code from common/env_flags.c that checks if a string has the format of a MAC address has been moved in net/eth.c as a separate function called eth_validate_ethaddr_str(). Signed-off-by: Codrin Ciubotariu codrin.ciubota...@freescale.com --- Changes for v3: - none, new patch;