Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

On 06/12/18 9:49 PM, Simon Goldschmidt wrote: > Am 06.12.2018 um 16:59 schrieb Tom Rini: >> On Thu, Dec 06, 2018 at 04:23:00PM +0100, Miquel Raynal wrote: >>> Hi Wolfgang, >>> >>> Wolfgang Denk wrote on Thu, 06 Dec 2018 10:32:14 +0100: >>> [...] >> Please understand that there is a

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Dear Miquel, In message <20181206162300.7ccfddda@xps13> you wrote: > > Do you see another significant impact that must prevent NOR flashes to > depend on MTD? My concern here is only resources. If the memory footprint really does not grow, I'm fine with that. But I somwhow doubt this is

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

On Fri, Dec 07, 2018 at 12:09:33PM +0100, Miquel Raynal wrote: > Hi Tom, Wolfgang, [snip] > So what's our next move? I think Wolfgang had two points: > * NOR (and everything related to NOR) should not depend on MTD. > * Same for NAND. > > For NAND this is already too late, NAND code already

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Hi Tom, Wolfgang, Tom Rini wrote on Thu, 6 Dec 2018 10:59:25 -0500: > On Thu, Dec 06, 2018 at 04:23:00PM +0100, Miquel Raynal wrote: > > Hi Wolfgang, > > > > Wolfgang Denk wrote on Thu, 06 Dec 2018 10:32:14 +0100: > > > > > Dear Boris, > > > > > > In message

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Am 06.12.2018 um 16:59 schrieb Tom Rini: On Thu, Dec 06, 2018 at 04:23:00PM +0100, Miquel Raynal wrote: Hi Wolfgang, Wolfgang Denk wrote on Thu, 06 Dec 2018 10:32:14 +0100: Dear Boris, In message <20181206100016.706330ba@bbrezillon> you wrote: I took a rather small configuration:

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

On Thu, Dec 06, 2018 at 04:23:00PM +0100, Miquel Raynal wrote: > Hi Wolfgang, > > Wolfgang Denk wrote on Thu, 06 Dec 2018 10:32:14 +0100: > > > Dear Boris, > > > > In message <20181206100016.706330ba@bbrezillon> you wrote: > > > > > > > > I took a rather small configuration:

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Hi Wolfgang, Wolfgang Denk wrote on Thu, 06 Dec 2018 10:32:14 +0100: > Dear Boris, > > In message <20181206100016.706330ba@bbrezillon> you wrote: > > > > > > I took a rather small configuration: stm32f429-discovery_defconfig > > > > which uses CONFIG_MTD_NOR_FLASH. Without CONFIG_MTD,

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Dear Boris, In message <20181206100016.706330ba@bbrezillon> you wrote: > > > > I took a rather small configuration: stm32f429-discovery_defconfig > > > which uses CONFIG_MTD_NOR_FLASH. Without CONFIG_MTD, u-boot.bin is > > > 209416 bytes. With CONFIG_MTD, u-boot.bin is 214540 bytes. This is an >

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Hello Wolfgang, On Thu, 06 Dec 2018 09:06:05 +0100 Wolfgang Denk wrote: > Dear Miquel, > > In message <20181205153218.36f6ed4e@xps13> you wrote: > > > > I took a rather small configuration: stm32f429-discovery_defconfig > > which uses CONFIG_MTD_NOR_FLASH. Without CONFIG_MTD, u-boot.bin is > >

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Dear Frieder, In message <35a6f1a5-e11d-4bc4-efbe-5977dde81...@kontron.de> you wrote: > > Moving towards a unified MTD layer to replace all the historic solutions > is definitely the right thing to do. Miquèl already mentioned the > reasons in detail... I fully agree on this. I just ask not

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Dear Miquel, In message <20181205153218.36f6ed4e@xps13> you wrote: > > I took a rather small configuration: stm32f429-discovery_defconfig > which uses CONFIG_MTD_NOR_FLASH. Without CONFIG_MTD, u-boot.bin is > 209416 bytes. With CONFIG_MTD, u-boot.bin is 214540 bytes. This is an > additional 5124

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

On 05.12.18 15:32, Miquel Raynal wrote: > Hi Wolfgang, > > Wolfgang Denk wrote on Wed, 05 Dec 2018 13:06:10 +0100: > >> Dear Miquel, >> >> In message <20181204235714.11805-14-miquel.ray...@bootlin.com> you wrote: >>> MTD support must be enabled when the environment is in NOR. >> >> Naked-by:

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Hi Wolfgang, Wolfgang Denk wrote on Wed, 05 Dec 2018 13:06:10 +0100: > Dear Miquel, > > In message <20181204235714.11805-14-miquel.ray...@bootlin.com> you wrote: > > MTD support must be enabled when the environment is in NOR. > > Naked-by: Wolfgang Denk > > Environment in NOR must not, I

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

Dear Miquel, In message <20181204235714.11805-14-miquel.ray...@bootlin.com> you wrote: > MTD support must be enabled when the environment is in NOR. Naked-by: Wolfgang Denk Environment in NOR must not, I repeat: must not ever depend on MTD! For more than 19 years we have been using

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

On Wed, 5 Dec 2018 00:56:59 +0100 Miquel Raynal wrote: > MTD support must be enabled when the environment is in NOR. > > Signed-off-by: Miquel Raynal > --- > configs/armadillo-800eva_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/armadillo-800eva_defconfig >

[U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

MTD support must be enabled when the environment is in NOR. Signed-off-by: Miquel Raynal --- configs/armadillo-800eva_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/armadillo-800eva_defconfig b/configs/armadillo-800eva_defconfig index b1d923c069..45736a9b01 100644 ---