Re: [U-Boot] [PATCH v3 3/3] Add TI816X evm board support

2013-04-15 Thread Tom Rini
On Fri, Apr 12, 2013 at 10:47:30AM -0500, Andrew Dyer wrote: On Fri, Apr 12, 2013 at 7:10 AM, TENART Antoine aten...@adeneo-embedded.com wrote: Signed-off-by: Antoine Tenart aten...@adeneo-embedded.com [snip] + if (0 == get_cpu_rev()) { + writel(0xF,

[U-Boot] [PATCH v3 3/3] Add TI816X evm board support

2013-04-12 Thread TENART Antoine
Signed-off-by: Antoine Tenart aten...@adeneo-embedded.com --- MAINTAINERS|4 + arch/arm/include/asm/arch-am33xx/spl.h |9 + board/ti/ti816x/Makefile | 48 ++ board/ti/ti816x/evm.c | 866

Re: [U-Boot] [PATCH v3 3/3] Add TI816X evm board support

2013-04-12 Thread TENART Antoine
[snip] these seem more SOC specific than board specific. Would likely be replicated per board, I'd suggest to move out of board specific file. [snip] this function is generic to the SOC, move out of board specific file and call with appropriate values or defines -plus the other ones- Well

Re: [U-Boot] [PATCH v3 3/3] Add TI816X evm board support

2013-04-12 Thread Andrew Dyer
On Fri, Apr 12, 2013 at 7:10 AM, TENART Antoine aten...@adeneo-embedded.com wrote: Signed-off-by: Antoine Tenart aten...@adeneo-embedded.com --- MAINTAINERS|4 + arch/arm/include/asm/arch-am33xx/spl.h |9 + board/ti/ti816x/Makefile | 48