Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message 1336671134-16342-4-git-send-email-mich...@walle.cc you wrote: Signed-off-by: Michael Walle mich...@walle.cc How many boards will be using this code? Eventually this should be made configurable? + sprintf(enetvar, index ? %s%daddr : %saddr, base_name,

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 21:25:27 schrieb Wolfgang Denk: Dear Michael Walle, In message 1336671134-16342-4-git-send-email-mich...@walle.cc you wrote: Signed-off-by: Michael Walle mich...@walle.cc How many boards will be using this code? Hopefully more boars will use this function in the

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Wolfgang Denk
Dear Michael Walle, In message 201205112301.50311.mich...@walle.cc you wrote: Eventually this should be made configurable? Given the above, i would keep it non-configurable if youre fine with that. Only if the code size for the existing boards that don't need this does not grow. Best

Re: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-11 Thread Michael Walle
Am Freitag 11 Mai 2012, 23:16:02 schrieb Wolfgang Denk: Dear Michael Walle, In message 201205112301.50311.mich...@walle.cc you wrote: Eventually this should be made configurable? Given the above, i would keep it non-configurable if youre fine with that. Only if the code size for

[U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

2012-05-10 Thread Michael Walle
Signed-off-by: Michael Walle mich...@walle.cc --- include/net.h | 12 net/eth.c |8 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/include/net.h b/include/net.h index 0da5679..eec846b 100644 --- a/include/net.h +++ b/include/net.h @@ -119,6 +119,18