Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 24.01.2018 06:13, Chee, Tien Fong wrote: On Tue, 2018-01-23 at 10:13 +0100, Simon Goldschmidt wrote: On 23.01.2018 09:31, Chee, Tien Fong wrote: On Tue, 2018-01-23 at 08:58 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Tue, 2018-01-23 at 10:13 +0100, Simon Goldschmidt wrote: > On 23.01.2018 09:31, Chee, Tien Fong wrote: > > > > On Tue, 2018-01-23 at 08:58 +0100, Simon Goldschmidt wrote: > > > > > > On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: > > > > > > > > From: Tien Fong Chee

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 23.01.2018 09:31, Chee, Tien Fong wrote: On Tue, 2018-01-23 at 08:58 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Tue, 2018-01-23 at 08:58 +0100, Simon Goldschmidt wrote: > On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > This is file system generic loader which can be used to load > > the file image from the storage into target such as

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the storage into target such as memory. The consumer driver would then use this loader to program whatever, ie.

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 23.01.2018 07:28, Chee, Tien Fong wrote: On Mon, 2018-01-22 at 12:41 +0100, Simon Goldschmidt wrote: On 22.01.2018 09:08, Chee, Tien Fong wrote: On Thu, 2018-01-18 at 06:57 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Mon, 2018-01-22 at 12:41 +0100, Simon Goldschmidt wrote: > On 22.01.2018 09:08, Chee, Tien Fong wrote: > > > > On Thu, 2018-01-18 at 06:57 +0100, Simon Goldschmidt wrote: > > > > > > On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: > > > > > > > > From: Tien Fong Chee

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Mon, 2018-01-22 at 09:44 +0100, Lothar Waßmann wrote: > Hi, > > On Mon, 22 Jan 2018 07:11:37 + Chee, Tien Fong wrote: > > > > On Thu, 2018-01-18 at 12:12 +0100, Marek Vasut wrote: > > > > > > On 01/18/2018 05:33 AM, Chee, Tien Fong wrote: > > > > > > > > > > > > On Tue, 2018-01-16 at

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 01/22/2018 08:11 AM, Chee, Tien Fong wrote: [...] >>> This is last line code of the function, so it's always return the >>> result regardless error or not. >> You are rewriting the true error code with -ENODEV instead of >> propagating it. >> > Ohhare you saying to change the codes as

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 22.01.2018 09:08, Chee, Tien Fong wrote: On Thu, 2018-01-18 at 06:57 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

Hi, On Mon, 22 Jan 2018 07:11:37 + Chee, Tien Fong wrote: > On Thu, 2018-01-18 at 12:12 +0100, Marek Vasut wrote: > > On 01/18/2018 05:33 AM, Chee, Tien Fong wrote: > > > > > > On Tue, 2018-01-16 at 15:41 +0100, Marek Vasut wrote: > > > > > > > > On 12/27/2017 06:04 AM,

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Thu, 2018-01-18 at 06:57 +0100, Simon Goldschmidt wrote: > On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > This is file system generic loader which can be used to load > > the file image from the storage into target such as

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Thu, 2018-01-18 at 12:12 +0100, Marek Vasut wrote: > On 01/18/2018 05:33 AM, Chee, Tien Fong wrote: > > > > On Tue, 2018-01-16 at 15:41 +0100, Marek Vasut wrote: > > > > > > On 12/27/2017 06:04 AM, tien.fong.c...@intel.com wrote: > > > > > > Whoa, this improved substantially since last time

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 01/18/2018 05:33 AM, Chee, Tien Fong wrote: > On Tue, 2018-01-16 at 15:41 +0100, Marek Vasut wrote: >> On 12/27/2017 06:04 AM, tien.fong.c...@intel.com wrote: >> >> Whoa, this improved substantially since last time I checked. Minor >> nitpicks below. >> >> [...] >> >>> >>> +/* USB build is not

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the storage into target such as memory. The consumer driver would then use this loader to program whatever, ie.

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On Tue, 2018-01-16 at 15:41 +0100, Marek Vasut wrote: > On 12/27/2017 06:04 AM, tien.fong.c...@intel.com wrote: > > Whoa, this improved substantially since last time I checked. Minor > nitpicks below. > > [...] > > > > > +/* USB build is not supported yet in SPL */ > > +#ifndef

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

On 12/27/2017 06:04 AM, tien.fong.c...@intel.com wrote: Whoa, this improved substantially since last time I checked. Minor nitpicks below. [...] > +/* USB build is not supported yet in SPL */ > +#ifndef CONFIG_SPL_BUILD > +#ifdef CONFIG_USB_STORAGE > +static int init_usb(void) > +{ > + int

[U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the storage into target such as memory. The consumer driver would then use this loader to program whatever, ie. the FPGA device. Signed-off-by: Tien Fong Chee