Re: [U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-11 Thread Masahiro Yamada
Hello Charles, Gerhard, Is there any (real, technical) reason why the bzip stuff (the CRC-32 calculation that has been made available separately) cannot get built and used as a library, and the tools/ application just gets linked against it as one would expect? From my limited

Re: [U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-11 Thread Charles Manning
On Tuesday 11 March 2014 22:13:26 you wrote: Hello Charles, Gerhard, Is there any (real, technical) reason why the bzip stuff (the CRC-32 calculation that has been made available separately) cannot get built and used as a library, and the tools/ application just gets linked

Re: [U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-10 Thread Gerhard Sittig
[ Cc: to Masahiro for the tools/ vs lib/ build support part ] On Mon, Mar 10, 2014 at 16:04 +1300, Charles Manning wrote: On Sunday 09 March 2014 05:51:23 Gerhard Sittig wrote: On Thu, Mar 06, 2014 at 15:40 +1300, Charles Manning wrote: --- /dev/null +++ b/lib/bzlib_crc32.c @@

Re: [U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-10 Thread Charles Manning
Dear Gerhard Thank you for your further comments and clarifications, may I press you for a few more? On Tuesday 11 March 2014 08:36:24 Gerhard Sittig wrote: [ Cc: to Masahiro for the tools/ vs lib/ build support part ] On Mon, Mar 10, 2014 at 16:04 +1300, Charles Manning wrote: On Sunday

Re: [U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-09 Thread Charles Manning
Hello Gerhard Thank you for that feedback. On Sunday 09 March 2014 05:51:23 Gerhard Sittig wrote: On Thu, Mar 06, 2014 at 15:40 +1300, Charles Manning wrote: [ ... ] Unfortunately the CRC used in this boot ROM is not the same as the Adler CRC in lib/crc32.c. Indeed the Adler code is not

Re: [U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-08 Thread Gerhard Sittig
On Thu, Mar 06, 2014 at 15:40 +1300, Charles Manning wrote: [ ... ] Unfortunately the CRC used in this boot ROM is not the same as the Adler CRC in lib/crc32.c. Indeed the Adler code is not technically a CRC but is more correctly described as a checksum. I don't quite get why you say that

[U-Boot] [PATCH v7] socfpga: Add socfpga preloader signing to mkimage

2014-03-05 Thread Charles Manning
Like many platforms, the Altera socfpga platform requires that the preloader be signed in a certain way or the built-in boot ROM will not boot the code. This change automatically creates an appropriately signed preloader from an SPL image. The signed image includes a CRC which must, of course,