Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Stefano Babic
On 12/11/2014 23:27, John Tobias wrote: add the spl info in the header file. Also, added a macro statement in m6sabre_common.h to avoid compiler warning. Signed-off-by: John Tobias john.tobias...@gmail.com --- include/configs/mx6sabre_common.h | 2 ++ include/configs/mx6sabresd.h |

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Fabio Estevam
Hi John, On Thu, Nov 13, 2014 at 6:58 AM, Stefano Babic sba...@denx.de wrote: #define CONFIG_LOADADDR0x1200 +#ifndef CONFIG_SYS_TEXT_BASE #define CONFIG_SYS_TEXT_BASE 0x1780 +#endif Why is that needed ? SPL does not use it, because it use

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Fabio Estevam
On Thu, Nov 13, 2014 at 10:41 AM, Fabio Estevam feste...@gmail.com wrote: Hi John, On Thu, Nov 13, 2014 at 6:58 AM, Stefano Babic sba...@denx.de wrote: #define CONFIG_LOADADDR0x1200 +#ifndef CONFIG_SYS_TEXT_BASE #define CONFIG_SYS_TEXT_BASE 0x1780

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Fabio Estevam
Hi Stefano, On Thu, Nov 13, 2014 at 10:49 AM, Fabio Estevam feste...@gmail.com wrote: Sorry, I meant to remove only the ifdef: --- a/include/configs/mx6sabre_common.h +++ b/include/configs/mx6sabre_common.h @@ -95,9 +95,7 @@ #define CONFIG_BOOTDELAY 1 #define

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Stefano Babic
Hi Fabio, John, On 13/11/2014 15:39, Fabio Estevam wrote: Hi Stefano, On Thu, Nov 13, 2014 at 10:49 AM, Fabio Estevam feste...@gmail.com wrote: Sorry, I meant to remove only the ifdef: --- a/include/configs/mx6sabre_common.h +++ b/include/configs/mx6sabre_common.h @@ -95,9 +95,7 @@

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Fabio Estevam
On Thu, Nov 13, 2014 at 12:42 PM, Stefano Babic sba...@denx.de wrote: We already agree about the changes. There is no need to resend the patchset, I will fix it when I apply the patchset. Excellent! Thanks, Stefano ___ U-Boot mailing list

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread John Tobias
Hi Stefano, On Thu, Nov 13, 2014 at 4:49 AM, Fabio Estevam feste...@gmail.com wrote: On Thu, Nov 13, 2014 at 10:41 AM, Fabio Estevam feste...@gmail.com wrote: Hi John, On Thu, Nov 13, 2014 at 6:58 AM, Stefano Babic sba...@denx.de wrote: #define CONFIG_LOADADDR

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread John Tobias
Hi Fabio, Stefano, Thanks for reviewing my work and for accepting it. Regards, John On Thu, Nov 13, 2014 at 6:42 AM, Stefano Babic sba...@denx.de wrote: Hi Fabio, John, On 13/11/2014 15:39, Fabio Estevam wrote: Hi Stefano, On Thu, Nov 13, 2014 at 10:49 AM, Fabio Estevam

Re: [U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-13 Thread Stefano Babic
Hi John, On 13/11/2014 16:47, John Tobias wrote: The CONFIG_SYS_TEXT_BASE was defined in imx6_spl.h and I was seeing previously some warning related to the duplication of the said macro. I thought it would be great to remove the warning messages so that is why I added the macro. Maybe it

[U-Boot] [PATCH v7 4/5] imx6: add spl in the header file

2014-11-12 Thread John Tobias
add the spl info in the header file. Also, added a macro statement in m6sabre_common.h to avoid compiler warning. Signed-off-by: John Tobias john.tobias...@gmail.com --- include/configs/mx6sabre_common.h | 2 ++ include/configs/mx6sabresd.h | 6 ++ 2 files changed, 8 insertions(+) diff