Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-06-01 Thread Marek Vasut
On Friday, May 29, 2015 at 05:24:19 PM, Dinh Nguyen wrote: [...] My concern is if this is actually true (and I asked this before, in an earlier round ov reviews). I cannot make heads or tails of this comment, as I don't understand what configuration time and reset are supposed to mean in

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-29 Thread Dinh Nguyen
On 05/28/2015 01:18 PM, Marek Vasut wrote: On Thursday, May 28, 2015 at 05:41:26 PM, Dinh Nguyen wrote: On 05/25/2015 08:23 AM, Wolfgang Denk wrote: Dear Pavel, In message 20150525123750.GD9943@amd you wrote: + ** All global variables that are explicitly initialized (including ** +

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-28 Thread Marek Vasut
On Thursday, May 28, 2015 at 05:41:26 PM, Dinh Nguyen wrote: On 05/25/2015 08:23 AM, Wolfgang Denk wrote: Dear Pavel, In message 20150525123750.GD9943@amd you wrote: + ** All global variables that are explicitly initialized (including ** + ** explicitly initialized to zero),

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-28 Thread Dinh Nguyen
On 05/25/2015 08:23 AM, Wolfgang Denk wrote: Dear Pavel, In message 20150525123750.GD9943@amd you wrote: + ** All global variables that are explicitly initialized (including ** + ** explicitly initialized to zero), are only initialized once, during ** + ** configuration

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-28 Thread Dinh Nguyen
On 05/25/2015 08:23 AM, Wolfgang Denk wrote: Dear Pavel, In message 20150525123750.GD9943@amd you wrote: + ** All global variables that are explicitly initialized (including ** + ** explicitly initialized to zero), are only initialized once, during ** + ** configuration

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-25 Thread Pavel Machek
Hi! +/** + ** + ** NOTE: Special Rules for Globale Variables ** They are global, not globale. + ** All

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-25 Thread Wolfgang Denk
Dear Pavel, In message 20150525123750.GD9943@amd you wrote: + ** All global variables that are explicitly initialized (including ** + ** explicitly initialized to zero), are only initialized once, during ** + ** configuration time, and not again on reset. This means

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-22 Thread Stefan Roese
On 22.05.2015 04:43, Dinh Nguyen wrote: On 5/21/15 6:35 PM, Marek Vasut wrote: On Monday, May 18, 2015 at 09:36:48 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com This patch adds the DDR calibration portion of the Altera SDRAM driver.

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-22 Thread Marek Vasut
On Friday, May 22, 2015 at 08:39:37 AM, Stefan Roese wrote: On 22.05.2015 04:43, Dinh Nguyen wrote: On 5/21/15 6:35 PM, Marek Vasut wrote: On Monday, May 18, 2015 at 09:36:48 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com This patch adds the

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-21 Thread Marek Vasut
On Monday, May 18, 2015 at 09:36:48 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com This patch adds the DDR calibration portion of the Altera SDRAM driver. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Hi, DTTO here. The code is still

Re: [U-Boot] [PATCHv3 2/3] driver/ddr/altera/: Add the sdram calibration portion

2015-05-21 Thread Dinh Nguyen
On 5/21/15 6:35 PM, Marek Vasut wrote: On Monday, May 18, 2015 at 09:36:48 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com This patch adds the DDR calibration portion of the Altera SDRAM driver. Signed-off-by: Dinh Nguyen