Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-08-12 Thread Joe Hershberger
Hi Tim, On Tue, May 19, 2015 at 12:01 PM, Tim Harvey thar...@gateworks.com wrote: This reverts commit 17da7120249bfdef877f46be5bbcb3cc01212eb9. The i210/i211 do have the SW_FW_SYNC (0x5b5c) register and this is what should be used when acquiring the semaphore. I believe the issue that this

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-07-28 Thread Tim Harvey
On Mon, Jul 13, 2015 at 8:45 AM, Tim Harvey thar...@gateworks.com wrote: On Sat, Jul 11, 2015 at 3:11 PM, Marcel Ziswiler mar...@ziswiler.com wrote: On Fri, 2015-07-10 at 08:47 -0700, Tim Harvey wrote: Marcel, Could you give an 'acked-by' if you agree with this series? I would like to see

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-07-13 Thread Tim Harvey
On Sat, Jul 11, 2015 at 3:11 PM, Marcel Ziswiler mar...@ziswiler.com wrote: On Fri, 2015-07-10 at 08:47 -0700, Tim Harvey wrote: Marcel, Could you give an 'acked-by' if you agree with this series? I would like to see it merged: https://patchwork.ozlabs.org/patch/473997/

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-07-11 Thread Marcel Ziswiler
On Fri, 2015-07-10 at 08:47 -0700, Tim Harvey wrote: Marcel, Could you give an 'acked-by' if you agree with this series? I would like to see it merged: https://patchwork.ozlabs.org/patch/473997/ https://patchwork.ozlabs.org/patch/473998/ https://patchwork.ozlabs.org/patch/473996/

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-07-10 Thread Tim Harvey
On Wed, May 20, 2015 at 8:00 AM, Tim Harvey thar...@gateworks.com wrote: On Wed, May 20, 2015 at 7:14 AM, Marcel Ziswiler mar...@ziswiler.com wrote: On Wed, 2015-05-20 at 06:15 -0700, Tim Harvey wrote: snip Tested on Apalis T30 1GB V1.1A with properly fused i211 Tested on Apalis T30 2GB

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-05-20 Thread Marcel Ziswiler
On Tue, 2015-05-19 at 10:01 -0700, Tim Harvey wrote: This reverts commit 17da7120249bfdef877f46be5bbcb3cc01212eb9. The i210/i211 do have the SW_FW_SYNC (0x5b5c) register and this is what should be used when acquiring the semaphore. I believe the issue that this patch was trying to resolve

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-05-20 Thread Bin Meng
On Wed, May 20, 2015 at 1:01 AM, Tim Harvey thar...@gateworks.com wrote: This reverts commit 17da7120249bfdef877f46be5bbcb3cc01212eb9. The i210/i211 do have the SW_FW_SYNC (0x5b5c) register and this is what should be used when acquiring the semaphore. I believe the issue that this patch was

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-05-20 Thread Tim Harvey
On Wed, May 20, 2015 at 4:27 AM, Marcel Ziswiler mar...@ziswiler.com wrote: On Tue, 2015-05-19 at 10:01 -0700, Tim Harvey wrote: This reverts commit 17da7120249bfdef877f46be5bbcb3cc01212eb9. The i210/i211 do have the SW_FW_SYNC (0x5b5c) register and this is what should be used when

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-05-20 Thread Marcel Ziswiler
On Wed, 2015-05-20 at 06:15 -0700, Tim Harvey wrote: snip Tested on Apalis T30 1GB V1.1A with properly fused i211 Tested on Apalis T30 2GB V1.1A with iNVM fused i210 Tested on Apalis T30 1GB V1.0A with tools only aka non fused i211 Tested-by: Marcel Ziswiler marcel.ziswi...@toradex.com

Re: [U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-05-20 Thread Tim Harvey
On Wed, May 20, 2015 at 7:14 AM, Marcel Ziswiler mar...@ziswiler.com wrote: On Wed, 2015-05-20 at 06:15 -0700, Tim Harvey wrote: snip Tested on Apalis T30 1GB V1.1A with properly fused i211 Tested on Apalis T30 2GB V1.1A with iNVM fused i210 Tested on Apalis T30 1GB V1.0A with tools only

[U-Boot] [Patch 2/3] Revert e1000: fix sw fw sync on igb i210/i211

2015-05-19 Thread Tim Harvey
This reverts commit 17da7120249bfdef877f46be5bbcb3cc01212eb9. The i210/i211 do have the SW_FW_SYNC (0x5b5c) register and this is what should be used when acquiring the semaphore. I believe the issue that this patch was trying to resolve is now resolved by properly releasing the semaphore once no