[U-Boot] [RFC][PATCH] fdt: Remove fdt_fixup_memory function

2014-04-09 Thread Tom Rini
The fdt_fixup_memory function is only used on PowerPC where we only claim one memory bank in U-Boot (and then in the device tree) so we can call a function that just calls fdt_fixup_memory_banks(..., 1). Call this directly for consistency with other architectures. Cc: Jerry Van Baren

Re: [U-Boot] [RFC][PATCH] fdt: Remove fdt_fixup_memory function

2014-04-09 Thread Wolfgang Denk
Dear Tom Rini, In message 1397047800-26221-1-git-send-email-tr...@ti.com you wrote: The fdt_fixup_memory function is only used on PowerPC where we only claim one memory bank in U-Boot (and then in the device tree) so we can call a function that just calls fdt_fixup_memory_banks(..., 1). Call

Re: [U-Boot] [RFC][PATCH] fdt: Remove fdt_fixup_memory function

2014-04-09 Thread Tom Rini
On Wed, Apr 09, 2014 at 04:26:40PM +0200, Wolfgang Denk wrote: Dear Tom Rini, In message 1397047800-26221-1-git-send-email-tr...@ti.com you wrote: The fdt_fixup_memory function is only used on PowerPC where we only claim one memory bank in U-Boot (and then in the device tree) so we can

Re: [U-Boot] [RFC][PATCH] fdt: Remove fdt_fixup_memory function

2014-04-09 Thread Wolfgang Denk
Dear Tom, In message 20140409182426.GV23803@bill-the-cat you wrote: I understand what you mean and what you want, but I'm not really happy about it. Code or comment wise? Both... Right, so we have a mismatch between function name (fdt_fixup_memory_bank) and function of the node

Re: [U-Boot] [RFC][PATCH] fdt: Remove fdt_fixup_memory function

2014-04-09 Thread Tom Rini
On Wed, Apr 09, 2014 at 11:39:10PM +0200, Wolfgang Denk wrote: Dear Tom, In message 20140409182426.GV23803@bill-the-cat you wrote: I understand what you mean and what you want, but I'm not really happy about it. Code or comment wise? Both... OK, concept wise? Right, so we