Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Hi Albert, On 12/01/2010 08:42 AM, Albert ARIBAUD wrote: Hi Darius, Le 30/11/2010 10:19, Darius Augulis a écrit : I understand, that there is such rule in u-boot, but it's ... at least strange. Even linux kernel doesn't use such approach and uses simple defines instead. One big

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Hi, thank you for review. Please find my questions inline: + +static void dm9000_pre_init(void) +{ +       SROM_BW_REG = ~(0xf 4); u-boot don't allow it. Please use read/write function. And please access the register by C structure. it's clear about read/write. But why C structure? We

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Dear Darius Augulis, On 30 November 2010 17:17, Darius Augulis augulis.dar...@gmail.com wrote: Hi, thank you for review. Please find my questions inline: + +static void dm9000_pre_init(void) +{ +       SROM_BW_REG = ~(0xf 4); u-boot don't allow it. Please use read/write function. And

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Hi, On Tue, Nov 30, 2010 at 10:50 AM, Minkyu Kang proms...@gmail.com wrote: Dear Darius Augulis, On 30 November 2010 17:17, Darius Augulis augulis.dar...@gmail.com wrote: Hi, thank you for review. Please find my questions inline: + +static void dm9000_pre_init(void) +{ +      

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Hi Darius, Le 30/11/2010 10:19, Darius Augulis a écrit : I understand, that there is such rule in u-boot, but it's ... at least strange. Even linux kernel doesn't use such approach and uses simple defines instead. One big disadvantage for already existing platforms - one must convert all

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Dear Darius Augulis, On 18 November 2010 06:26, Darius Augulis augulis.dar...@gmail.com wrote: Add support for mini6410 from FriendlyARM Signed-off-by: Darius Augulis augulis.dar...@gmail.com ---  MAKEALL                                         |    1  Makefile                              

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Hi all, is there anybody interested in U-boot for s3c64xx? If not, at least I would like to ask Wolfgang to review generic things (not architecture specific). I will send some minor issues fixed with next patch version. Mostly they will be board specific initialisation issues. New nand spl code

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Dear Darius Augulis, On 23 November 2010 03:28, Darius Augulis augulis.dar...@gmail.com wrote: Hi all, is there anybody interested in U-boot for s3c64xx? If not, at least I would like to ask Wolfgang to review generic things (not architecture specific). I will send some minor issues fixed

[U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

Add support for mini6410 from FriendlyARM Signed-off-by: Darius Augulis augulis.dar...@gmail.com --- MAKEALL |1 Makefile|4 arch/arm/cpu/arm1176/s3c64xx/Makefile |6 -