Great, I will check out v2! And yes free to add a "Signed-off-by" for me on
any of the original patchsets.
On Mon, Apr 30, 2018 at 1:37 AM Alex Kiernan wrote:
> On Fri, Apr 27, 2018 at 1:20 PM, Alex Kiernan
> wrote:
> > On Fri, Apr 27, 2018 at 9:04 AM, Lukasz Majewski wrote:
> >> Hi Kever,
> >
On Fri, Apr 27, 2018 at 1:20 PM, Alex Kiernan wrote:
> On Fri, Apr 27, 2018 at 9:04 AM, Lukasz Majewski wrote:
>> Hi Kever,
>>
>>> Hi Jocelyn and Alex,
>>>
>>>
>>> It's great to see you are getting this feature from google code
>>> to be mainline code.
>>>
>>> My opinion is that we should
Hi Sam,
On Fri, Apr 27, 2018 at 8:10 PM, Sam Protsenko
wrote:
> On 24 April 2018 at 12:37, Alex Kiernan wrote:
>>
>> This series merges the fastboot UDP support from AOSP into mainline
>> U-Boot.
>>
>
> Can you please point me out from which AOSP code exactly this code was
> ported? Links to cod
On 24 April 2018 at 12:37, Alex Kiernan wrote:
>
> This series merges the fastboot UDP support from AOSP into mainline
> U-Boot.
>
Can you please point me out from which AOSP code exactly this code was
ported? Links to code, maybe some docs. Thanks.
> Open questions:
>
> - what's the correct way
On Fri, Apr 27, 2018 at 9:04 AM, Lukasz Majewski wrote:
> Hi Kever,
>
>> Hi Jocelyn and Alex,
>>
>>
>> It's great to see you are getting this feature from google code
>> to be mainline code.
>>
>> My opinion is that we should have the same fastboot cmd handling
>> in both UDP and USB in a
Hi Kever,
> Hi Jocelyn and Alex,
>
>
> It's great to see you are getting this feature from google code
> to be mainline code.
>
> My opinion is that we should have the same fastboot cmd handling
> in both UDP and USB in a common file, but not have separate code in
> net/fastboot.c and d
Hi Jocelyn and Alex,
It's great to see you are getting this feature from google code to be
mainline code.
My opinion is that we should have the same fastboot cmd handling
in both UDP and USB in a common file, but not have separate code in
net/fastboot.c and drivers/usb/gadget/f_fastboot.
On Wed, 25 Apr 2018 13:50:50 +0100
Alex Kiernan wrote:
> On Wed, Apr 25, 2018 at 8:53 AM, Alex Kiernan
> wrote:
> > On Tue, Apr 24, 2018 at 6:10 PM, Jocelyn Bohr
> > wrote:
> >> Thanks so much for porting this, Alex!
> >>
>
> ...
>
> >>
> >> You can select both network and USB fastboot to
On Wed, Apr 25, 2018 at 8:53 AM, Alex Kiernan wrote:
> On Tue, Apr 24, 2018 at 6:10 PM, Jocelyn Bohr wrote:
>> Thanks so much for porting this, Alex!
>>
...
>>
>> You can select both network and USB fastboot to be enabled with the Kconfig,
>> but at runtime you have to select to wait on either
2018-04-25 10:43 GMT+02:00 Alex Kiernan :
> >> - what's the correct way of attributing the original authors? I've
> >> added Co-authored-by, is that right? checkpatch doesn't seem to know
> >> any of the co- tags
> >
> > I think that two authors (Alex and Jocelyn) have replied to your e-mail.
> >
On Wed, Apr 25, 2018 at 8:52 AM, Lukasz Majewski wrote:
> Hi Alex,
>
>> Open questions:
>>
>> - what's the correct way of attributing the original authors? I've
>> added Co-authored-by, is that right? checkpatch doesn't seem to know
>> any of the co- tags
>
> I think that two authors (Alex and Joc
Hi Alex,
> > - the USB and UDP code want consolidating, with this series there
> > would then be two separate implementations of the same protocol
>
> Yes - this is an issue.
>
> For USB the fastboot protocol (at least some its logic) is implemented
> in drivers/usb/gadget/f_fastboot.c
>
> I
On Tue, Apr 24, 2018 at 6:10 PM, Jocelyn Bohr wrote:
> Thanks so much for porting this, Alex!
>
> On Tue, Apr 24, 2018 at 4:58 AM Alex Kiernan wrote:
>>
>> On Tue, Apr 24, 2018 at 11:24 AM, Alex Deymo wrote:
>> > +Jocelyn.
>> >
>> > Thanks Alex for taking the time to port this!!
>>
>> It turned
Hi Alex,
> Open questions:
>
> - what's the correct way of attributing the original authors? I've
> added Co-authored-by, is that right? checkpatch doesn't seem to know
> any of the co- tags
I think that two authors (Alex and Jocelyn) have replied to your e-mail.
Maybe it would be doable to hav
Hi Alex,
> On Tue, Apr 24, 2018 at 11:24 AM, Alex Deymo
> wrote:
> > +Jocelyn.
> >
> > Thanks Alex for taking the time to port this!!
>
> It turned out to be a great opportunity to play with coccinelle on
> something trivial, which I'd been meaning to do for ages... the
> refactor to add respo
Thanks so much for porting this, Alex!
On Tue, Apr 24, 2018 at 4:58 AM Alex Kiernan wrote:
> On Tue, Apr 24, 2018 at 11:24 AM, Alex Deymo wrote:
> > +Jocelyn.
> >
> > Thanks Alex for taking the time to port this!!
>
> It turned out to be a great opportunity to play with coccinelle on
> somethin
On Tue, Apr 24, 2018 at 11:24 AM, Alex Deymo wrote:
> +Jocelyn.
>
> Thanks Alex for taking the time to port this!!
It turned out to be a great opportunity to play with coccinelle on
something trivial, which I'd been meaning to do for ages... the
refactor to add response into the fastboot_okay/fai
+Jocelyn.
Thanks Alex for taking the time to port this!! Some comments inline here
about your questions.
2018-04-24 11:37 GMT+02:00 Alex Kiernan :
>
> This series merges the fastboot UDP support from AOSP into mainline
> U-Boot.
>
> Open questions:
>
> - what's the correct way of attributing the
This series merges the fastboot UDP support from AOSP into mainline
U-Boot.
Open questions:
- what's the correct way of attributing the original authors? I've added
Co-authored-by, is that right? checkpatch doesn't seem to know any
of the co- tags
- currently there's no NAND support and I've
19 matches
Mail list logo
