Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-03-18 Thread Philipp Tomsich
Simon, > On 18.03.2019, at 12:58, Simon Glass wrote: > > Hi, > > On Tue, 12 Mar 2019 at 09:26, Kever Yang > wrote: >> >> >> >> On 03/11/2019 09:04 PM, Philipp Tomsich wrote: >>> Note that the minimum improvement that I’d expect to get this fully >>>

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-03-18 Thread Simon Glass
Hi, On Tue, 12 Mar 2019 at 09:26, Kever Yang wrote: > > > > On 03/11/2019 09:04 PM, Philipp Tomsich wrote: > > Note that the minimum improvement that I’d expect to get this fully > > enabled again would be a clean-up of the Kconfig options, so it is > > easy and (from the documentation)

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】【请注意,邮件由s...@google.com代发】

2019-03-12 Thread Andy Yan
Hi Simon: On 2019/3/11 上午10:30, Simon Glass wrote: Hi Andy, On Wed, 6 Mar 2019 at 03:52, Andy Yan wrote: Hi Simon: On 2019/2/12 下午11:31, Simon Glass wrote: HI Andy, On Tue, 12 Feb 2019 at 04:05, Andy Yan wrote: Hi Philipp: Sorry for the late reply, we just come back from the

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-03-11 Thread Kever Yang
On 03/11/2019 09:04 PM, Philipp Tomsich wrote: > Note that the minimum improvement that I’d expect to get this fully > enabled again would be a clean-up of the Kconfig options, so it is > easy and (from the documentation) predictable for boards to turn > this off. > > I still want this to be

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】【请注意,邮件由s...@google.com代发】

2019-03-11 Thread Philipp Tomsich
> On 11.03.2019, at 03:30, Simon Glass wrote: > > Hi Andy, > > On Wed, 6 Mar 2019 at 03:52, Andy Yan wrote: >> >> Hi Simon: >> >> On 2019/2/12 下午11:31, Simon Glass wrote: >>> HI Andy, >>> >>> On Tue, 12 Feb 2019 at 04:05, Andy Yan wrote: Hi Philipp: Sorry for the late

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】【请注意,邮件由s...@google.com代发】

2019-03-10 Thread Simon Glass
Hi Andy, On Wed, 6 Mar 2019 at 03:52, Andy Yan wrote: > > Hi Simon: > > On 2019/2/12 下午11:31, Simon Glass wrote: > > HI Andy, > > > > On Tue, 12 Feb 2019 at 04:05, Andy Yan wrote: > >> Hi Philipp: > >> > >> Sorry for the late reply, we just come back from the Chinese Spring > >> Festival.

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】【请注意,邮件由s...@google.com代发】

2019-03-06 Thread Andy Yan
Hi Simon: On 2019/2/12 下午11:31, Simon Glass wrote: HI Andy, On Tue, 12 Feb 2019 at 04:05, Andy Yan wrote: Hi Philipp: Sorry for the late reply, we just come back from the Chinese Spring Festival. On 2019/2/1 下午6:26, Philipp Tomsich wrote: Kever, Independent of whether we revert

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】

2019-02-12 Thread Simon Glass
HI Andy, On Tue, 12 Feb 2019 at 04:05, Andy Yan wrote: > > Hi Philipp: > > Sorry for the late reply, we just come back from the Chinese Spring > Festival. > > On 2019/2/1 下午6:26, Philipp Tomsich wrote: > > Kever, > > > > Independent of whether we revert this for the current cycle (and also

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】

2019-02-11 Thread Andy Yan
Hi Philipp:     Sorry for the late reply, we just come back from the Chinese Spring Festival. On 2019/2/1 下午6:26, Philipp Tomsich wrote: Kever, Independent of whether we revert this for the current cycle (and also independent of if I ever find the other patch you had been referring to — I

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】

2019-02-01 Thread Simon Glass
Hi Kever, On Fri, 1 Feb 2019 at 03:26, Philipp Tomsich wrote: > > Kever, > > Independent of whether we revert this for the current cycle (and also > independent of > if I ever find the other patch you had been referring to — I couldn’t find it > in my local > mailing list archive) and then

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】

2019-02-01 Thread Philipp Tomsich
Kever, Independent of whether we revert this for the current cycle (and also independent of if I ever find the other patch you had been referring to — I couldn’t find it in my local mailing list archive) and then deprecate it for the next release (unless converted to DM), we still have a

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】

2019-02-01 Thread Philipp Tomsich
> On 01.02.2019, at 10:32, Kever Yang wrote: > > Hi Philipp, > > This is not right, this patch should not merged like this!!! > > I have give my review comment in previous mail, and this will break > many boards. > > My another patch do not break anything, but you insist NAK it

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-boun...@lists.denx.de代发】

2019-02-01 Thread Kever Yang
Hi Philipp,     This is not right,  this patch should not merged like this!!!     I have give my review comment in previous mail, and this will break many boards.     My another patch do not break anything, but you insist NAK it without acceptable reason;     This patch definitely break other

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-02-01 Thread Philipp Tomsich
> On 01.02.2019, at 09:38, Philipp Tomsich > wrote: > > Andy, > >> On 01.02.2019, at 02:32, andy@rock-chips.com wrote: >> >> Hi: >> >>> This function causes a 5-second delay and stops the display working on >>> minnie. This code should be in a driver and should only be enabled by >>> a

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-02-01 Thread Philipp Tomsich
Andy, > On 01.02.2019, at 02:32, andy@rock-chips.com wrote: > > Hi: > > > This function causes a 5-second delay and stops the display working on > > minnie. This code should be in a driver and should only be enabled by > > a device-tree property, so that it does not affect devices which do

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-01-31 Thread andy....@rock-chips.com
Hi: > This function causes a 5-second delay and stops the display working on > minnie. This code should be in a driver and should only be enabled by > a device-tree property, so that it does not affect devices which do not > have this feature. > > Signed-off-by: Simon Glass > Reviewed-by:

Re: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

2019-01-31 Thread Philipp Tomsich
> This function causes a 5-second delay and stops the display working on > minnie. This code should be in a driver and should only be enabled by > a device-tree property, so that it does not affect devices which do not > have this feature. > > Signed-off-by: Simon Glass > Reviewed-by: Philipp