Re: [U-Boot] [u-boot-release] [PATCH 3/6] powerpc/85xx: introduce function serdes_device_from_fm_port()

2012-08-13 Thread Timur Tabi
Kim Phillips wrote: > it's ~30% less lines of code, and the maps lie on the same line, > which helps when grepping. OK. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinf

Re: [U-Boot] [u-boot-release] [PATCH 3/6] powerpc/85xx: introduce function serdes_device_from_fm_port()

2012-08-13 Thread Kim Phillips
On Mon, 13 Aug 2012 16:22:01 -0500 Timur Tabi wrote: > Kim Phillips wrote: > > shouldn't this be a static const array lookup? > > The compiler should convert it into an array lookup automatically, but I > can change it if you insist. Since I don't like writing code that depends > on the values

Re: [U-Boot] [u-boot-release] [PATCH 3/6] powerpc/85xx: introduce function serdes_device_from_fm_port()

2012-08-13 Thread Kim Phillips
please don't post patches upstream with '[u-boot-release]' in the subject. On Fri, 10 Aug 2012 17:01:33 -0500 Timur Tabi wrote: > +enum srds_prtcl serdes_device_from_fm_port(enum fm_port port) > +{ > + switch (port) { > + case FM1_DTSEC1: > + return SGMII_FM1_DTSEC1; > +

Re: [U-Boot] [u-boot-release] [PATCH 3/6] powerpc/85xx: introduce function serdes_device_from_fm_port()

2012-08-13 Thread Timur Tabi
Kim Phillips wrote: > please don't post patches upstream with '[u-boot-release]' in the > subject. I didn't. http://lists.denx.de/pipermail/u-boot/2012-August/130618.html Your mailer is confused. I bcc the u-boot-release mailing list, and I presume your mailer (or our mail server) sent you that