Re: [U-Boot] DHCP regression on 2009-06

2009-07-14 Thread Ben Warren
Michael Zaidman wrote: > On Tue, Jul 14, 2009 at 5:57 PM, Ben Warren wrote: > >> On Tue, Jul 14, 2009 at 2:26 AM, Michael Zaidman >> wrote: >> >>> If nobody has objections I can submit this fix. >>> >>> Michael. >>> >> Please do. >> >> regards, >> Ben >> >> > > Done. > > http:/

Re: [U-Boot] DHCP regression on 2009-06

2009-07-14 Thread Michael Zaidman
On Tue, Jul 14, 2009 at 5:57 PM, Ben Warren wrote: > > On Tue, Jul 14, 2009 at 2:26 AM, Michael Zaidman > wrote: >> >> If nobody has objections I can submit this fix. >> >> Michael. > > Please do. > > regards, > Ben > Done. http://lists.denx.de/pipermail/u-boot/2009-July/056354.html Regards, Mi

Re: [U-Boot] DHCP regression on 2009-06

2009-07-14 Thread Ben Warren
On Tue, Jul 14, 2009 at 2:26 AM, Michael Zaidman wrote: > On Mon, Jul 13, 2009 at 9:40 PM, Robin Getz > wrote: > > > > On Mon 13 Jul 2009 11:11, Michael Zaidman pondered: > > > > I did verify that reverting the line exposes the bug that Michael > fixed, ... > > > > > > Ok, my target uses static I

Re: [U-Boot] DHCP regression on 2009-06

2009-07-14 Thread Michael Zaidman
On Mon, Jul 13, 2009 at 9:40 PM, Robin Getz wrote: > > On Mon 13 Jul 2009 11:11, Michael Zaidman pondered: > > > I did verify that reverting the line exposes the bug that Michael fixed, > > > ... > > > > Ok, my target uses static IP configuration so I did not verified the DHCP > > behavior. Now I

Re: [U-Boot] DHCP regression on 2009-06

2009-07-13 Thread Robin Getz
On Mon 13 Jul 2009 11:11, Michael Zaidman pondered: > > I did verify that reverting the line exposes the bug that Michael fixed, ... > > Ok, my target uses static IP configuration so I did not verified the DHCP > behavior. Now I did it. I also reverted the line and did DHCP afterwards > changed th

Re: [U-Boot] DHCP regression on 2009-06

2009-07-13 Thread Robin Getz
On Mon 13 Jul 2009 11:11, Michael Zaidman pondered: > > I did verify that reverting the line exposes the bug that Michael fixed, ... > > Ok, my target uses static IP configuration so I did not verified the DHCP > behavior. Now I did it. I also reverted the line and did DHCP afterwards > changed th

Re: [U-Boot] DHCP regression on 2009-06

2009-07-13 Thread Michael Zaidman
> I did verify that reverting the line exposes the bug that Michael fixed, ... Ok, my target uses static IP configuration so I did not verified the DHCP behavior. Now I did it. I also reverted the line and did DHCP afterwards changed the subnet and did DHCP again. It works as expected. diff --git

Re: [U-Boot] DHCP regression on 2009-06

2009-07-12 Thread Robin Getz
On Sun 12 Jul 2009 09:14, Michael Zaidman pondered: > > On Fri, Jul 10, 2009 at 10:18 PM, Robin Getz wrote: > > > On Fri 10 Jul 2009 12:27, Robin Getz pondered: > > > http://git.denx.de/?p=u-boot/u-boot-net.git;a=commitdiff;h=3c172c4fdbbb5858fae38478d6399be4a16be3fc > > > > causes a regressio

Re: [U-Boot] DHCP regression on 2009-06

2009-07-12 Thread Wolfgang Denk
Dear Michael Zaidman, In message <660c0f820907120614i2b33d8a1g9ac46c103e548...@mail.gmail.com> you wrote: > > Did you try to remove the CONFIG_IPADDR from the board's config file? > In this case the NetOurIP will get 0. That should solve the problem. Setting or not setting CONFIG_IPADDR

Re: [U-Boot] DHCP regression on 2009-06

2009-07-12 Thread Michael Zaidman
On Fri, Jul 10, 2009 at 10:18 PM, Robin Getz wrote: > On Fri 10 Jul 2009 12:27, Robin Getz pondered: > > http://git.denx.de/?p=u-boot/u-boot-net.git;a=commitdiff;h=3c172c4fdbbb5 > > 858fae38478d6399be4a16be3fc > > > > causes a regression on my network's DHCP server. > > The part of the diff that c

Re: [U-Boot] DHCP regression on 2009-06

2009-07-10 Thread Robin Getz
On Fri 10 Jul 2009 12:27, Robin Getz pondered: > http://git.denx.de/?p=u-boot/u-boot-net.git;a=commitdiff;h=3c172c4fdbbb5 > 858fae38478d6399be4a16be3fc > > causes a regression on my network's DHCP server. > > The part of the diff that causes the problem: > > #if defined(CONFIG_CMD_DHCP) > >

[U-Boot] DHCP regression on 2009-06

2009-07-10 Thread Robin Getz
http://git.denx.de/?p=u-boot/u-boot-net.git;a=commitdiff;h=3c172c4fdbbb5858fae38478d6399be4a16be3fc causes a regression on my network's DHCP server. The part of the diff that causes the problem: #if defined(CONFIG_CMD_DHCP) case DHCP: - /* Start with a cle