Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-31 Thread Michael Trimarchi
Not yet tested. Cleanup code and fix rootdev GET_DESCRIPTOR request Signed-off-by: Michael Trimarchi mich...@panicking.kicks-ass.org --- diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 324c308..3d495ca 100644 --- a/drivers/usb/host/ehci-hcd.c +++

Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-31 Thread Remy Bohmer
Hello Michael, I would prefer patches on the mailinglist to be inlined and tested. But, no further remarks on this patch. Maybe Prafulla or Terry can provide some help in testing this patch? Kind Regards, Remy ___ U-Boot mailing list

[U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-29 Thread Lv Terry-R65388
Hi All, I'm trying to enable ehci usb in our board and I found that there maybe two issues in funcion ehci_submit_root() in ehci-hcd.c. 1) In ehci_submit_root(), the function will do the following operation. From line 553 in ehci-hcd.c: typeReq = req-request 8 |

Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-29 Thread Remy Bohmer
Hi, 2009/7/29 Lv Terry-R65388 rui...@freescale.com: Hi All,    I'm trying to enable ehci usb in our board and I found that there maybe two issues in funcion ehci_submit_root() in ehci-hcd.c. 1)    In ehci_submit_root(), the function will do the following operation. From line 553 in

Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-29 Thread Michael Trimarchi
Remy Bohmer wrote: Hi, 2009/7/29 Lv Terry-R65388 rui...@freescale.com: Hi All, I'm trying to enable ehci usb in our board and I found that there maybe two issues in funcion ehci_submit_root() in ehci-hcd.c. 1) In ehci_submit_root(), the function will do the following operation.

Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-29 Thread Prafulla Wadaskar
-Original Message- From: Michael Trimarchi [mailto:trimar...@gandalf.sssup.it] Sent: Wednesday, July 29, 2009 8:41 PM To: Remy Bohmer Cc: Lv Terry-R65388; Prafulla Wadaskar; u-boot@lists.denx.de Subject: Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

Re: [U-Boot] Is it an error in function ehci_submit_root() in ehci-hcd.c

2009-07-29 Thread Lv Terry-R65388
Hi Prafulla, I'm using a little-endian machine. My board is freescale i.mx51, the core is arm12. I will try to correct these two places and test it in my board. Hope it can work. Thanks~~ Yours Terry -Original Message- From: Prafulla Wadaskar