Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Wolfgang Wegner
Dear Scott, Wolfgang, On Tue, Jul 21, 2009 at 02:02:43PM -0400, Scott McNutt wrote: ... for a two line bug fix? This is hardly a valid reason to claim copyright on the module. This practice will only discourage the contribution of original work to the project. Nobody wants to have their

Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Wolfgang Denk
Dear Wolfgang Wegner, In message 20090722094127.gv20...@leila.ping.de you wrote: So you really think your practice will encourage anybody to submit a clean patch for a bug he spent days (or weeks) to find? That's how the public review process works: You submit a patch, and it either gets

Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Wolfgang Wegner
Dear Wolfgang, On Wed, Jul 22, 2009 at 12:56:52PM +0200, Wolfgang Denk wrote: [...] If you don't do that, then either somebody else will clean up your patch and commit it and earn the credits for your work, or nobody will care and the problem remains, which means your work was basicly wasted.

Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Wolfgang Denk
Dear Wolfgang Wegner, In message 20090722103358.gw20...@leila.ping.de you wrote: Um... and instead of maintaining several private source trees you should consider poushing your code upstream, so that others do the maintenance for you. The intention is to do so with my next project at

Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Scott McNutt
Wolfgang Wegner wrote: Dear Scott, Wolfgang, On Tue, Jul 21, 2009 at 02:02:43PM -0400, Scott McNutt wrote: ... for a two line bug fix? This is hardly a valid reason to claim copyright on the module. This practice will only discourage the contribution of original work to the project.

Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Renato Andreola
Ok, please update the file with the correct bug fix with no more copyright. My intent is only to fix the bug that caused random boot failures and to keep free the good work on Nios2. I was warried about that the official main UBoot distribution contained a bug that has a big impact on the

Re: [U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-22 Thread Wolfgang Denk
Dear Renato Andreola, In message 4a66c746.4050...@imagos.it you wrote: Ok, please update the file with the correct bug fix with no more copyright. My intent is only to fix the bug that caused random boot failures and to keep free the good work on Nios2. Please re-submit a cleaned up patch.

[U-Boot] Rejected: PATCH Nios2 kernel bootstrap error due to missing processor data cache flush: fix

2009-07-21 Thread Scott McNutt
See comments. diff --git a/lib_nios2/bootm.c b/lib_nios2/bootm.c index 53fd569..1e8034b 100644 --- a/lib_nios2/bootm.c +++ b/lib_nios2/bootm.c @@ -2,6 +2,9 @@ * (C) Copyright 2003, Psyent Corporation www.psyent.com * Scott McNutt smcn...@psyent.com * + * (C) Copyright 2009, Imagos