On Thu, Jan 17, 2019 at 10:18:47AM +0100, Quentin Schulz wrote: > cmd/mtd.c:447:13: warning: ‘mtd_help_text’ defined but not used > [-Wunused-variable] > static char mtd_help_text[] = > ^~~~~~~~~~~~~ > > When SYS_LONGHELP is not defined. After looking at how other commands > work, we should surround the whole help text (even its declaration) with > an #ifdef CONFIG_SYS_LONGHELP, since it's compiled out when calling > _CMD_HELP[1] on the help text variable argument to U_BOOT_CMD. > > [1] https://elixir.bootlin.com/u-boot/latest/source/include/command.h#L181 > > Signed-off-by: Quentin Schulz <quentin.sch...@bootlin.com> > Reviewed-by: Miquel Raynal <miquel.ray...@bootlin.com>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
