Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-27 Thread Reinhard Meyer (-VC)
Martin Krause schrieb: Hi all, Some time ago I modified the current encc28j60 driver to use the generic SPI api and to work with CONFIG_NET_MULTI. It was for a project not part of mainline U-Boot (and a bit of a hack), so I didn't post the patches on the mailing list. Reinhard, if you are

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-27 Thread Martin Krause
Hi all, u-boot-boun...@lists.denx.de wrote on Monday, July 26, 2010 4:51 PM: On Sunday, July 25, 2010, Reinhard Meyer reinhard.me...@emk-elektronik.de wrote: Mike Frysinger wrote: On Sunday, July 25, 2010 20:07:31 Reinhard Meyer wrote: I can rename the current driver to like

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-27 Thread Martin Krause
Reinhard Meyer (-VC) wrote on Tuesday, July 27, 2010 9:29 AM: Martin Krause schrieb: Hi all, Some time ago I modified the current encc28j60 driver to use the generic SPI api and to work with CONFIG_NET_MULTI. It was for a project not part of mainline U-Boot (and a bit of a hack), so I didn't

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-26 Thread Reinhard Meyer
Mike Frysinger wrote: On Sunday, July 25, 2010 20:07:31 Reinhard Meyer wrote: I can rename the current driver to like enc28j60_lpc2292.c and make the two affected boards use it, so they still compile and work. I can't do those boards' maintainers work and add the required code to use the

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-26 Thread Ben Warren
On Sunday, July 25, 2010, Reinhard Meyer reinhard.me...@emk-elektronik.de wrote: Mike Frysinger wrote: On Sunday, July 25, 2010 20:07:31 Reinhard Meyer wrote: I can rename the current driver to like enc28j60_lpc2292.c and make the two affected boards use it, so they still compile and work.

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-26 Thread Mike Frysinger
On Sunday, July 25, 2010 16:40:14 Mike Frysinger wrote: On Sunday, July 25, 2010 16:06:31 Reinhard Meyer wrote: Mike Frysinger wrote: On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote: I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. someone

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Reinhard Meyer
Wolfgang Denk wrote: Submit patches, and put the board maintainers (if there are any) on Cc: If nobody complains the patches go in. Hello, making the source adhere to coding style, removing wrappers that only change function names, and making it CONFIG_NET_MULTI-able seems to change

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Mike Frysinger
On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote: I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. someone already has ... look at the archives in december of 09 -mike signature.asc Description: This is a digitally signed message part.

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Reinhard Meyer
Mike Frysinger wrote: On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote: I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. someone already has ... look at the archives in december of 09 Thanks for the hint Mike, it seems the thread there has

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Ben Warren
Hi Reinhard, On Sun, Jul 25, 2010 at 1:06 PM, Reinhard Meyer reinhard.me...@emk-elektronik.de wrote: Mike Frysinger wrote: On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote: I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. someone already has

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Reinhard Meyer
Ben Warren wrote: Hi Reinhard, On Sun, Jul 25, 2010 at 1:06 PM, Reinhard Meyer reinhard.me...@emk-elektronik.de wrote: Mike Frysinger wrote: On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote: I would like to generalize that driver and make it also

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Mike Frysinger
On Sunday, July 25, 2010 16:06:31 Reinhard Meyer wrote: Mike Frysinger wrote: On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote: I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. someone already has ... look at the archives in december of 09

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-25 Thread Mike Frysinger
On Sunday, July 25, 2010 20:07:31 Reinhard Meyer wrote: I can rename the current driver to like enc28j60_lpc2292.c and make the two affected boards use it, so they still compile and work. I can't do those boards' maintainers work and add the required code to use the new driver and make a

[U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-24 Thread Reinhard Meyer
Hello, I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. Currently it contains hard coded functionality for the LPC2292 Cpu and is used by only two boards: lpc2292sodimm and SMN42. Since the driver could be clearly generic, using just SPI and two I/O Pins for

Re: [U-Boot] drivers/net/enc28j60.c - generalisation, how?

2010-07-24 Thread Wolfgang Denk
Dear Reinhard Meyer, In message 4c4a8404.6030...@emk-elektronik.de you wrote: I would like to generalize that driver and make it also CONFIG_NET_MULTI-able. ... When I do that, clearly I cannot test the two above boards for continued functionality. Messing up the driver with #ifdefs to