Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-10 Thread Scott Wood
On Wed, 10 Nov 2010 22:28:29 +0100 Wolfgang Denk wrote: > Well, see above. You are argumenting from a low-level, implementation > point of view. For the end user this is not transparent at all. He > just runs a single "make foo_config" and a single "make all". The end > user sees and thinks

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-10 Thread Wolfgang Denk
Dear Scott Wood, In message <20101110150307.279a5...@udp111988uds.am.freescale.net> you wrote: > > I was just looking for some consistency so I could figure out what is > being objected to. When something is rejected for specific reasons, > questioning whether those reasons actually imply the con

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-10 Thread Scott Wood
On Tue, 9 Nov 2010 23:22:26 +0100 Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20101109155225.183a3...@udp111988uds.am.freescale.net> you wrote: > > > > What, semantically, is the difference between the CONFIG_SYS_TEXT_BASE > > and CONFIG_SYS_MONITOR_BASE? Just that one is used from

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Scott Wood, In message <20101109155225.183a3...@udp111988uds.am.freescale.net> you wrote: > > What, semantically, is the difference between the CONFIG_SYS_TEXT_BASE > and CONFIG_SYS_MONITOR_BASE? Just that one is used from linker Nothing. > scripts/makefiles and the other from C/assembly c

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 22:11:41 +0100 Wolfgang Denk wrote: > #ifdef NAND_SPL > #define CONFIG_SYS_TEXT_BASE_SPL xxx > #define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_TEXT_BASE_SPL > #else > #define CONFIG_SYS_TEXT_BASE yyy > #define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_TEXT_BASE > #endif > > followed by mu

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Haiying Wang, In message <1289337782.2168.148.ca...@haiying-laptop> you wrote: > > > Assuming that your code really needs to know the start address of the > > image, it should probably do something like this instead: > > > > #ifdef NAND_SPL > > #define CONFIG_SYS_TEXT_BASE xxx > > #define CO

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Haiying Wang
On Tue, 2010-11-09 at 14:11 -0700, Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20101109143747.685f9...@udp111988uds.am.freescale.net> you > wrote: > > > > I don't see how > > > > #ifdef NAND_SPL > > #define CONFIG_SYS_TEXT_BASE xxx > > #else > > #define CONFIG_SYS_TEXT_BASE yyy > > #en

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Scott Wood, In message <20101109143747.685f9...@udp111988uds.am.freescale.net> you wrote: > > I don't see how > > #ifdef NAND_SPL > #define CONFIG_SYS_TEXT_BASE xxx > #else > #define CONFIG_SYS_TEXT_BASE yyy > #endif > > is more of a maintenance problem than > > #define CONFIG_SYS_TEXT_BAS

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 21:13:00 +0100 Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20101109130427.5e918...@udp111988uds.am.freescale.net> you wrote: > > > > > For me it is on the fly when running a single "make all" sees these > > > values changing. > > > > In any case, the right answer

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Scott Wood, In message <20101109130427.5e918...@udp111988uds.am.freescale.net> you wrote: > > > For me it is on the fly when running a single "make all" sees these > > values changing. > > In any case, the right answer is a separate autoconf.mk per image. NAK. If different images need to b

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 19:59:47 +0100 Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20101109122218.13f16...@udp111988uds.am.freescale.net> you wrote: > > > > > This is no problem as long as these variables doen't change their > > > values on the fly. > > > > It's not "on the fly", it's ju

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Scott Wood, In message <20101109122218.13f16...@udp111988uds.am.freescale.net> you wrote: > > > This is no problem as long as these variables doen't change their > > values on the fly. > > It's not "on the fly", it's just that each image needs its own > autoconf.mk. For me it is on the fly

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 18:18:53 +0100 Wolfgang Denk wrote: > Dear Scott Wood, > > In message <20101109102643.45d7f...@udp111988uds.am.freescale.net> you wrote: > > > > > Maybe they should use different variables then, say > > > CONFIG_SYS_TEXT_BASE and CONFIG_SYS_TEXT_BASE_SPL ? > > > > Why? It's

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Haiying Wang, In message <1289320865.2168.92.ca...@haiying-laptop> you wrote: > > It is in one of the error messages, there are others for the same error. > Here is the total message when building tlb.c for nand_spl: ... > powerpc-none-linux-gnuspe-gcc -g -Os -mrelocatable -fPIC -meabi > -

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Scott Wood, In message <20101109102643.45d7f...@udp111988uds.am.freescale.net> you wrote: > > > Maybe they should use different variables then, say > > CONFIG_SYS_TEXT_BASE and CONFIG_SYS_TEXT_BASE_SPL ? > > Why? It's the same variable, just for a different build. Are we going > to have _S

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Wolfgang Denk
Dear Haiying Wang, In message <1289314359.2168.20.ca...@haiying-laptop> you wrote: > > > You did not answer my question. The error message shows _where_ the > > previous definition came from. Please check this. > OK, the error message is: > "In file included > from /home/haiying/Opensource/Kumar/u

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Scott Wood
On Tue, 9 Nov 2010 17:23:43 +0100 Wolfgang Denk wrote: > > Yes, now the problem is only one define of CONFIG_SYS_TEXT_BASE is > > allowed for one board config,i.e CONFIG_NAND, but two images need to be > > generated for nand boot, one is u-boot-spl.bin, the other is u-boot.bin. > > They need diff

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Haiying Wang
On Tue, 2010-11-09 at 09:23 -0700, Wolfgang Denk wrote: > Dear Haiying Wang, > Is this all the error messages you get? Normally tehre should be > another message, for example: > > [filename]:[lineno]:[column]: warning: this is the location of the > previous definition > > or, if there was a "-DC

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-09 Thread Haiying Wang
Dear Wolfgang, On Mon, 2010-11-08 at 16:36 -0700, Wolfgang Denk wrote: > Dear Haiying Wang, > > Why it looks broken? I do need CONFIG_NAND defined for 8536DS nand > > build. For building nand uboot, 2 images are needed, one is 4K > nand_spl > > Yes. But there is also MPC8536DS and MPC8536DS_36BIT

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-08 Thread Wolfgang Denk
Dear Haiying Wang, In message <1289240747.1900.58.ca...@haiying-laptop> you wrote: > > > > Before sending last email, I modified the CONFIG_SYS_TEXT_BASE in > > 8536DS > > > header file like this: > > > #ifdef CONFIG_NAND > > > #ifdef CONFIG_NAND_SPL > > > #define CONFIG_SYS_TEXT

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-08 Thread Haiying Wang
On Mon, 2010-11-08 at 09:30 -0700, Wolfgang Denk wrote: > Dear Haiying Wang, > > In message <1289230710.1900.27.ca...@haiying-laptop> you wrote: > > > > Before sending last email, I modified the CONFIG_SYS_TEXT_BASE in > 8536DS > > header file like this: > > #ifdef CONFIG_NAND > > #ifd

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-08 Thread Wolfgang Denk
Dear Haiying Wang, In message <1289230710.1900.27.ca...@haiying-laptop> you wrote: > > Before sending last email, I modified the CONFIG_SYS_TEXT_BASE in 8536DS > header file like this: > #ifdef CONFIG_NAND > #ifdef CONFIG_NAND_SPL > #define CONFIG_SYS_TEXT_BASE 0xfff0 >

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-08 Thread Haiying Wang
Dear Wolfgang, On Sun, 2010-11-07 at 14:31 -0700, Wolfgang Denk wrote: > Dear Haiying Wang, > > In message <1288970062.1855.44.ca...@haiying-laptop> you wrote: > > > > Wolfgang's latest commit to change all TEXT_BASE to > CONFIG_SYS_TEXT_BASE > > breaks the build for nand_spl. He defined CONFIG_S

Re: [U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-07 Thread Wolfgang Denk
Dear Haiying Wang, In message <1288970062.1855.44.ca...@haiying-laptop> you wrote: > > Wolfgang's latest commit to change all TEXT_BASE to CONFIG_SYS_TEXT_BASE > breaks the build for nand_spl. He defined CONFIG_SYS_TEXT_BASE in board Which board(s) / configuration(s) are you talkign about? > he

[U-Boot] nand spl build with wrong CONFIG_SYS_TEXT_BASE

2010-11-05 Thread Haiying Wang
Hi Scott, Wolfgang's latest commit to change all TEXT_BASE to CONFIG_SYS_TEXT_BASE breaks the build for nand_spl. He defined CONFIG_SYS_TEXT_BASE in board header file for CONFIG_NAND, and renamed TEXT_BASE to CONFIG_SYS_TEXT_BASE in nand_spl/board/.../Makefile. Then for u-boot-spl, the CONFIG_SYS_