Rather than selecting CMD_QFW, we should make the option itself by
enabled by default on these platforms.  Then in the board-specific
Kconfig we should select the appropriate back-end as needed if the
command is enabled.

Signed-off-by: Tom Rini <tr...@konsulko.com>
---
Cc: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi>
Cc: Bin Meng <bmeng...@gmail.com>
---
 board/emulation/qemu-arm/Kconfig | 3 +--
 board/emulation/qemu-x86/Kconfig | 2 +-
 cmd/Kconfig                      | 2 ++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/board/emulation/qemu-arm/Kconfig b/board/emulation/qemu-arm/Kconfig
index 09c95413a541..ac2d078f42a1 100644
--- a/board/emulation/qemu-arm/Kconfig
+++ b/board/emulation/qemu-arm/Kconfig
@@ -5,8 +5,7 @@ config TEXT_BASE
 
 config BOARD_SPECIFIC_OPTIONS # dummy
        def_bool y
-       select CMD_QFW
-       select QFW_MMIO
+       select QFW_MMIO if CMD_QFW
        imply VIRTIO_MMIO
        imply VIRTIO_PCI
        imply VIRTIO_NET
diff --git a/board/emulation/qemu-x86/Kconfig b/board/emulation/qemu-x86/Kconfig
index 787751abba4f..01dc1d497aec 100644
--- a/board/emulation/qemu-x86/Kconfig
+++ b/board/emulation/qemu-x86/Kconfig
@@ -20,7 +20,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
        def_bool y
        select X86_RESET_VECTOR
        select QEMU
-       select QFW_PIO
+       select QFW_PIO if CMD_QFW
        select BOARD_ROMSIZE_KB_1024
        imply VIRTIO_PCI
        imply VIRTIO_NET
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 205df2f1fb65..cd2793b6876b 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -2247,6 +2247,8 @@ config CMD_SYSBOOT
 config CMD_QFW
        bool "qfw"
        select QFW
+       default y if TARGET_QEMU_ARM_32BIT || TARGET_QEMU_ARM_64BIT || \
+               TARGET_QEMU_X86 || TARGET_QEMU_X86_64
        help
          This provides access to the QEMU firmware interface.  The main
          feature is to allow easy loading of files passed to qemu-system
-- 
2.34.1

Reply via email to