Re: [PATCH 1/5] dm: core: Fix devfdt_get_addr_ptr return value

2020-06-11 Thread Ovidiu Panait
Hi, On 27.05.2020 15:05, Matthias Brugger wrote: On 27/05/2020 08:41, Ovidiu Panait wrote: According to the description of devfdt_get_addr_ptr, this function should return NULL on failure, but currently it returns (void *)FDT_ADDR_T_NONE. This is also a problem because there are two

Re: [PATCH 1/5] dm: core: Fix devfdt_get_addr_ptr return value

2020-05-28 Thread Simon Glass
Hi Sean, On Thu, 28 May 2020 at 13:29, Sean Anderson wrote: > > On 5/28/20 10:32 AM, Simon Glass wrote: > > On Wed, 27 May 2020 at 00:45, Ovidiu Panait > > wrote: > >> > >> According to the description of devfdt_get_addr_ptr, this function should > >> return NULL on failure, but currently it

Re: [PATCH 1/5] dm: core: Fix devfdt_get_addr_ptr return value

2020-05-28 Thread Sean Anderson
On 5/28/20 10:32 AM, Simon Glass wrote: > On Wed, 27 May 2020 at 00:45, Ovidiu Panait > wrote: >> >> According to the description of devfdt_get_addr_ptr, this function should >> return NULL on failure, but currently it returns (void *)FDT_ADDR_T_NONE. >> >> This is also a problem because there

Re: [PATCH 1/5] dm: core: Fix devfdt_get_addr_ptr return value

2020-05-28 Thread Simon Glass
On Wed, 27 May 2020 at 00:45, Ovidiu Panait wrote: > > According to the description of devfdt_get_addr_ptr, this function should > return NULL on failure, but currently it returns (void *)FDT_ADDR_T_NONE. > > This is also a problem because there are two definitions for > dev_read_addr_ptr,

Re: [PATCH 1/5] dm: core: Fix devfdt_get_addr_ptr return value

2020-05-28 Thread Cédric Le Goater
On 5/27/20 8:41 AM, Ovidiu Panait wrote: > According to the description of devfdt_get_addr_ptr, this function > should return NULL on failure, but currently it returns (void > *)FDT_ADDR_T_NONE. > > This is also a problem because there are two definitions for > dev_read_addr_ptr, depending on

Re: [PATCH 1/5] dm: core: Fix devfdt_get_addr_ptr return value

2020-05-27 Thread Matthias Brugger
On 27/05/2020 08:41, Ovidiu Panait wrote: > According to the description of devfdt_get_addr_ptr, this function should > return NULL on failure, but currently it returns (void *)FDT_ADDR_T_NONE. > > This is also a problem because there are two definitions for > dev_read_addr_ptr, depending on