On 15/06/2022 02:25, Peng Fan wrote:
>> Subject: Re: [PATCH 7/8] binman_sym: guard with
>> CONFIG_IS_ENABLED(BINMAN_SYMBOLS)
>>
>> On 13/06/2022 05:34, Peng Fan (OSS) wrote:
>>> 在 2022/6/11 20:44, Alper Nebi Yasak 写道:
>>>> CONFIG_IS_ENABLED(BINMAN)
> Subject: Re: [PATCH 7/8] binman_sym: guard with
> CONFIG_IS_ENABLED(BINMAN_SYMBOLS)
>
> On 13/06/2022 05:34, Peng Fan (OSS) wrote:
> > 在 2022/6/11 20:44, Alper Nebi Yasak 写道:
> >> CONFIG_IS_ENABLED(BINMAN) doesn't work, but
> IS_ENABLED(CONFIG_BINMAN)
> >
On 13/06/2022 05:34, Peng Fan (OSS) wrote:
> 在 2022/6/11 20:44, Alper Nebi Yasak 写道:
>> CONFIG_IS_ENABLED(BINMAN) doesn't work, but IS_ENABLED(CONFIG_BINMAN)
>> worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send you
>> a git branch if you want?
>
> But now with your suggestion,
On 13/06/2022 05:31, Peng Fan (OSS) wrote:
>> 在 2022/6/11 0:47, Alper Nebi Yasak 写道:
>>> Looks like I have misunderstood things here a bit. CONFIG_BINMAN enables
>>> you to declare and use symbols. CONFIG_SPL/TPL_BINMAN_SYMBOLS declares
>>> certain symbols ('u_boot_any'). The name is a bit
在 2022/6/11 20:44, Alper Nebi Yasak 写道:
On 11/06/2022 13:32, Peng Fan (OSS) wrote:
在 2022/6/11 0:47, Alper Nebi Yasak 写道:
I have sent a patch [1] that fixes the build error mentioned here, which
should be used instead of this patch. Please:
- Rebase on top of that series [1]
- Maybe drop
在 2022/6/11 18:32, Peng Fan (OSS) 写道:
在 2022/6/11 0:47, Alper Nebi Yasak 写道:
On 04/06/2022 14:50, Alper Nebi Yasak wrote:
On 03/06/2022 10:17, Peng Fan (OSS) wrote:
From: Peng Fan
There is case that CONFIG_BINMAN is defined, but
CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case,
On 11/06/2022 13:32, Peng Fan (OSS) wrote:
> 在 2022/6/11 0:47, Alper Nebi Yasak 写道:
>> I have sent a patch [1] that fixes the build error mentioned here, which
>> should be used instead of this patch. Please:
>>
>> - Rebase on top of that series [1]
>> - Maybe drop config changes in 1/8 and 2/8
在 2022/6/11 0:47, Alper Nebi Yasak 写道:
On 04/06/2022 14:50, Alper Nebi Yasak wrote:
On 03/06/2022 10:17, Peng Fan (OSS) wrote:
From: Peng Fan
There is case that CONFIG_BINMAN is defined, but
CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
build failure. So use
On 04/06/2022 14:50, Alper Nebi Yasak wrote:
> On 03/06/2022 10:17, Peng Fan (OSS) wrote:
>> From: Peng Fan
>>
>> There is case that CONFIG_BINMAN is defined, but
>> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
>> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard
On 03/06/2022 10:17, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> There is case that CONFIG_BINMAN is defined, but
> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and
> define CONFIG_SPL_BINMAN_SYMBOLS
10 matches
Mail list logo