Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-18 Thread Alper Nebi Yasak
On 15/06/2022 02:25, Peng Fan wrote: >> Subject: Re: [PATCH 7/8] binman_sym: guard with >> CONFIG_IS_ENABLED(BINMAN_SYMBOLS) >> >> On 13/06/2022 05:34, Peng Fan (OSS) wrote: >>> 在 2022/6/11 20:44, Alper Nebi Yasak 写道: >>>> CONFIG_IS_ENABLED(BINMAN)

RE: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-14 Thread Peng Fan
> Subject: Re: [PATCH 7/8] binman_sym: guard with > CONFIG_IS_ENABLED(BINMAN_SYMBOLS) > > On 13/06/2022 05:34, Peng Fan (OSS) wrote: > > 在 2022/6/11 20:44, Alper Nebi Yasak 写道: > >> CONFIG_IS_ENABLED(BINMAN) doesn't work, but > IS_ENABLED(CONFIG_BINMAN) > >

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-14 Thread Alper Nebi Yasak
On 13/06/2022 05:34, Peng Fan (OSS) wrote: > 在 2022/6/11 20:44, Alper Nebi Yasak 写道: >> CONFIG_IS_ENABLED(BINMAN) doesn't work, but IS_ENABLED(CONFIG_BINMAN) >> worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send you >> a git branch if you want? > > But now with your suggestion,

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-14 Thread Alper Nebi Yasak
On 13/06/2022 05:31, Peng Fan (OSS) wrote: >> 在 2022/6/11 0:47, Alper Nebi Yasak 写道: >>> Looks like I have misunderstood things here a bit. CONFIG_BINMAN enables >>> you to declare and use symbols. CONFIG_SPL/TPL_BINMAN_SYMBOLS declares >>> certain symbols ('u_boot_any'). The name is a bit

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-12 Thread Peng Fan (OSS)
在 2022/6/11 20:44, Alper Nebi Yasak 写道: On 11/06/2022 13:32, Peng Fan (OSS) wrote: 在 2022/6/11 0:47, Alper Nebi Yasak 写道: I have sent a patch [1] that fixes the build error mentioned here, which should be used instead of this patch. Please: - Rebase on top of that series [1] - Maybe drop

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-12 Thread Peng Fan (OSS)
在 2022/6/11 18:32, Peng Fan (OSS) 写道: 在 2022/6/11 0:47, Alper Nebi Yasak 写道: On 04/06/2022 14:50, Alper Nebi Yasak wrote: On 03/06/2022 10:17, Peng Fan (OSS) wrote: From: Peng Fan There is case that CONFIG_BINMAN is defined, but CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case,

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-11 Thread Alper Nebi Yasak
On 11/06/2022 13:32, Peng Fan (OSS) wrote: > 在 2022/6/11 0:47, Alper Nebi Yasak 写道: >> I have sent a patch [1] that fixes the build error mentioned here, which >> should be used instead of this patch. Please: >> >> - Rebase on top of that series [1] >> - Maybe drop config changes in 1/8 and 2/8

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-11 Thread Peng Fan (OSS)
在 2022/6/11 0:47, Alper Nebi Yasak 写道: On 04/06/2022 14:50, Alper Nebi Yasak wrote: On 03/06/2022 10:17, Peng Fan (OSS) wrote: From: Peng Fan There is case that CONFIG_BINMAN is defined, but CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be build failure. So use

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-10 Thread Alper Nebi Yasak
On 04/06/2022 14:50, Alper Nebi Yasak wrote: > On 03/06/2022 10:17, Peng Fan (OSS) wrote: >> From: Peng Fan >> >> There is case that CONFIG_BINMAN is defined, but >> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be >> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard

Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

2022-06-04 Thread Alper Nebi Yasak
On 03/06/2022 10:17, Peng Fan (OSS) wrote: > From: Peng Fan > > There is case that CONFIG_BINMAN is defined, but > CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be > build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and > define CONFIG_SPL_BINMAN_SYMBOLS