Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Tom Rini
On Fri, Feb 05, 2021 at 09:31:00PM +0200, Andy Shevchenko wrote: > On Fri, Feb 05, 2021 at 01:07:02PM -0500, Tom Rini wrote: > > On Fri, Feb 05, 2021 at 12:50:56PM -0500, Tom Rini wrote: > > > On Fri, Feb 05, 2021 at 07:06:54PM +0200, Andy Shevchenko wrote: > > > > On Wed, Feb 03, 2021 at

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 01:07:02PM -0500, Tom Rini wrote: > On Fri, Feb 05, 2021 at 12:50:56PM -0500, Tom Rini wrote: > > On Fri, Feb 05, 2021 at 07:06:54PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 03, 2021 at 11:50:53AM +0200, Andy Shevchenko wrote: ... > > > Okay, as promised, I

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Tom Rini
On Fri, Feb 05, 2021 at 12:50:56PM -0500, Tom Rini wrote: > On Fri, Feb 05, 2021 at 07:06:54PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 03, 2021 at 11:50:53AM +0200, Andy Shevchenko wrote: > > > On Mon, Feb 1, 2021 at 9:29 PM Tom Rini wrote: > > > > > > > > On Fri, Jan 29, 2021 at 09:50:50AM

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Tom Rini
On Fri, Feb 05, 2021 at 07:06:54PM +0200, Andy Shevchenko wrote: > On Wed, Feb 03, 2021 at 11:50:53AM +0200, Andy Shevchenko wrote: > > On Mon, Feb 1, 2021 at 9:29 PM Tom Rini wrote: > > > > > > On Fri, Jan 29, 2021 at 09:50:50AM +0100, Matthias Brugger wrote: > > > > > > > > > > > > On

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Andy Shevchenko
On Wed, Feb 03, 2021 at 11:50:53AM +0200, Andy Shevchenko wrote: > On Mon, Feb 1, 2021 at 9:29 PM Tom Rini wrote: > > > > On Fri, Jan 29, 2021 at 09:50:50AM +0100, Matthias Brugger wrote: > > > > > > > > > On 28/01/2021 16:52, Andy Shevchenko wrote: > > > > On Thu, Jan 28, 2021 at 02:12:40PM

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-03 Thread Andy Shevchenko
On Mon, Feb 1, 2021 at 9:29 PM Tom Rini wrote: > > On Fri, Jan 29, 2021 at 09:50:50AM +0100, Matthias Brugger wrote: > > > > > > On 28/01/2021 16:52, Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 02:12:40PM +0100, Nicolas Saenz Julienne wrote: > > >> Don't start/stop an stdio device that

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-01 Thread Simon Glass
Hi Nicolas, On Thu, 28 Jan 2021 at 06:12, Nicolas Saenz Julienne wrote: > > Don't start/stop an stdio device that might have been already freed. > > Signed-off-by: Nicolas Saenz Julienne > Fixes: 70c2525c0d3c ("IOMUX: Stop dropped consoles") > > --- > Changes since v1: > - Add comment stating

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-01 Thread Tom Rini
On Fri, Jan 29, 2021 at 09:50:50AM +0100, Matthias Brugger wrote: > > > On 28/01/2021 16:52, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 02:12:40PM +0100, Nicolas Saenz Julienne wrote: > >> Don't start/stop an stdio device that might have been already freed. > >> > >> Signed-off-by:

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-01-29 Thread Matthias Brugger
On 28/01/2021 16:52, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 02:12:40PM +0100, Nicolas Saenz Julienne wrote: >> Don't start/stop an stdio device that might have been already freed. >> >> Signed-off-by: Nicolas Saenz Julienne >> Fixes: 70c2525c0d3c ("IOMUX: Stop dropped consoles") > >

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 02:12:40PM +0100, Nicolas Saenz Julienne wrote: > Don't start/stop an stdio device that might have been already freed. > > Signed-off-by: Nicolas Saenz Julienne > Fixes: 70c2525c0d3c ("IOMUX: Stop dropped consoles") ... > + /* > + * TODO: This is a workaround