Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-23 Thread Albert ARIBAUD
Hi Jeroen, On Sat, 24 Aug 2013 13:55:38 +0200, Jeroen Hofstee jer...@myspectrum.nl wrote: The movt/movw instruction can be used to hardcode an memory location in the instruction itself. The linker starts complaining about this if the compiler decides to do so: relocation R_ARM_MOVW_ABS_NC

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-20 Thread Jeroen Hofstee
Hello Tom, On 09/19/2013 11:16 PM, Tom Rini wrote: On Sat, Aug 24, 2013 at 01:55:38PM +0200, Jeroen Hofstee wrote: The movt/movw instruction can be used to hardcode an memory location in the instruction itself. The linker starts complaining about this if the compiler decides to do so:

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-20 Thread Tom Rini
On Fri, Sep 20, 2013 at 07:15:29PM +0200, Jeroen Hofstee wrote: Hello Tom, On 09/19/2013 11:16 PM, Tom Rini wrote: On Sat, Aug 24, 2013 at 01:55:38PM +0200, Jeroen Hofstee wrote: The movt/movw instruction can be used to hardcode an memory location in the instruction itself. The linker

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-20 Thread Simon Glass
On Sat, Aug 24, 2013 at 5:55 AM, Jeroen Hofstee jer...@myspectrum.nlwrote: The movt/movw instruction can be used to hardcode an memory location in the instruction itself. The linker starts complaining about this if the compiler decides to do so: relocation R_ARM_MOVW_ABS_NC against `a local

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-19 Thread Tom Rini
On Sat, Aug 24, 2013 at 01:55:38PM +0200, Jeroen Hofstee wrote: The movt/movw instruction can be used to hardcode an memory location in the instruction itself. The linker starts complaining about this if the compiler decides to do so: relocation R_ARM_MOVW_ABS_NC against `a local symbol' can

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-17 Thread TigerLiu
Hi, experts: The movt/movw instruction can be used to hardcode an memory location in the instruction itself. The linker starts complaining about this if the compiler decides to do so: relocation R_ARM_MOVW_ABS_NC against `a local symbol' can not be used and it is not support by U-boot as well.

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-17 Thread Wolfgang Denk
Dear tiger...@viatech.com.cn, In message fe7aded5c2218b4786c09cd97dc4c49fa88...@exchbj02.viatech.com.bj you wrote: I tested 2013.10-rc2, but still failed to build by -O0 / -O1 etc. May I ask why you want to use other optimization levels? Do you just hope that your code may run faster, or do

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-17 Thread TigerLiu
Hi, Denk: May I ask why you want to use other optimization levels? Do you just hope that your code may run faster, or do you have actual proof (i. e. measurements) that this is the case? It would be interesting if you could share any such measured results. Not for running faster. I just think:

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-17 Thread Wolfgang Denk
Dear tiger...@viatech.com.cn, In message fe7aded5c2218b4786c09cd97dc4c49fa88...@exchbj02.viatech.com.bj you wrote: May I ask why you want to use other optimization levels? Do you just hope that your code may run faster, or do you have actual proof (i. e. measurements) that this is the case?

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-17 Thread TigerLiu
Hi, experts: -# check that only R_ARM_RELATIVE relocations are generated ifneq ($(CONFIG_SPL_BUILD),y) -ALL-y += checkarmreloc +# Check that only R_ARM_RELATIVE relocations are generated. +ALL-y += checkarmreloc +# The movt / movw can hardcode 16 bit parts of the addresses in the +# instruction.

Re: [U-Boot] [PATCH] arm: prevent using movt/movw address loads

2013-09-17 Thread Jeroen Hofstee
On 09/17/2013 12:44 PM, tiger...@viatech.com.cn wrote: Jeroen's patch is very simple. So, is there any side-effect? Not that I am aware of. If not, why not add it into 2013.10 release version? :) That is up to Albert and Tom. Regards, Jeroen ___