Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-08-12 Thread Michael Trimarchi
Hi On Mon, Aug 12, 2013 at 6:57 PM, Axel Lin wrote: > 2013/7/1 Vipin Kumar : >> On 7/1/2013 11:02 AM, Axel Lin wrote: The questions raised here are valid and it forced me to re-read the datasheet. For your convenience, I must tell you that the device is actually pl06

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-08-12 Thread Axel Lin
2013/7/1 Vipin Kumar : > On 7/1/2013 11:02 AM, Axel Lin wrote: >>> >>> >>> The questions raised here are valid and it forced me to re-read the >>> datasheet. For your convenience, I must tell you that the device is >>> actually >>> pl061 from ARM, so the driver can also be named so. >>> >>> The dat

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Vipin Kumar
On 7/1/2013 11:02 AM, Axel Lin wrote: The questions raised here are valid and it forced me to re-read the datasheet. For your convenience, I must tell you that the device is actually pl061 from ARM, so the driver can also be named so. The datasheet is here http://infocenter.arm.com/help/index.j

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Axel Lin
> > The questions raised here are valid and it forced me to re-read the > datasheet. For your convenience, I must tell you that the device is actually > pl061 from ARM, so the driver can also be named so. > > The datasheet is here > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi019

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Vipin Kumar
On 6/30/2013 2:27 PM, Axel Lin wrote: 2013/6/30 Michael Trimarchi: Hi Il giorno 30/giu/2013 06:18, "Axel Lin" ha scritto: 2013/6/21 Michael Trimarchi: On 06/21/2013 06:40 AM, Vipin Kumar wrote: On 6/20/2013 7:26 PM, Axel Lin wrote: 2013/6/20 Marek Vasut Dear Axel Lin, In current gpio

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Axel Lin
2013/6/30 Michael Trimarchi : > Hi > Il giorno 30/giu/2013 06:18, "Axel Lin" ha scritto: > > >> >> 2013/6/21 Michael Trimarchi : >> > On 06/21/2013 06:40 AM, Vipin Kumar wrote: >> >> On 6/20/2013 7:26 PM, Axel Lin wrote: >> >>> 2013/6/20 Marek Vasut >> >> Dear Axel Lin, >> >> >

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-30 Thread Michael Trimarchi
Hi Il giorno 30/giu/2013 06:18, "Axel Lin" ha scritto: > > 2013/6/21 Michael Trimarchi : > > On 06/21/2013 06:40 AM, Vipin Kumar wrote: > >> On 6/20/2013 7:26 PM, Axel Lin wrote: > >>> 2013/6/20 Marek Vasut > > Dear Axel Lin, > > > In current gpio_set_value() implementation, it

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-29 Thread Axel Lin
2013/6/21 Michael Trimarchi : > On 06/21/2013 06:40 AM, Vipin Kumar wrote: >> On 6/20/2013 7:26 PM, Axel Lin wrote: >>> 2013/6/20 Marek Vasut Dear Axel Lin, > In current gpio_set_value() implementation, it always sets the gpio > control > bit no matter the value argument

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Michael Trimarchi
On 06/21/2013 06:40 AM, Vipin Kumar wrote: > On 6/20/2013 7:26 PM, Axel Lin wrote: >> 2013/6/20 Marek Vasut >>> >>> Dear Axel Lin, >>> In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value argument is 0 or 1. Thus the GPIOs never set to l

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Vipin Kumar
On 6/20/2013 7:26 PM, Axel Lin wrote: 2013/6/20 Marek Vasut Dear Axel Lin, In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value argument is 0 or 1. Thus the GPIOs never set to low. This patch fixes this bug. Signed-off-by: Axel Lin --- drivers

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Marek Vasut
Dear Michael Trimarchi, > Hi > > On 06/20/2013 03:56 PM, Axel Lin wrote: > > 2013/6/20 Marek Vasut > > > >> Dear Axel Lin, > >> > >>> In current gpio_set_value() implementation, it always sets the gpio > >>> control bit no matter the value argument is 0 or 1. Thus the GPIOs > >>> never set to

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Michael Trimarchi
Hi On 06/20/2013 03:56 PM, Axel Lin wrote: > 2013/6/20 Marek Vasut >> >> Dear Axel Lin, >> >>> In current gpio_set_value() implementation, it always sets the gpio control >>> bit no matter the value argument is 0 or 1. Thus the GPIOs never set to >>> low. This patch fixes this bug. >>> >>> Signed

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Marek Vasut
Dear Michael Trimarchi, > Hi > > Il giorno 20/giu/2013 15:57, "Marek Vasut" ha scritto: > > Dear Michael Trimarchi, > > > > > Hi > > > > > > Il giorno 20/giu/2013 09:14, "Axel Lin" ha > > scritto: > > > > In current gpio_set_value() implementation, it always sets the gpio > > > > > > contro

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Michael Trimarchi
Hi Il giorno 20/giu/2013 15:57, "Marek Vasut" ha scritto: > > Dear Michael Trimarchi, > > > Hi > > > > Il giorno 20/giu/2013 09:14, "Axel Lin" ha scritto: > > > In current gpio_set_value() implementation, it always sets the gpio > > > > control bit > > > > > no matter the value argument is 0 or 1

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Axel Lin
2013/6/20 Marek Vasut > > Dear Axel Lin, > > > In current gpio_set_value() implementation, it always sets the gpio control > > bit no matter the value argument is 0 or 1. Thus the GPIOs never set to > > low. This patch fixes this bug. > > > > Signed-off-by: Axel Lin > > --- > > drivers/gpio/spea

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Marek Vasut
Dear Michael Trimarchi, > Hi > > Il giorno 20/giu/2013 09:14, "Axel Lin" ha scritto: > > In current gpio_set_value() implementation, it always sets the gpio > > control bit > > > no matter the value argument is 0 or 1. Thus the GPIOs never set to low. > > This patch fixes this bug. > > > > Si

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Marek Vasut
Dear Axel Lin, > In current gpio_set_value() implementation, it always sets the gpio control > bit no matter the value argument is 0 or 1. Thus the GPIOs never set to > low. This patch fixes this bug. > > Signed-off-by: Axel Lin > --- > drivers/gpio/spear_gpio.c | 5 - > 1 file changed, 4 i

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Michael Trimarchi
Hi Il giorno 20/giu/2013 09:14, "Axel Lin" ha scritto: > > In current gpio_set_value() implementation, it always sets the gpio control bit > no matter the value argument is 0 or 1. Thus the GPIOs never set to low. > This patch fixes this bug. > > Signed-off-by: Axel Lin > --- > drivers/gpio/spea

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-06-20 Thread Stefan Roese
On 20.06.2013 09:13, Axel Lin wrote: > In current gpio_set_value() implementation, it always sets the gpio control > bit > no matter the value argument is 0 or 1. Thus the GPIOs never set to low. > This patch fixes this bug. > > Signed-off-by: Axel Lin Acked-by: Stefan Roese Thanks, Stefan _