Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-11-02 Thread Lukasz Majewski
Hi Andy, Hmm... looks like it is code done by me :-) So little explanation shall be given. This code is necessary for some targets (like Samsung's Goni) which can only support 4 bit MMC mode. for (; width = 0; width--) { So for FSL ESDHC, the width = 3, after

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-11-01 Thread Huang Changming-R66093
: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit Hmm... looks like it is code done by me :-) So little explanation shall be given. This code is necessary for some targets (like Samsung's Goni) which can only support 4 bit MMC mode. for (; width = 0; width

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-11-01 Thread Jaehoon Chung
Hi, Andy has sent the patch related with this problem. Check the patch [RFC] mmc: Properly determine maximum supported bus width Best Regards, Jaehoon Chung decide the best workaround was to cripple our controller by eliminating support for 8-bit? I see 12bit width when using mmcinfo, then

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-11-01 Thread Huang Changming-R66093
; l...@theia.denx.de Subject: Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit Hi, Andy has sent the patch related with this problem. Check the patch [RFC] mmc: Properly determine maximum supported bus width Best Regards, Jaehoon Chung decide the best workaround

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-11-01 Thread Marek Vasut
[mailto:jh80.ch...@samsung.com] Sent: Friday, November 02, 2012 10:03 AM To: Huang Changming-R66093 Cc: Andy Fleming; Lukasz Majewski; Jaehoon Chung; Marek Vasut; u- b...@lists.denx.de; Wen; l...@theia.denx.de Subject: Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit Hi

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-31 Thread Lukasz Majewski
Hi Jaehoon, Hi, Lukasz, For the current u-boot codes, only 4bit/1bit SD/SDHC bus width is support. So for MMC card, we also support 4bit bus width, otherwiase, we will get the 12bit bus width, which is not correct: Andy ... can you please explain? I don't quite understand the

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-31 Thread Jaehoon Chung
Hi Lukasz, width = ((mmc-host_caps MMC_MODE_MASK_WIDTH_BITS) MMC_MODE_WIDTH_BITS_SHIFT); This code has the problem. If width is set to 0x3, then BUS_WIDTH field of ext_csd register is set to 0x3. Value 0x3 is nothing.(It's reserved) If we want to set

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-31 Thread Marek Vasut
Of Huang Changming-R66093 Sent: Wednesday, October 31, 2012 10:08 AM To: Andy Fleming; Marek Vasut Cc: u-b...@linux.freescale.net Subject: Re: [u-boot] [PATCH] powerpc/esdhc: force the bus width to 4bit Below is the old codes (width = 2): } else { for (width

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-31 Thread Marek Vasut
Dear Huang Changming-R66093, Reposting _AGAIN_ because you again discarded the U-Boot ML address. Best Regards Jerry Huang Can you please fix your mailer? -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Thursday, November 01, 2012 10:26 AM To: Huang

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-31 Thread Huang Changming-R66093
-Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Thursday, November 01, 2012 11:06 AM To: Huang Changming-R66093 Cc: Andy Fleming; u-b...@linux.freescale.net; u-boot@lists.denx.de Subject: Re: [PATCH] powerpc/esdhc: force the bus width to 4bit Dear Huang

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-31 Thread Andy Fleming
Hmm... looks like it is code done by me :-) So little explanation shall be given. This code is necessary for some targets (like Samsung's Goni) which can only support 4 bit MMC mode. for (; width = 0; width--) { So for FSL ESDHC, the width = 3, after implement mmc_switch

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-30 Thread Jaehoon Chung
On 10/23/2012 06:50 PM, Marek Vasut wrote: Dear Huang Changming-R66093, Best Regards Jerry Huang -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Tuesday, October 23, 2012 3:24 PM To: Huang Changming-R66093 Cc: u-boot@lists.denx.de; Andy Fleming Subject: Re:

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-30 Thread Lukasz Majewski
Hi Jaehoon, On 10/23/2012 06:50 PM, Marek Vasut wrote: Dear Huang Changming-R66093, Best Regards Jerry Huang -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Tuesday, October 23, 2012 3:24 PM To: Huang Changming-R66093 Cc: u-boot@lists.denx.de; Andy

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-30 Thread Jaehoon Chung
Hi, Lukasz, For the current u-boot codes, only 4bit/1bit SD/SDHC bus width is support. So for MMC card, we also support 4bit bus width, otherwiase, we will get the 12bit bus width, which is not correct: Andy ... can you please explain? I don't quite understand the problem, I thought we

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-23 Thread Marek Vasut
Dear chang-ming.hu...@freescale.com, From: Jerry Huang chang-ming.hu...@freescale.com For the current u-boot codes, only 4bit/1bit SD/SDHC bus width is support. So for MMC card, we also support 4bit bus width, otherwiase, we will get the 12bit bus width, which is not correct: Andy ... can

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-23 Thread Huang Changming-R66093
Best Regards Jerry Huang -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Tuesday, October 23, 2012 3:24 PM To: Huang Changming-R66093 Cc: u-boot@lists.denx.de; Andy Fleming Subject: Re: [PATCH] powerpc/esdhc: force the bus width to 4bit Dear

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-23 Thread Marek Vasut
Dear Huang Changming-R66093, Best Regards Jerry Huang -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Tuesday, October 23, 2012 3:24 PM To: Huang Changming-R66093 Cc: u-boot@lists.denx.de; Andy Fleming Subject: Re: [PATCH] powerpc/esdhc: force the bus

Re: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit

2012-10-23 Thread Huang Changming-R66093
Dear chang-ming.hu...@freescale.com, From: Jerry Huang chang-ming.hu...@freescale.com For the current u-boot codes, only 4bit/1bit SD/SDHC bus width is support. So for MMC card, we also support 4bit bus width, otherwiase, we will get the 12bit bus width,