Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-20 Thread Stephen Warren
On 09/20/2018 12:19 PM, Heinrich Schuchardt wrote: Spawn.exept has a try block without 'except'. When the py test is running it is connected via pipes to the U-Boot process. If the U-Boot process ends prematurely, e.g. due to a segmentation fault, the pipes are broken. Trying to read from a

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-20 Thread Stephen Warren
On 09/19/2018 10:45 AM, Heinrich Schuchardt wrote: On 09/19/2018 05:24 PM, Stephen Warren wrote: On 09/18/2018 06:43 PM, Heinrich Schuchardt wrote: On 09/18/2018 07:23 PM, Stephen Warren wrote: On 09/18/2018 11:21 AM, Heinrich Schuchardt wrote: Spawn.exept has a try block without 'except'.

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-19 Thread Heinrich Schuchardt
On 09/19/2018 05:24 PM, Stephen Warren wrote: > On 09/18/2018 06:43 PM, Heinrich Schuchardt wrote: >> On 09/18/2018 07:23 PM, Stephen Warren wrote: >>> On 09/18/2018 11:21 AM, Heinrich Schuchardt wrote: Spawn.exept has a try block without 'except'. If no output is available an

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-19 Thread Simon Glass
Hi Heinrich, On 18 September 2018 at 18:43, Heinrich Schuchardt wrote: > On 09/18/2018 07:23 PM, Stephen Warren wrote: >> On 09/18/2018 11:21 AM, Heinrich Schuchardt wrote: >>> Spawn.exept has a try block without 'except'. >>> >>> If no output is available an OSError may arise. Catch this

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-19 Thread Stephen Warren
On 09/18/2018 06:43 PM, Heinrich Schuchardt wrote: On 09/18/2018 07:23 PM, Stephen Warren wrote: On 09/18/2018 11:21 AM, Heinrich Schuchardt wrote: Spawn.exept has a try block without 'except'. If no output is available an OSError may arise. Catch this exception and continue testing.

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-18 Thread Heinrich Schuchardt
On 09/18/2018 07:23 PM, Stephen Warren wrote: > On 09/18/2018 11:21 AM, Heinrich Schuchardt wrote: >> Spawn.exept has a try block without 'except'. >> >> If no output is available an OSError may arise. Catch this exception and >> continue testing. >> >> Signed-off-by: Heinrich Schuchardt >>

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-18 Thread Alexander Graf
On 18.09.18 10:21, Heinrich Schuchardt wrote: > Spawn.exept has a try block without 'except'. > > If no output is available an OSError may arise. Catch this exception and > continue testing. I agree with Stephen that the actual error this is trying to fix is not obvious from the description.

Re: [U-Boot] [PATCH 1/1] test/py: catch errors occurring when reading the console

2018-09-18 Thread Stephen Warren
On 09/18/2018 11:21 AM, Heinrich Schuchardt wrote: Spawn.exept has a try block without 'except'. If no output is available an OSError may arise. Catch this exception and continue testing. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- I suggest that Alex takes the patch