> > btw. a quick hint:
> >
> > git reset HEAD^
> > git add -p
> >
> > Add only the reg32 changes, commit, add the rest, commit. Send ;-)
>
> Well, I made it a little more work than that. But who would have
> thought? GIT is actually growing on me!
>
> I've got my changes in my repository now, i
> btw. a quick hint:
>
> git reset HEAD^
> git add -p
>
> Add only the reg32 changes, commit, add the rest, commit. Send ;-)
Well, I made it a little more work than that. But who would have
thought? GIT is actually growing on me!
I've got my changes in my repository now, in 4 separate commits.
> Hi,
>
> > That's why I put the ternary operator there ?
>
> Ah; without anything behind it, it really just looked like a question mark.
> But using a ternary caters only for a set of two. So enumeration would
> be better ideed.
>
> > It's impossible to review like this though and much more pro
Hi,
> That's why I put the ternary operator there ?
Ah; without anything behind it, it really just looked like a question mark.
But using a ternary caters only for a set of two. So enumeration would
be better ideed.
> It's impossible to review like this though and much more prone to pull in
> b
> Hi Marek,
>
> > - if (io == MXC_IOCLK0) {
> > - writel(CLKCTRL_FRAC0_CLKGATEIO0,
> > - &clkctrl_regs->hw_clkctrl_frac0_set);
> > - clrsetbits_le32(&clkctrl_regs->hw_clkctrl_frac0,
> > - CLKCTRL_FRAC0_IO0FRAC_MASK,
> > -
> > btw 2/2 is missing?
>
> Not missing, just not sent again; It hasn't been changed.
Uh ... I don't see this patch in in-reply-to either. So I can't find it, really.
M
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/
> Hi Marek,
>
> > - if (io == MXC_IOCLK0) {
> > - writel(CLKCTRL_FRAC0_CLKGATEIO0,
> > - &clkctrl_regs->hw_clkctrl_frac0_set);
> > - clrsetbits_le32(&clkctrl_regs->hw_clkctrl_frac0,
> > - CLKCTRL_FRAC0_IO0FRAC_MASK,
> > -
> btw 2/2 is missing?
Not missing, just not sent again; It hasn't been changed.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Hi Marek,
> - if (io == MXC_IOCLK0) {
> - writel(CLKCTRL_FRAC0_CLKGATEIO0,
> - &clkctrl_regs->hw_clkctrl_frac0_set);
> - clrsetbits_le32(&clkctrl_regs->hw_clkctrl_frac0,
> - CLKCTRL_FRAC0_IO0FRAC_MASK,
> -
> Hi,
>
> This patch fixes ref_cpu clock setup. This bug leads to a hanging board
> after rebooting from the Kernel, due to failing memory size detection:
> U-Boot 2011.12-svn342 (Feb 02 2012 - 17:20:00)
>
> Freescale i.MX28 family
> I2C: ready
> DRAM: 0 Bytes
>
> The cause of the bug is regi
> Hi,
>
> This patch fixes ref_cpu clock setup. This bug leads to a hanging board
> after rebooting from the Kernel, due to failing memory size detection:
> U-Boot 2011.12-svn342 (Feb 02 2012 - 17:20:00)
>
> Freescale i.MX28 family
> I2C: ready
> DRAM: 0 Bytes
>
> The cause of the bug is regi
11 matches
Mail list logo
