Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-04 Thread Lukasz Majewski
Hi Heiko, Hello Lukasz, Am 03.10.2013 18:15, schrieb Lukasz Majewski: Hi Heiko, Sorry for a late reply. Hello Lukasz, Am 02.10.2013 17:11, schrieb Lukasz Majewski: Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-04 Thread Heiko Schocher
Hello Lukasz, Am 04.10.2013 10:58, schrieb Lukasz Majewski: Hi Heiko, Hello Lukasz, Am 03.10.2013 18:15, schrieb Lukasz Majewski: Hi Heiko, Sorry for a late reply. Hello Lukasz, Am 02.10.2013 17:11, schrieb Lukasz Majewski: Hi Leela, [...] but exactly I want to get rid of this code

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-03 Thread Leela Krishna Amudala
Hello Lukasz, Thanks for reviewing the patch. On Wed, Oct 2, 2013 at 8:41 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-03 Thread Lukasz Majewski
Hi Leela, Hello Lukasz, Thanks for reviewing the patch. On Wed, Oct 2, 2013 at 8:41 PM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true.

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-03 Thread Lukasz Majewski
Hi Heiko, Sorry for a late reply. Hello Lukasz, Am 02.10.2013 17:11, schrieb Lukasz Majewski: Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-03 Thread Heiko Schocher
Hello Lukasz, Am 03.10.2013 18:15, schrieb Lukasz Majewski: Hi Heiko, Sorry for a late reply. Hello Lukasz, Am 02.10.2013 17:11, schrieb Lukasz Majewski: Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-02 Thread Lukasz Majewski
Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron Durbin adur...@chromium.org Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 2/6] power: Explicitly select pmic device's bus

2013-10-02 Thread Heiko Schocher
Hello Lukasz, Am 02.10.2013 17:11, schrieb Lukasz Majewski: Hi Leela, The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction. Signed-off-by: Aaron