Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-09-05 Thread Rob Clark
On Tue, Sep 5, 2017 at 4:56 AM, Simon Glass wrote: > Hi Rob, > > On 3 September 2017 at 23:08, Łukasz Majewski wrote: >> On 09/02/2017 06:37 PM, Rob Clark wrote: >>> >>> And drop a whole lot of ugly code! > > :-) > >> >> >> +1 >> >> Reviewed-by: Łukasz Majewski

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-09-05 Thread Simon Glass
Hi Rob, On 3 September 2017 at 23:08, Łukasz Majewski wrote: > On 09/02/2017 06:37 PM, Rob Clark wrote: >> >> And drop a whole lot of ugly code! :-) > > > +1 > > Reviewed-by: Łukasz Majewski > > > >> >> Signed-off-by: Rob Clark >> --- >>

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:37 PM, Rob Clark wrote: And drop a whole lot of ugly code! +1 Reviewed-by: Łukasz Majewski Signed-off-by: Rob Clark --- fs/fat/fat.c | 723 ++ include/fat.h | 6 - 2 files

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-08-14 Thread Rob Clark
On Mon, Aug 14, 2017 at 10:39 AM, Rob Clark wrote: > On Mon, Aug 14, 2017 at 9:47 AM, Brüns, Stefan > wrote: > >> Have you checked this case still works? AFAICS this is not covered in fs- >> test.sh. Examples of suitables sandbox commands are

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-08-14 Thread Rob Clark
On Mon, Aug 14, 2017 at 9:47 AM, Brüns, Stefan wrote: > On Montag, 14. August 2017 15:16:15 CEST Rob Clark wrote: >> And drop a whole lot of ugly code! >> >> Signed-off-by: Rob Clark >> --- >> fs/fat/fat.c | 723 >>

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-08-14 Thread Brüns , Stefan
On Montag, 14. August 2017 15:16:15 CEST Rob Clark wrote: > And drop a whole lot of ugly code! > > Signed-off-by: Rob Clark > --- > fs/fat/fat.c | 723 > ++ include/fat.h | > 6 - > 2 files changed, 75 insertions(+),