Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-26 Thread York Sun
On 10/26/18 03:36, Rajat Srivastava wrote: > Spansion flashes (on our boards) support both 3-byte and 4-byte addressing > modes which needs active switching. What could be added to your patch is > already supported in SFDP method. SFDP also provides information about page > size, flash

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-26 Thread Rajat Srivastava
Hi Stefan > -Original Message- > From: Stefan Roese > Sent: Friday, October 26, 2018 3:42 PM > To: Rajat Srivastava ; York Sun > ; Jagan Teki > Cc: u-boot@lists.denx.de; simon.k.r.goldschm...@gmail.com; Ashish Kumar > > Subject: Re: [U-Boot] [PATCH v3] sf: Add

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-26 Thread Stefan Roese
Hi Rajat, On 26.10.18 11:59, Rajat Srivastava wrote: From what I read, Rajat's method is to extend the controller driver to support read SFDP and default to 4-byte mode if supported, or overwritten by user's flag. Stefan's method is to read 4-byte status bit and doesn't change controller

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-26 Thread Rajat Srivastava
@gmail.com > > Cc: Ashish Kumar ; u-boot@lists.denx.de > > Subject: Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode > > (vs standard 3-byte mode) > > > > Hi Rajat, > > > > On 23.10.18 07:17, Rajat Srivastava wrote: > > >> -

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-26 Thread Rajat Srivastava
> -Original Message- > From: York Sun > Sent: Thursday, October 25, 2018 9:20 PM > To: Stefan Roese > Cc: u-boot@lists.denx.de; Jagan Teki ; Rajat > Srivastava ; simon.k.r.goldschm...@gmail.com; > Ashish Kumar > Subject: Re: [U-Boot] [PATCH v3] sf: Add auto dete

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-25 Thread York Sun
On 10/25/18 08:59, Stefan Roese wrote: > Hi York, > > On 25.10.18 17:49, York Sun wrote: >> Guys, >> >> Let get back to the original thread. Since Rajat's first reply, the >> message id has been changed. All the comments were not captured by >> patchwork. > > I also wondered about this. Seems to

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-25 Thread Stefan Roese
Hi York, On 25.10.18 17:49, York Sun wrote: Guys, Let get back to the original thread. Since Rajat's first reply, the message id has been changed. All the comments were not captured by patchwork. I also wondered about this. Seems to have happened at some top-posting quite at the beginning of

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-25 Thread York Sun
Guys, Let get back to the original thread. Since Rajat's first reply, the message id has been changed. All the comments were not captured by patchwork. On 10/11/18 07:50, Stefan Roese wrote: > Some SPI NOR chips only support 4-byte mode addressing. Here the default > 3-byte mode does not work

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-25 Thread Stefan Roese
Hi Rajat, On 25.10.18 11:28, Rajat Srivastava wrote: Simply adding SPI_FLASH_USE_SFDP flag is not enough to make SFDP work. You'll need to add the driver code corresponding to the mtd layer code (in spi_flash.c) which will send the actual READ SFDP command to flash. The patch-set I

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-25 Thread Rajat Srivastava
To: Rajat Srivastava <mailto:rajat.srivast...@nxp.com>; > >> mailto:ja...@openedev.com; > >> mailto:simon.k.r.goldschm...@gmail.com > >> Cc: Ashish Kumar <mailto:ashish.ku...@nxp.com>; mailto:u-boot@lists.denx.de > >> Subject: Re: [U-Boot] [PATCH v3] sf:

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-23 Thread Stefan Roese
-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode) Hi Rajat, On 17.10.18 13:52, Rajat Srivastava wrote: Hi Stefan Sorry for top-posting. Why can't we read SFDP parameters from flash and auto-detect 3-byte/4-byte addressing mode? Using address width information we can

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-22 Thread Rajat Srivastava
Hi Stefan > -Original Message- > From: Stefan Roese [mailto:s...@denx.de] > Sent: Monday, October 22, 2018 12:45 PM > To: Rajat Srivastava ; ja...@openedev.com; > simon.k.r.goldschm...@gmail.com > Cc: Ashish Kumar ; u-boot@lists.denx.de > Subject: Re: [U-Boot] [P

Re: [U-Boot] [PATCH v3] sf: Add auto detection of 4-byte mode (vs standard 3-byte mode)

2018-10-22 Thread Stefan Roese
Hi Rajat, On 17.10.18 13:52, Rajat Srivastava wrote: Hi Stefan Sorry for top-posting. Why can't we read SFDP parameters from flash and auto-detect 3-byte/4-byte addressing mode? Using address width information we can support both types of flash i.e. flashes supporting 3-byte addressing mode