On 09/15/13 16:21, Marek Vasut wrote:
I suppose this thread can be concluded by droping the INIT_ALL stuff
entirely.
Afterall, we do not want to init _ALL_ ports at once, but we want to init
them
selectively.
Best regards,
Marek Vasut
+1
--
Mateusz Zalega
Samsung RD Institute
Dear Mateusz Zalega,
On 09/06/13 13:40, Marek Vasut wrote:
Moreover, the 'int index' should likely be unsigned int and the
special value to init all controllers at once should probably then
be 0x
Despite our greatest ambitions, I don't think we're likely to use
more than
On 09/05/13 19:51, Marek Vasut wrote:
Why not wrap board_usb_init() and board_usb_init_fail() into single call.
You now pass some flags to board_usb_init() already, so just add another
for the fail case. How does it sound to you?
Like overengineering. It would lead to
Dear Mateusz Zalega,
On 09/05/13 19:51, Marek Vasut wrote:
Why not wrap board_usb_init() and board_usb_init_fail() into single
call. You now pass some flags to board_usb_init() already, so just add
another for the fail case. How does it sound to you?
Like overengineering. It would
On 09/06/13 13:24, Marek Vasut wrote:
Moreover, the 'int index' should likely be unsigned int and the special
value to init all controllers at once should probably then be
0x
Despite our greatest ambitions, I don't think we're likely to use more
than 2^31-1 USB controllers at a time.
Dear Mateusz Zalega,
On 09/06/13 13:24, Marek Vasut wrote:
Moreover, the 'int index' should likely be unsigned int and the
special value to init all controllers at once should probably then
be 0x
Despite our greatest ambitions, I don't think we're likely to use more
than
On 09/06/13 13:40, Marek Vasut wrote:
Moreover, the 'int index' should likely be unsigned int and the
special value to init all controllers at once should probably then
be 0x
Despite our greatest ambitions, I don't think we're likely to use more
than 2^31-1 USB controllers at a time.
On 09/05/13 17:50, Marek Vasut wrote:
v3 changes:
- added 'index' argument to perform selective port initialization
OK, a few general ideas again:
Why not wrap board_usb_init() and board_usb_init_fail() into single call. You
now pass some flags to board_usb_init() already, so just add
Dear Mateusz Zalega,
On 09/05/13 17:50, Marek Vasut wrote:
v3 changes:
- added 'index' argument to perform selective port initialization
OK, a few general ideas again:
Why not wrap board_usb_init() and board_usb_init_fail() into single call.
You now pass some flags to
Dear Mateusz Zalega,
This commit unifies board-specific USB initialization implementations
under one symbol (usb_board_init), declaration of which is available in
usb.h.
Signed-off-by: Mateusz Zalega m.zal...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by:
10 matches
Mail list logo
