Re: [U-Boot] [PATCH v3 1/4] PXA: PXA27x Matrix keypad driver

2012-01-13 Thread Marek Vasut
From: Marek Vasut marek.va...@gmail.com Signed-off-by: Marek Vasut marek.va...@gmail.com Signed-off-by: Vasily Khoruzhick anars...@gmail.com [vasily: adapted Marek's old version for newer u-boot, fixed multiple keypresses handling] --- v2: use struct-based access to regs, minor

Re: [U-Boot] [PATCH v3 1/4] PXA: PXA27x Matrix keypad driver

2012-01-13 Thread Vasily Khoruzhick
On Fri, 2012-01-13 at 13:41 +0100, Marek Vasut wrote: +#define KPDK_DK1 (0x1 1) +#define KPDK_DK0 (0x1 0) Drop those two spaces here Two spaces? It's tabs! Btw, it's for good looking formatting and it was taken from pxa-regs.h. I'd like to preserve it like it is. +static

Re: [U-Boot] [PATCH v3 1/4] PXA: PXA27x Matrix keypad driver

2012-01-13 Thread Marek Vasut
On Fri, 2012-01-13 at 13:41 +0100, Marek Vasut wrote: +#define KPDK_DK1 (0x1 1) +#define KPDK_DK0 (0x1 0) Drop those two spaces here Two spaces? It's tabs! Btw, it's for good looking formatting and it was taken from pxa-regs.h. I'd like to preserve it like it is. Then change