Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-06 Thread Lukasz Majewski
Dear Stephen Warren, On 08/03/2012 12:13 AM, Lukasz Majewski wrote: Dear Stephen Warren, Again, this is confusing two different kinds of partitions. There are HW-level partitions/regions/areas within the eMMC HW itself. You need to send commands to the eMMC device to select

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-03 Thread Lukasz Majewski
Dear Stephen Warren, Again, this is confusing two different kinds of partitions. There are HW-level partitions/regions/areas within the eMMC HW itself. You need to send commands to the eMMC device to select whether read/write commands act on the boot0/boot1/general*/user HW partition. This

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-03 Thread Stephen Warren
On 08/03/2012 12:13 AM, Lukasz Majewski wrote: Dear Stephen Warren, Again, this is confusing two different kinds of partitions. There are HW-level partitions/regions/areas within the eMMC HW itself. You need to send commands to the eMMC device to select whether read/write commands act on

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-02 Thread Marek Vasut
Dear Mike Frysinger, On Tuesday 31 July 2012 02:37:01 Lukasz Majewski wrote: --- /dev/null +++ b/common/cmd_dfu.c + static char *s = dfu; no need for this to be static It can be pulled out of the function and be made into const static -mike Best regards, Marek Vasut

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-02 Thread Lukasz Majewski
On Wed, 01 Aug 2012 11:13:14 -0600 Stephen Warren swar...@wwwdotorg.org wrote: On 08/01/2012 01:16 AM, Lukasz Majewski wrote: Hi Stephen Warren, On 07/31/2012 12:37 AM, Lukasz Majewski wrote: Support for u-boot's dfu interface dev [list] command. +U_BOOT_CMD(dfu, CONFIG_SYS_MAXARGS,

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-02 Thread Lukasz Majewski
Dear Marek Vasut, Dear Mike Frysinger, On Tuesday 31 July 2012 02:37:01 Lukasz Majewski wrote: --- /dev/null +++ b/common/cmd_dfu.c + static char *s = dfu; no need for this to be static It can be pulled out of the function and be made into const static Ok. -mike

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-02 Thread Stephen Warren
On 08/02/2012 02:31 AM, Lukasz Majewski wrote: On Wed, 01 Aug 2012 11:13:14 -0600 Stephen Warren swar...@wwwdotorg.org wrote: On 08/01/2012 01:16 AM, Lukasz Majewski wrote: Hi Stephen Warren, On 07/31/2012 12:37 AM, Lukasz Majewski wrote: Support for u-boot's dfu interface dev [list]

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-02 Thread Mike Frysinger
On Thursday 02 August 2012 03:16:18 Marek Vasut wrote: Dear Mike Frysinger, On Tuesday 31 July 2012 02:37:01 Lukasz Majewski wrote: --- /dev/null +++ b/common/cmd_dfu.c + static char *s = dfu; no need for this to be static It can be pulled out of the function and be made

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-01 Thread Lukasz Majewski
Hi Stephen Warren, On 07/31/2012 12:37 AM, Lukasz Majewski wrote: Support for u-boot's dfu interface dev [list] command. +U_BOOT_CMD(dfu, CONFIG_SYS_MAXARGS, 1, do_dfu, + Device Firmware Upgrade, + interface dev [list]\n + - device firmware upgrade on a device dev\n +

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-01 Thread Stephen Warren
On 08/01/2012 01:16 AM, Lukasz Majewski wrote: Hi Stephen Warren, On 07/31/2012 12:37 AM, Lukasz Majewski wrote: Support for u-boot's dfu interface dev [list] command. +U_BOOT_CMD(dfu, CONFIG_SYS_MAXARGS, 1, do_dfu, + Device Firmware Upgrade, + interface dev [list]\n + - device

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-08-01 Thread Mike Frysinger
On Tuesday 31 July 2012 02:37:01 Lukasz Majewski wrote: --- /dev/null +++ b/common/cmd_dfu.c + static char *s = dfu; no need for this to be static -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing

Re: [U-Boot] [PATCH v3 5/7] dfu:cmd: Support for DFU u-boot command

2012-07-31 Thread Stephen Warren
On 07/31/2012 12:37 AM, Lukasz Majewski wrote: Support for u-boot's dfu interface dev [list] command. +U_BOOT_CMD(dfu, CONFIG_SYS_MAXARGS, 1, do_dfu, + Device Firmware Upgrade, + interface dev [list]\n + - device firmware upgrade on a device dev\n + attached to