Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-07 Thread Ilya Yanok
Hi Tom, On Tue, Aug 7, 2012 at 1:11 AM, Ilya Yanok ilya.ya...@cogentembedded.comwrote: Yes. What I meant was that not all of the stuff that is guarded today is garbage collected so the resulting image is larger than it must be. Yep. And that's actually goes beyond the subject of this

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Ilya Yanok
Hi Tom, On Mon, Aug 6, 2012 at 2:36 AM, Tom Rini tr...@ti.com wrote: On Sun, Aug 5, 2012 at 2:21 PM, Ilya Yanok ilya.ya...@cogentembedded.com wrote: __u_boot_cmd* symbols are not used in SPL so there is no need to tell the linker that they are undefined. With these symbols marked as

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Tom Rini
On 08/06/2012 08:10 AM, Ilya Yanok wrote: Hi Tom, On Mon, Aug 6, 2012 at 2:36 AM, Tom Rini tr...@ti.com mailto:tr...@ti.com wrote: On Sun, Aug 5, 2012 at 2:21 PM, Ilya Yanok ilya.ya...@cogentembedded.com mailto:ilya.ya...@cogentembedded.com wrote: __u_boot_cmd* symbols

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Ilya Yanok
On Mon, Aug 6, 2012 at 7:30 PM, Tom Rini tr...@ti.com wrote: On 08/06/2012 08:10 AM, Ilya Yanok wrote: Hi Tom, On Mon, Aug 6, 2012 at 2:36 AM, Tom Rini tr...@ti.com mailto:tr...@ti.com wrote: On Sun, Aug 5, 2012 at 2:21 PM, Ilya Yanok ilya.ya...@cogentembedded.com

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Tom Rini
On Mon, Aug 6, 2012 at 8:31 AM, Ilya Yanok ilya.ya...@cogentembedded.com wrote: On Mon, Aug 6, 2012 at 7:30 PM, Tom Rini tr...@ti.com wrote: On 08/06/2012 08:10 AM, Ilya Yanok wrote: Hi Tom, On Mon, Aug 6, 2012 at 2:36 AM, Tom Rini tr...@ti.com mailto:tr...@ti.com wrote: On Sun,

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Ilya Yanok
Hi Tom, On Mon, Aug 6, 2012 at 9:10 PM, Tom Rini tr...@ti.com wrote: OK, installed and it's still larger with this change than without and it's not garbage collecting and dropping commands if I un-guard the nandecc command for example. Tested with omap3_beagle. Did some testing as well.

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Tom Rini
On Mon, Aug 06, 2012 at 11:15:25PM +0400, Ilya Yanok wrote: Hi Tom, On Mon, Aug 6, 2012 at 9:10 PM, Tom Rini tr...@ti.com wrote: OK, installed and it's still larger with this change than without and it's not garbage collecting and dropping commands if I un-guard the nandecc command

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-06 Thread Ilya Yanok
Hi Tom, On Tue, Aug 7, 2012 at 12:52 AM, Tom Rini tr...@ti.com wrote: By comparing of two images I've found that the difference comes from ro-strings (two help strings in U_BOOT_CMD, string in printf, sw hw). It looks like the linker doesn't collect ro-strings referenced from collected

Re: [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined

2012-08-05 Thread Tom Rini
On Sun, Aug 5, 2012 at 2:21 PM, Ilya Yanok ilya.ya...@cogentembedded.com wrote: __u_boot_cmd* symbols are not used in SPL so there is no need to tell the linker that they are undefined. With these symbols marked as undefined linker fails to garbage collect some unused functions and even fails