Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-03 Thread Wolfgang Denk
Dear Simon Glass, In message CAPnjgZ2jS8kzCt06LbYnXSyEKm6ck8apm=p1yqqdtnz0+q9...@mail.gmail.com you wrote: Well let's see how we go with the incremental approach - hopefully we can get the same result with less pain and risk, and not too much work. Did you miss my proposal not to change

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-03 Thread Graeme Russ
Hi Wolfgang, On 03/01/12 19:12, Wolfgang Denk wrote: Dear Simon Glass, In message CAPnjgZ2jS8kzCt06LbYnXSyEKm6ck8apm=p1yqqdtnz0+q9...@mail.gmail.com you wrote: Well let's see how we go with the incremental approach - hopefully we can get the same result with less pain and risk, and not

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-03 Thread Simon Glass
Hi Wolfgang, On Tue, Jan 3, 2012 at 12:12 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message CAPnjgZ2jS8kzCt06LbYnXSyEKm6ck8apm=p1yqqdtnz0+q9...@mail.gmail.com you wrote: Well let's see how we go with the incremental approach - hopefully we can get the same result with

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-03 Thread Wolfgang Denk
Dear Simon Glass, In message CAPnjgZ3592m_m=tmafptwzo+_o94veykvrffdgpp599igef...@mail.gmail.com you wrote: I have brought in PPC to board_f.c and board_r.c but not dealt with relocation. Once I have done that, gone through the new x86 series again and MAKEALL doesn't scream too loudly I'll

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-03 Thread Simon Glass
Hi Wolfgang, On Tue, Jan 3, 2012 at 2:35 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message CAPnjgZ3592m_m=tmafptwzo+_o94veykvrffdgpp599igef...@mail.gmail.com you wrote: I have brought in PPC to board_f.c and board_r.c but not dealt with relocation. Once I have done

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-02 Thread Graeme Russ
Hi Simon, In case you haven't noticed (I did not Cc you or Wolfgang, sorry 'bout that) I've posted the cleaned up version of my x86 init refactoring... On 02/01/12 10:48, Simon Glass wrote: Hi Graeme, On Sat, Dec 31, 2011 at 3:52 AM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, On

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-02 Thread Wolfgang Denk
Dear Graeme Russ, In message 4f019473.8000...@gmail.com you wrote: The problem is not one of how sparsely the test/fix cycles are spread over time, it is one of spreading the breakage over multiple patches - If you are replacing functionality then add the new functionality, add the hooks to

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-02 Thread Simon Glass
Hi Graham, On Mon, Jan 2, 2012 at 3:26 AM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, In case you haven't noticed (I did not Cc you or Wolfgang, sorry 'bout that) I've posted the cleaned up version of my x86 init refactoring... Yes I see it - thats great thanks. I will go through it

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-02 Thread Simon Glass
Hi Wolfgang, On Mon, Jan 2, 2012 at 6:46 AM, Wolfgang Denk w...@denx.de wrote: Dear Graeme Russ, In message 4f019473.8000...@gmail.com you wrote: The problem is not one of how sparsely the test/fix cycles are spread over time, it is one of spreading the breakage over multiple patches - If

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-01 Thread Simon Glass
Hi Wolfgang, On Sat, Dec 31, 2011 at 5:54 PM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message CAPnjgZ1Zim6=u3rlcnake-0bw3so_hry+u67jkpknoni8g7...@mail.gmail.com you wrote: Also it does depend on expectations. I would hope that moving an architecture over would be a fairly

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-01 Thread Simon Glass
Hi Graeme, On Sat, Dec 31, 2011 at 3:52 AM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, On 31/12/11 13:02, Simon Glass wrote: Hi Graeme, On Fri, Dec 30, 2011 at 7:49 AM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, [snip] However, I think this approach is not the right

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2012-01-01 Thread Wolfgang Denk
Dear Simon Glass, In message CAPnjgZ1eutEboyvEtYcxcZcv=1z_3tkq_45wbrgndpsnxrt...@mail.gmail.com you wrote: - getting generic relocation working I don;t see why this would be a direct prerequisite here. =A0We want to have that, no boubt about that. =A0But it appears to be an unrelated

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-31 Thread Graeme Russ
Hi Simon, On 31/12/11 13:02, Simon Glass wrote: Hi Graeme, On Fri, Dec 30, 2011 at 7:49 AM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, [snip] However, I think this approach is not the right one - and I think the CFI driver backs me up. Your plan is to create generic code which

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-31 Thread Wolfgang Denk
Dear Simon Glass, In message CAPnjgZ1Zim6=u3rlcnake-0bw3so_hry+u67jkpknoni8g7...@mail.gmail.com you wrote: Also it does depend on expectations. I would hope that moving an architecture over would be a fairly small task: - getting generic relocation working I don;t see why this would be a

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-30 Thread Graeme Russ
Hi Simon, Sorry for the delay in reviewing this - I've been doing a lot of work on the x86 side of things. I now have a working solution to the board_init_f_r() / global data clobbering problem which involves having the gd 'variable' as a register like all other arch's. The solution is

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-30 Thread Wolfgang Denk
Dear Graeme Russ, In message 4efddd7d.50...@gmail.com you wrote: I honestly think we should get the x86 init sequence patches finalised first for several reasons: - Because x86 is so small, it provides a good test-bed - ELF relocation was first finalised on x86 (it came and went with

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-30 Thread Simon Glass
Hi Graeme, On Fri, Dec 30, 2011 at 7:49 AM, Graeme Russ graeme.r...@gmail.com wrote: Hi Simon, Sorry for the delay in reviewing this - I've been doing a lot of work on the x86 side of things. I now have a working solution to the board_init_f_r() / global data clobbering problem which

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-28 Thread Wolfgang Denk
Dear Simon, In message 1325054160-24894-1-git-send-email-...@chromium.org you wrote: This series creates a generic board.c implementation which contains the essential functions of the various arch/xxx/lib/board.c files. I'll be loking into this deeper when I'm back at work (i. e. starting with

Re: [U-Boot] [RFC PATCH 0/19] Create generic board init and move ARM and x86 to it

2011-12-28 Thread Simon Glass
Hi Wolfgang, On Wed, Dec 28, 2011 at 9:30 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon, In message 1325054160-24894-1-git-send-email-...@chromium.org you wrote: This series creates a generic board.c implementation which contains the essential functions of the various arch/xxx/lib/board.c