Re: [U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-07 Thread Alex Kiernan
Hi Stefano On Thu, Jun 7, 2018 at 9:15 AM Stefano Babic wrote: > > Hi Alex, > > On 07/06/2018 10:07, Alex Kiernan wrote: > > Hi Stefano > > > > On Thu, Jun 7, 2018 at 8:16 AM Stefano Babic wrote: > >> > >> Hi Alex, > >> > >> On 06/06/2018 18:33, Alex Kiernan wrote: > >>> The line length limit

Re: [U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-07 Thread Stefano Babic
Hi Alex, On 07/06/2018 10:07, Alex Kiernan wrote: > Hi Stefano > > On Thu, Jun 7, 2018 at 8:16 AM Stefano Babic wrote: >> >> Hi Alex, >> >> On 06/06/2018 18:33, Alex Kiernan wrote: >>> The line length limit that fw_{printenv,setenv} impose (1024 >>> characters) has tripped me up twice in as

Re: [U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-07 Thread Alex Kiernan
Hi Stefano On Thu, Jun 7, 2018 at 8:16 AM Stefano Babic wrote: > > Hi Alex, > > On 06/06/2018 18:33, Alex Kiernan wrote: > > The line length limit that fw_{printenv,setenv} impose (1024 > > characters) has tripped me up twice in as many days, so I figured I'd > > rewrite it to use getline as we

Re: [U-Boot] Rewriting fw_{printenv,getenv} to not use fgets

2018-06-07 Thread Stefano Babic
Hi Alex, On 06/06/2018 18:33, Alex Kiernan wrote: > The line length limit that fw_{printenv,setenv} impose (1024 > characters) has tripped me up twice in as many days, so I figured I'd > rewrite it to use getline as we already have that in tools/. > > But in looking how I structure that change,