Re: Reproducibility regression with mx6cuboxi

2020-07-28 Thread Fabio Estevam
Hi Vagrant, On Sun, Jul 26, 2020 at 3:17 PM Vagrant Cascadian wrote: > That appears to build reproducibly for me on top of v2020.07. Haven't > tested if the resulting image boots. When you have a chance to test it, please reply with your Tested-by on my v2 patch. Thanks

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Fabio Estevam
Hi Vagrant, On Sun, Jul 26, 2020 at 3:17 PM Vagrant Cascadian wrote: > That appears to build reproducibly for me on top of v2020.07. Haven't > tested if the resulting image boots. I can confirm it boots fine on a imx6 humming board. I will submit it as a formal patch. Thanks

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Vagrant Cascadian
On 2020-07-26, Fabio Estevam wrote: > On Sun, Jul 26, 2020 at 2:16 PM Tom Rini wrote: > >> I mean just literally changing the malloc(...) to calloc(1, ...), audit any >> other malloc(...) calls in the file and change nothing else. Thanks! > > Thanks for the clarification, Tom > > Vagrant, > >

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Fabio Estevam
On Sun, Jul 26, 2020 at 2:16 PM Tom Rini wrote: > I mean just literally changing the malloc(...) to calloc(1, ...), audit any > other malloc(...) calls in the file and change nothing else. Thanks! Thanks for the clarification, Tom Vagrant, Does the patch below fix the reproducibility

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Tom Rini
On Sun, Jul 26, 2020 at 02:00:33PM -0300, Fabio Estevam wrote: > On Sun, Jul 26, 2020 at 12:05 PM Tom Rini wrote: > > > We just need to use calloc() in the tool and not mess with alignment. > > Like this? > > --- a/tools/fit_image.c > +++ b/tools/fit_image.c > @@ -446,7 +446,6 @@ static int

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Fabio Estevam
On Sun, Jul 26, 2020 at 12:05 PM Tom Rini wrote: > We just need to use calloc() in the tool and not mess with alignment. Like this? --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -446,7 +446,6 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname) int

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Tom Rini
On Sun, Jul 26, 2020 at 11:57:43AM -0300, Fabio Estevam wrote: > Hi Vagrant, > > On Wed, Jul 22, 2020 at 6:10 PM Tom Rini wrote: > > > > Do you mean this one? > > > http://u-boot.10912.n7.nabble.com/PATCH-V2-mkimage-fit-Do-not-tail-pad-fitImage-with-external-data-td409920.html > > > > Yes, that

Re: Reproducibility regression with mx6cuboxi

2020-07-26 Thread Fabio Estevam
Hi Vagrant, On Wed, Jul 22, 2020 at 6:10 PM Tom Rini wrote: > > Do you mean this one? > > http://u-boot.10912.n7.nabble.com/PATCH-V2-mkimage-fit-Do-not-tail-pad-fitImage-with-external-data-td409920.html > > Yes, that one. I know Marek's patch caused a regression on other platforms, but could

Re: Reproducibility regression with mx6cuboxi

2020-07-22 Thread Tom Rini
On Wed, Jul 22, 2020 at 05:40:12PM -0300, Fabio Estevam wrote: > Hi Tom, > > [Adding Marek] > > On Wed, Jul 22, 2020 at 3:45 PM Tom Rini wrote: > > > > On Wed, Jul 22, 2020 at 08:32:28PM +0200, Heinrich Schuchardt wrote: > > > On 19.07.20 20:23, Vagrant Cascadian wrote: > > > > The mx6cuboxi

Re: Reproducibility regression with mx6cuboxi

2020-07-22 Thread Fabio Estevam
Hi Tom, [Adding Marek] On Wed, Jul 22, 2020 at 3:45 PM Tom Rini wrote: > > On Wed, Jul 22, 2020 at 08:32:28PM +0200, Heinrich Schuchardt wrote: > > On 19.07.20 20:23, Vagrant Cascadian wrote: > > > The mx6cuboxi target no longer builds reproducibility on Debian. I've > > > bisected it down to:

Re: Reproducibility regression with mx6cuboxi

2020-07-22 Thread Tom Rini
On Wed, Jul 22, 2020 at 08:32:28PM +0200, Heinrich Schuchardt wrote: > On 19.07.20 20:23, Vagrant Cascadian wrote: > > The mx6cuboxi target no longer builds reproducibility on Debian. I've > > bisected it down to: > > > > eb9124f5748c96ffd548e50fd6989c3b5395b353 mx6cuboxi: enable OF_CONTROL > >

Re: Reproducibility regression with mx6cuboxi

2020-07-22 Thread Heinrich Schuchardt
On 19.07.20 20:23, Vagrant Cascadian wrote: > The mx6cuboxi target no longer builds reproducibility on Debian. I've > bisected it down to: > > eb9124f5748c96ffd548e50fd6989c3b5395b353 mx6cuboxi: enable OF_CONTROL with > DM_MMC and DM_USB > > > Based on the diffoscope output, it *might* have

Re: Reproducibility regression with mx6cuboxi

2020-07-21 Thread Vagrant Cascadian
On 2020-07-21, Tom Rini wrote: > On Sun, Jul 19, 2020 at 11:23:05AM -0700, Vagrant Cascadian wrote: > >> The mx6cuboxi target no longer builds reproducibility on Debian. I've >> bisected it down to: >> >> eb9124f5748c96ffd548e50fd6989c3b5395b353 mx6cuboxi: enable OF_CONTROL with >> DM_MMC and

Re: Reproducibility regression with mx6cuboxi

2020-07-21 Thread Tom Rini
On Sun, Jul 19, 2020 at 11:23:05AM -0700, Vagrant Cascadian wrote: > The mx6cuboxi target no longer builds reproducibility on Debian. I've > bisected it down to: > > eb9124f5748c96ffd548e50fd6989c3b5395b353 mx6cuboxi: enable OF_CONTROL with > DM_MMC and DM_USB Are you tracking any other

Reproducibility regression with mx6cuboxi

2020-07-19 Thread Vagrant Cascadian
The mx6cuboxi target no longer builds reproducibility on Debian. I've bisected it down to: eb9124f5748c96ffd548e50fd6989c3b5395b353 mx6cuboxi: enable OF_CONTROL with DM_MMC and DM_USB Based on the diffoscope output, it *might* have something to do with the changes to how board detection uses