[U-Boot] [PATCH v3 2/5] imx: mx6sabre common: Factorize the Pfuze init function

2014-11-06 Thread Ye . Li
Since the Pfuze initializations are similar on various mx6 SABRE boards. Factorize the initialization to a common function in file board/freescale/common/pfuze.c. So that all SABRE boards BSP can share the function. Signed-off-by: Ye.Li b37...@freescale.com --- Changes since v1: - Factorize the

[U-Boot] [PATCH v3 3/5] imx: mx6sabresd: Use the pfuze common init function

2014-11-06 Thread Ye . Li
Modify the pfuze init for mx6sabresd to use the shared pfuze_common_init function. And move this initialization to power_init_board. Signed-off-by: Ye.Li b37...@freescale.com --- Changes since v1: - Change to use pfuze common init function for sabre boards. Changes since v2: - Move the pfuze

[U-Boot] [PATCH v3 1/5] power: pfuze100: Update definitions for buck regulators

2014-11-06 Thread Ye . Li
Add definitions for buck regulators (SW1A/B/C) registers and voltage values. Signed-off-by: Ye.Li b37...@freescale.com --- Changes since v1: - None Changes since v2: - Create this patch for updating registers definitions and magic value. include/power/pfuze100_pmic.h | 80

[U-Boot] [PATCH v3 5/5] imx: imx6q/dlsabreauto: Add PMIC Pfuze100 support

2014-11-06 Thread Ye . Li
Add the pfuze100 initialization in power_init_board for imx6q/dl sabreauto board. Signed-off-by: Ye.Li b37...@freescale.com --- Changes since v1: - Change to use pfuze common init function for sabre boards. Changes since v2: - Move the pfuze init to power_init_board

[U-Boot] [PATCH v3 4/5] imx: mx6sxsabresd: Use the pfuze common init function

2014-11-06 Thread Ye . Li
Modify the pfuze init for mx6sxsabresd to use the shared pfuze_common_init function. And move this initialization to power_init_board. Signed-off-by: Ye.Li b37...@freescale.com --- Changes since v1: - Change to use pfuze common init function for sabre boards. Changes since v2: - Move the pfuze

[U-Boot] uboot uImage binary does not boot in Qemu

2014-11-06 Thread pegasus711
I cross compiled u-boot's latest version 2014-10 using buildroot's built-in cross compiler and generated uboot.bin. When I try to invoke it like so: it throws an error complaining wrong image format: I've checked qemu's sources and as per 'uboot_image.h' , the only valid type numbers are

Re: [U-Boot] [PATCH v3 2/2] Odroid-XU3: Add support for Odroid-XU3

2014-11-06 Thread Lukasz Majewski
Hi Hyungwon, Dear Lukasz Majewski, On Wed, 05 Nov 2014 11:29:53 +0100 Lukasz Majewski l.majew...@samsung.com wrote: +#undef CONFIG_EXYNOS_SPL +#undef CONFIG_SILENT_CONSOLE +#undef CONFIG_CROS_EC +#undef CONFIG_CROS_EC_SPI +#undef CONFIG_CROS_EC_I2C +#undef

Re: [U-Boot] Query on the ci_udc driver for USB client implementation

2014-11-06 Thread Lukasz Majewski
Hi Sanchayan, On Tuesday 04 November 2014 09:58 PM, Lukasz Majewski wrote: Hi Sanchayan, On Tuesday 04 November 2014 10:25 AM, Marek Vasut wrote: On Monday, November 03, 2014 at 04:46:48 PM, Fabio Estevam wrote: On Mon, Nov 3, 2014 at 3:33 AM, Sanchayan Maity

Re: [U-Boot] [PATCH 6/6] linux/kernel.h: sync min, max, min3, max3 macros with Linux

2014-11-06 Thread Lukasz Majewski
Hi Masahiro, U-Boot has never cared about the type when we get max/min of two values, but Linux Kernel does. This commit gets min, max, min3, max3 macros synced with the kernel introduing type checks. Many of references of those macros must be fixed to suppress warnings. We have two

Re: [U-Boot] [PATCH 1/5] usb: s3c-otg: Remove useless include

2014-11-06 Thread Lukasz Majewski
Hi Marek, Remove the useless inclusion of arch/arm/gpio.h , which is completely bogus in this driver. Signed-off-by: Marek Vasut ma...@denx.de Cc: Chin Liang See cl...@altera.com Cc: Dinh Nguyen dingu...@opensource.altera.com Cc: Vince Bridgers vbrid...@altera.com Cc: Pavel Machek

Re: [U-Boot] [PATCH 2/5] usb: s3c-otg: Encapsulate PHY control

2014-11-06 Thread Lukasz Majewski
Hi Marek, Encapsulate the Samsung PHY control and it's register accesses into the otg_phy_init() and otg_phy_off() functions. Signed-off-by: Marek Vasut ma...@denx.de Cc: Chin Liang See cl...@altera.com Cc: Dinh Nguyen dingu...@opensource.altera.com Cc: Vince Bridgers vbrid...@altera.com

Re: [U-Boot] [PATCH 3/5] usb: s3c-otg: Split out PHY control

2014-11-06 Thread Lukasz Majewski
Hi Marek, Split the Samsung specific PHY control into a separate file and compile this into the S3C OTG driver only if used on a Samsung system. Signed-off-by: Marek Vasut ma...@denx.de Cc: Chin Liang See cl...@altera.com Cc: Dinh Nguyen dingu...@opensource.altera.com Cc: Vince Bridgers

[U-Boot] [PATCH] test: ums: Add sleep before unmount directory

2014-11-06 Thread Lukasz Majewski
This change helps to run script on machines with quite long uptime. Without this the following error emerges: File: ./dat_14M.img umount: /mnt/tmp-ums-test: device is busy. (In some cases useful info about processes that use the device is found by lsof(8) or fuser(1)) TX:

Re: [U-Boot] [PATCH 1/2] blackfin: spi: move spi max chip select to spi.h

2014-11-06 Thread Scott Jiang
Ping. Scott 2014-09-25 17:25 GMT+08:00 Scott Jiang scott.jiang.li...@gmail.com: This macro is only related to spi. So it's better to place it in spi.h. Signed-off-by: Scott Jiang scott.jiang.li...@gmail.com --- arch/blackfin/include/asm/config-pre.h |3 ---

Re: [U-Boot] [PATCH 2/2] spi: add common spi3 controller driver

2014-11-06 Thread Scott Jiang
Ping. Scott 2014-09-25 17:25 GMT+08:00 Scott Jiang scott.jiang.li...@gmail.com: SPI3 controller is not only used on BF609 platform. So we add a common controller driver and leave machine specific configuration in board drivers. Remove obsolete spi6xx.h and select new board driver in

[U-Boot] [PATCH] mtd: sf: Zap ramtron driver

2014-11-06 Thread Jagannadha Sutradharudu Teki
Removed ramtron driver since the EMK boards are no longer been active, and these are the only boards used this flash driver. Commit details for EMK zap: ppc/arm: zap EMK boards (sha1: d58a9451e7339ed4cf2b2627e534611f427fb791) Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com

[U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow

2014-11-06 Thread Sjoerd Simons
The current vbus GPIOs on snow make very little sense, their number is far above the maximum. As a result, USB doesn't work on snow. Correct the GPIO numbering so they match the current scheme for exynos5. Tested both EHCI and XHCI to correctly work after this change. Signed-off-by: Sjoerd

[U-Boot] [PATCH] ARM: UniPhier: move DDR related configuration to Kconfig

2014-11-06 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/arm/cpu/armv7/uniphier/Kconfig | 23 +++ arch/arm/cpu/armv7/uniphier/dram_init.c | 2 +- arch/arm/cpu/armv7/uniphier/ph1-ld4/Makefile| 3 +--

[U-Boot] [PATCH v4 0/2] Adds support for Exynos5422 odroid xu3 board

2014-11-06 Thread Hyungwon Hwang
This is v4 of the patchset adding support Odroud XU3 board. link to the previous version: v2: https://www.mail-archive.com/u-boot@lists.denx.de/msg152275.html v3: https://www.mail-archive.com/u-boot%40lists.denx.de/msg152677.html This patchset fixes GPIO information of Exynos5420 which is needed

[U-Boot] [PATCH v4 1/2] exynos5: fix GPIO information of exynos5420

2014-11-06 Thread Hyungwon Hwang
This patch fixes wrong GPIO information such as GPIO bank, table which is used to convert GPIO name to index, bank base address, and etc. Signed-off-by: Hyungwon Hwang human.hw...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com --- Changes for v4:

[U-Boot] [PATCH v4 2/2] Odroid-XU3: Add support for Odroid-XU3

2014-11-06 Thread Hyungwon Hwang
This patch adds support for Odroid-XU3. Signed-off-by: Hyungwon Hwang human.hw...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com --- Changes for v3: - Remove unnecessary node from DT file - Remove unnecessary features from config file

[U-Boot] arch/arm/lib/board.c - uninitialized vars

2014-11-06 Thread Wolfgang Denk
Hi, I'm trying to clean up some warnings/errors detected when running cppcheck on the U-Boot source tree. For arch/arm/lib/board.c I get this: [arch/arm/lib/board.c:445]: (error) Uninitialized variable: id [arch/arm/lib/board.c:422]: (error) Uninitialized variable: addr_sp The problem is not

Re: [U-Boot] [PATCH V2 3/4] common: introduce board_preboot_os hook

2014-11-06 Thread Nikita Kiryanov
Hi Stefano, On 11/05/2014 02:32 PM, Stefano Babic wrote: Hi Nikita, On 29/10/2014 16:56, Nikita Kiryanov wrote: Introduce board specific function board_preboot_os() to allow for board specific config before we boot. Signed-off-by: Nikita Kiryanov nik...@compulab.co.il Cc: Igor Grinberg

[U-Boot] MCF: uninitialized variables

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [arch/m68k/cpu/mcf5227x/speed.c:89]: (error) Uninitialized variable: bootmode [arch/m68k/cpu/mcf532x/speed.c:248]: (error) Uninitialized variable: fout [arch/m68k/cpu/mcf5445x/speed.c:194]: (error) Uninitialized variable: bootmode Could you please have a look how to fix

[U-Boot] MPC85xx: Uninitialized variables and other problems

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [arch/powerpc/cpu/mpc85xx/cmd_errata.c:62]: (error) Uninitialized variable: x108 [board/freescale/common/cds_pci_ft.c:36]: (error) Possible null pointer dereference: map [board/freescale/common/cds_pci_ft.c:52]: (error) Uninitialized variable: len

[U-Boot] sandbox: Uninitialized variable

2014-11-06 Thread Wolfgang Denk
Dear Simon, cppcheck reports: [arch/sandbox/cpu/start.c:132]: (error) Uninitialized variable: err And also: [arch/sandbox/cpu/os.c:371]: (error) Memory leak: fname Could you please have a look? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk

Re: [U-Boot] arch/arm/lib/board.c - uninitialized vars

2014-11-06 Thread Heiko Schocher
Hello Wolfgang, Am 06.11.2014 12:28, schrieb Wolfgang Denk: Hi, I'm trying to clean up some warnings/errors detected when running cppcheck on the U-Boot source tree. For arch/arm/lib/board.c I get this: [arch/arm/lib/board.c:445]: (error) Uninitialized variable: id

[U-Boot] CONFIG_LCD_BMP_RLE8 and MCC200 dead code?

2014-11-06 Thread Nikita Kiryanov
Hi all, I've been trying to do some cleanup in common/lcd.c, and noticed some unused code: One is the CONFIG_LCD_BMP_REL8 stuff. This code was added 2 years ago in patch 45d7f52511f43b71b623a502fdf31feb905f70a1, and so far it has no users (sandbox.h defines it, but only to fix a compilation

[U-Boot] [board/gdsys/405ep/iocon.c:372]: (error) Uninitialized variable: fpga_features

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [board/gdsys/405ep/iocon.c:372]: (error) Uninitialized variable: fpga_features can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194

[U-Boot] [board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable: psize

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable: psize can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194

[U-Boot] [board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194

[U-Boot] [common/cmd_ini.c:137]: (error) Uninitialized variable: line

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [common/cmd_ini.c:137]: (error) Uninitialized variable: line can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,

[U-Boot] [drivers/misc/cros_ec.c:704]: (error) Uninitialized variable: req

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [drivers/misc/cros_ec.c:704]: (error) Uninitialized variable: req can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,

[U-Boot] [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,

[U-Boot] [drivers/net/e1000.c:2251]: (error) Uninitialized variable: phy_data

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [drivers/net/e1000.c:2251]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2261]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2303]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2313]: (error) Uninitialized variable:

[U-Boot] [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194

[U-Boot] [drivers/usb/musb-new/musb_core.c:2166]: (error) Uninitialized variable: musb

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [drivers/usb/musb-new/musb_core.c:2166]: (error) Uninitialized variable: musb [drivers/usb/musb-new/musb_host.c:1918]: (error) Uninitialized variable: idle can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD:

[U-Boot] [fs/zfs/zfs.c:743]: (error) Uninitialized variable: ct

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [fs/zfs/zfs.c:743]: (error) Uninitialized variable: ct [fs/zfs/zfs.c:937]: (error) Memory leak: l [fs/zfs/zfs.c:1048]: (error) Memory leak: zapbuf [fs/zfs/zfs.c:1083]: (error) Memory leak: zapbuf [fs/zfs/zfs.c:1141]: (error) Memory leak: dnbuf [fs/zfs/zfs.c:1372]:

Re: [U-Boot] [board/gdsys/405ep/iocon.c:372]: (error) Uninitialized variable: fpga_features

2014-11-06 Thread Dirk Eibach
Hello Wolfgang, 2014-11-06 13:31 GMT+01:00 Wolfgang Denk w...@denx.de: Hello, cppcheck reports: [board/gdsys/405ep/iocon.c:372]: (error) Uninitialized variable: fpga_features can you please have a look? Thanks! oops, nice one, thanks. Will fix. Cheers Dirk

[U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [net/eth.c:64]: (error) Uninitialized variable: skip_state can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH v2] doc: fix documentation of out-of-tree build

2014-11-06 Thread Timo Ketola
Correct environment variable for output directory is KBUILD_OUTPUT. Signed-off-by: Timo Ketola t...@exertus.fi --- v2 changes: - Fixed the example in the doc/README.kwbimage file functionally correct README |6 +++--- doc/README.kwbimage |4 ++-- 2 files

[U-Boot] [scripts/docproc.c:398]: (error) Common realloc mistake

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [scripts/docproc.c:398]: (error) Common realloc mistake: 'data' nulled but not freed upon failure [scripts/docproc.c:422]: (error) Common realloc mistake: 'all_list' nulled but not freed upon failure can you please have a look? Thanks! Best regards, Wolfgang Denk --

Re: [U-Boot] SPL (Secondary Program Loader) on iMX6SL

2014-11-06 Thread Fabio Estevam
Hi John, On Thu, Nov 6, 2014 at 12:54 AM, John Tobias john.tobias...@gmail.com wrote: Hi Fabio, The SPL support that I have done for sabresd is not %100 done. I just did that for the testing and to see if I could load the SPL image. Btw, I saw in freescale repository that they have the

[U-Boot] [scripts/kconfig/nconf.gui.c:375]: (error) Common realloc mistake

2014-11-06 Thread Wolfgang Denk
Hello, cppcheck reports: [scripts/kconfig/confdata.c:983]: (error) Resource leak: tristate [scripts/kconfig/nconf.gui.c:375]: (error) Common realloc mistake: 'result' nulled but not freed upon failure [scripts/kconfig/nconf.gui.c:481]: (error) Common realloc mistake: 'result' nulled but not

Re: [U-Boot] arch/arm/lib/board.c - uninitialized vars

2014-11-06 Thread Wolfgang Denk
Dear Heiko, In message 545b6539.9090...@denx.de you wrote: - so I think, we can drop the CONFIG_SPL_BUILD in u-boot:/arch/arm/lib/board.c board_init_f(), as it is not used, thats maybe the reason, why this issue never poped up! I agree - this appears to be dead code. Albert, what do you

Re: [U-Boot] CONFIG_LCD_BMP_RLE8 and MCC200 dead code?

2014-11-06 Thread Wolfgang Denk
Dear Nikita, In message 545b6844.2060...@compulab.co.il you wrote: I've been trying to do some cleanup in common/lcd.c, and noticed some unused code: Thanks! The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I don't think is likely to be used by current and future

[U-Boot] [PATCH] usb_storage: skip all unknown devices when probing

2014-11-06 Thread Soeren Moch
Not only skip storage devices with DEV_TYPE_UNKNOWN, but also all devices which are unknown to u-boot (e.g., are not HARDDISK, TAPE, CDROM, OPDISK). This especially avoids long timeouts when probing for external usb harddisks which provide Enclosure Services. Signed-off-by: Soeren Moch

Re: [U-Boot] [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d

2014-11-06 Thread Lukasz Majewski
Hi Wolfgang, Hello, cppcheck reports: [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d can you please have a look? Thanks! I will look on it, but first at a first glance it all looks correct. We definitely need usb_interface descriptor... Best regards,

[U-Boot] [PATCH 1/9] cppcheck cleanup: fix nullPointer errors

2014-11-06 Thread Wolfgang Denk
There are a number of places where U-Boot intentionally and legally accesses physical address 0x, for example when installing exception vectors on systems where these are located in low memory. Add cppcheck-suppress nullPointer comments to silence cppcheck where this is intentional and legal.

[U-Boot] [PATCH 0/9] cppcheck cleanup

2014-11-06 Thread Wolfgang Denk
The following patches clean up a number of errors and warnings detected by running the cppcheck [1] tool over the U-Boot source tree. This discovers a number of issues that escape GCC, for example because they are inside #ifdef branches which are never compiled for any of the tested

[U-Boot] [PATCH 2/9] board/cogent/lcd.c: fix syntax error

2014-11-06 Thread Wolfgang Denk
Fix error detected by cppcheck: [board/cogent/lcd.c:237]: (error) Invalid number of character (() when these macros are defined: 'CONFIG_SHOW_ACTIVITY;CONFIG_STATUS_LED'. Signed-off-by: Wolfgang Denk w...@denx.de --- board/cogent/lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[U-Boot] [PATCH 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow

2014-11-06 Thread Wolfgang Denk
Fix error detected by cppcheck: [board/matrix_vision/mvblx/sys_eeprom.c:353]: (error) Buffer is accessed out of bounds. Signed-off-by: Wolfgang Denk w...@denx.de cc: Michael Jones michael.jo...@matrix-vision.de --- board/matrix_vision/mvblx/sys_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1

[U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: fix syntax error

2014-11-06 Thread Wolfgang Denk
Fix error detected by cppcheck: [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: ''. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'.

[U-Boot] [PATCH 7/9] board/renesas/ecovec/ecovec.c: fix buffer overflow

2014-11-06 Thread Wolfgang Denk
Fix error detected by cppcheck: [board/renesas/ecovec/ecovec.c:66]: (error) Buffer is accessed out of bounds. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Nobuhiro Iwamatsu iwamatsu.nobuh...@renesas.com --- board/renesas/ecovec/ecovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[U-Boot] [PATCH 5/9] common/cmd_fitupd.c: restore corrupted file

2014-11-06 Thread Wolfgang Denk
This file got corrupted by the automatic editin of commit 1a45966 Add GPL-2.0+ SPDX-License-Identifier to source files; restore the opiginal content and manually insert the SPDX ID. The bug was detected by running cppcheck, which reported: [common/cmd_fitupd.c:8]: (error) Invalid number of

[U-Boot] [PATCH 8/9] ARM: MXS: fix Uninitialized variable error

2014-11-06 Thread Wolfgang Denk
cppcheck reports: [arch/arm/cpu/arm926ejs/mxs/timer.c:96]: (error) Uninitialized variable: now Signed-off-by: Wolfgang Denk w...@denx.de Cc: Marek Vasut ma...@denx.de Cc: Stefano Babic sba...@denx.de --- arch/arm/cpu/arm926ejs/mxs/timer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable

2014-11-06 Thread Wolfgang Denk
cppcheck reports: [board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt The variable is not really used anywhere, so remove it. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Matthias Fuchs matthias.fu...@esd-electronics.com --- board/esd/common/auto_update.c | 3 +-- 1 file

[U-Boot] [PATCH 4/9] drivers/net/uli526x.c: fix syntax error

2014-11-06 Thread Wolfgang Denk
Fix error detected by cppcheck: [drivers/net/uli526x.c:551]: (error) printf format string requires 3 parameters but only 2 are given. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Roy Zang tie-fei.z...@freescale.com --- drivers/net/uli526x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d

2014-11-06 Thread Wolfgang Denk
Dear Lukasz, In message 20141106135936.26788299@amdc2363 you wrote: [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d ... I will look on it, but first at a first glance it all looks correct. We definitely need usb_interface descriptor... You are right. This appears to be

Re: [U-Boot] [PATCH 6/6] linux/kernel.h: sync min, max, min3, max3 macros with Linux

2014-11-06 Thread Pavel Machek
On Wed 2014-11-05 07:02:23, Marek Vasut wrote: On Wednesday, November 05, 2014 at 06:06:09 AM, Masahiro Yamada wrote: Hi Pavel, Thanks for your close checking. On Tue, 4 Nov 2014 20:50:13 +0100 Pavel Machek pa...@denx.de wrote: On Tue 2014-11-04 20:26:26, Masahiro Yamada

Re: [U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: fix syntax error

2014-11-06 Thread Marek Vasut
On Thursday, November 06, 2014 at 02:02:59 PM, Wolfgang Denk wrote: Fix error detected by cppcheck: [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: ''. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character

Re: [U-Boot] [scripts/docproc.c:398]: (error) Common realloc mistake

2014-11-06 Thread Marek Vasut
On Thursday, November 06, 2014 at 01:42:41 PM, Wolfgang Denk wrote: Hello, Hello, cppcheck reports: [scripts/docproc.c:398]: (error) Common realloc mistake: 'data' nulled but not freed upon failure [scripts/docproc.c:422]: (error) Common realloc mistake: 'all_list' nulled but not freed

Re: [U-Boot] [drivers/usb/musb-new/musb_core.c:2166]: (error) Uninitialized variable: musb

2014-11-06 Thread Marek Vasut
On Thursday, November 06, 2014 at 01:36:22 PM, Wolfgang Denk wrote: Hello, Hi, cppcheck reports: [drivers/usb/musb-new/musb_core.c:2166]: (error) Uninitialized variable: musb [drivers/usb/musb-new/musb_host.c:1918]: (error) Uninitialized variable: idle can you please have a look?

Re: [U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable

2014-11-06 Thread Matthias Fuchs
On 11/06/2014 02:03 PM, Wolfgang Denk wrote: cppcheck reports: [board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt The variable is not really used anywhere, so remove it. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Matthias Fuchs

[U-Boot] [PATCH] km/km82xx: remove CONFIG_SYS_RAMBOOT

2014-11-06 Thread Holger Brunck
This define is never set in our setup, so we can remove it safely. The former code causes cppcheck to complain about: [board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable: psize Signed-off-by: Holger Brunck holger.bru...@keymile.com cc: Valentin Longchamp

Re: [U-Boot] [PATCH] sunxi: move select CPU_V7 to ARCH_SUNXI

2014-11-06 Thread Hans de Goede
Hi, On 11/06/2014 03:36 AM, Masahiro Yamada wrote: CPU_V7 is select'ed by all the MACH_SUN*I. While we are here, let's delete the redundant string typedef of SYS_CONFIG_NAME. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com I deliberately put the CPU_V7 where it is because I

Re: [U-Boot] [PATCH 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow

2014-11-06 Thread Michael Jones
On 11/06/2014 02:03 PM, Wolfgang Denk wrote: Fix error detected by cppcheck: [board/matrix_vision/mvblx/sys_eeprom.c:353]: (error) Buffer is accessed out of bounds. Signed-off-by: Wolfgang Denk w...@denx.de cc: Michael Jones michael.jo...@matrix-vision.de ---

Re: [U-Boot] [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb

2014-11-06 Thread Heiko Schocher
Hello Wolfgang, Am 06.11.2014 13:34, schrieb Wolfgang Denk: Hello, cppcheck reports: [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb can you please have a look? Thanks! I see in drivers/mtd/ubi/eba.c: 1267:ubi_rb_for_each_entry(rb, aeb, av-root, u.rb)

[U-Boot] [PATCH] powerpc, muas3001: remove CONFIG_SYS_RAMBOOT

2014-11-06 Thread Heiko Schocher
cppcheck reports: [board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize remove the CONFIG_SYS_RAMBOOT define to prevent this error report. Signed-off-by: Heiko Schocher h...@denx.de Reported-by: Wolfgang Denk w...@denx.de --- board/muas3001/muas3001.c | 4

Re: [U-Boot] [PATCH] sunxi: move select CPU_V7 to ARCH_SUNXI

2014-11-06 Thread Masahiro YAMADA
Hi Hans, 2014-11-06 22:56 GMT+09:00 Hans de Goede hdego...@redhat.com: Hi, On 11/06/2014 03:36 AM, Masahiro Yamada wrote: CPU_V7 is select'ed by all the MACH_SUN*I. While we are here, let's delete the redundant string typedef of SYS_CONFIG_NAME. Signed-off-by: Masahiro Yamada

[U-Boot] [PATCH 02/11] arm: omap5: tps659038: rename regulator defines

2014-11-06 Thread Felipe Balbi
Those regulators don't have any coupling with what they supply, so remove the suffixes in order to not confuse anybody. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/cpu/armv7/omap5/hw_data.c | 10 +- arch/arm/include/asm/arch-omap5/clock.h | 10 +- 2 files changed,

[U-Boot] [PATCH 07/11] arm: omap5: make hw_init_data weak

2014-11-06 Thread Felipe Balbi
this way we can let boards overwrite based on what they need. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/cpu/armv7/omap5/hw_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c index

[U-Boot] [PATCH 04/11] usb: phy: omap_usb_phy: fix build breakage

2014-11-06 Thread Felipe Balbi
there's no such function usb3_phy_power(), it's likely that author meant to call, usb_phy_power() instead, but that's already called properly from xhci-omap.c. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/omap_usb_phy.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[U-Boot] [PATCH 03/11] arm: dra7xx: prcm: add missing registers

2014-11-06 Thread Felipe Balbi
some boards might want to use USB1 for host, without fiddling those registers it'll be impossible. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/cpu/armv7/omap5/prcm-regs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/cpu/armv7/omap5/prcm-regs.c

[U-Boot] [PATCH 01/11] arm: omap5: don't enable misc_init_r by default

2014-11-06 Thread Felipe Balbi
Out of all OMAP5-like boards, only one of them needs CONFIG_MISC_INIT_R, so it's best to enable that for that particular board only, instead of enabling for all boards unconditionally. Signed-off-by: Felipe Balbi ba...@ti.com --- board/ti/dra7xx/evm.c | 12

[U-Boot] [PATCH 05/11] arm: omap-common: emif: allow to map memory without interleaving

2014-11-06 Thread Felipe Balbi
If we want to have two sections, one on each EMIF, without interleaving, current code wouldn't enable emif2. Fix that problem. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/cpu/armv7/omap-common/emif-common.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[U-Boot] [PATCH 11/11] beagle_x15: add board support for Beagle x15

2014-11-06 Thread Felipe Balbi
This is the bare minimum support for Beagle x15 into u-boot. There is still quite some work in order to get this in good shape, but it's a start. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/cpu/armv7/omap5/Kconfig | 4 +

[U-Boot] [PATCH 08/11] arm: omap5: sdram: mark emif_get_ext_phy_ctrl_const_regs __weak

2014-11-06 Thread Felipe Balbi
this will allow for boards to overwrite those in case memory setup is different. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/cpu/armv7/omap5/sdram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/omap5/sdram.c b/arch/arm/cpu/armv7/omap5/sdram.c

[U-Boot] [PATCH 06/11] configs: omap5_common : Boot rootfs from sd card by default

2014-11-06 Thread Felipe Balbi
From: Franklin S Cooper Jr fcoo...@ti.com * Since the emmc isn't always programed trying to load the fs from the emmc causes boot failures/kernel panic. * The current bootcmd is set to: bootcmd=run findfdt; run mmcboot;setenv mmcdev 1; setenv bootpart 1:2; \ setenv mmcroot /dev/mmcblk0p2

[U-Boot] [PATCH 10/11] arm: omap: add support for am57xx devices

2014-11-06 Thread Felipe Balbi
just add a few ifdefs around because this device is very similar to dra7xxx. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/cpu/armv7/omap-common/boot-common.c | 2 +- arch/arm/include/asm/arch-omap5/clock.h | 2 +- arch/arm/include/asm/arch-omap5/omap.h | 4 ++--

[U-Boot] [PATCH 09/11] arm: omap_common: expose tps659038 and dra7xx_dplls

2014-11-06 Thread Felipe Balbi
expose those two definitions so they can be used by another board which we're adding in upcoming patches. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/include/asm/omap_common.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/include/asm/omap_common.h

Re: [U-Boot] [PATCH 11/11] beagle_x15: add board support for Beagle x15

2014-11-06 Thread menon.nisha...@gmail.com
On Thu, Nov 6, 2014 at 8:28 AM, Felipe Balbi ba...@ti.com wrote: This is the bare minimum support for Beagle x15 into u-boot. There is still quite some work in order to get this in good shape, but it's a start. Sorry, I should have commented earlier :) we could expand this a little more

[U-Boot] [PATCH 2/2] mx6sabresd: Staticize when possible

2014-11-06 Thread Fabio Estevam
Annotate 'static' when appropriate for the variables used locally. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- board/freescale/mx6sabresd/mx6sabresd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/board/freescale/mx6sabresd/mx6sabresd.c

Re: [U-Boot] [PATCH 11/11] beagle_x15: add board support for Beagle x15

2014-11-06 Thread Felipe Balbi
On Thu, Nov 06, 2014 at 08:35:41AM -0600, menon.nisha...@gmail.com wrote: On Thu, Nov 6, 2014 at 8:28 AM, Felipe Balbi ba...@ti.com wrote: This is the bare minimum support for Beagle x15 into u-boot. There is still quite some work in order to get this in good shape, but it's a start.

[U-Boot] [PATCH v2 11/11] beagle_x15: add board support for Beagle x15

2014-11-06 Thread Felipe Balbi
BeagleBoard-X15 is the next generation Open Source Hardware BeagleBoard based on TI's AM5728 SoC featuring dual core 1.5GHZ A15 processor. The platform features 2GB DDR3L (w/dual 32bit busses), eSATA, 3 USB3.0 ports, integrated HDMI (1920x108@60), separate LCD port, video In port, 4GB eMMC, uSD,

Re: [U-Boot] [PATCH v2 11/11] beagle_x15: add board support for Beagle x15

2014-11-06 Thread menon.nisha...@gmail.com
On Thu, Nov 6, 2014 at 8:44 AM, Felipe Balbi ba...@ti.com wrote: BeagleBoard-X15 is the next generation Open Source Hardware BeagleBoard based on TI's AM5728 SoC featuring dual core 1.5GHZ A15 processor. The platform features 2GB DDR3L (w/dual 32bit busses), eSATA, 3 USB3.0 ports, integrated

[U-Boot] [PATCH 1/2] mx6sabresd: Fix error handling in board_mmc_init()

2014-11-06 Thread Fabio Estevam
When an invalid USDHC port is passed we should return -EINVAL instead of 0. Also, return the error immediately on fsl_esdhc_initialize() failure. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- board/freescale/mx6sabresd/mx6sabresd.c | 10 ++ 1 file changed, 6

Re: [U-Boot] [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb

2014-11-06 Thread Wolfgang Denk
Dear Heiko, In message 545b81d9.6070...@denx.de you wrote: [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb can you please have a look? Thanks! I see in drivers/mtd/ubi/eba.c: 1267:ubi_rb_for_each_entry(rb, aeb, av-root, u.rb) 1268:

[U-Boot] Can i pass pass an environmental variable or argument from command line to build u-boot?

2014-11-06 Thread harsha kiran
Hi ! For our project, we are trying to build the Bootloader with a Software partnumber. and i want it to be displayed on the first U-boot print.. U-Boot 2014.07 (Nov 05 2014 - 16:27:50) PN#12345678-001 I2C: ready DRAM: 256 MiB WARNING: Caches not enabled MMC: OMAP SD/MMC: 0, OMAP SD/MMC:

Re: [U-Boot] Can i pass pass an environmental variable or argument from command line to build u-boot?

2014-11-06 Thread Tom Rini
On Thu, Nov 06, 2014 at 08:30:35AM -0700, harsha kiran wrote: Hi ! For our project, we are trying to build the Bootloader with a Software partnumber. and i want it to be displayed on the first U-boot print.. Upgrade to current mainline and you can use CONFIG_LOCALVERSION for what you want.

Re: [U-Boot] [U-Boot, U-boot, v2] net: phy: marvell: add errata w/a for 88E151* chips

2014-11-06 Thread Tom Rini
On Thu, Oct 30, 2014 at 06:59:43PM +0200, Ivan Khoronzhuk wrote: From: Hao Zhang hzh...@ti.com As per Marvell Release Notes - Alaska 88E1510/88E1518/88E1512/88E1514 Rev A0, Errata Section 3.1 Marvell PHY has an errata which requires that certain registers get written in order to restart

Re: [U-Boot] [U-Boot, U-boot] net: phy: marvell: add errata w/a for 88E151* chips

2014-11-06 Thread Tom Rini
On Wed, Nov 05, 2014 at 04:30:33PM -0500, Tom Rini wrote: On Wed, Oct 29, 2014 at 08:38:23PM +0200, Khoronzhuk, Ivan wrote: From: Hao Zhang hzh...@ti.com As per Marvell Release Notes - Alaska 88E1510/88E1518/88E1512/88E1514 Rev A0, Errata Section 3.1 Marvell PHY has an errata which

Re: [U-Boot] [common/cmd_ini.c:137]: (error) Uninitialized variable: line

2014-11-06 Thread Tom Rini
On Thu, Nov 06, 2014 at 01:32:59PM +0100, Wolfgang Denk wrote: Hello, cppcheck reports: [common/cmd_ini.c:137]: (error) Uninitialized variable: line can you please have a look? Thanks! trini@bill-the-cat:~/work/u-boot/u-boot-ti (master)$ cppcheck --version Cppcheck 1.52

Re: [U-Boot] SPL (Secondary Program Loader) on iMX6SL

2014-11-06 Thread John Tobias
Hi Fabio, Thanks for the info. I will try to send some patch or file for iMX6 SabreSD and for iMX6SL-evk later today. Regards, john On Thu, Nov 6, 2014 at 4:43 AM, Fabio Estevam feste...@gmail.com wrote: Hi John, On Thu, Nov 6, 2014 at 12:54 AM, John Tobias john.tobias...@gmail.com wrote:

Re: [U-Boot] [net/eth.c:64]: (error) Uninitialized variable: skip_state

2014-11-06 Thread Tom Rini
On Thu, Nov 06, 2014 at 01:37:23PM +0100, Wolfgang Denk wrote: Hello, cppcheck reports: [net/eth.c:64]: (error) Uninitialized variable: skip_state can you please have a look? Thanks! Dense code, like cmd_ini.c my cppcheck is OK and looking at the code manually I think it's fine too:

Re: [U-Boot] Can i pass pass an environmental variable or argument from command line to build u-boot?

2014-11-06 Thread harsha kiran
Thanks Rini, We have freeze the code base of bootloader for 2014-07 main line. What can be another alternate approach? i was looking at the make file and i see that they take everything before _config and is sorted to find all the right pieces from boards.cfg file %_config:: outputmakefile

Re: [U-Boot] [PATCH] test: ums: Add sleep before unmount directory

2014-11-06 Thread Stephen Warren
On 11/06/2014 03:23 AM, Lukasz Majewski wrote: This change helps to run script on machines with quite long uptime. Without this the following error emerges: File: ./dat_14M.img umount: /mnt/tmp-ums-test: device is busy. (In some cases useful info about processes that use the

Re: [U-Boot] Can i pass pass an environmental variable or argument from command line to build u-boot?

2014-11-06 Thread Masahiro YAMADA
Hi harsha, 2014-11-07 1:43 GMT+09:00 harsha kiran kj.h.ki...@us.abb.com: Thanks Rini, We have freeze the code base of bootloader for 2014-07 main line. What can be another alternate approach? i was looking at the make file and i see that they take everything before _config and is sorted

Re: [U-Boot] Can i pass pass an environmental variable or argument from command line to build u-boot?

2014-11-06 Thread harsha kiran
Thank you guys. This is exactly what i wanted. Thanks, Harsha -- View this message in context: http://u-boot.10912.n7.nabble.com/Can-i-pass-pass-an-environmental-variable-or-argument-from-command-line-to-build-u-boot-tp194962p194972.html Sent from the U-Boot mailing list archive at

Re: [U-Boot] CONFIG_LCD_BMP_RLE8 and MCC200 dead code?

2014-11-06 Thread Nikita Kiryanov
Hi Wolfgang, On 11/06/2014 02:50 PM, Wolfgang Denk wrote: Dear Nikita, In message 545b6844.2060...@compulab.co.il you wrote: I've been trying to do some cleanup in common/lcd.c, and noticed some unused code: Thanks! The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I

  1   2   3   >