Re: [U-Boot] [RFC PATCH v2 09/11] sf_mtd: Simply mtd operations

2018-12-05 Thread Vignesh R
Hi Boris, On 04/12/18 6:19 PM, Boris Brezillon wrote: > On Tue, 4 Dec 2018 17:56:57 +0530 > Vignesh R wrote: > >> Now that there is new SPI NOR framework, simplify mtd device >> registration and read/write/erase operations. >> >> Signed-off-by: Vignesh R >> --- >>

Re: [U-Boot] [PATCH v3 15/28] mtd: ensure MTD is compiled when CMD_MTDPARTS is selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:01 +0100 Miquel Raynal wrote: > MTD support must be enabled when using mtdparts. Indeed, functions > like get_mtd_info(), get_mtd_device() and put_mtd_device() are in > drivers/mtd/mtd_uboot.c and are built only with CONFIG_MTD. > > Signed-off-by: Miquel Raynal

Re: [U-Boot] [PATCH v3 16/28] configs: move CONFIG_MTD in defconfigs when set in arch includes

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:02 +0100 Miquel Raynal wrote: > Let's be consistent and always declare CONFIG_MTD from the defconfig > file when needed. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon One comment below. > --- > configs/socfpga_stratix10_defconfig | 1 + >

Re: [U-Boot] [PATCH v3 19/28] mtd: nand: add includes in NAND core to avoid warnings

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:05 +0100 Miquel Raynal wrote: > Because of the include's game, when some files are compiled for a SPI > NAND device, no warning appears. But when it is for a raw NAND device, > GCC complains. Fix these warning by including . > > Signed-off-by: Miquel Raynal

Re: [U-Boot] [PATCH v3 10/28] mtd: ensure UBI is compiled when CMD_UBI is selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:56 +0100 Miquel Raynal wrote: > UBI must be enabled when CMD_UBI is used, this is mandatory and will > later be reflected thanks to a "depends on" in Kconfig. But first, > defconfigs needs to be fixed. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon

Re: [U-Boot] [PATCH v3 09/28] mtd: ensure MTD is compiled when UBI is used

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:55 +0100 Miquel Raynal wrote: > MTD must be enabled when UBI is used, this is mandatory and will later > be reflected thanks to a "depends on" in Kconfig. But first, > defconfigs needs to be fixed. ^ need > > Signed-off-by: Miquel Raynal Reviewed-by:

Re: [U-Boot] [PATCH v3 08/28] mtd: ensure UBI is compiled when using fastmap

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:54 +0100 Miquel Raynal wrote: > UBI must be enabled when using fastmap, reflect this is defconfigs. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v3 21/28] mtd: nor: NOR flashes depend on MTD

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:07 +0100 Miquel Raynal wrote: > A NOR flash needs the MTD core, ensure this dependency is met by > adding a "depends on" in Kconfig. This is fine since defconfigs have > been fixed. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/Kconfig | 1 + > 1 file changed,

Re: [U-Boot] [PATCH v4 00/11] mtd/sf: Various fixes

2018-12-05 Thread Boris Brezillon
Hi Jagan, On Sun, 2 Dec 2018 10:54:21 +0100 Boris Brezillon wrote: > Hello, > > This is the 4th version of the mtd / sf fixes patchset. This v4 just > adds a new check in del_mtd_device() (and a debug() when > del_mtd_partitions() fails). > > Regards, > > Boris > > P.S.: travis-ci results

[U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass

2018-12-05 Thread Michal Simek
Generic wrapper requires MISC uclass but dependency is not covered in Kconfig. misc0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe20 misc1 [ ] dwc3-generic-wrapper | |-- usb1@ff9e usb

Re: [U-Boot] [PATCH v3 02/28] mtd: rename CONFIG_NAND -> CONFIG_MTD_RAW_NAND

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:48 +0100 Miquel Raynal wrote: > Add more clarity by changing the Kconfig entry name. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v3 01/28] Makefile: move MTD-related lines in coherent Makefiles

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:47 +0100 Miquel Raynal wrote: > Move MTD-related lines out of the root Makefile. Put them in their > respective directories. > > Enclose some of these new lines to skip them when building the SPL > (the SPL directly points to what is needed). > > CONFIG_CMD_NAND is

Re: [U-Boot] [PATCH v3 06/28] mtd: ensure MTD/the raw NAND core are compiled when there is a NAND flash

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:52 +0100 Miquel Raynal wrote: > Both symbols must be enabled when there is a raw NAND driver > selected. Also enable them when CONFIG_CMD_NAND is selected to do not > break any build during later cleanup. "... to avoid breaking things when we'll further rework the MTD

Re: [U-Boot] [PATCH] pinctrl: meson: Fix GPIO direction registers access

2018-12-05 Thread Neil Armstrong
On 05/12/2018 08:44, Jerome Brunet wrote: > On Mon, 2018-12-03 at 18:00 +, Carlo Caione wrote: >> The macros used to set the direction of the GPIO pins are misused, >> resulting in a wrong behavior when trying to read the GPIO input level >> from U-Boot. >> >> A better macro is also used when

Re: [U-Boot] [PATCH v3 12/28] mtd: ensure MTD_RAW_NAND is compiled when ENV_IS_IN_NAND is selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:58 +0100 Miquel Raynal wrote: > Raw NAND support must be enabled when the environment is in NAND. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 05/19] riscv: Add a SYSCON driver for Core Local Interruptor

2018-12-05 Thread Bin Meng
Hi Lukas, On Wed, Nov 14, 2018 at 6:33 PM Auer, Lukas wrote: > > Hi Bin, > > On Wed, 2018-11-14 at 09:48 +0800, Bin Meng wrote: > > Hi Lukas, > > > > On Tue, Nov 13, 2018 at 10:45 PM Auer, Lukas > > wrote: > > > > > > Hi Bin, > > > > > > On Tue, 2018-11-13 at 00:21 -0800, Bin Meng wrote: > > >

Re: [U-Boot] [PATCH v3 17/28] configs: remove raw NAND core from k2g defconfigs

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:03 +0100 Miquel Raynal wrote: > Due to previous Makefile organization, the raw NAND subdirectory was > not compiled in if CMD_NAND was not enabled. Because the Denali driver > does not compile with these boards (undefined environment offset), > remove the dependency

Re: [U-Boot] [PATCH v3 18/28] configs: remove MTD support from bcm11130 and M54418TWR defconfigs

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:04 +0100 Miquel Raynal wrote: > While the right Kconfig entries were selected, because of the missing > CMD_NAND symbol the raw NAND core was never compiled. Remove it from > the defconfigs otherwise the build will fail. See my comment on patch 17.

[U-Boot] Issue with memcpy when booting a fitImage on SPEAr600

2018-12-05 Thread Quentin Schulz
Hello everyone, I'm working on porting a mainline U-Boot on a custom board based on a SPEAr600. Right now, I'm facing an issue related with fitImage booting. Before starting on the fitImage issue, let me state that the zImage and the custom DTB concatenated in a uImage have the load address and

Re: [U-Boot] [PATCH v3 23/28] mtd: ubi: remove dependency on command in Kconfig

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:09 +0100 Miquel Raynal wrote: > Now that the defconfigs have been fixed, remove the dependencies on > commands in Kconfig. No changes in Kconfig in this patch. > The necessary symbols are enabled so this will > not break anything. > > Signed-off-by: Miquel Raynal >

Re: [U-Boot] [PATCH v3 25/28] cmd: nand/sf: isolate legacy code

2018-12-05 Thread Thomas Petazzoni
Hello, On Wed, 5 Dec 2018 11:37:54 +0100, Boris Brezillon wrote: > ifeq (,$(findstring y,$(CONFIG_CMD_NAND)$(CONFIG_CMD_SF))) This could be "simplified" as: ifneq ($(CONFIG_CMD_NAND)$(CONFIG_CMD_SF),) if either of the options is 'y', the string is non-empty, so the condition will be true.

Re: [U-Boot] [PATCH v3 16/28] configs: move CONFIG_MTD in defconfigs when set in arch includes

2018-12-05 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 5 Dec 2018 11:17:28 +0100: > On Wed, 5 Dec 2018 00:57:02 +0100 > Miquel Raynal wrote: > > > Let's be consistent and always declare CONFIG_MTD from the defconfig > > file when needed. > > > > Signed-off-by: Miquel Raynal > > Reviewed-by: Boris

Re: [U-Boot] [PATCH v3 24/28] cmd: mtdparts: show Kconfig options only if the command is selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:10 +0100 Miquel Raynal wrote: > Guard mtdparts options with an if/endif statement in Kconfig. Also > move the Kconfig entry of the option right after the entry of the > command. > > Signed-off-by: Miquel Raynal > --- > cmd/Kconfig | 21 +++-- > 1 file

Re: [U-Boot] [PATCH v3 22/28] mtd: nand: remove dependency on commands in Kconfig

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:08 +0100 Miquel Raynal wrote: > Now that the defconfigs have been fixed, remove the dependencies on > commands in Kconfig. That's not what I'm seeing in this diff ;-). > The necessary symbols are enabled so this will > not break anything. > > Signed-off-by: Miquel

[U-Boot] [RFC PATCH] spl/tpl: change banner into upper case

2018-12-05 Thread Heiko Schocher
commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT") changes the SPL/TPL banner from upper case into lower case. As SPL and TPL are three-letter acronyms and they are written in upper case, change it back to upper case. Signed-off-by: Heiko Schocher --- include/spl.h

Re: [U-Boot] [PATCH v3 26/28] cmd: make MTD commands depend on MTD

2018-12-05 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 5 Dec 2018 11:42:08 +0100: > On Wed, 5 Dec 2018 00:57:12 +0100 > Miquel Raynal wrote: > > > Defconfigs have been fixed, now we can add proper dependencies in > > Kconfig. SPI FLASH is still not dependent on MTD (deeper rework needed). > > > >

Re: [U-Boot] [PATCH v3 28/28] mtd: properly handle SPL kbuild lines

2018-12-05 Thread Boris Brezillon
Hi Miquel, On Wed, 5 Dec 2018 00:57:14 +0100 Miquel Raynal wrote: > Instead of compiling just a few files from the root Makefile, rework > the MTD Makefile tree to take into account SPL's needs. > As mentioned in my review of patch 1, I think patch 1, 27 and 28 could be merged in a single

Re: [U-Boot] [RFC PATCH v2 08/11] mtd: spi: Add lightweight SPI flash stack for SPL

2018-12-05 Thread Vignesh R
On 05/12/18 12:31 PM, Simon Goldschmidt wrote: > On Tue, Dec 4, 2018 at 1:27 PM Vignesh R wrote: >> >> Add a tiny SPI flash stack that just supports reading data/images from >> SPI flash. This is useful for boards that have SPL size constraints and >> would need to use SPI flash framework just

[U-Boot] [PATCH v2] common: command: Add support for $ auto-completion

2018-12-05 Thread Boris Brezillon
Add the dollar_complete() function to auto-complete arguments starting with a '$' and use it in the cmd_auto_complete() path such that all args starting with a $ can be auto-completed based on the available env vars. Signed-off-by: Boris Brezillon --- Changes in v2: - Call dollar_complete() from

Re: [U-Boot] [PATCH v3 03/28] mtd: rename CONFIG_MTD -> CONFIG_DM_MTD

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:49 +0100 Miquel Raynal wrote: > CONFIG_MTD must be reserved for the MTD core. Like any other > subsystem, prefix the symbol by DM when it comes to DM support. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon

Re: [U-Boot] [PATCH v3 04/28] mtd: rename CONFIG_MTD_DEVICE -> CONFIG_MTD

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:50 +0100 Miquel Raynal wrote: > Like in Linux, just use CONFIG_MTD to compile the MTD stack. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v3 05/28] mtd: ensure MTD is compiled when there is a NOR flash

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:51 +0100 Miquel Raynal wrote: > CONFIG_MTD must be enabled when there is a NOR flash selected. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH] QE: ls1043a: modify CONFIG_SYS_QE_FW_ADDR to (512*4A00) in SD Card

2018-12-05 Thread Zhao Qiang
Due to the new layout of Layerscape series, move the QE firmware to address (512*4A00) in SD Card. Signed-off-by: Zhao Qiang --- include/configs/ls1043a_common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/configs/ls1043a_common.h

Re: [U-Boot] [PATCH v3 20/28] dfu: add dependency on the NAND core

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:06 +0100 Miquel Raynal wrote: > CONFIG_DFU_NAND needs the NAND core being compiled. > > Also fix the colibri_vf defconfig to reflect this dependency. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon BTW, it would be great to have an MTD backend

Re: [U-Boot] [PATCH v3 25/28] cmd: nand/sf: isolate legacy code

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:11 +0100 Miquel Raynal wrote: > The 'sf' command is not supposed to rely on the MTD stack, but both > 'sf' and 'nand' commands use helpers located in mtd_uboot.c. Despite > their location, these functions do not depend at all on the MTD > stack. > > This file

Re: [U-Boot] [PATCH v3 26/28] cmd: make MTD commands depend on MTD

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 11:48:32 +0100 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Wed, 5 Dec 2018 > 11:42:08 +0100: > > > On Wed, 5 Dec 2018 00:57:12 +0100 > > Miquel Raynal wrote: > > > > > Defconfigs have been fixed, now we can add proper dependencies in > > > Kconfig.

Re: [U-Boot] [PATCH v3 26/28] cmd: make MTD commands depend on MTD

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:12 +0100 Miquel Raynal wrote: > Defconfigs have been fixed, now we can add proper dependencies in > Kconfig. SPI FLASH is still not dependent on MTD (deeper rework needed). > > Signed-off-by: Miquel Raynal > --- > cmd/Kconfig | 10 +++--- > 1 file changed, 7

Re: [U-Boot] [PATCH v3 17/28] configs: remove raw NAND core from k2g defconfigs

2018-12-05 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 5 Dec 2018 11:19:49 +0100: > On Wed, 5 Dec 2018 00:57:03 +0100 > Miquel Raynal wrote: > > > Due to previous Makefile organization, the raw NAND subdirectory was > > not compiled in if CMD_NAND was not enabled. Because the Denali driver > > does not

Re: [U-Boot] [RFC PATCH v2 09/11] sf_mtd: Simply mtd operations

2018-12-05 Thread Miquel Raynal
Hi Vignesh, Vignesh R wrote on Wed, 5 Dec 2018 13:30:27 +0530: > Hi Boris, > > On 04/12/18 6:19 PM, Boris Brezillon wrote: > > On Tue, 4 Dec 2018 17:56:57 +0530 > > Vignesh R wrote: > > > >> Now that there is new SPI NOR framework, simplify mtd device > >> registration and read/write/erase

Re: [U-Boot] [PATCH v3 07/28] mtd: ensure MTD is compiled when there is a SPI NOR flash using MTD

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:53 +0100 Miquel Raynal wrote: > MTD must be enabled when there is a SPI NOR flash using the > SPI_FLASH_MTD config entry. > > Signed-off-by: Miquel Raynal With Vignesh's comment addressed Reviewed-by: Boris Brezillon ___

Re: [U-Boot] [PATCH v3 11/28] mtd: ensure UBI is compiled when ENV_IS_IN_UBI is selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:57 +0100 Miquel Raynal wrote: > UBI must be enabled when the environment is in UBI. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH] common: fdt_support: print hexadecimal numbers in debug

2018-12-05 Thread Sekhar Nori
We usually deal with hexadecimal addresses and sizes in device-tree. Its much easier if debug logs print hexadecimal values too. Signed-off-by: Sekhar Nori --- common/fdt_support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/fdt_support.c

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:56:59 +0100 Miquel Raynal wrote: > MTD support must be enabled when the environment is in NOR. > > Signed-off-by: Miquel Raynal > --- > configs/armadillo-800eva_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/armadillo-800eva_defconfig >

Re: [U-Boot] [PATCH] Enable expression support for CONFIG_BOARD_SIZE_LIMIT

2018-12-05 Thread Wolfgang Denk
Dear Fabio, In message you wrote: > > Still not working for me. I do see a warning now: > > LD spl/u-boot-spl > /bin/sh: 1: arithmetic expression: expecting primary: ""((768 - 69) * 1024)"" > COPYu-boot.bin > MKIMAGE u-boot.img > OBJCOPY spl/u-boot-spl-nodtb.bin > COPY

Re: [U-Boot] [PATCH v3 14/28] mtd: ensure CMD_NAND is compiled when its options are selected

2018-12-05 Thread Boris Brezillon
On Wed, 5 Dec 2018 00:57:00 +0100 Miquel Raynal wrote: > In some files, options of CMD_NAND are selected but not the command > itself. Fix this inconsistency. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon ___ U-Boot mailing list

Re: [U-Boot] [RFC PATCH v2 06/11] mtd spi: Switch to new SPI NOR framework

2018-12-05 Thread Vignesh R
On 05/12/18 12:34 PM, Simon Goldschmidt wrote: > On Tue, Dec 4, 2018 at 1:27 PM Vignesh R wrote: >> >> Switch spi_flash_* interfaces to call into new SPI NOR framework via MTD >> layer. Fix up sf_dataflash to work in legacy way. And update sandbox to >> use new interfaces/defintions >> >>

Re: [U-Boot] [Fwd: [PATCH] mpc83xx: Add support for -msingle-pic-base]

2018-12-05 Thread Mario Six
Hi Joakim, On Wed, Dec 5, 2018 at 11:03 AM Joakim Tjernlund wrote: > > Ping ? > > On Thu, 2018-11-29 at 14:09 +0100, Joakim Tjernlund wrote: > > OOPS, I forgot to include you in this patch so I do that now :) > > > > > > --- Forwarded Message > > From: Joakim Tjernlund > > To:

Re: [U-Boot] [PATCH v3 06/28] mtd: ensure MTD/the raw NAND core are compiled when there is a NAND flash

2018-12-05 Thread Wolfgang Denk
Dear Miquel Raynal, In message <20181204235714.11805-7-miquel.ray...@bootlin.com> you wrote: > Both symbols must be enabled when there is a raw NAND driver > selected. Also enable them when CONFIG_CMD_NAND is selected to do not > break any build during later cleanup. Why would we need MTD for

Re: [U-Boot] [PATCH v3 7/7] x86: acpi: Generate SPCR table

2018-12-05 Thread Simon Glass
On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko wrote: > > Microsoft specifies a SPCR (Serial Port Console Redirection Table) [1]. > Let's provide it in U-Boot. > > [1]: > https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table > > Signed-off-by:

Re: [U-Boot] [PATCH v3 3/7] serial: ns16550: Group reg_* members of ns16550_platdata

2018-12-05 Thread Simon Glass
On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko wrote: > > Group reg_* members of struct ns16550_platdata together for better > maintenance. > > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > include/ns16550.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [PATCH v3 4/7] serial: ns16550: Read reg-io-width from device tree

2018-12-05 Thread Simon Glass
On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko wrote: > > Cache the value of the reg-io-width property for the future use. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/ns16550.c | 1 + > include/ns16550.h| 2 ++ > 2 files changed, 3 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v3 5/7] serial: ns16550: Provide ->getinfo() implementation

2018-12-05 Thread Simon Glass
On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko wrote: > > New callback will supply necessary information, for example, > to ACPI SPCR table. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/ns16550.c | 20 > 1 file changed, 20 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-12-05 Thread Simon Goldschmidt
On Wed, Dec 5, 2018 at 2:21 PM Simon Glass wrote: > > Hi Simon, > > On Sun, 25 Nov 2018 at 23:05, Simon Goldschmidt > wrote: > > > > [I've cut down the CC list a bit due to some gmail warnings] > > On Mon, Nov 26, 2018 at 4:00 AM Simon Glass wrote: > > > > > > Hi Simon, > > > > > > On Sun, 25

Re: [U-Boot] network not work with u-boot

2018-12-05 Thread Wolfgang Denk
Dear 张国富, In message <3ddf0dcd.d340.1677de6d85a.coremail.cleanc...@163.com> you wrote: > > Recently I came across a problem, and I tried many things but it still > does not work. > I have a board with a u-boot ready and the kernel image yet to upload. > Unfortunately the board could not

Re: [U-Boot] Issue with memcpy when booting a fitImage on SPEAr600

2018-12-05 Thread Stefan Roese
Hi Quentin, On 05.12.18 11:38, Quentin Schulz wrote: I'm working on porting a mainline U-Boot on a custom board based on a SPEAr600. Right now, I'm facing an issue related with fitImage booting. Before starting on the fitImage issue, let me state that the zImage and the custom DTB concatenated

Re: [U-Boot] [U-Boot, PATCHv3, 2/4] dm: MIGRATION: Add migration plan for DM_USB

2018-12-05 Thread Tom Rini
On Wed, Dec 05, 2018 at 08:14:14AM +0100, Stefan Roese wrote: > Hi Tom, > > On 04.12.18 05:49, Tom Rini wrote: > >On Thu, Nov 29, 2018 at 06:21:12PM -0500, Tom Rini wrote: > > > >>As much of the USB system has been migrated to DM now, formalize a > >>deadline for migration. > >> > >>Reviewed-by:

Re: [U-Boot] [PATCH 1/1] usb: musb-new: sunxi: Fix null pointer access

2018-12-05 Thread Marek Vasut
On 12/05/2018 01:49 PM, Stefan Mavrodiev wrote: > When the device is in peripheral mode Can you have two devices, one in peripheral mode and one in host mode, on the same system ? > there is no > struct usb_bus_priv allocated pointer, as the uclass driver > ("usb_dev_generic") doesn't call

[U-Boot] [PATCH] blk: Rework guard around part_init call

2018-12-05 Thread Tom Rini
The function part_init() will only be built when we have both CONFIG_PARTITIONS and CONFIG_HAVE_BLOCK_DEVICE set. Protect the call to this function with both of these tests now. Cc: Simon Glass Cc: Philipp Tomsich Cc: Michal Simek Cc: York Sun Cc: Prabhakar Kushwaha Cc: Mingkai Hu Cc:

Re: [U-Boot] [PATCH v3 25/28] cmd: nand/sf: isolate legacy code

2018-12-05 Thread Miquel Raynal
Hello, Thomas Petazzoni wrote on Wed, 5 Dec 2018 11:53:52 +0100: > Hello, > > On Wed, 5 Dec 2018 11:37:54 +0100, Boris Brezillon wrote: > > > ifeq (,$(findstring y,$(CONFIG_CMD_NAND)$(CONFIG_CMD_SF))) > > This could be "simplified" as: > > ifneq ($(CONFIG_CMD_NAND)$(CONFIG_CMD_SF),) > >

[U-Boot] [PATCH] mmc: zynq: Remove unused pwrseq variable

2018-12-05 Thread Michal Simek
This variable was incorrectly added by: "mmc: zynq_sdhci: Add support for SD3.0" (sha1: d1f4e39d58db32a4fd1a1b4085e0ede498bd773f) which had nothing to do with MMC power sequence provider. Signed-off-by: Michal Simek --- drivers/mmc/zynq_sdhci.c | 1 - 1 file changed, 1 deletion(-) diff --git

[U-Boot] [PATCH 1/3] buildman: Drop comment about Ctrl-C problem

2018-12-05 Thread Simon Glass
This bug is now fixed, so drop this comment. Signed-off-by: Simon Glass --- tools/buildman/README | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/buildman/README b/tools/buildman/README index 5a709c6ff9e..d688b7cf006 100644 --- a/tools/buildman/README +++ b/tools/buildman/README @@

[U-Boot] [PATCH 3/3] travis: Use buildman for building with clang

2018-12-05 Thread Simon Glass
Now that buildman supports clang, use it. Signed-off-by: Simon Glass --- .travis.yml | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index a061f02399c..59a00d065e3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -109,16 +109,9 @@

Re: [U-Boot] [PATCH 1/1] usb: musb-new: sunxi: Fix null pointer access

2018-12-05 Thread Stefan Mavrodiev
On 12/5/18 2:57 PM, Marek Vasut wrote: On 12/05/2018 01:49 PM, Stefan Mavrodiev wrote: When the device is in peripheral mode Can you have two devices, one in peripheral mode and one in host mode, on the same system ? Not 100% sure, but I'm thinking there is only one OTG port for all sunxi

Re: [U-Boot] [PATCH v3 16/28] configs: move CONFIG_MTD in defconfigs when set in arch includes

2018-12-05 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 5 Dec 2018 11:17:28 +0100: > On Wed, 5 Dec 2018 00:57:02 +0100 > Miquel Raynal wrote: > > > Let's be consistent and always declare CONFIG_MTD from the defconfig > > file when needed. > > > > Signed-off-by: Miquel Raynal > > Reviewed-by: Boris

Re: [U-Boot] [PATCH v3 21/28] mtd: nor: NOR flashes depend on MTD

2018-12-05 Thread Wolfgang Denk
Dear Miquel Raynal, In message <20181204235714.11805-22-miquel.ray...@bootlin.com> you wrote: > A NOR flash needs the MTD core, ensure this dependency is met by > adding a "depends on" in Kconfig. This is fine since defconfigs have > been fixed. If such a dependeny exists, it must be fixed.

Re: [U-Boot] [PATCH 6/7] defconfigs: Add config for AM57xx High Security EVM with UART/USB Boot support

2018-12-05 Thread Lokesh Vutla
On 05/12/18 3:07 AM, Andrew F. Davis wrote: On 12/2/18 11:24 PM, Lokesh Vutla wrote: On 30/11/18 10:41 PM, Andrew F. Davis wrote: Add a new defconfig file for the AM57xx High Security EVM. This config is specific for the case of UART/USB booting. Can you share the steps on how you

[U-Boot] [PATCH 1/1] usb: musb-new: sunxi: Fix null pointer access

2018-12-05 Thread Stefan Mavrodiev
When the device is in peripheral mode there is no struct usb_bus_priv allocated pointer, as the uclass driver ("usb_dev_generic") doesn't call per_device_auto_alloc_size. This results in writing to the internal SDRAM at priv->desc_before_addr = true; Signed-off-by: Stefan Mavrodiev ---

Re: [U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback

2018-12-05 Thread Simon Glass
HI Andy, On Tue, 27 Nov 2018 at 09:03, Andy Shevchenko wrote: > > On Mon, Nov 26, 2018 at 06:02:28PM -0700, Simon Glass wrote: > > Hi Andy, > > > > On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko > > wrote: > > > > > > In some cases it would be good to know the settings, such as parity, > > > of

Re: [U-Boot] [PATCH] test: hexdump: fix misplaced return

2018-12-05 Thread Simon Glass
On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt wrote: > > One of the hexdump tests in test/lib/hexdump.c returns right at the > start of the function without testing anything. > > Fix this by moving the 'return 0;' statement to the end of the function. > > Signed-off-by: Simon Goldschmidt > ---

[U-Boot] network not work with u-boot

2018-12-05 Thread 张国富
Hi all, Recently I came across a problem, and I tried many things but it still does not work. I have a board with a u-boot ready and the kernel image yet to upload. Unfortunately the board could not get the kernel image by ftp. The kernel image was built ready and the ftp server was

[U-Boot] [PATCH] pcm058: fix NAND flash not using badblock table

2018-12-05 Thread Harald Seiler
Without setting this flag, U-Boot will silently use a memory only badblock table. This is not only bad because it means badblock info is ignored, but also leads to other issues if a driver ontop then tries to read the badblock table as filesystem info (eg. UBI). Signed-off-by: Harald Seiler ---

Re: [U-Boot] [PATCH v3 0/8] Fix CVE-2018-18440 and CVE-2018-18439

2018-12-05 Thread Simon Goldschmidt
On Wed, Dec 5, 2018 at 2:13 PM Simon Glass wrote: > > Hi Simon, > > On Tue, 4 Dec 2018 at 04:54, Simon Goldschmidt > wrote: > > > > On Tue, Dec 4, 2018 at 12:45 AM Simon Glass wrote: > > > > > > Hi Simon, > > > > > > On Mon, 3 Dec 2018 at 12:05, Simon Goldschmidt > > > wrote: > > > > > > > > >

Re: [U-Boot] [PATCH 1/1] usb: musb-new: sunxi: Fix null pointer access

2018-12-05 Thread Marek Vasut
On 12/05/2018 02:06 PM, Stefan Mavrodiev wrote: > > On 12/5/18 2:57 PM, Marek Vasut wrote: >> On 12/05/2018 01:49 PM, Stefan Mavrodiev wrote: >>> When the device is in peripheral mode >> Can you have two devices, one in peripheral mode and one in host mode, >> on the same system ? > > Not 100%

Re: [U-Boot] [ANN] U-Boot v2019.01-rc1 released

2018-12-05 Thread Tom Rini
On Tue, Dec 04, 2018 at 04:06:49PM +0800, Kever Yang wrote: > Hi, > >     Any one get  any idea about below error? I'm using > evb-rk3229_defconfig and gcc-linaro-6.3.1-2017.05. > >   LD  u-boot > fs/built-in.o: In function `set_contents': > /home/kever/src/u-boot/fs/fat/fat_write.c:831:

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

2018-12-05 Thread Wolfgang Denk
Dear Miquel, In message <20181204235714.11805-14-miquel.ray...@bootlin.com> you wrote: > MTD support must be enabled when the environment is in NOR. Naked-by: Wolfgang Denk Environment in NOR must not, I repeat: must not ever depend on MTD! For more than 19 years we have been using

[U-Boot] [PATCH 1/1] arm: sunxi: Add NULL pointer check

2018-12-05 Thread Stefan Mavrodiev
Current driver doesn't check if the destination pointer is NULL. This cause the data from the FIFO to be stored inside the internal SDRAM ( address 0 ). The patch add simple check if the destination pointer is NULL. Signed-off-by: Stefan Mavrodiev --- drivers/spi/sun4i_spi.c | 3 ++- 1 file

Re: [U-Boot] [PATCH v3 2/7] dm: serial: Introduce ->getinfo() callback

2018-12-05 Thread Simon Glass
On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko wrote: > > New callback will give a necessary information to fill up ACPI SPCR table, > for example. Maybe used later for other purposes. > > Signed-off-by: Andy Shevchenko > --- > drivers/serial/sandbox.c | 21 ++ >

Re: [U-Boot] [PATCH v3 0/8] Fix CVE-2018-18440 and CVE-2018-18439

2018-12-05 Thread Simon Glass
Hi Simon, On Tue, 4 Dec 2018 at 04:54, Simon Goldschmidt wrote: > > On Tue, Dec 4, 2018 at 12:45 AM Simon Glass wrote: > > > > Hi Simon, > > > > On Mon, 3 Dec 2018 at 12:05, Simon Goldschmidt > > wrote: > > > > > > > > > > > > Am Mo., 3. Dez. 2018, 19:20 hat Simon Glass > > > geschrieben: >

Re: [U-Boot] [PATCH v3 21/28] mtd: nor: NOR flashes depend on MTD

2018-12-05 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 5 Dec 2018 11:31:44 +0100: > On Wed, 5 Dec 2018 00:57:07 +0100 > Miquel Raynal wrote: > > > A NOR flash needs the MTD core, ensure this dependency is met by > > adding a "depends on" in Kconfig. This is fine since defconfigs have > > been fixed. > > >

Re: [U-Boot] [PATCH v3 05/28] mtd: ensure MTD is compiled when there is a NOR flash

2018-12-05 Thread Wolfgang Denk
Dear Miquel Raynal, In message <20181204235714.11805-6-miquel.ray...@bootlin.com> you wrote: > CONFIG_MTD must be enabled when there is a NOR flash selected. This is a fundamental breakage. See previous messages. Naked-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software

[U-Boot] [PATCH 2/3] buildman: Add support for building with clang

2018-12-05 Thread Simon Glass
Add a -O option which allows building with clang. Signed-off-by: Simon Glass --- tools/buildman/README | 10 ++ tools/buildman/cmdline.py | 2 ++ tools/buildman/control.py | 2 +- tools/buildman/toolchain.py | 18 ++ 4 files changed, 27 insertions(+), 5

Re: [U-Boot] [PATCH 1/1] usb: musb-new: sunxi: Fix null pointer access

2018-12-05 Thread Maxime Ripard
On Wed, Dec 05, 2018 at 01:57:14PM +0100, Marek Vasut wrote: > On 12/05/2018 01:49 PM, Stefan Mavrodiev wrote: > > When the device is in peripheral mode > > Can you have two devices, one in peripheral mode and one in host mode, > on the same system ? No, or at least, on all of the SoCs that

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-12-05 Thread Simon Glass
Hi Simon, On Sun, 25 Nov 2018 at 23:05, Simon Goldschmidt wrote: > > [I've cut down the CC list a bit due to some gmail warnings] > On Mon, Nov 26, 2018 at 4:00 AM Simon Glass wrote: > > > > Hi Simon, > > > > On Sun, 25 Nov 2018 at 14:09, Simon Goldschmidt > > wrote: > > > > > > On Thu, Nov

Re: [U-Boot] [PATCH v3 13/28] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected

2018-12-05 Thread Miquel Raynal
Hi Wolfgang, Wolfgang Denk wrote on Wed, 05 Dec 2018 13:06:10 +0100: > Dear Miquel, > > In message <20181204235714.11805-14-miquel.ray...@bootlin.com> you wrote: > > MTD support must be enabled when the environment is in NOR. > > Naked-by: Wolfgang Denk > > Environment in NOR must not, I

[U-Boot] [PATCH] arm: dts: am33xx: Sync dts with Linux 4.20.0

2018-12-05 Thread Felix Brack
This patch synchronizes the am33xx SoC specific files with those from Linux 4.20.0. Hence all board maintainers of am33xx based boards are on the cc list. The main purpose of this patch is to prevent further diverging of the dts files from U-Boot and those from Linux. It aims to set the stage for

Re: [U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass

2018-12-05 Thread Marek Vasut
On 12/05/2018 09:05 AM, Michal Simek wrote: > Generic wrapper requires MISC uclass but dependency is not covered in > Kconfig. > > misc0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d > usb_dev_ge 0 [ + ] dwc3-generic-periphe | | `-- dwc3@fe20 > misc1 [ ]

Re: [U-Boot] [PATCH] blk: Rework guard around part_init call

2018-12-05 Thread Simon Glass
On Wed, 5 Dec 2018 at 06:23, Tom Rini wrote: > > The function part_init() will only be built when we have both > CONFIG_PARTITIONS and CONFIG_HAVE_BLOCK_DEVICE set. Protect the call to > this function with both of these tests now. > > Cc: Simon Glass > Cc: Philipp Tomsich > Cc: Michal Simek >

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-12-05 Thread Simon Goldschmidt
Am 05.12.2018 um 14:54 schrieb Simon Glass: Hi Simon, On Wed, 5 Dec 2018 at 06:38, Simon Goldschmidt wrote: On Wed, Dec 5, 2018 at 2:21 PM Simon Glass wrote: Hi Simon, On Sun, 25 Nov 2018 at 23:05, Simon Goldschmidt wrote: [I've cut down the CC list a bit due to some gmail warnings]

Re: [U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass

2018-12-05 Thread Marek Vasut
On 12/05/2018 03:17 PM, Michal Simek wrote: > On 05. 12. 18 14:26, Marek Vasut wrote: >> On 12/05/2018 09:05 AM, Michal Simek wrote: >>> Generic wrapper requires MISC uclass but dependency is not covered in >>> Kconfig. >>> >>> misc0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d

Re: [U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass

2018-12-05 Thread Michal Simek
On 05. 12. 18 15:24, Marek Vasut wrote: > On 12/05/2018 03:17 PM, Michal Simek wrote: >> On 05. 12. 18 14:26, Marek Vasut wrote: >>> On 12/05/2018 09:05 AM, Michal Simek wrote: Generic wrapper requires MISC uclass but dependency is not covered in Kconfig. misc0 [ + ]

[U-Boot] New item at list end for backwards compatibility

2018-12-05 Thread Marek Vasut
From: Robert Berger Signed-off-by: Robert Berger I received this off-list from Robert, it's a bugfix to mkimage, where the IH_TYPE_ enumeration changed recently and broke backward mkimage backward compatibility. Peng, can you respin the patch, test it and repost it ? Thanks --- diff --git

[U-Boot] [PATCH] fdt: Add warning about CONFIG_OF_EMBED

2018-12-05 Thread Simon Glass
This option has crept into use with some boards. Add a warning to try to prevent this. As an example: https://lists.denx.de/pipermail/u-boot/2017-September/304966.html Signed-off-by: Simon Glass --- Makefile | 8 1 file changed, 8 insertions(+) diff --git a/Makefile b/Makefile

Re: [U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass

2018-12-05 Thread Michal Simek
On 05. 12. 18 14:26, Marek Vasut wrote: > On 12/05/2018 09:05 AM, Michal Simek wrote: >> Generic wrapper requires MISC uclass but dependency is not covered in >> Kconfig. >> >> misc0 [ + ] dwc3-generic-wrapper | |-- usb0@ff9d >> usb_dev_ge 0 [ + ] dwc3-generic-periphe |

Re: [U-Boot] [PATCH] usb: dwc3: Add missing dependency on MISC uclass

2018-12-05 Thread Marek Vasut
On 12/05/2018 03:29 PM, Michal Simek wrote: > On 05. 12. 18 15:24, Marek Vasut wrote: >> On 12/05/2018 03:17 PM, Michal Simek wrote: >>> On 05. 12. 18 14:26, Marek Vasut wrote: On 12/05/2018 09:05 AM, Michal Simek wrote: > Generic wrapper requires MISC uclass but dependency is not covered

Re: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board

2018-12-05 Thread Simon Glass
Hi Simon, On Wed, 5 Dec 2018 at 06:38, Simon Goldschmidt wrote: > > On Wed, Dec 5, 2018 at 2:21 PM Simon Glass wrote: > > > > Hi Simon, > > > > On Sun, 25 Nov 2018 at 23:05, Simon Goldschmidt > > wrote: > > > > > > [I've cut down the CC list a bit due to some gmail warnings] > > > On Mon, Nov

Re: [U-Boot] [PATCH v2 1/2] x86: Wrap calls to 8259 with CONFIG_I8259_PIC

2018-12-05 Thread Simon Glass
On Thu, 29 Nov 2018 at 20:52, Bin Meng wrote: > > mask_irq(), unmask_irq() and specific_eoi() are provided by the > i8259 PIC driver and should be wrapped with CONFIG_I8259_PIC. > > Signed-off-by: Bin Meng > Tested-by: Hannes Schmelzer > > --- > > Changes in v2: > - use if() instead of #if > >

Re: [U-Boot] [PATCH v2 2/2] x86: kconfig: Allow board defconfig file to disable 8259 and APIC

2018-12-05 Thread Simon Glass
On Thu, 29 Nov 2018 at 20:52, Bin Meng wrote: > > At present the Kconfig options (CONFIG_I8259_PIC and CONFIG_APIC) > do not include a prompt message, which makes it impossible to > be disabled from a board defconfig file. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 05, 2018 at 05:55:37AM -0700, Simon Glass wrote: > On Tue, 27 Nov 2018 at 09:03, Andy Shevchenko > wrote: > > On Mon, Nov 26, 2018 at 06:02:28PM -0700, Simon Glass wrote: > > The rest of similar functions are operate on top of current console device > > and > > do not have such

Re: [U-Boot] [PATCH] fdt: Add warning about CONFIG_OF_EMBED

2018-12-05 Thread Simon Goldschmidt
Am 05.12.2018 um 14:57 schrieb Simon Glass: This option has crept into use with some boards. Add a warning to try to prevent this. As an example: https://lists.denx.de/pipermail/u-boot/2017-September/304966.html We have just discussed this in another thread. There seem to be ~109

Re: [U-Boot] [PATCH v3 0/8] Fix CVE-2018-18440 and CVE-2018-18439

2018-12-05 Thread Simon Glass
Hi Simon, On Wed, 5 Dec 2018 at 06:16, Simon Goldschmidt wrote: > > On Wed, Dec 5, 2018 at 2:13 PM Simon Glass wrote: > > > > Hi Simon, > > > > On Tue, 4 Dec 2018 at 04:54, Simon Goldschmidt > > wrote: > > > > > > On Tue, Dec 4, 2018 at 12:45 AM Simon Glass wrote: > > > > > > > > Hi Simon, >

  1   2   3   >