Re: [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"

2019-10-06 Thread Tom Rini
On Thu, Aug 22, 2019 at 04:47:39PM +0900, AKASHI Takahiro wrote: > With the patch below applied, host_block_dev structure was switched > to be placed in platdata rather than priv. The command "host info" > must be aligned with this change. Otherwise, we will see "Segmentation > Fault." > >

Re: [U-Boot] [PATCH] arm: socfpga: disable CONFIG_SPL_WDT for gen5 and a10

2019-10-06 Thread Tom Rini
On Sat, Oct 05, 2019 at 10:10:11PM +0200, Simon Goldschmidt wrote: > These boards don't have a watchdog enabled in SPL, so make sure > CONFIG_SPL_WDT is not enabled. > > Fixes: commit 6874cb72204f ("watchdog: Split WDT from SPL_WDT") > > Signed-off-by: Simon Goldschmidt Applied to

Re: [U-Boot] [PATCH] MAINTAINERS: Update my email address

2019-10-06 Thread Tom Rini
On Thu, Oct 03, 2019 at 06:32:11PM +0200, Maxime Ripard wrote: > I'm not at bootlin anymore, and my mail address doesn't work any longer. > > Signed-off-by: Maxime Ripard Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [U-Boot] [PATCH] gitlab-ci: fix typo 'plaforms'

2019-10-06 Thread Tom Rini
On Sun, Oct 06, 2019 at 12:26:16PM +0200, Heinrich Schuchardt wrote: > %s/plaforms/platforms/g > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Bin Meng Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___

Re: [U-Boot] [PATCH v3] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-10-06 Thread AKASHI Takahiro
On Sun, Oct 06, 2019 at 09:42:30PM -0400, Tom Rini wrote: > On Mon, Oct 07, 2019 at 09:47:46AM +0900, AKASHI Takahiro wrote: > > On Sat, Oct 05, 2019 at 08:53:39AM +0200, Heinrich Schuchardt wrote: > > > On 10/4/19 3:20 AM, AKASHI Takahiro wrote: > > > >With this patch, when setting UEFI variable

[U-Boot] [PATCH v4 2/5] fs: clean up around fs_type

2019-10-06 Thread AKASHI Takahiro
fs_ls(), fs_mkdir() and fs_unlink() sets fs_type to FS_TYPE_ANY explicitly, but it is redundant as they call fs_close(). So just remove those lines. Signed-off-by: AKASHI Takahiro --- fs/fs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/fs.c b/fs/fs.c index

[U-Boot] [PATCH v4 3/5] fs: add fs_get_type() for current filesystem type

2019-10-06 Thread AKASHI Takahiro
This function is a variant of fs_get_type_name() and returns a filesystem type with which the current device is associated. We don't want to export fs_type variable directly because we have to take care of it consistently within fs.c. Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich

Re: [U-Boot] [PATCH 048/126] x86: Move acpi_s3.h to a common location

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:33 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present this hedaer is only available on x86. To allow sandbox to use > > it for testing, move it to a common location. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [U-Boot] [PATCH v3] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-10-06 Thread AKASHI Takahiro
On Sat, Oct 05, 2019 at 08:53:39AM +0200, Heinrich Schuchardt wrote: > On 10/4/19 3:20 AM, AKASHI Takahiro wrote: > >With this patch, when setting UEFI variable with "env set -e" command, > >we will be able to > >- specify vendor guid with "-guid guid", > >- specify variable attributes,

Re: [U-Boot] [PATCH 005/126] dm: core: Don't include ofnode functions with of-platdata

2019-10-06 Thread Bin Meng
Hi Simon, On Sun, Oct 6, 2019 at 5:15 PM Bin Meng wrote: > > On Thu, Oct 3, 2019 at 8:48 PM Bin Meng wrote: > > > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > > > These functions cannot work with of-platdata since libfdt is not > > > available. At present when dev_read_...()

Re: [U-Boot] [PATCH 057/126] dm: core: Drop fdtdec_get_pci_addr()

2019-10-06 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > This function ise effectively replaced by ofnode_read_pci_addr() which > works with flat tree. Delete it to avoid code duplication. > > Signed-off-by: Simon Glass > --- > > drivers/core/fdtaddr.c | 13 -- > include/fdtdec.h |

Re: [U-Boot] [PATCH 060/126] x86: timer: Set up the timer in timer_early_get_count()

2019-10-06 Thread Bin Meng
Hi Simon, On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > This function can be called before the timer is set up. Make sure that the > init function is called so that it works correctly. > > Signed-off-by: Simon Glass > --- > > drivers/timer/tsc_timer.c | 2 ++ > 1 file changed, 2

Re: [U-Boot] [PATCH 056/126] x86: Add new common CPU functions for turbo/burst mode

2019-10-06 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > Add a few more CPU functions that are common on Intel CPUs. Also add > attribution for the code source. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/intel_common/cpu.c | 60 +++ >

Re: [U-Boot] [PATCH 059/126] x86: Allow the PCH and LPC uclasses to work with of-platdata

2019-10-06 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > At present these uclasses assumes that they are used with a device tree. > Update them to support of-platdata as well. > > Signed-off-by: Simon Glass > --- > > arch/x86/lib/lpc-uclass.c | 2 ++ > drivers/pch/pch-uclass.c | 2 ++ > 2 files

Re: [U-Boot] [PATCH 058/126] sandbox: pci: Create a new sandbox_pci_read_bar() function

2019-10-06 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > The code in swapcase can be used by other sandbox drivers. Move it into a > common place to allow this. > > Signed-off-by: Simon Glass > --- > > arch/sandbox/include/asm/test.h | 15 +++ > drivers/misc/Makefile | 2

Re: [U-Boot] [PATCH 041/126] iod: Enhance to support display of multiple values

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:18 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present the 'iod' command differs from 'md' in that it only shows a > > single value. It is useful to see a dump of multiple values, particularly > > when x86 peripherals contain

Re: [U-Boot] [PATCH 031/126] pci: Add more debug detail when resources are exhausted

2019-10-06 Thread Bin Meng
On Sun, Oct 6, 2019 at 7:19 PM Bin Meng wrote: > > On Sat, Oct 5, 2019 at 9:12 PM Bin Meng wrote: > > > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > > > If PCI auto-config runs out of memory, show a few more details to help > > > diagnose the problem. > > > > > > Signed-off-by:

Re: [U-Boot] [PATCH 025/126] sandbox: Allow use of real I/O with readl(), etc.

2019-10-06 Thread Bin Meng
On Sun, Oct 6, 2019 at 6:04 PM Bin Meng wrote: > > On Sat, Oct 5, 2019 at 11:30 AM Bin Meng wrote: > > > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > > > At present these functions are stubbed out. For more comprehensive testing > > > with PCI devices it is useful to be able to

Re: [U-Boot] [PATCH v3] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-10-06 Thread Tom Rini
On Mon, Oct 07, 2019 at 09:47:46AM +0900, AKASHI Takahiro wrote: > On Sat, Oct 05, 2019 at 08:53:39AM +0200, Heinrich Schuchardt wrote: > > On 10/4/19 3:20 AM, AKASHI Takahiro wrote: > > >With this patch, when setting UEFI variable with "env set -e" command, > > >we will be able to > > >- specify

Re: [U-Boot] [PATCH 0/2] Fix memory instability on ROCK64

2019-10-06 Thread Kurt Miller
On Sun, 2019-10-06 at 12:28 -0400, Simon South wrote: > These two patches fix small issues with the Rockchip RK3328 SDRAM > driver that prevented my PINE64 ROCK64 from booting and running > normally using U-Boot's TPL [1]. > > The first patch updates the phy_dll_bypass_set() function to use the >

Re: [U-Boot] [PATCH 043/126] spl: Allow tiny printf() to be controlled in SPL and TPL

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:18 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present there is only one control for this and it is used for both SPL > > and TPL. But SPL might have a lot more space than TPL so the extra cost of > > a full printf() might be

Re: [U-Boot] [PATCH 042/126] arm: mxs: Correct CONFIG_SPL_NO_CPU_SUPPORT option

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:18 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present this is defined in Kconfig but there is a separate one in the > > CONFIG whitelist. It looks like these are duplicates. > > > > Rename the non-Kconfig one and remove it from

Re: [U-Boot] [PATCH 044/126] spl: Convert CONFIG_SPL_LIMIT to hex

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:18 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This is currently a decimal value which is not as convenient or > > meaningful. Also U-Boot tends to use hex everywhere. > > > > Convert this option to hex and add a comment for the

Re: [U-Boot] [PATCH 046/126] spl: Allow distinguishing between two phases in U-Boot

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:30 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > U-Boot has two distinct phases: before and after relocation. These are > > commonly referred to as F (running from Flash) and R (Relocated and > > running from RAM). Some drivers want

Re: [U-Boot] [PATCH] efi_loader: device_path: allow for arbitrary length of file path

2019-10-06 Thread AKASHI Takahiro
On Fri, Oct 04, 2019 at 08:09:57AM +0200, Heinrich Schuchardt wrote: > On 10/4/19 6:45 AM, AKASHI Takahiro wrote: > >This patch will lift the upper limit of maximum path length. > > > >Signed-off-by: AKASHI Takahiro > > Thanks for addressing this issue. > > Please, have a look at the side

Re: [U-Boot] [PATCH 047/126] spl: Allow SPL/TPL to use of-platdata without libfdt

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:30 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present libfdt is included in SPL/TPL if SPL/TPL_OF_CONTROL is enabled. > > But if of-platdata is in use this is not required. Update the condition to > > avoid building this extra

[U-Boot] [PATCH 1/1] cbfs: do not pack struct cbfs_cachenode

2019-10-06 Thread Heinrich Schuchardt
With the __packed attribute sandbox_defconfig cannot be compiled with GCC 9.2.1: fs/cbfs/cbfs.c: In function ‘file_cbfs_fill_cache’: fs/cbfs/cbfs.c:164:16: error: taking address of packed member of ‘struct cbfs_cachenode’ may result in an unaligned pointer value [-Werror=address-of-packed-member]

Re: [U-Boot] [PATCH 4/8] ARM: socfpga: arria10: Add generic handoff devicetree include

2019-10-06 Thread Dalon L Westergreen
On Sun, 2019-10-06 at 15:44 +0200, Marek Vasut wrote: > On 10/6/19 1:19 AM, Dalon L Westergreen wrote: > > On Sat, 2019-10-05 at 01:51 +0200, Marek Vasut wrote: > > > On 10/5/19 12:30 AM, Dalon Westergreen wrote: > > > > From: Dalon Westergreen Generic handoff > > > > devicetree include uses a

Re: [U-Boot] [PATCH 1/1] cbfs: do not pack struct cbfs_cachenode

2019-10-06 Thread Bin Meng
On Mon, Oct 7, 2019 at 6:37 AM Heinrich Schuchardt wrote: > > With the __packed attribute sandbox_defconfig cannot be compiled with GCC > 9.2.1: > > fs/cbfs/cbfs.c: In function ‘file_cbfs_fill_cache’: > fs/cbfs/cbfs.c:164:16: error: taking address of packed member of > ‘struct cbfs_cachenode’ may

Re: [U-Boot] [PATCH v3 2/4] fs: add fs_get_type() for current filesystem type

2019-10-06 Thread AKASHI Takahiro
On Fri, Oct 04, 2019 at 09:04:59PM +0200, Heinrich Schuchardt wrote: > On 10/4/19 5:05 AM, AKASHI Takahiro wrote: > > This function is a variant of fs_get_type_name() and returns a filesystem > > type with which the current device is associated. > > We don't want to export fs_type variable

Re: [U-Boot] [PATCH v3 3/4] efi_loader: disk: install FILE_SYSTEM_PROTOCOL only if available

2019-10-06 Thread AKASHI Takahiro
On Fri, Oct 04, 2019 at 09:13:08PM +0200, Heinrich Schuchardt wrote: > On 10/4/19 5:05 AM, AKASHI Takahiro wrote: > > In the current implementation, EFI_SIMPLEFILE_SYSTEM_PROTOCOL is always > > installed to all the partitions even if some of them may house no file > > system. > > > > With this

[U-Boot] [PATCH v4] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-10-06 Thread AKASHI Takahiro
With this patch, when setting UEFI variable with "env set -e" command, we will be able to - specify vendor guid with "-guid guid", - specify variable attributes, BOOTSERVICE_ACCESS, RUNTIME_ACCESS, respectively with "-bs" and "-rt", - append a value instead of overwriting with "-a", - use

[U-Boot] [PATCH v4 0/5] efi_loader: disk: install FILE_SYSTEM_PROTOCOL to whole disk

2019-10-06 Thread AKASHI Takahiro
Changes in v4 (Oct 7, 2019) * modify commit message of patch#1 after Heinrich's suggestion * add patch#2 after Heinrich's suggestion * add a function description to efi_fs_exists() after Heinrich's suggestion (patch#4) Changes in v3 (Oct 4, 2019) * add patch#1 * use newly-added fs_get_type()

Re: [U-Boot] [PATCH 4/8] ARM: socfpga: arria10: Add generic handoff devicetree include

2019-10-06 Thread Dalon L Westergreen
On Sun, 2019-10-06 at 20:05 +0200, Simon Goldschmidt wrote: > Am 06.10.2019 um 19:44 schrieb Dalon L Westergreen: > > On Sun, 2019-10-06 at 15:44 +0200, Marek Vasut wrote: > > > On 10/6/19 1:19 AM, Dalon L Westergreen wrote: > > > > On Sat, 2019-10-05 at 01:51 +0200, Marek Vasut wrote: > > > > >

Re: [U-Boot] [PATCH v3 1/4] fs: export fs_close()

2019-10-06 Thread AKASHI Takahiro
On Fri, Oct 04, 2019 at 08:53:00PM +0200, Heinrich Schuchardt wrote: > On 10/4/19 5:05 AM, AKASHI Takahiro wrote: > > This function is always paired with either fs_set_blk_desc() or > > fs_set_blk_desc_with_part(). So just export it. > > > > Signed-off-by: AKASHI Takahiro > > --- > > fs/fs.c

Re: [U-Boot] [PATCH v3 4/4] efi_loader: disk: install file system protocol to a whole disk

2019-10-06 Thread AKASHI Takahiro
On Fri, Oct 04, 2019 at 09:15:19PM +0200, Heinrich Schuchardt wrote: > On 10/4/19 5:05 AM, AKASHI Takahiro wrote: > > Currently, a whole disk without any partitions is not associated > > with EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. So even if it houses some > > file system, there is a chance that we may

[U-Boot] Pull request for UEFI sub-system for efi-2020-01-rc1

2019-10-06 Thread Heinrich Schuchardt
The following changes since commit dac51e9aaf6fd38298007b266feb6a80e9ec91ee: Merge branch 'master' of git://git.denx.de/u-boot-sh (2019-10-05 20:06:58 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2020-01-rc1 for you to

Re: [U-Boot] [PATCH 1/1] tools: provide cbfstool

2019-10-06 Thread Tom Rini
On Sun, Oct 06, 2019 at 10:50:45PM +0200, Heinrich Schuchardt wrote: > 'make tests' requires cbfstool. But this file is not built by U-Boot. > > cbfstool can be built from https://github.com/coreboot/coreboot.git > after copying some include files from > https://github.com/coreboot/vboot.git but

Re: [U-Boot] [PATCH 003/126] dm: core: Drop a few early returns

2019-10-06 Thread Bin Meng
On Thu, Oct 3, 2019 at 8:47 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Two functions in this file return early for no good reason. Adjust the > > code to match the standard DM style of returning 0 at the end of the > > function on success. > > > > Oddly

Re: [U-Boot] [PATCH 001/126] dm: core: Use U-Boot logging instead of pr_debug()

2019-10-06 Thread Bin Meng
On Thu, Oct 3, 2019 at 8:47 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > The pr_debug() functions do not response to setting the log level and in > > fact have their own separate log level. Use U-Boot logging instead. > > > > Perhaps we should make these

Re: [U-Boot] [PATCH 009/126] dm: core: Call ofdata_to_platdata() with of-platdata

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present this function is never called when of-platdata is enabled since > > we never have a device tree. However, this function is responsible for > > copying over the of-platdata,

Re: [U-Boot] [PATCH 007/126] dm: test: Fix running of multiple test from command line

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present when multiple 'ut dm' commands are executed, all but the first > > is run with a flat tree, even if live tree is enabled. This is because the > > live tree node pointer is

Re: [U-Boot] [PATCH 004/126] dm: core: Add documentation on how to debug driver model

2019-10-06 Thread Bin Meng
On Thu, Oct 3, 2019 at 8:47 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Sometimes devices don't appear and it can be confusing. Add a few notes to > > help with this situation. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [U-Boot] [PATCH 005/126] dm: core: Don't include ofnode functions with of-platdata

2019-10-06 Thread Bin Meng
On Thu, Oct 3, 2019 at 8:48 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > These functions cannot work with of-platdata since libfdt is not > > available. At present when dev_read_...() functions are used it produces > > error messages about ofnode which is

Re: [U-Boot] [PATCH 008/126] dm: test: Don't fail when tests are skipped due to build

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present tests that are marked as only for livetree fail when executed > > on sandbox_flattree. They cannot actually be executed, but we should not > > resport them as 'not found',

Re: [U-Boot] [PATCH 012/126] dm: core: Add device_foreach_child()

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > We have a 'safe' version of this function but sometimes it is not needed. > > Add a normal version too and update a few places that can use it. > > > > Signed-off-by: Simon Glass > >

Re: [U-Boot] [PATCH 013/126] dm: test: Correct a stray backslash in dm_test_destroy()

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This should perhaps be a period but it is not necessary. Remove it. > > > > Signed-off-by: Simon Glass > > --- > > > > test/dm/test-main.c | 2 +- > > 1 file changed, 1 insertion(+),

Re: [U-Boot] [PATCH 011/126] dm: core: Correct the return value for uclass_find_first_device()

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This function returns -ENODEV when there is no device. This is > > inconsistent with other functions, such as uclass_find_next_device(), > > which returns 0. > > > > Update it and tidy

Re: [U-Boot] [PATCH 015/126] sandbox: spmi: Add ranges property for address translation

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:58 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present address translation does not work since there is no ranges > > property in the spmi nodes. Add empty ranges properties and a little more > > logging so that this shows the

Re: [U-Boot] [PATCH 016/126] sandbox: mmc: Fix up MMC emulator for valgrind

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:58 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present running sandbox with valgrind produces some warnings due to the > > MMC emulator not filling in all the expected fields. Fix it. > > > > Signed-off-by: Simon Glass > > --- >

Re: [U-Boot] [PATCH 019/126] sandbox: swap_case: Use statics where possible

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:01 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Some functions and a struct should be marked static since they are not > > used outside this file. Update them. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [U-Boot] [PATCH 017/126] sandbox: Rename PCI ID for swap_case to be more specific

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:58 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Rename this ID to SANDBOX_PCI_SWAP_CASE_EMUL_ID since it is more > > descriptive and allows us to add new PCI emulators without any conflict or > > confusion. > > > > Signed-off-by:

Re: [U-Boot] [PATCH 018/126] sandbox: Add support for clrsetio_32() and friends

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:01 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > These functions are available on x86 but not sandbox. They are useful > > shortcuts and clarify the code, so add them to sandbox. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [U-Boot] [PATCH 020/126] sandbox: pci: Drop the get_devfn() method

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:01 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This method is not used anymore since the bus/device/function of PCI > > devices can be obtained from their (parent's per-child) platform data. > > Drop it. > > > > Signed-off-by:

Re: [U-Boot] [PATCH 024/126] sandbox: pci: Increase the memory space

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:14 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Increase the memory space so we can support the p2sb bus which needs > > multiples of 1MB. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/sandbox/dts/test.dts | 2 +- > > 1

Re: [U-Boot] [PATCH 025/126] sandbox: Allow use of real I/O with readl(), etc.

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:30 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present these functions are stubbed out. For more comprehensive testing > > with PCI devices it is useful to be able to fully emulate I/O access. Add > > simple implementations for

Re: [U-Boot] [PATCH 022/126] sandbox: pci: Move pci_offset_to_barnum() to pci.h

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:17 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > This function is useful in PCI emulators. More it into the header file to > > avoid duplicating it in other drivers. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [U-Boot] [PATCH 023/126] sandbox: Add a -T flag to use the test device tree

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 11:13 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > U-Boot already supports using -D to indicate that it should use the normal > > device tree. It is sometimes useful to run with the test device tree, e.g. > > when running a test. Add a

Re: [U-Boot] [PATCH 026/126] pci: sandbox: Move the emulators into their own node

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 1:03 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Sandbox i2c works using emulation drivers which are currently children of > > pci > > > the i2c device: > > pci Fixed these, and > > > > > pci-controller { > >

Re: [U-Boot] [PATCH 028/126] pci: Show the result of binding a device

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 1:03 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Update the debugging info a little to show the result of trying to bind > > a PCI device. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/pci/pci-uclass.c | 3 ++- > > 1

Re: [U-Boot] [PATCH 030/126] pci: Correct 'specifified' and 'Plese' typos

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 1:03 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Fix these spelling errors the header file and documentation. > > in the header > > > > > Fix a small typo in the PCI documentation. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [U-Boot] [PATCH 029/126] pci: Disable autoconfig in SPL

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 1:03 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present U-Boot runs autoconfig in SPL but this is best left to U-Boot > > proper. For TPL and SPL we can normally used fixed BARs and save code size > > and time. > > > >

Re: [U-Boot] [PATCH 027/126] pci: sandbox: Probe PCI emulation devices when used

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 1:03 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present PCI emulation devices are not probed before use, since they > > used to be children of the device that used them, and children cannot be > > probed before their parents. > >

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Baruch Siach
Hi Adam, (Adding MMC and i.MX maintainers to Cc) On Fri, Sep 27 2019, Adam Ford wrote: > On Fri, Sep 27, 2019 at 4:38 AM Jonathan Gray wrote: >> >> On Thu, Sep 26, 2019 at 05:07:21PM -0300, Fabio Estevam wrote: >> > Hi Vagrant, >> > >> > On Thu, Sep 26, 2019 at 4:16 PM Vagrant Cascadian >> >

Re: [U-Boot] [PATCH] gitlab-ci: fix typo 'plaforms'

2019-10-06 Thread Bin Meng
On Sun, Oct 6, 2019 at 6:26 PM Heinrich Schuchardt wrote: > > %s/plaforms/platforms/g > > Signed-off-by: Heinrich Schuchardt > --- > > .gitlab-ci.yml | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng ___ U-Boot

Re: [U-Boot] [PATCH 031/126] pci: Add more debug detail when resources are exhausted

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:12 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > If PCI auto-config runs out of memory, show a few more details to help > > diagnose the problem. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/pci/pci_auto_common.c | 3

Re: [U-Boot] [PATCH 034/126] serial: ns16550: Add a PCI device/function field

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:12 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > When this UART is used early in boot (before PCI is set up) it is > > convenient to store the PCI BDF of the UART so that it can be manually > > configured. This is useful when it is

[U-Boot] [PATCH 1/1] lib: errno: sync error codes

2019-10-06 Thread Heinrich Schuchardt
Macro ERRNO_MSG() ignores the error number but we should still use the same constants as in include/linux/errno.h. Signed-off-by: Heinrich Schuchardt --- lib/errno_str.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/errno_str.c b/lib/errno_str.c index

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Peter Robinson
> > I just tested mx6cuboxi with 2019.10-rc4, and it fails to load > > u-boot.img from MMC: > > > > 1 2019-09-26_17:31:27.63089 U-Boot SPL 2019.10-rc4+dfsg-1 (Sep 24 2019 - > > 08:03:23 +) > > 2 2019-09-26_17:31:27.63092 Trying to boot from MMC2 > > 3 2019-09-26_17:31:27.63095 MMC Device 1 not

Re: [U-Boot] [PATCH 038/126] binman: Take account of skip-at-start with image-header

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:42 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > The image-header currently sets it offset assuming that skip-at-start is > > zero. This does not work on x86 where offsets end at 4GB. Add in this > > value so that the offset is

Re: [U-Boot] [PATCH 035/126] binman: Allow verbose output with all commands

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:12 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present the verbose flag only works for the 'build' command. This is > > not intended, nor is it useful. Update the code to support the verbose > > flag and make use of a command

[U-Boot] [PATCH 1/1] lib: errno: avoid error format-overflow

2019-10-06 Thread Heinrich Schuchardt
In cmd/regulator.c an error occurs with GCC 9.2.1 if CONFIG_ERRNO_STR is not defined: cmd/regulator.c: In function ‘failure’: cmd/regulator.c:20:2: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 20 | printf("Error: %d (%s)\n", ret, errno_str(ret)); |

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Adam Ford
On Sun, Oct 6, 2019 at 6:30 AM Adam Ford wrote: > > On Sun, Oct 6, 2019 at 5:23 AM Baruch Siach wrote: > > > > Hi Adam, > > > > (Adding MMC and i.MX maintainers to Cc) > > > > On Fri, Sep 27 2019, Adam Ford wrote: > > > On Fri, Sep 27, 2019 at 4:38 AM Jonathan Gray wrote: > > >> > > >> On Thu,

[U-Boot] [PATCH 0/2] lib: errno: check for unsupported error number

2019-10-06 Thread Heinrich Schuchardt
errno_str() should not return a random pointer for unknown error codes. Provide a unit test for errno_str(). Heinrich Schuchardt (2): lib: errno: check for unsupported error number test: provide test for errno_str() lib/errno_str.c | 8 ++- test/lib/Makefile | 1 +

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Adam Ford
On Sun, Oct 6, 2019 at 7:30 AM Adam Ford wrote: > > On Sun, Oct 6, 2019 at 7:22 AM Baruch Siach wrote: > > > > Hi Adam, > > > > On Sun, Oct 06 2019, Adam Ford wrote: > > > On Sun, Oct 6, 2019 at 5:23 AM Baruch Siach wrote: > > >> (Adding MMC and i.MX maintainers to Cc) > > >> > > >> On Fri, Sep

Re: [U-Boot] [PATCH 3/8] ARM: socfpga: arria10: Add common u-boot devicetree include

2019-10-06 Thread Marek Vasut
On 10/6/19 1:25 AM, Dalon L Westergreen wrote: > On Sat, 2019-10-05 at 01:49 +0200, Marek Vasut wrote: >> On 10/5/19 12:30 AM, Dalon Westergreen wrote: >>> From: Dalon Westergreen >>> Add a common u-boot devicetree include file for the SocFPGAArria10 device. >> >> Isn't

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Adam Ford
On Sun, Oct 6, 2019 at 7:48 AM Baruch Siach wrote: > > Hi Adam, > > On Sun, Oct 06 2019, Adam Ford wrote: > > On Sun, Oct 6, 2019 at 7:30 AM Adam Ford wrote: > >> > >> On Sun, Oct 6, 2019 at 7:22 AM Baruch Siach wrote: > >> > > >> > Hi Adam, > >> > > >> > On Sun, Oct 06 2019, Adam Ford wrote: >

Re: [U-Boot] [PATCH 033/126] dm: pci: Add a function to read a PCI BAR

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:12 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present PCI address transaction is not supported so drivers must > > manually read the correct BAR after reading the device tree info. The > > ns16550 has a suitable implementation,

Re: [U-Boot] [PATCH 036/126] binman: Add a base implementation of Entry.ReadChildData()

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:41 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present this function is not present in the Entry base class so it is > > hard to find the documentation for it. Move the docs from the section > > class and expand it a little. > >

Re: [U-Boot] [PATCH 039/126] log: Add log_nop() to avoid unused-variable warnings

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:42 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > If a log statement includes a variable and logging is disabled, this can > > generate warnings about unused variables. Add a bit more complexity to the > > macros to avoid this for the

Re: [U-Boot] [PATCH 037/126] binman: Handle reading data for end-at-4gb sections

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:42 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Some x86 sections have special offsets which currently result in empty > > data being returned from the 'extract' command. Fix this by taking account > > of the skip-at-start property.

Re: [U-Boot] [PATCH 040/126] cros_ec: Add MEC_EMI_BASE and size to the header file

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 10:42 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > Provide these values which are part of the EC interface now. > > > > Signed-off-by: Simon Glass > > --- > > > > include/ec_commands.h | 4 > > 1 file changed, 4 insertions(+) >

Re: [U-Boot] [PATCH 032/126] pci: Show a message if PCI autoconfig fails

2019-10-06 Thread Bin Meng
On Sat, Oct 5, 2019 at 9:12 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > At present this fails silently which can be confusing since some devices > > on the PCI bus may not work correctly. Show a message in this case > > nits: missing . after case Fixed,

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Adam Ford
On Sun, Oct 6, 2019 at 5:23 AM Baruch Siach wrote: > > Hi Adam, > > (Adding MMC and i.MX maintainers to Cc) > > On Fri, Sep 27 2019, Adam Ford wrote: > > On Fri, Sep 27, 2019 at 4:38 AM Jonathan Gray wrote: > >> > >> On Thu, Sep 26, 2019 at 05:07:21PM -0300, Fabio Estevam wrote: > >> > Hi

[U-Boot] [PATCH 1/2] lib: errno: check for unsupported error number

2019-10-06 Thread Heinrich Schuchardt
If errno_str() is called with an unsupported error number, do not return a random pointer but a reasonable text. Signed-off-by: Heinrich Schuchardt --- lib/errno_str.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/errno_str.c b/lib/errno_str.c index

[U-Boot] [PATCH 1/2] lib: errno: check for unsupported errors

2019-10-06 Thread Heinrich Schuchardt
If errno_str() is called with an unsupported error number, do not return a random pointer but a reasonable text. Signed-off-by: Heinrich Schuchardt --- lib/errno_str.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/errno_str.c b/lib/errno_str.c index

[U-Boot] [PATCH 2/2] test: provide test for errno_str()

2019-10-06 Thread Heinrich Schuchardt
Provide a unit test for errno_str(). Test that known and unknown error numbers are handled correctly. Signed-off-by: Heinrich Schuchardt --- test/lib/Makefile | 1 + test/lib/test_errno_str.c | 50 +++ 2 files changed, 51 insertions(+) create mode

[U-Boot] [PATCH 1/1] configs: sheevaplug disable EFI_UNICODE_CAPITALIZATION

2019-10-06 Thread Heinrich Schuchardt
With upcoming patches u-boot.kwb gets too large. Save 3740 bytes in u-boot.kwb by disabling Unicode support in the UEFI sub-system. Signed-off-by: Heinrich Schuchardt --- configs/sheevaplug_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sheevaplug_defconfig

[U-Boot] [PATCH] gitlab-ci: fix typo 'plaforms'

2019-10-06 Thread Heinrich Schuchardt
%s/plaforms/platforms/g Signed-off-by: Heinrich Schuchardt --- .gitlab-ci.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a1c5b4fc76..0c4343468d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -59,7 +59,7 @@ stages:

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Baruch Siach
Hi Adam, On Sun, Oct 06 2019, Adam Ford wrote: > On Sun, Oct 6, 2019 at 5:23 AM Baruch Siach wrote: >> (Adding MMC and i.MX maintainers to Cc) >> >> On Fri, Sep 27 2019, Adam Ford wrote: >> > On Fri, Sep 27, 2019 at 4:38 AM Jonathan Gray wrote: >> >> >> >> On Thu, Sep 26, 2019 at 05:07:21PM

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Adam Ford
On Sun, Oct 6, 2019 at 7:22 AM Baruch Siach wrote: > > Hi Adam, > > On Sun, Oct 06 2019, Adam Ford wrote: > > On Sun, Oct 6, 2019 at 5:23 AM Baruch Siach wrote: > >> (Adding MMC and i.MX maintainers to Cc) > >> > >> On Fri, Sep 27 2019, Adam Ford wrote: > >> > On Fri, Sep 27, 2019 at 4:38 AM

Re: [U-Boot] [PATCH 1/2] lib: errno: check for unsupported errors

2019-10-06 Thread Heinrich Schuchardt
On 10/6/19 2:33 PM, Heinrich Schuchardt wrote: If errno_str() is called with an unsupported error number, do not return a random pointer but a reasonable text. Signed-off-by: Heinrich Schuchardt This mail was sent by mistake. The correct patch is [PATCH 1/2] lib: errno: check for unsupported

Re: [U-Boot] mx6cuboxi fails to load u-boot.img

2019-10-06 Thread Baruch Siach
Hi Adam, On Sun, Oct 06 2019, Adam Ford wrote: > On Sun, Oct 6, 2019 at 7:30 AM Adam Ford wrote: >> >> On Sun, Oct 6, 2019 at 7:22 AM Baruch Siach wrote: >> > >> > Hi Adam, >> > >> > On Sun, Oct 06 2019, Adam Ford wrote: >> > > On Sun, Oct 6, 2019 at 5:23 AM Baruch Siach wrote: >> > >> (Adding

Re: [U-Boot] [PATCH 4/8] ARM: socfpga: arria10: Add generic handoff devicetree include

2019-10-06 Thread Marek Vasut
On 10/6/19 1:19 AM, Dalon L Westergreen wrote: > On Sat, 2019-10-05 at 01:51 +0200, Marek Vasut wrote: >> On 10/5/19 12:30 AM, Dalon Westergreen wrote: >>> From: Dalon Westergreen >>> Generic handoff devicetree include uses a header generated bythe qts-filter- >>> a10.sh script in mach-socfpga.

[U-Boot] [PATCH 1/1] cmd: disable CMD_NVEDIT_EFI by default

2019-10-06 Thread Heinrich Schuchardt
The growth of the UEFI sub-system leads to build failures for systems with strict limits on the U-Boot image size. CMD_NVEDIT_EFI supports displaying and editing of UEFI variables. The setting is not needed for booting. Disabling it by default reduces the size of the U-Boot image by 2 KiB.

Re: [U-Boot] [PATCH 054/126] x86: Add common functions for TDP and perf control

2019-10-06 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > These functions are the same on modern Intel CPUs, so use common code to > set them. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/broadwell/cpu.c | 7 ++ > arch/x86/cpu/broadwell/cpu_full.c | 9

Re: [U-Boot] [PATCH 055/126] x86: Tidy up some duplicate MSR defines

2019-10-06 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > Some MSR registers are defined twice in different parts of the file. Move > them together and remove the duplicates. Also drop some thermal defines > which are not used. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/baytrail/cpu.c

Re: [U-Boot] [PATCH 054/126] x86: Add common functions for TDP and perf control

2019-10-06 Thread Bin Meng
On Mon, Oct 7, 2019 at 12:09 AM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass wrote: > > > > These functions are the same on modern Intel CPUs, so use common code to > > set them. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/x86/cpu/broadwell/cpu.c

[U-Boot] [PATCH 1/2] ram: rk3328: Use correct frequency units in function

2019-10-06 Thread Simon South
Fix a pair of tests in phy_dll_bypass_set() that used incorrect units for the DDR frequency, causing the DRAM controller to be misconfigured in most cases. Signed-off-by: Simon South --- drivers/ram/rockchip/sdram_rk3328.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[U-Boot] [PATCH 2/2] ram: rk3328: Fix loading of skew values

2019-10-06 Thread Simon South
Fix a typo that caused incorrect values to be loaded into the DRAM controller's deskew registers. Signed-off-by: Simon South --- drivers/ram/rockchip/sdram_rk3328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ram/rockchip/sdram_rk3328.c

  1   2   >