Re: [U-Boot] Pull request: u-boot-spi/master

2019-10-27 Thread Jagan Teki
Hi Tom, On Fri, Oct 25, 2019 at 11:19 PM Tom Rini wrote: > > On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote: > > > Hi Tom, > > > > Please pull this PR. > > > > Summary: > > - SPL_SPI_FLASH_MTD (Frieder) > > - SPI NOR IDs' fixes, additions (Vignesh) > > - cs_info change (Bin) > > -

[U-Boot] [PATCH 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py

2019-10-27 Thread Bin Meng
In the 'Make' function, the codes tries to create a directory if current stage is 'build'. But the directory isn't used at all anywhere. Signed-off-by: Bin Meng --- tools/buildman/test.py | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tools/buildman/test.py

[U-Boot] [PATCH 5/5] Bring all testings in gitlab and travis CI to Azure Pipelines

2019-10-27 Thread Bin Meng
This expands current Azure Pipelines Windows host tools build testing to cover all the CI testing in gitlab and travis CI. Note for some unknown reason, the 'container' cannot be used for any jobs that have buildman, for buildman does not exit properly and hangs the job forever. As a workaround,

[U-Boot] [PATCH 4/5] .travis.yml: Remove the unneeded '&' for ls20xx buildman

2019-10-27 Thread Bin Meng
Signed-off-by: Bin Meng --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index a3e7451..3aaed93 100644 --- a/.travis.yml +++ b/.travis.yml @@ -200,7 +200,7 @@ matrix: - BUILDMAN="freescale" - name: "buildman NXP AArch64

[U-Boot] [PATCH 0/5] Bring all testings in gitlab and travis CI to Azure Pipelines

2019-10-27 Thread Bin Meng
At present we have set up a Microsoft Azure Pipelines to build U-Boot host tools for Windows. We can expand it to cover all the CI testing in gitlab and travis CI. There are issues if we use the 'container' keyword in the pipeline, that buildman seems to not able to exit correctly and hangs

[U-Boot] [PATCH 3/5] arm: mvebu: Avoid generating kwbimage.cfg in the source tree

2019-10-27 Thread Bin Meng
At present some boards generate kwbimage.cfg in the source tree during the build. This breaks buildman testing on some systems where the source tree is read-only. Update makefile rules to generate it in the build tree instead. Note some other boards have the kwbimage.cfg file written in advance,

[U-Boot] [PATCH 1/5] tools: buildman: Honor output directory when generating boards.cfg

2019-10-27 Thread Bin Meng
buildman always generates boards.cfg in the U-Boot source tree. When '-o' is given, we should generate boards.cfg to the given output directory. Signed-off-by: Bin Meng --- tools/buildman/control.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[U-Boot] [PATCH 4/4] fdt: Sync up to the latest libfdt

2019-10-27 Thread Simon Glass
Bring over the fdt from this commit: 430419c (origin/master) tests: fix some python warnings adding in the 'assumptions' series designed to reduce code size. Signed-off-by: Simon Glass --- lib/libfdt/fdt_ro.c | 420 ---

[U-Boot] [PATCH] patman: fix some typos in comments

2019-10-27 Thread Anatolij Gustschin
s/Subprocress/Subprocess/ s/easiler/easier/ s/repositiory/repository/ s/rangem/range/ s/Retruns/Returns/ Signed-off-by: Anatolij Gustschin --- tools/patman/cros_subprocess.py | 4 ++-- tools/patman/gitutil.py | 4 ++-- tools/patman/terminal.py| 2 +- 3 files changed, 5

[U-Boot] [PATCH v3 8/9] tools: Avoid creating symbolic links for tools/version.h

2019-10-27 Thread Bin Meng
When building U-Boot host tools for Windows from Microsoft Azure Pipelines, the following errors were seen: HOSTCC tools/mkenvimage.o In file included from tools/mkenvimage.c:25: ./tools/version.h:1:1: error: expected identifier or ‘(’ before ‘.’ token 1 | ../include/version.h

[U-Boot] [PATCH v3 3/9] tools: zynqmpbif: Use compiler builtin instead of linux-specific __swab32

2019-10-27 Thread Bin Meng
__swab32() is a Linux specific macro defined in linux/swab.h. Let's use the compiler equivalent builtin function __builtin_bswap32() for better portability. Signed-off-by: Bin Meng --- Changes in v3: None Changes in v2: None tools/zynqmpbif.c | 2 +- 1 file changed, 1 insertion(+), 1

[U-Boot] [PATCH v3 2/9] tools: mtk_image.h: Use portable uintXX_t instead of linux-specific __leXX

2019-10-27 Thread Bin Meng
__leXX has Linux kernel specific __attribute__((bitwise)) which is not portable. Use corresponding uintXX_t instead. Signed-off-by: Bin Meng --- Changes in v3: None Changes in v2: None tools/mtk_image.h | 86 +++ 1 file changed, 43

[U-Boot] [PATCH v3 0/9] tools: Support building U-Boot host tools for Windows via MSYS2

2019-10-27 Thread Bin Meng
Per current U-Boot README, building Windows versions of the utilities in the tools directory is done via the MinGW toolchain. But testing shows that it is broken and actually it must have been broken for quite a long time. Fixing MinGW build seems quite amount of work as developers of U-Boot

[U-Boot] [PATCH v3 1/9] tools: image.h: Use portable uint32_t instead of linux-specific __be32

2019-10-27 Thread Bin Meng
__be32 has Linux kernel specific __attribute__((bitwise)) which is not portable. Use uint32_t instead. Signed-off-by: Bin Meng --- Changes in v3: None Changes in v2: None include/image.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/image.h

Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup

2019-10-27 Thread Tom Rini
On Sun, Oct 27, 2019 at 05:23:14PM +0530, Jagan Teki wrote: > On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal > wrote: > > > > Hi Jagan, > > > > Jagan Teki wrote on Sat, 26 Oct 2019 > > 15:50:06 +0530: > > > > > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > > > wrote: > > > > > > > > As

[U-Boot] [PATCH] stm32mp1: configs: fix checking the presence of an environment

2019-10-27 Thread Bartosz Bilas
Execute env check command within extra env settings section instead of bootcmd whereby we are able to mount rootfs partition from sd card properly. Signed-off-by: Bartosz Bilas --- include/configs/stm32mp1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 01/30] lib: Allow crc32 to be disabled.

2019-10-27 Thread Simon Glass
Unfortunately this table seems to appear in TPL with gcc 7.3 even if it is not used. Fix it by creating a Kconfig that can be used to disable this routine. It is enabled by default, since most boards use it. Signed-off-by: Simon Glass --- lib/Kconfig | 29 +

Re: [U-Boot] [PATCH 01/30] lib: Allow crc32 to be disabled.

2019-10-27 Thread Heinrich Schuchardt
On 10/27/19 4:53 PM, Simon Glass wrote: Unfortunately this table seems to appear in TPL with gcc 7.3 even if it is not used. Fix it by creating a Kconfig that can be used to disable this routine. It is enabled by default, since most boards use it. Signed-off-by: Simon Glass --- lib/Kconfig

Re: [U-Boot] [PATCH 16/30] efi: Tidy up header includes

2019-10-27 Thread Heinrich Schuchardt
On 10/27/19 4:53 PM, Simon Glass wrote:> Two files relay on efi_driver.h to include common.h and dm.h which is %s/relay/rely/ incorrect. The former should always be included in a non-host C file and the latter should be included if driver model is used.

Re: [U-Boot] [PATCH 2/4] fdt: Add Kconfig options to control code size

2019-10-27 Thread Heinrich Schuchardt
On 10/27/19 4:47 PM, Simon Glass wrote: For better or worse libfdt recent grew a lot of code that checks the validity of the device tree in great detail. When using unsigned or unverified data this makes things safer, but it does add to code size. Add some controls to select the trade-off

[U-Boot] [PATCH 26/30] adc: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Drop the common.h inclusion also. Signed-off-by: Simon Glass --- drivers/adc/stm32-adc-core.c | 1 + drivers/adc/stm32-adc-core.h | 4 ++-- drivers/adc/stm32-adc.c | 1 + 3

[U-Boot] [PATCH 23/30] video: meson: Drop unnecessary header includes

2019-10-27 Thread Simon Glass
These files should not be included in meson header files. Drop them and tidy up the affected C files. Signed-off-by: Simon Glass --- drivers/video/meson/meson_canvas.c | 4 drivers/video/meson/meson_plane.c| 5 + drivers/video/meson/meson_vclk.c | 2 ++

[U-Boot] [PATCH 05/30] wdt: Move code out of the header

2019-10-27 Thread Simon Glass
We should not have C code in a header file. Move it into a shared C file so it can be used by U-Boot and SPL. Signed-off-by: Simon Glass --- common/init/Makefile | 1 + common/init/wdt.c| 46 include/init.h | 7 +++ include/wdt.h

[U-Boot] [PATCH 22/30] pci: Drop dm.h inclusion from header file

2019-10-27 Thread Simon Glass
The layerscape header should not include dm.h so remove it. Signed-off-by: Simon Glass --- drivers/pci/pcie_layerscape.h| 1 - drivers/pci/pcie_layerscape_fixup.c | 1 + drivers/pci/pcie_layerscape_gen4.h | 1 - drivers/pci/pcie_layerscape_gen4_fixup.c | 1 + 4 files

[U-Boot] [PATCH 19/30] spi: Drop duplicate dm.h inclusion

2019-10-27 Thread Simon Glass
We only need to include this header once. Drop the duplicate. Signed-off-by: Simon Glass --- drivers/spi/mscc_bb_spi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/mscc_bb_spi.c b/drivers/spi/mscc_bb_spi.c index c3c7b80426..22fa2efd34 100644 --- a/drivers/spi/mscc_bb_spi.c

[U-Boot] [PATCH 02/30] spi: Allow separate control of SPI_FLASH_TINY for SPL/TPL

2019-10-27 Thread Simon Glass
In some cases SPL needs to be able to erase but TPL just needs to read. Allow these to have separate settings for SPI_FLASH_TINY. Signed-off-by: Simon Glass --- common/spl/Kconfig | 10 ++ drivers/mtd/spi/Makefile | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff

[U-Boot] [PATCH 03/30] mtd: spi-nor: Tidy up error handling / debug code

2019-10-27 Thread Simon Glass
The -ENODEV error value in spi_nor_read_id() is incorrect since there clearly is a device - it just cannot be supported. Use -ENOMEDIUM instead which has the virtue of being less common. Fix the return value in spi_nor_scan(). Also there are a few printf() statements which should be debug()

[U-Boot] [PATCH 27/30] nand: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- drivers/mtd/nand/raw/brcmnand/brcmnand_compat.c | 4 drivers/mtd/nand/raw/brcmnand/brcmnand_compat.h | 4 ++-- 2 files changed, 6 insertions(+), 2

[U-Boot] [PATCH 28/30] ufs: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Also drop asm.io Signed-off-by: Simon Glass --- drivers/ufs/cdns-platform.c | 1 + drivers/ufs/ufs.c | 2 +- drivers/ufs/ufs.h | 5 ++--- 3 files changed, 4

[U-Boot] [PATCH 16/30] efi: Tidy up header includes

2019-10-27 Thread Simon Glass
Two files relay on efi_driver.h to include common.h and dm.h which is incorrect. The former should always be included in a non-host C file and the latter should be included if driver model is used. Signed-off-by: Simon Glass --- include/efi_driver.h | 2 --

[U-Boot] [PATCH 20/30] ti: am654: Drop duplicate dm.h inclusion

2019-10-27 Thread Simon Glass
We only need to include this header once. Drop the duplicate. Signed-off-by: Simon Glass --- drivers/ram/k3-am654-ddrss.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ram/k3-am654-ddrss.c b/drivers/ram/k3-am654-ddrss.c index 7015d8cfe7..00673e80a9 100644 ---

[U-Boot] [PATCH 29/30] usb: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Also move the inline function out into a C file. We should not include C code in headers. Signed-off-by: Simon Glass --- drivers/usb/musb-new/musb_uboot.c | 37

[U-Boot] [PATCH 17/30] power: Tidy up inclusion of regulator_common.h

2019-10-27 Thread Simon Glass
This file should not include common.h and dm.h so remove them. Also move the inclusion of this file to after the normal includes. Signed-off-by: Simon Glass --- drivers/power/regulator/fixed.c| 3 ++- drivers/power/regulator/gpio-regulator.c | 3 ++-

Re: [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq

2019-10-27 Thread Simon Glass
On Tue, 22 Oct 2019 at 01:40, Kever Yang wrote: > > Use log() insted of debug() for uclass_find_device_by_seq function, > since this print is very much and we can filter it out with log() > interface. > > Signed-off-by: Kever Yang > --- > > Changes in v2: > - use log_debug() instead of log() > >

Re: [U-Boot] [PATCH v2] patman: separate emails in CC list with NULs

2019-10-27 Thread Simon Glass
On Mon, 21 Oct 2019 at 21:10, Dmitry Torokhov wrote: > > There is a contributor in Linux kernel with a comma in their name, which > confuses patman and results in invalid to- or cc- addresses on some > patches. To avoid this, let's use \0 as a separator when generating cc > file. > >

Re: [U-Boot] [PATCH v2] fdt: Fix alignment issue when reading 64-bits properties from fdt

2019-10-27 Thread Simon Glass
On Tue, 22 Oct 2019 at 02:05, Jean-Jacques Hiblot wrote: > > The FDT specification [0] gives a requirement of aligning properties on > 32-bits. Make sure that the compiler is aware of this constraint when > accessing 64-bits properties. > > [0]: >

[U-Boot] [PATCH 1/4] fdt: Add INT32_MAX to kernel.h for libfdt

2019-10-27 Thread Simon Glass
Unfortunately libfdt needs this value now, which is present in the stdint.h header. That file is just a placeholder in U-Boot and these sorts of constants appear in the linux/kernel.h header instead. To keep libfdt happy, add INT32_MAX too. Signed-off-by: Simon Glass ---

[U-Boot] [PATCH 10/30] dm: core: Drop header files from dm/test.h

2019-10-27 Thread Simon Glass
These header file should not be included in other header files. Remove them and add to each individual file. Signed-off-by: Simon Glass --- include/dm/test.h | 3 --- test/dm/adc.c | 1 + test/dm/audio.c| 1 + test/dm/axi.c | 3 ++- test/dm/blk.c | 1 +

[U-Boot] [PATCH 30/30] dm: core: Guard against including dm.h in header files

2019-10-27 Thread Simon Glass
Header files generally should not include header files just for a struct, since forward declarations work just as well and reduce overhead. Add a warning for dm.h being included, since this has crept into U-Boot. Signed-off-by: Simon Glass dm: Avoid including dm.h in header files At present a

[U-Boot] [PATCH 25/30] mscc: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it from each one and use a forward declaration instead. Signed-off-by: Simon Glass --- arch/mips/mach-mscc/include/mach/jr2/jr2.h | 3 --- arch/mips/mach-mscc/include/mach/luton/luton.h | 3 ---

[U-Boot] [PATCH 14/30] thermal: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- arch/arm/mach-imx/cpu.c | 1 + include/thermal.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/cpu.c

[U-Boot] [PATCH 04/30] mtd: spi: Export spi_flash_std_probe()

2019-10-27 Thread Simon Glass
With of-platdata we need to create drivers for particular chips, or at least drivers that are separate from the standard code, since C structures are created by dtoc which are private to that driver. To avoid duplicating the probing code, export this probe function for use by these drivers.

[U-Boot] [PATCH 12/30] net: Drop dm.h header file from phy.h

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use other headers and C inclusions instead. Signed-off-by: Simon Glass --- cmd/mdio.c| 1 + cmd/mii.c | 1 + include/dm/read.h | 1 + include/phy.h | 5 - net/eth_legacy.c | 1 + 5 files

[U-Boot] [PATCH 21/30] liebherr: Drop duplicate dm.h inclusion

2019-10-27 Thread Simon Glass
We only need to include this header once. Drop the duplicate. Signed-off-by: Simon Glass --- board/liebherr/display5/display5.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/liebherr/display5/display5.c b/board/liebherr/display5/display5.c index 85ca777c1d..14bae67886 100644 ---

[U-Boot] [PATCH 06/30] wdt: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- include/wdt.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/wdt.h b/include/wdt.h index 5698605c02..62f4b34c30 100644

Re: [U-Boot] [PATCH 23/30] video: meson: Drop unnecessary header includes

2019-10-27 Thread Neil Armstrong
On 27/10/2019 16:54, Simon Glass wrote: > These files should not be included in meson header files. Drop them and > tidy up the affected C files. > > Signed-off-by: Simon Glass > --- > > drivers/video/meson/meson_canvas.c | 4 > drivers/video/meson/meson_plane.c| 5 + >

Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup

2019-10-27 Thread Jagan Teki
On Sun, 27 Oct, 2019, 15:06 Tom Rini, wrote: > On Sun, Oct 27, 2019 at 05:23:14PM +0530, Jagan Teki wrote: > > On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal > wrote: > > > > > > Hi Jagan, > > > > > > Jagan Teki wrote on Sat, 26 Oct 2019 > > > 15:50:06 +0530: > > > > > > > On Fri, Oct 25, 2019

Re: [U-Boot] [PATCH 23/30] video: meson: Drop unnecessary header includes

2019-10-27 Thread Anatolij Gustschin
On Sun, 27 Oct 2019 09:54:03 -0600 Simon Glass s...@chromium.org wrote: > These files should not be included in meson header files. Drop them and > tidy up the affected C files. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin ___

Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup

2019-10-27 Thread Jagan Teki
On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal wrote: > > Hi Jagan, > > Jagan Teki wrote on Sat, 26 Oct 2019 > 15:50:06 +0530: > > > On Fri, Oct 25, 2019 at 11:09 PM Miquel Raynal > > wrote: > > > > > > As rightfully pointed by Jagan, I should have dropped the dependency > > > of cmd/sf.c and

[U-Boot] [PATCH v3 5/9] tools: ifwitool: Define __packed when it is not defined

2019-10-27 Thread Bin Meng
Some compilers may provide __packed define for us. Signed-off-by: Bin Meng --- Changes in v3: - new patch: tools: ifwitool: Define __packed when it is not defined Changes in v2: None tools/ifwitool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/ifwitool.c b/tools/ifwitool.c

[U-Boot] [PATCH v3 9/9] Add Microsoft Azure Pipelines configuration

2019-10-27 Thread Bin Meng
Microsoft Azure Pipelines [1] provides unlimited CI/CD minutes and 10 parallel jobs to every open source project for free. This adds a configuration file for Azure Pipelines to utilize the free Windows VM hosted by Microsoft to ensure no build broken in building U-Boot host tools for Windows.

[U-Boot] [PATCH v3 7/9] Add .gitattributes for line endings

2019-10-27 Thread Bin Meng
When building U-Boot host tools for Windows from Microsoft Azure Pipelines, we see tons of weird warnings and errors emitted from every Kconfig files: Kconfig:6:warning: ignoring unsupported character '' Kconfig:6:warning: ignoring unsupported character '' Kconfig:8:warning: ignoring

[U-Boot] [PATCH v3 6/9] doc: Add documentation for how to build U-Boot host tools

2019-10-27 Thread Bin Meng
This adds a reST document for how to build U-Boot host tools, including information for both Linux and Windows. Signed-off-by: Bin Meng --- Changes in v3: None Changes in v2: None doc/build/index.rst | 9 + doc/build/tools.rst | 47 +++

[U-Boot] [PATCH v3 4/9] linux/types.h: Surround 'struct ustat' with __linux__

2019-10-27 Thread Bin Meng
'struct ustat' uses linux-specific typedefs to declare its memebers: __kernel_daddr_t and __kernel_ino_t. It is currently not used by any U-Boot codes, but when we build U-Boot tools for other platform like Windows, this becomes a problem. Let's surround it with __linux__. Signed-off-by: Bin

[U-Boot] [PATCH 2/4] fdt: Add Kconfig options to control code size

2019-10-27 Thread Simon Glass
For better or worse libfdt recent grew a lot of code that checks the validity of the device tree in great detail. When using unsigned or unverified data this makes things safer, but it does add to code size. Add some controls to select the trade-off between safety and code size. Signed-off-by:

[U-Boot] [PATCH 0/4] fdt: Switch to the latest libfdt, sort-of

2019-10-27 Thread Simon Glass
This series brings over the latest libfdt with some changes to deal with the recent code-size bloat. With this change U-Boot size increases about 2.5KB on 'rock' and SPL reduces by about 128 bytes. This should be acceptable. The 'assumptions' series is still under review, so we can sync that up

[U-Boot] [PATCH 3/4] mx6: tbs2910: Minimise libfdt code size

2019-10-27 Thread Simon Glass
This board appears to be very near its size limit and cannot accept the new checking code in libfdt. Disable this code so this the board can continue to build. Signed-off-by: Simon Glass --- configs/tbs2910_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/tbs2910_defconfig

[U-Boot] [PATCH 15/30] w1: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- board/atmel/common/board.c | 1 + cmd/w1.c | 1 + include/w1.h | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-)

[U-Boot] [PATCH 11/30] fs: fs-loader: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- drivers/fpga/socfpga_arria10.c | 1 + include/fs_loader.h| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 09/30] dm: core: Drop dm.h header file from dm-demo.h

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and add it to the cmd file instead. Signed-off-by: Simon Glass --- cmd/demo.c| 1 + include/dm-demo.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/demo.c b/cmd/demo.c index

Re: [U-Boot] [PATCH 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py

2019-10-27 Thread Bin Meng
On Sun, Oct 27, 2019 at 8:28 PM Bin Meng wrote: > > In the 'Make' function, the codes tries to create a directory > if current stage is 'build'. But the directory isn't used at > all anywhere. > > Signed-off-by: Bin Meng > --- > > tools/buildman/test.py | 9 + > 1 file changed, 1

Re: [U-Boot] [PATCH v6 0/3] End of the MTD makefile cleanup

2019-10-27 Thread Miquel Raynal
Hello, Jagan Teki wrote on Sun, 27 Oct 2019 15:24:40 +0100: > On Sun, 27 Oct, 2019, 15:06 Tom Rini, wrote: > > > On Sun, Oct 27, 2019 at 05:23:14PM +0530, Jagan Teki wrote: > > > On Sun, Oct 27, 2019 at 3:33 AM Miquel Raynal > > > > > wrote: > > > > > > > > Hi Jagan, > > > > > > > >

[U-Boot] [PATCH 24/30] mediatek: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- arch/arm/include/asm/arch-mediatek/reset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 13/30] sf: Drop dm.h header file from spi_flash.h

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/sdram.c | 1 + include/spi_flash.h| 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 07/30] mtd: spi-mem: Drop dm.h header file

2019-10-27 Thread Simon Glass
This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- drivers/spi/spi-mem-nodm.c | 1 + drivers/spi/spi-mem.c | 5 + drivers/spi/stm32_qspi.c | 2 ++ include/spi-mem.h | 5 + 4

[U-Boot] [PATCH 18/30] mmc: Drop duplicate dm.h inclusion

2019-10-27 Thread Simon Glass
We only need to include this header once. Drop the duplicate. Signed-off-by: Simon Glass --- drivers/mmc/sdhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index fbc576fd72..c081bfde5f 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c

[U-Boot] [PATCH 08/30] mtd: spi: Drop SPI_XFER_MMAP*

2019-10-27 Thread Simon Glass
These two defines are no-longer supported. Drop them. Signed-off-by: Simon Glass --- include/spi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/spi.h b/include/spi.h index 5eec0c4775..f5001a2cb2 100644 --- a/include/spi.h +++ b/include/spi.h @@ -113,8 +113,6 @@ struct spi_slave

Re: [U-Boot] [RFC 3/3] lib: rsa: add rsa_verify_with_pkey()

2019-10-27 Thread Simon Glass
Hi Takahiro, On Tue, 22 Oct 2019 at 23:43, AKASHI Takahiro wrote: > > On Tue, Oct 22, 2019 at 07:50:20AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Tue, 17 Sep 2019 at 20:59, AKASHI Takahiro > > wrote: > > > > > > Simon, > > > > > > Overall, do you agree to my approach here? > > > >

Re: [U-Boot] [PATCH v6 1/1] cmd: env: extend "env [set|print] -e" to manage UEFI variables

2019-10-27 Thread AKASHI Takahiro
On Fri, Oct 25, 2019 at 08:17:03PM +0200, Heinrich Schuchardt wrote: > On 10/24/19 8:17 AM, AKASHI Takahiro wrote: > > With this patch, when setting UEFI variable with "env set -e" command, > > we will be able to > > - specify vendor guid with "-guid guid", > > - specify variable attributes,

Re: [U-Boot] Pull request: u-boot-spi/master

2019-10-27 Thread Tom Rini
On Sun, Oct 27, 2019 at 05:20:22PM +0530, Jagan Teki wrote: > Hi Tom, > > On Fri, Oct 25, 2019 at 11:19 PM Tom Rini wrote: > > > > On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote: > > > > > Hi Tom, > > > > > > Please pull this PR. > > > > > > Summary: > > > - SPL_SPI_FLASH_MTD

Re: [U-Boot] [RFC 3/3] lib: rsa: add rsa_verify_with_pkey()

2019-10-27 Thread AKASHI Takahiro
Simon, On Sun, Oct 27, 2019 at 10:31:59AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Tue, 22 Oct 2019 at 23:43, AKASHI Takahiro > wrote: > > > > On Tue, Oct 22, 2019 at 07:50:20AM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Tue, 17 Sep 2019 at 20:59, AKASHI Takahiro > > >

Re: [U-Boot] [PATCH v3 008/108] dm: pci: Delay auto-config until after relocation

2019-10-27 Thread Bin Meng
Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > At present PCI auto-configuration happens in U-Boot both before and after > relocation. This is a waste of time and may mess up static addresses used > in board_init_f(). Adjust the code to do auto-configuration once, after >

[U-Boot] [PATCH] phy: atheros: add some debug output

2019-10-27 Thread Michael Walle
The network driver has to set the PHY node correctly. If that is not the case, ar803x_of_init() will fail. Add some debugging output. If the device tree binding is not working for you have a look at the ar803x_of_init: found PHY node: phy@0 output. In the case above "phy@0" is the phy node in

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-27 Thread AKASHI Takahiro
Simon, Tom, On Fri, Oct 25, 2019 at 12:29:08PM -0600, Simon Glass wrote: > Hi, > > On Fri, 25 Oct 2019 at 12:27, Tom Rini wrote: > > > > On Thu, Oct 24, 2019 at 03:36:07PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 22 Oct 2019 at 23:23, AKASHI Takahiro > > > wrote: > > > > > > > >

Re: [U-Boot] [PATCH v3 007/108] dm: core: Fix offset_to_ofnode() with invalid offset

2019-10-27 Thread Bin Meng
Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > If the offset is -1 this function correct sets up a null ofnode. But if correctly? > the offset is any other negative number (e.g. an FDT_ERR) then it does the FDT_ERR is -1. So probably another error number? > wrong thing. >

Re: [U-Boot] [PATCH v3 006/108] dm: gpio: Allow control of GPIO uclass in SPL

2019-10-27 Thread Bin Meng
On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > At present if CONFIG_SPL_GPIO_SUPPORT is enabled then the GPIO uclass > is included in SPL/TPL without any control for boards. Some boards may > want to disable this to reduce code size where GPIOs are not needed in > SPL or TPL. > > Add a

Re: [U-Boot] [PATCH v2 4/9] mpc85xx, socrates: add DM support

2019-10-27 Thread Heiko Schocher
Hello Priyanka Jain, Am 23.10.2019 um 13:18 schrieb Priyanka Jain: -Original Message- From: U-Boot On Behalf Of Heiko Schocher Sent: Wednesday, October 16, 2019 9:26 AM To: U-Boot Mailing List Subject: [U-Boot] [PATCH v2 4/9] mpc85xx, socrates: add DM support enable CONFIG_DM for

Re: [U-Boot] [PATCH v3 011/108] i2c: Tidy up designware PCI support

2019-10-27 Thread Heiko Schocher
Hello Simon, Am 21.10.2019 um 05:31 schrieb Simon Glass: This is hacked into the driver at present. It seems better to have it as a separate driver that uses the base driver. Create a new file and put the X86 code into it. Actually the Baytrail settings should really come from the device tree.

Re: [U-Boot] [PATCH v3 010/108] net: Move the checksum functions to lib/

2019-10-27 Thread Bin Meng
Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > These functions are used by code outside the network support, so move them > to lib/ to be more accessible. > > Fix up a few code-style nits while we are here. > > Signed-off-by: Simon Glass > --- > > Changes in v3: None >

Re: [U-Boot] [PATCH v3 009/108] dm: pci: Move pci_get_devfn() into a common file

2019-10-27 Thread Bin Meng
Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > Early in boot it is necessary to decode the PCI device/function values for > particular peripherals in the device tree or of-platdata. This is needed > in TPL where CONFIG_PCI is not defined. > > To handle this, move

Re: [U-Boot] [PATCH v3 094/108] i2c: designware: Add apollolake support

2019-10-27 Thread Heiko Schocher
Hello Simon, Am 21.10.2019 um 05:38 schrieb Simon Glass: For apollolake we need to take the I2C bus controller out of reset before using this. Add this functionality to the driver. Signed-off-by: Simon Glass --- Changes in v3: - Add a weak function to avoid errors on other platforms Changes

Re: [U-Boot] [PATCH 2/4] fdt: Add Kconfig options to control code size

2019-10-27 Thread Simon Glass
Hi Heinrich, On Sun, 27 Oct 2019 at 12:06, Heinrich Schuchardt wrote: > > On 10/27/19 4:47 PM, Simon Glass wrote: > > For better or worse libfdt recent grew a lot of code that checks the > > validity of the device tree in great detail. When using unsigned or > > unverified data this makes things

Re: [U-Boot] [PATCH v2 01/17] linux_compat: move kmemdup() from ubifs.c to linux_compat.c

2019-10-27 Thread AKASHI Takahiro
On Fri, Oct 25, 2019 at 07:38:45PM +0200, Heinrich Schuchardt wrote: > On 10/25/19 12:07 PM, AKASHI Takahiro wrote: > > linux_compat.c is the best place for kmemdup(), which is currenly used > > only in ubifs.c, but will also be used when other kernel files > > (in my case,

Re: [U-Boot] [PATCH v2 16/17] test: add lib specific Kconfig

2019-10-27 Thread AKASHI Takahiro
Tom, On Fri, Oct 25, 2019 at 12:07:30PM -0400, Tom Rini wrote: > On Fri, Oct 25, 2019 at 07:07:48PM +0900, AKASHI Takahiro wrote: > > Adding new unit tests for library routines will make test/Kconfig > > messy. So just create a Kconfig file under lib. > > > > Signed-off-by: AKASHI Takahiro > >

Re: [U-Boot] [PATCH v2 00/17] import x509/pkcs7 parsers from linux

2019-10-27 Thread AKASHI Takahiro
On Fri, Oct 25, 2019 at 07:07:32PM +0900, AKASHI Takahiro wrote: > # This patch set should be merged first prior to my rsa extension patch > # due to some dependency. I plan to send out a new version of rsa > # extension next week. > > Asn1 parsers of x509 certificates and pkcs7 messages are

Re: [U-Boot] [PATCH 05/30] wdt: Move code out of the header

2019-10-27 Thread Stefan Roese
On 27.10.19 16:53, Simon Glass wrote: We should not have C code in a header file. Move it into a shared C file so it can be used by U-Boot and SPL. Signed-off-by: Simon Glass Reviewed-by: Stefan Roese Thanks, Stefan --- common/init/Makefile | 1 + common/init/wdt.c| 46

Re: [U-Boot] [PATCH 3/5] arm: mvebu: Avoid generating kwbimage.cfg in the source tree

2019-10-27 Thread Stefan Roese
On 27.10.19 13:28, Bin Meng wrote: At present some boards generate kwbimage.cfg in the source tree during the build. This breaks buildman testing on some systems where the source tree is read-only. Update makefile rules to generate it in the build tree instead. Note some other boards have the

Re: [U-Boot] [PATCH 16/30] efi: Tidy up header includes

2019-10-27 Thread Simon Glass
Hi Heinrich, On Sun, 27 Oct 2019 at 11:42, Heinrich Schuchardt wrote: > > On 10/27/19 4:53 PM, Simon Glass wrote:> Two files relay on efi_driver.h > to include common.h and dm.h which is > %s/relay/rely/ > > > incorrect. The former should always be included in a non-host C file and > > the

Re: [U-Boot] [PATCH 3/5] arm: mvebu: Avoid generating kwbimage.cfg in the source tree

2019-10-27 Thread Chris Packham
Hi Bin, On Mon, 28 Oct 2019, 1:28 AM Bin Meng, wrote: > At present some boards generate kwbimage.cfg in the source tree > during the build. This breaks buildman testing on some systems > where the source tree is read-only. Update makefile rules to > generate it in the build tree instead. > >

Re: [U-Boot] [PATCH v3 005/108] binman: Add a library to access binman entries

2019-10-27 Thread Bin Meng
Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > SPL and TPL can access information about binman entries using link-time > symbols but this is not available in U-Boot proper. Of course it could be > made available, but the intention is to just read the device tree. > > Add

Re: [U-Boot] [PATCH v3 001/108] binman: Correct symbol calculation with non-zero image base

2019-10-27 Thread Bin Meng
On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > At present binman adds the image base address to the symbol value before > it writes it to the binary. This is not correct since the symbol value > itself (e.g. image position) has no relationship to the image base. > > Fix this and update

Re: [U-Boot] [PATCH v3 003/108] binman: Add support for Intel FSP-T

2019-10-27 Thread Bin Meng
On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > This entry is used to hold an Intel FSP-T (Firmware Support Package > Temp-RAM init) binary. Add support for this in binman. > > Signed-off-by: Simon Glass > --- > > Changes in v3: None > Changes in v2: None > > tools/binman/README.entries

Re: [U-Boot] [PATCH v3 011/108] i2c: Tidy up designware PCI support

2019-10-27 Thread Bin Meng
+Stefan Hi Simon, On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > This is hacked into the driver at present. It seems better to have it as > a separate driver that uses the base driver. Create a new file and put > the X86 code into it. > > Actually the Baytrail settings should really

Re: [U-Boot] [EXT] Re: [RFC/RESEND 01/22] arm: introduce ARCH_THUNDERX

2019-10-27 Thread Suneel Garapati
Hi Matthias, Thanks for your patience. Sorry for the delay. I will post the patch-set tomorrow. Regards, Suneel On Fri, Sep 27, 2019 at 01:59 Matthias Brugger wrote: > Hi Suneel, > > On 04/09/2019 08:03, Suneel Garapati wrote: > > Hi Matthias, > > > > Thank you for your concern. I picked up

Re: [U-Boot] [PATCH 06/30] wdt: Drop dm.h header file

2019-10-27 Thread Stefan Roese
On 27.10.19 16:53, Simon Glass wrote: This header file should not be included in other header files. Remove it and use a forward declaration instead. Signed-off-by: Simon Glass --- include/wdt.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/wdt.h

Re: [U-Boot] [PATCH v2 4/9] mpc85xx, socrates: add DM support

2019-10-27 Thread Heiko Schocher
Am 28.10.2019 um 06:02 schrieb Heiko Schocher: Hello Priyanka Jain, Am 23.10.2019 um 13:18 schrieb Priyanka Jain: -Original Message- From: U-Boot On Behalf Of Heiko Schocher Sent: Wednesday, October 16, 2019 9:26 AM To: U-Boot Mailing List Subject: [U-Boot] [PATCH v2 4/9]

Re: [U-Boot] [PATCH v3 012/108] spl: Correct priority selection for image loaders

2019-10-27 Thread Bin Meng
On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > At present the name of the image comes first in the linker-list symbol > used. This means that the name of the function sets the sort order, which > is not the intention. > > Update it to put the boot-device type first, then the priority.