[PATCH] dfu: dfu_mtd: set max_buf_size to erasesize also for NOR devices

2021-03-04 Thread Patrick Delaunay
For NOR devices the logical DFU buffer size is the sector_size, as it is done in dfu_sf.c or in spi/sf_mtd.c (sf_mtd_info.erasesize = flash->sector_size) For NAND the DFU size was already limited to erasesize as has_pages = true. So the mtd dfu backend can use this erasesize for all the MTD

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Pali Rohár
On Thursday 04 March 2021 11:17:01 Tom Rini wrote: > On Thu, Mar 04, 2021 at 09:07:33AM -0600, Adam Ford wrote: > > On Thu, Mar 4, 2021 at 8:58 AM Tom Rini wrote: > > > > > > On Thu, Mar 04, 2021 at 07:46:18AM -0600, Adam Ford wrote: > > > > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > >

[PATCH] cmd: xtrace: Convert to bool

2021-03-04 Thread Sean Anderson
This variable is a boolean, not a string. Signed-off-by: Sean Anderson --- cmd/Kconfig | 2 +- configs/bcm_ns3_defconfig | 2 +- configs/taurus_defconfig | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 928a2a0a2d..09e638fafe

[PATCH] configs: omap3_logic: Enable CONFIG_SPL_ALLOC_BD

2021-03-04 Thread Adam Ford
With bd_info dropped from the data section, the Logic PD OMAP3 boards and AM3517 fail to boot. Enabling CONFIG_SPL_ALLOC_BD restores them. Fixes: 38d6b7ebdaee ("spl: Drop bd_info in the data section") Signed-off-by: Adam Ford diff --git a/configs/am3517_evm_defconfig

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Tom Rini
On Thu, Mar 04, 2021 at 04:37:29PM +0100, Marek Behun wrote: > On Thu, 4 Mar 2021 09:07:33 -0600 > Adam Ford wrote: > > > On Thu, Mar 4, 2021 at 8:58 AM Tom Rini wrote: > > > > > > On Thu, Mar 04, 2021 at 07:46:18AM -0600, Adam Ford wrote: > > > > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Tom Rini
On Thu, Mar 04, 2021 at 09:07:33AM -0600, Adam Ford wrote: > On Thu, Mar 4, 2021 at 8:58 AM Tom Rini wrote: > > > > On Thu, Mar 04, 2021 at 07:46:18AM -0600, Adam Ford wrote: > > > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > > > > > > > On Wed, 3 Mar 2021 16:36:05 -0500 > > > > Tom

Re: [PATCH v4 06/42] doc: Explain how to run tests without pytest

2021-03-04 Thread Heinrich Schuchardt
On 3/4/21 2:50 PM, Simon Glass wrote: Add details about how to run a sandbox test directly, without using pytest. This is more convenient for rapid development, since it is faster and allows easier use of a debugger. Also mention sandbox_flattree as an example of the different sandbox builds

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Marek Behun
On Thu, 4 Mar 2021 09:07:33 -0600 Adam Ford wrote: > Interesting. with LTO enabled, the DRAM reports 7.2 GB and hangs. > Without LTO, U-Boot boots fine. > > LTO: > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit >

Re: [PATCH 2/2] video: dw_mipi_dsi: update log of dphy_enable

2021-03-04 Thread yannick Fertre
Acked-by: Yannick Fertre On 3/4/21 1:14 PM, Patrick Delaunay wrote: From: Yannick Fertre The DSI phy can be turned on from the DSI digital interface in the dphy_enable() function or from a dedicated DSI phy "wrapper" in phy_ops->init() function. If the STM32MP1 case, the wrapper is used

Re: [PATCH 1/2] video: dw_mipi_dsi: missing device to log debug

2021-03-04 Thread yannick Fertre
Acked-by: Yannick Fertre On 3/4/21 1:14 PM, Patrick Delaunay wrote: From: Yannick Fertre Missing udevice to struct dw_mipi_dsi to log trace. Signed-off-by: Yannick Fertre Signed-off-by: Patrick Delaunay --- drivers/video/dw_mipi_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] imx8mn_ddr4_evk: Allow booting the kernel by default

2021-03-04 Thread Andrey Zhizhikin
Hello Fabio, On Thu, Mar 4, 2021 at 12:07 PM Fabio Estevam wrote: > > Currently it is not possible to boot Linux from the SD card > by default. > > Make the necessary adjustments to allow it. > > Reported-by: Peter Bergin > Signed-off-by: Fabio Estevam Tested-by: Andrey Zhizhikin #

Re: [PATCH V4 00/13] net: smc911x: Convert to DM

2021-03-04 Thread Adam Ford
On Thu, Mar 4, 2021 at 9:15 AM Adam Ford wrote: > > On Thu, Mar 4, 2021 at 9:11 AM Tom Rini wrote: > > > > On Thu, Mar 04, 2021 at 08:41:23AM -0600, Adam Ford wrote: > > > On Tue, Apr 28, 2020 at 8:04 AM Marek Vasut wrote: > > > > > > > > On 4/28/20 2:45 PM, Adam Ford wrote: > > > > > On Wed,

Re: [PATCH v4 04/42] sandbox: Drop the 'starting...' message unless testing

2021-03-04 Thread Heinrich Schuchardt
On 3/4/21 2:50 PM, Simon Glass wrote: This message is annoying since it is only useful for testing. Add a flag to control whether it is emitted or not, so it can be supressed by default. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/start.c | 15

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Marek Behun
On Thu, 4 Mar 2021 09:07:33 -0600 Adam Ford wrote: > On Thu, Mar 4, 2021 at 8:58 AM Tom Rini wrote: > > > > On Thu, Mar 04, 2021 at 07:46:18AM -0600, Adam Ford wrote: > > > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > > > > > > > On Wed, 3 Mar 2021 16:36:05 -0500 > > > > Tom Rini

Re: [PATCH v4 02/42] doc: Tidy up testing section

2021-03-04 Thread Heinrich Schuchardt
On 3/4/21 2:50 PM, Simon Glass wrote: Tweak this so the output looks a little better. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v2) Changes in v2: - Use correct rst format for 'Ad-hoc tests' section doc/develop/testing.rst | 20

Re: [PATCH v4 35/42] test: Rename all linker lists to have a ut_ prefix

2021-03-04 Thread Heinrich Schuchardt
On 3/4/21 2:51 PM, Simon Glass wrote: At present each test suite has its own portion of the linker_list section of the image, but other lists are interspersed. This makes it hard to enumerate all the available tests without knowing the suites that each one is in. Place all tests together in a

Re: [PATCH V4 00/13] net: smc911x: Convert to DM

2021-03-04 Thread Adam Ford
On Thu, Mar 4, 2021 at 9:11 AM Tom Rini wrote: > > On Thu, Mar 04, 2021 at 08:41:23AM -0600, Adam Ford wrote: > > On Tue, Apr 28, 2020 at 8:04 AM Marek Vasut wrote: > > > > > > On 4/28/20 2:45 PM, Adam Ford wrote: > > > > On Wed, Mar 25, 2020 at 11:47 AM Marek Vasut > > > > wrote: > > > >> > >

Re: [PATCH V4 00/13] net: smc911x: Convert to DM

2021-03-04 Thread Tom Rini
On Thu, Mar 04, 2021 at 08:41:23AM -0600, Adam Ford wrote: > On Tue, Apr 28, 2020 at 8:04 AM Marek Vasut wrote: > > > > On 4/28/20 2:45 PM, Adam Ford wrote: > > > On Wed, Mar 25, 2020 at 11:47 AM Marek Vasut > > > wrote: > > >> > > >> Perform DM conversion of the SMC911x driver. > > >> > > >>

Re: [PATCH v4 05/16] gpio: Drop dm_gpio_set_dir()

2021-03-04 Thread Tom Rini
On Thu, Mar 04, 2021 at 09:22:35AM -0500, Simon Glass wrote: > Hi Tom, > > On Wed, 3 Mar 2021 at 15:39, Tom Rini wrote: > > > > On Thu, Feb 04, 2021 at 09:21:58PM -0700, Simon Glass wrote: > > > > > This function is not used. Drop it. > > > > > > Signed-off-by: Simon Glass > > > > > >

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Adam Ford
On Thu, Mar 4, 2021 at 8:58 AM Tom Rini wrote: > > On Thu, Mar 04, 2021 at 07:46:18AM -0600, Adam Ford wrote: > > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > > > > > On Wed, 3 Mar 2021 16:36:05 -0500 > > > Tom Rini wrote: > > > > > > > So, as I start testing things locally with two

[RFC] devices without FDT node

2021-03-04 Thread Heinrich Schuchardt
Hello Simon, in U-Boot we can define drivers via U_BOOT_DRVINFO and U_BOOT_DRIVER. My current use case is SBI system reset extension. A driver would not reasonably depend on the device-tree because if the RISC-V cpu is in S-mode we know that there must be an SBI implementation. If the extension

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Tom Rini
On Thu, Mar 04, 2021 at 07:46:18AM -0600, Adam Ford wrote: > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > > > On Wed, 3 Mar 2021 16:36:05 -0500 > > Tom Rini wrote: > > > > > So, as I start testing things locally with two additional changes (1. > > > LTO by default 2. No

Re: [PATCH V4 00/13] net: smc911x: Convert to DM

2021-03-04 Thread Adam Ford
On Tue, Apr 28, 2020 at 8:04 AM Marek Vasut wrote: > > On 4/28/20 2:45 PM, Adam Ford wrote: > > On Wed, Mar 25, 2020 at 11:47 AM Marek Vasut wrote: > >> > >> Perform DM conversion of the SMC911x driver. > >> > >> Note that the DT compatible is set only for 9115 , so this might need > >> to be

Re: [PATCH v4 05/16] gpio: Drop dm_gpio_set_dir()

2021-03-04 Thread Simon Glass
Hi Tom, On Wed, 3 Mar 2021 at 15:39, Tom Rini wrote: > > On Thu, Feb 04, 2021 at 09:21:58PM -0700, Simon Glass wrote: > > > This function is not used. Drop it. > > > > Signed-off-by: Simon Glass > > > > Reviewed-by: Patrick Delaunay > > I'm dropping this patch as it seems to be an explicit

Re: Dead code CONFIG_ARMADA_39X?

2021-03-04 Thread Stefan Roese
On 04.03.21 14:58, Pali Rohár wrote: On Thursday 04 March 2021 14:50:56 Stefan Roese wrote: On 04.03.21 14:41, Pali Rohár wrote: On Thursday 04 March 2021 14:29:46 Stefan Roese wrote: On 03.03.21 11:21, Pali Rohár wrote: Hello! I see in more U-Boot files check for ifdef CONFIG_ARMADA_39X

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Adam Ford
On Thu, Mar 4, 2021 at 7:50 AM Marek Behun wrote: > > On Thu, 4 Mar 2021 07:46:18 -0600 > Adam Ford wrote: > > > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > > > > > On Wed, 3 Mar 2021 16:36:05 -0500 > > > Tom Rini wrote: > > > > > > > So, as I start testing things locally with two

Re: Dead code CONFIG_ARMADA_39X?

2021-03-04 Thread Pali Rohár
On Thursday 04 March 2021 14:50:56 Stefan Roese wrote: > On 04.03.21 14:41, Pali Rohár wrote: > > On Thursday 04 March 2021 14:29:46 Stefan Roese wrote: > > > On 03.03.21 11:21, Pali Rohár wrote: > > > > Hello! > > > > > > > > I see in more U-Boot files check for ifdef CONFIG_ARMADA_39X but I do

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:34:53PM +0100, Stefan Roese wrote: > On 04.03.21 14:28, Phil Sutter wrote: > > On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: > >> On 03.03.21 01:55, Phil Sutter wrote: > >>> Signed-off-by: Phil Sutter > >> > >> It's common practice to add some minimal

[PATCH v4 42/42] doc: Explain briefly how to write new tests

2021-03-04 Thread Simon Glass
Add a second on writing tests, covering when to use Python and C, where to put the tests, etc. Add a link to the existing Python test documentation. Signed-off-by: Simon Glass --- Changes in v4: - Add correct SPDX header Changes in v2: - Add new patches to cover running an SPL test

[PATCH v4 41/42] test: sandbox: Move sandbox test docs into doc/develop

2021-03-04 Thread Simon Glass
At present some of the documentation about running sandbox tests is in the sandbox docs. It makes more sense to put it in with the other testing docs, with a link there from sandbox. Update the documentation accordingly. Also add a paragraph explaining why sandbox exists and the test philosophy

[PATCH v4 35/42] test: Rename all linker lists to have a ut_ prefix

2021-03-04 Thread Simon Glass
At present each test suite has its own portion of the linker_list section of the image, but other lists are interspersed. This makes it hard to enumerate all the available tests without knowing the suites that each one is in. Place all tests together in a single contiguous list by giving them

[PATCH v4 40/42] spl: test: Add a test for spl_load_simple_fit()

2021-03-04 Thread Simon Glass
As an example of an SPL test, add a new test for loading a FIT within SPL. This runs on sandbox_spl. For this to work, the text base is adjusted so that there is plenty of space available. While we are here, document struct spl_load_info properly, since this is currently ambiguous. This test

[PATCH v4 34/42] test: Add a macros for finding tests in linker_lists

2021-03-04 Thread Simon Glass
At present we use the linker list directly. This is not very friendly, so add a helpful macro instead. This will also allow us to change the naming later without updating this code. Signed-off-by: Simon Glass --- (no changes since v1) include/test/test.h | 6 ++ test/bloblist.c

[PATCH v4 38/42] spl: Convert spl_fit to work with sandbox

2021-03-04 Thread Simon Glass
At present this casts addresses to pointers so cannot work with sandbox. Update the code to use map_sysmem() instead. As part of this change, the existing load_ptr is renamed to src_ptr since it is not a pointer to load_addr. It is confusing to use a similar name for something that is not

[PATCH v4 36/42] test: Allow SPL to run any available test

2021-03-04 Thread Simon Glass
At present SPL only runs driver model tests. Update it to run all available tests, i.e. in any test suite. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 7 +-- include/test/test.h| 16 +--- test/dm/test-dm.c | 11 ++-

[PATCH v4 37/42] sandbox: Update os_find_u_boot() to find the .img file

2021-03-04 Thread Simon Glass
At present this function can only locate the u-boot ELF file. For SPL it is handy to be able to locate u-boot.img since this is what would normally be loaded by SPL. Add another argument to allow this to be selected. While we are here, update the function to load SPL when running in TPL, since

[PATCH v4 39/42] doc: Move coccinelle into its own section

2021-03-04 Thread Simon Glass
This tool has nothing to do with testing. Create a new section for 'refactoring' and move it into there. It is likely that other topics may fall under the same heading, such as using moveconfig and search/replace tools. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v4 32/42] test: Move restoring of driver model state to ut_run_list()

2021-03-04 Thread Simon Glass
Add this functionality to ut_run_list() so it can be removed from dm_test_run(). At this point all tests are run through ut_run_list(). Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 11 --- test/test-main.c | 30 +- 2 files

[PATCH v4 31/42] test: Move the devicetree check into ut_run_list()

2021-03-04 Thread Simon Glass
Add a check to ut_run_list() as to whether a list has driver model tests. Move the logic for the test devicetree into that function, in an effort to eventually remove all logic from dm_test_run(). Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 13 -

[PATCH v4 33/42] test: log: Rename log main test file to log_ut.c

2021-03-04 Thread Simon Glass
The current name is the same as the main test runner file. Rename it to avoid confusion. Signed-off-by: Simon Glass --- (no changes since v1) test/log/Makefile | 2 +- test/log/{test-main.c => log_ut.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename

[PATCH v4 29/42] test: Run driver-model tests using ut_run_list()

2021-03-04 Thread Simon Glass
Use this function instead of implementing it separately for driver model. Make ut_run_tests() private since it is only used in test-main.c Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Allow for prefix to be NULL, to match function comment include/test/ut.h | 42

[PATCH v4 26/42] test: Drop dm_do_test()

2021-03-04 Thread Simon Glass
In an effort to make use of a common test runner, use ut_run_test() directly to run driver model tests. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/test/dm/test-dm.c

[PATCH v4 28/42] test: Use a local variable for test state

2021-03-04 Thread Simon Glass
At present we use a global test state for all driver-model tests. Make use of a local struct like we do with the other tests. To make this work, add functions to get and set this state. When a test starts, the state is set (so it can be used in the test). When a test finishes, the state is unset,

[PATCH v4 27/42] test: Add ut_run_test_live_flat() to run tests twice

2021-03-04 Thread Simon Glass
Driver model tests are generally run twice, once with livetree enable and again with it disabled. Add a function to handle this and call it from the driver model test runner. Make ut_run_test() private since it is not used outside test-main.c now. Signed-off-by: Simon Glass --- (no changes

[PATCH v4 30/42] test: Use return values in dm_test_run()

2021-03-04 Thread Simon Glass
Update this function to use the return value of ut_run_list() to check for success/failure, so that they are in sync. Also return a command success code so that the caller gets what it expects. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 14 ++ 1 file

[PATCH v4 22/42] test: Move dm_test_init() into test-main.c

2021-03-04 Thread Simon Glass
Move this function into test-main so that all the init is in one place. Rename it so that its purpose is clearer. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 9 - test/dm/test-dm.c | 22 -- test/test-main.c | 33

[PATCH v4 21/42] test: Drop struct dm_test_state

2021-03-04 Thread Simon Glass
Driver model is a core part of U-Boot. We don't really need to have a separate test structure for the driver model tests and it makes it harder to write a test if you have to think about which type of test it is. Subsume the fields from struct dm_test_state into struct unit_test_state and delete

[PATCH v4 25/42] test: Use ut_run_test() to run driver model tests

2021-03-04 Thread Simon Glass
Instead of having a separate function for running driver model tests, use the common one. Make the pre/post-run functions private since we don't need these outside of test-main.c Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 20

[PATCH v4 24/42] test: Move test running into a separate function

2021-03-04 Thread Simon Glass
Add a function to handle the preparation for running a test and the post-test clean-up. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 16 test/test-main.c | 32 +++- 2 files changed, 39 insertions(+), 9 deletions(-)

[PATCH v4 23/42] test: Move dm_test_destroy() into test-main.c

2021-03-04 Thread Simon Glass
Move this function into the common test runner and rename it to dm_test_post_run() so that its purpose is clear. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 22 -- test/test-main.c | 23 +++ 2 files changed, 23

[PATCH v4 20/42] test: Handle driver model reinit in test_pre_run()

2021-03-04 Thread Simon Glass
For driver model tests we want to reinit the data structures so that everything is in a known state before the test runs. This avoids one test changing something that breaks a subsequent tests. Move the call for this into test_pre_run(). Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v4 19/42] test: Move delay skipping to test_pre_run()

2021-03-04 Thread Simon Glass
This allows delays to be skipped in sandbox tests. Move it to the common pre-init function. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 11 +++ test/dm/test-dm.c | 2 -- test/test-main.c | 2 ++ test/ut.c | 7 +++ 4 files changed, 20

[PATCH v4 18/42] test: Move console silencing to test_pre_run()

2021-03-04 Thread Simon Glass
We already have a function for silencing the console during tests. Use this from test_pre_run() and drop this code from the driver model tests. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 4 test/test-main.c | 3 ++- 2 files changed, 2 insertions(+), 5

[PATCH v4 15/42] test: Move do_autoprobe() to test_pre_run()

2021-03-04 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 17 - test/test-main.c | 18 ++ 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index

[PATCH v4 17/42] test: Drop mallinfo() work-around

2021-03-04 Thread Simon Glass
This is not needed now. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 2 -- test/test-main.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 18877c7ae56..d1d83e34782 100644 ---

[PATCH v4 16/42] test: Move dm_scan_plat() to test_pre_run()

2021-03-04 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 2 -- test/test-main.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index c2e1a1b9207..18877c7ae56 100644 ---

[PATCH v4 12/42] test: Create pre/post-run functions

2021-03-04 Thread Simon Glass
Split out the test preparation into a separation function before expanding it. Add a post-run function as well, currently empty. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 20 test/test-main.c | 41 +++--

[PATCH v4 14/42] test: Move dm_extended_scan() to test_pre_run()

2021-03-04 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 3 --- test/test-main.c | 7 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 69a0349d04c..4cb0da13b7c

[PATCH v4 13/42] test: Call test_pre/post_run() from driver model tests

2021-03-04 Thread Simon Glass
Ultimately we want to get rid of the special driver model test init and use test_pre_run() and test_post_run() for all tests. As a first step, use those function to handle console recording. For now we need a special case for setting uts->start, but that wil go away once all init is in one place.

[PATCH v4 10/42] test: Rename test-main.c to test-dm.c

2021-03-04 Thread Simon Glass
This is the main test function for driver model but not for other tests. Rename the file and the function so this is clear. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 2 +- include/test/test.h| 4 ++-- test/dm/Makefile

[PATCH v4 11/42] test: Add an overall test runner

2021-03-04 Thread Simon Glass
Add a new test runner that will eventually be able to run any test. For now, have it run the 'command' unit tests, so that the functionality in cmd_ut_category() moves into it. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 42 ++

[PATCH v4 08/42] test: Correct setexpr test prefix

2021-03-04 Thread Simon Glass
This prefix should be for setexpr, not mem. This means that trying to select just these tests to run does not work. Fix it. For some reason this provokes an assertion failure due to memory not being freed. Move the env_set() in setexpr_test_str() to before the malloc() heap size size is recorded

[PATCH v4 04/42] sandbox: Drop the 'starting...' message unless testing

2021-03-04 Thread Simon Glass
This message is annoying since it is only useful for testing. Add a flag to control whether it is emitted or not, so it can be supressed by default. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/start.c | 15 +-- arch/sandbox/include/asm/state.h |

[PATCH v4 09/42] test: Mark all driver model tests with a flag

2021-03-04 Thread Simon Glass
Add a flag for driver model tests, so we can do special processing for them. Signed-off-by: Simon Glass --- (no changes since v1) include/dm/test.h | 3 ++- include/test/test.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/dm/test.h b/include/dm/test.h index

[PATCH v4 07/42] doc: Document how sandbox_spl_tests are run

2021-03-04 Thread Simon Glass
Add a few notes about the sandbox_spl tests, since they are special. Signed-off-by: Simon Glass Acked-by: Pratyush Yadav --- Changes in v4: - Fix 'of-pldata' typo Changes in v3: - Reword the SPL tests section for clarity Changes in v2: - Add a note that SPL tests can in fact be run

[PATCH v4 06/42] doc: Explain how to run tests without pytest

2021-03-04 Thread Simon Glass
Add details about how to run a sandbox test directly, without using pytest. This is more convenient for rapid development, since it is faster and allows easier use of a debugger. Also mention sandbox_flattree as an example of the different sandbox builds available. Signed-off-by: Simon Glass ---

[PATCH v4 02/42] doc: Tidy up testing section

2021-03-04 Thread Simon Glass
Tweak this so the output looks a little better. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use correct rst format for 'Ad-hoc tests' section doc/develop/testing.rst | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[PATCH v4 01/42] dm: core: Fix allocation of empty of-platdata

2021-03-04 Thread Simon Glass
With of-platdata we always have a dtv struct that holds the platform data provided by the driver_info record. However, this struct can be empty if there are no actual devicetree properties provided. The upshot of empty platform data is that it will end up as a zero-size member in the BSS section,

[PATCH v4 05/42] test: Re-enable test_ofplatdata

2021-03-04 Thread Simon Glass
This was inadvertently disabled after a recent change. Re-enable it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to re-enable test_ofplatdata test/py/tests/test_ofplatdata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 03/42] doc: Document make tcheck

2021-03-04 Thread Simon Glass
Add a comment about this option in the documentation. Also mention the script that runs these combinations. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Expand docs on how each type of test is marked doc/develop/testing.rst | 12 +++- 1 file changed, 11

[PATCH v4 00/42] test: Refactor tests to have a single test runner

2021-03-04 Thread Simon Glass
At present U-Boot has two broad sets of tests in the C code: driver model tests which do a lot of pre-/post-init and command tests which do not. This separation makes it slightly harder to write a test, since there are two different test-state structures and different rules for running the two

Re: Dead code CONFIG_ARMADA_39X?

2021-03-04 Thread Stefan Roese
On 04.03.21 14:41, Pali Rohár wrote: On Thursday 04 March 2021 14:29:46 Stefan Roese wrote: On 03.03.21 11:21, Pali Rohár wrote: Hello! I see in more U-Boot files check for ifdef CONFIG_ARMADA_39X but I do not see that CONFIG_ARMADA_39X could be defined in some header or board code. So does

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Marek Behun
On Thu, 4 Mar 2021 07:46:18 -0600 Adam Ford wrote: > On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > > > On Wed, 3 Mar 2021 16:36:05 -0500 > > Tom Rini wrote: > > > > > So, as I start testing things locally with two additional changes (1. > > > LTO by default 2. No

Re: [RFC PATCH u-boot 03/12] linker_lists: declare entries and lists externally visible

2021-03-04 Thread Marek Behun
We need to use the __ADDRESSABLE() macro from linux/compiler.h like Linux does in order to make it work even with clang's LTO.

Re: [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51)

2021-03-04 Thread Adam Ford
On Thu, Mar 4, 2021 at 4:43 AM Marek Behun wrote: > > On Wed, 3 Mar 2021 16:36:05 -0500 > Tom Rini wrote: > > > So, as I start testing things locally with two additional changes (1. > > LTO by default 2. No ffunction/data-sections with LTO) we see: > >

Re: [PATCH] arm: a37xx: pci: Implement workaround for the readback value of VEND_ID

2021-03-04 Thread Stefan Roese
On 03.03.21 14:37, Pali Rohár wrote: Marvell Armada 3720 Functional Errata, Guidelines, and Restrictions document describes in erratum 4.1 PCIe value of vendor ID (Ref #: 243): The readback value of VEND_ID (RD007h [15:0]) is 1B4Bh, while it should read 11ABh. The firmware

Re: Dead code CONFIG_ARMADA_39X?

2021-03-04 Thread Pali Rohár
On Thursday 04 March 2021 14:29:46 Stefan Roese wrote: > On 03.03.21 11:21, Pali Rohár wrote: > > Hello! > > > > I see in more U-Boot files check for ifdef CONFIG_ARMADA_39X but I do > > not see that CONFIG_ARMADA_39X could be defined in some header or board > > code. > > > > So does it mean

Re: [PATCH BUGFIX u-boot-marvell] ddr: marvell: axp: align signature of mv_xor_mem_init() with a38x

2021-03-04 Thread Stefan Roese
On 04.03.21 11:23, Marek Behún wrote: In arch/arm/mach-mvebu/dram.c we always include axp's xor.h for common XOR definitions, regardless whether we compile for axp or a38x. But the declaration of this function has a different signature in axp's xor.h from the one used in a38x' implementation -

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Stefan Roese
On 04.03.21 14:28, Phil Sutter wrote: On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: On 03.03.21 01:55, Phil Sutter wrote: Signed-off-by: Phil Sutter It's common practice to add some minimal text in the commit text, even for simple patches. I should learn to put less

Re: Dead code CONFIG_ARMADA_39X?

2021-03-04 Thread Stefan Roese
On 03.03.21 11:21, Pali Rohár wrote: Hello! I see in more U-Boot files check for ifdef CONFIG_ARMADA_39X but I do not see that CONFIG_ARMADA_39X could be defined in some header or board code. So does it mean that all code under ifdef CONFIG_ARMADA_39X is dead? Has U-Boot support for Marvell

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: > On 03.03.21 01:55, Phil Sutter wrote: > > Signed-off-by: Phil Sutter > > It's common practice to add some minimal text in the commit text, > even for simple patches. I should learn to put less meaningful subjects in those cases so

Re: [PATCH] arm: mvebu: Espressobin: Enable additional options

2021-03-04 Thread Stefan Roese
On 03.03.21 11:34, Pali Rohár wrote: Enable support for NVMe disks which can be connected to mPCIe slot via M.2 reduction. Enable btrfs and squashfs filesystems which are used by more Linux distributions. And enable fsuuid and setexpr commands which can be useful in scripting. Signed-off-by:

Re: [PATCH 4/5] ds414: Auto-populate env if appropriate

2021-03-04 Thread Stefan Roese
On 04.03.21 14:20, Phil Sutter wrote: On Thu, Mar 04, 2021 at 02:06:01PM +0100, Stefan Roese wrote: On 03.03.21 01:55, Phil Sutter wrote: Define a misc_init_r() which calls "syno populate_env" if the environment seems incomplete (or default), indicated by missing "ethaddr" variable. With this

Re: [PATCH] usb: host: ehci-vf: Fix portnr initialization

2021-03-04 Thread Simon Glass
+U-Boot Mailing List On Thu, 4 Mar 2021 at 03:50, Dominik Wild wrote: > > Hi Simon > > Okay, I had another look and figured that you worked on sequence numbers in > December. The thing is that I started the bisect from v2021.01 and up to this > version the sequence number was always -1. But I

Re: [PATCH 4/5] ds414: Auto-populate env if appropriate

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:06:01PM +0100, Stefan Roese wrote: > On 03.03.21 01:55, Phil Sutter wrote: > > Define a misc_init_r() which calls "syno populate_env" if the > > environment seems incomplete (or default), indicated by missing > > "ethaddr" variable. With this in place, no random MAC

Re: [PATCH u-boot-marvell] ddr: marvell: a38x: Sync code with Marvell mv-ddr-marvell repository

2021-03-04 Thread Stefan Roese
On 02.03.21 11:17, Pali Rohár wrote: This syncs drivers/ddr/marvell/a38x/ with the master branch of repository https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git up to the commit 7c351731d196 ("Merge pull request #29 from pali/sync-a38x-uboot"). This patch was created by following

Re: [PATCH 1/2] watchdog: Add booke watchdog driver

2021-03-04 Thread Stefan Roese
On 03.03.21 02:39, Chris Packham wrote: Add a driver for the PowerPC Book E watchdog driver that is present on a number of Freescale/NXP SoCs. Signed-off-by: Chris Packham --- drivers/watchdog/Kconfig | 7 +++ drivers/watchdog/Makefile| 1 + drivers/watchdog/booke_wdt.c | 107

Re: [PATCH 3/5] board/Synology: Unify legacy kernel support

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:03:58PM +0100, Stefan Roese wrote: > On 03.03.21 01:55, Phil Sutter wrote: > > Move the relevant bits from ds109.{c,h} into common/ and adjust the code > > to fit both DS109 and DS414. Moreover: > > > > * Introduce syno_board_id() which translates CONFIG_MACH_TYPE into

Re: [PATCH 2/5] configs: ds414: Enable XHCI_PCI by default

2021-03-04 Thread Phil Sutter
On Thu, Mar 04, 2021 at 02:00:50PM +0100, Stefan Roese wrote: > On 03.03.21 01:55, Phil Sutter wrote: > > With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear > > USB3 ports are finally usable and accessing them no longer hangs the > > system. > > > > Signed-off-by: Phil Sutter

Re: [PATCH] pci: Mark 64bit Memory BARs as such

2021-03-04 Thread Stefan Roese
On 03.03.21 01:57, Phil Sutter wrote: Just a bit more info to the reader. Signed-off-by: Phil Sutter --- drivers/pci/pci_auto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci_auto.c b/drivers/pci/pci_auto.c index da76148c58398..05663c72b4b84 100644 ---

Re: [PATCH 5/5] ds414: Add sample u-boot update command

2021-03-04 Thread Stefan Roese
On 03.03.21 01:55, Phil Sutter wrote: Signed-off-by: Phil Sutter It's common practice to add some minimal text in the commit text, even for simple patches. One short question below... --- include/configs/ds414.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 4/5] ds414: Auto-populate env if appropriate

2021-03-04 Thread Stefan Roese
On 03.03.21 01:55, Phil Sutter wrote: Define a misc_init_r() which calls "syno populate_env" if the environment seems incomplete (or default), indicated by missing "ethaddr" variable. With this in place, no random MAC address fallback is needed anymore. Signed-off-by: Phil Sutter ---

Re: [PATCH 3/5] board/Synology: Unify legacy kernel support

2021-03-04 Thread Stefan Roese
On 03.03.21 01:55, Phil Sutter wrote: Move the relevant bits from ds109.{c,h} into common/ and adjust the code to fit both DS109 and DS414. Moreover: * Introduce syno_board_id() which translates CONFIG_MACH_TYPE into the expected board ID tag value. * Properly initialize isusbhost, mac and

Re: [PATCH 2/5] configs: ds414: Enable XHCI_PCI by default

2021-03-04 Thread Stefan Roese
On 03.03.21 01:55, Phil Sutter wrote: With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear USB3 ports are finally usable and accessing them no longer hangs the system. Signed-off-by: Phil Sutter Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH 1/5] ds414: Add a Kconfig defining some strings

2021-03-04 Thread Stefan Roese
On 03.03.21 01:55, Phil Sutter wrote: A rather cosmetic change to conform with other board definitions. Signed-off-by: Phil Sutter Reviewed-by: Stefan Roese Thanks, Stefan

[PATCH 2/2] video: dw_mipi_dsi: update log of dphy_enable

2021-03-04 Thread Patrick Delaunay
From: Yannick Fertre The DSI phy can be turned on from the DSI digital interface in the dphy_enable() function or from a dedicated DSI phy "wrapper" in phy_ops->init() function. If the STM32MP1 case, the wrapper is used then the dphy_enable() "warning" traces are not relevant. This patch moves

[PATCH 1/2] video: dw_mipi_dsi: missing device to log debug

2021-03-04 Thread Patrick Delaunay
From: Yannick Fertre Missing udevice to struct dw_mipi_dsi to log trace. Signed-off-by: Yannick Fertre Signed-off-by: Patrick Delaunay --- drivers/video/dw_mipi_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/dw_mipi_dsi.c b/drivers/video/dw_mipi_dsi.c index

[PATCH] video: stm32: remove all child of DSI bridge when its probe failed

2021-03-04 Thread Patrick Delaunay
From: Patrick Delaunay Remove the child device of the STM32 DSI bridge when the driver probe failed to stop futher probe request on panels used with STMicroelectronics board (orisetech_otm8009a.c or raydium-rm68200.c driver). This patch avoid the trace "cannot get reset GPIO" when STM32MP157

Re: Habv4 on imx8m

2021-03-04 Thread Stefano Babic
On 04.03.21 12:18, Fabio Estevam wrote: Hi Frieder, On Thu, Mar 4, 2021 at 5:23 AM Frieder Schrempf wrote: Is this still on your list? It would be great if you could send a patch for this. Thanks for the reminder. I have just sent the patch. I forgot it as well, it is just to extend the

Re: Habv4 on imx8m

2021-03-04 Thread Fabio Estevam
Hi Frieder, On Thu, Mar 4, 2021 at 5:23 AM Frieder Schrempf wrote: > Is this still on your list? > It would be great if you could send a patch for this. Thanks for the reminder. I have just sent the patch.

<    1   2   3   >