This patchset adds the missing ethernet mvpp2 patches from the Marvell
U-Boot SDK version to support and fix higher connection speeds. This is
done in preparation for the integration of the Octeon TX2 CN913x
support, which uses the updated version of this code.
Please note that I explicitly did
From: Stefan Chulski
Signed-off-by: Stefan Chulski
Signed-off-by: Stefan Roese
---
(no changes since v1)
include/phy_interface.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/phy_interface.h b/include/phy_interface.h
index 841ade311efb..ebb18ecd40c0 100644
---
From: Stefan Chulski
GMII_SPEED should be enabled for 2.5G speed
Signed-off-by: Stefan Chulski
Reviewed-by: Yan Markman
Reviewed-by: Kostya Porotchkin
Signed-off-by: Stefan Roese
---
(no changes since v1)
drivers/net/mvpp2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
From: Stefan Chulski
Signed-off-by: Stefan Chulski
Signed-off-by: Stefan Roese
---
(no changes since v1)
drivers/net/mvpp2.c | 117 ++--
1 file changed, 112 insertions(+), 5 deletions(-)
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
index
From: Stefan Chulski
1. Differ between Port1 RGMII and SFI modes in Netcomplex config.
2. Remove XPCS config from SFI mode.
Port1 doesn't XPCS domain, XPCS config should be removed.
Access to Port1 XPCS can cause stall.
3. Add Port1 MPCS configurations.
Signed-off-by: Stefan Chulski
From: Ben Peled
Signed-off-by: Ben Peled
Reviewed-by: Stefan Chulski
Reviewed-by: Kostya Porotchkin
Signed-off-by: Stefan Roese
---
(no changes since v1)
drivers/net/mvpp2.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
index
From: Ben Peled
Signed-off-by: Ben Peled
Reviewed-by: Stefan Chulski
Reviewed-by: Kostya Porotchkin
Signed-off-by: Stefan Roese
---
(no changes since v1)
drivers/net/mvpp2.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
From: Marcin Wojtas
Because the mvpp2 driver now relies on the PHYLIB and
the external MDIO driver, configuring low level
SMI bus settings is redundant.
Signed-off-by: Marcin Wojtas
Reviewed-by: Kostya Porotchkin
Reviewed-by: Stefan Chulski
Signed-off-by: Stefan Roese
---
(no changes since
From: Ben Peled
Signed-off-by: Ben Peled
Reviewed-by: Stefan Chulski
Reviewed-by: Kostya Porotchkin
Signed-off-by: Stefan Roese
---
(no changes since v1)
drivers/net/mvpp2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
index
From: Marcin Wojtas
Until now the mvpp2 driver used an extra 'phy-speed'
DT property in order to differentiate between the
SGMII and SGMII @2.5GHz. As there is a dedicated
PHY_INTERFACE_MODE_SGMII_2500 flag to mark the latter
start using it and drop the custom flag.
Signed-off-by: Marcin Wojtas
From: Stefan Chulski
Currently, there are 2 valid cases for interface, PHY
and mdio relation:
- If an interface has PHY handler, it'll call
mdio_mii_bus_get_from_phy(), which will register
MDIO bus.
- If we want to use fixed-link for an interface,
PHY handle is not defined in the
Hi Ramon,
On 30.04.21 16:18, Ramon Fried wrote:
On Fri, Apr 30, 2021 at 7:40 AM Stefan Roese wrote:
On 29.04.21 22:24, Ramon Fried wrote:
On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese wrote:
From: Ben Peled
Signed-off-by: Ben Peled
Reviewed-by: Stefan Chulski
Reviewed-by: Kostya
Clear feature disable CSR to turn on all features of hart. The detail
is specified at section, 'SiFive Feature Disable CSR', in user manual
https://sifive.cdn.prismic.io/sifive/aee0dd4c-d156-496e-a6c4-db0cf54bbe68_sifive_U74MC_rtl_full_20G1.03.00_manual.pdf
Signed-off-by: Green Wan
Reviewed-by:
Add a callback harts_early_init() to start.S to allow different riscv
hart perform setup code for each hart as early as possible. Since all
the harts enter the callback, they must be able to run the same
setup.
Signed-off-by: Green Wan
Reviewed-by: Rick Chen
Reviewed-by: Bin Meng
---
On 01/05/2021 18:05, Dario Binacchi wrote:
As pointed by [1] and [2] the d64b9cdcd4 ("fdt: translate address if #size-cells =
<0>")
commit was wrong. The series reverts the patch and fixes the issue with
platform code, adding custom routines to access the clocks registers.
The solution has been
The pwm_sifive_set_config() and pwm_sifive_set_enable() cannot work
properly due to the wrong implementations. It will cause the u-boot
PWM command to not work as expected. The bugs will be resolved in this
patch.
Signed-off-by: Vincent Chen
---
drivers/pwm/pwm-sifive.c | 21
Hello Fabio,
> -Original Message-
> From: Fabio Estevam
> Sent: Sunday, May 2, 2021 11:45 PM
> To: ZHIZHIKIN Andrey
> Cc: U-Boot-Denx ; Stefano Babic ;
> NXP i.MX U-Boot Team ; Peng Fan
> ; Simon Glass ; Ye Li
> Subject: Re: [PATCH] arm: imx: imx8mm: correct unrecognized fracpll
Hi Marek
On 5/3/21 1:31 PM, Marek Vasut wrote:
> The CMD_UNZIP provides the 'gzwrite' command, which is convenient
> for writing e.g. gz-compressed images to eMMC from U-Boot.
>
> Signed-off-by: Marek Vasut
> Cc: Patrice Chotard
> Cc: Patrick Delaunay
> ---
>
Hi all,
I try to build u-boot by config of am335x_evm_test_defconfig on branch
master and burn to sd card on beaglebone black.
When I boot the device, the print the string "Trying to boot from MMC1".
But I build u-boot by config of am335x_evm_test_defconfig on branch
v2019.04 and boot normally.
Enable driver model support for FEC ethernet which allows us to remove
the iomux and board_eth_init function. Replace the toggling of the ethernet
phy reset with dt configuration.
Enable driver model support for PCI which allows us to remove the
eth1000_initialize() call. Additionally enable
On Mon, May 3, 2021 at 2:52 PM Giulio Benetti
wrote:
> Ok, is it ok if it even repeats the first line? Because I don’t know what
> write more than that.
Yes, that would be fine.
On Mon, May 3, 2021 at 9:13 AM Stefan Roese wrote:
>
> Hi Ramon,
>
> On 30.04.21 16:18, Ramon Fried wrote:
> > On Fri, Apr 30, 2021 at 7:40 AM Stefan Roese wrote:
> >>
> >> On 29.04.21 22:24, Ramon Fried wrote:
> >>> On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese wrote:
>
> From: Ben
From: Takahiro Kuwano
The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI.
The summary datasheets can be found in the following links.
https://www.cypress.com/file/424146/download (256Mb/512Mb/1Gb, single die)
https://www.cypress.com/file/499246/download (2Gb/4Gb, dual/quad
From: Pratyush Yadav
These structures will be used in a later commit inside another structure
definition. Also take the declarations out of the ifdef since they won't
affect the final binary anyway and will be used in a later commit.
Signed-off-by: Pratyush Yadav
---
Taken from Pratyush's
From: Pratyush Yadav
nor->setup() can be used by flashes to configure settings in case they
have any peculiarities that can't be easily expressed by the generic
spi-nor framework. This includes things like different opcodes, dummy
cycles, page size, uniform/non-uniform sector sizes, etc.
Move
From: Pratyush Yadav
Sometimes the information in a flash's SFDP tables is wrong. Sometimes
some information just can't be expressed in the SFDP table. So,
introduce the fixup hooks to allow tailoring settings for a specific
flash.
Three hooks are added: default_init, post_sfdp, and post_bfpt.
From: Takahiro Kuwano
Some of Spansion/Cypress chips have overlaid 4KB sectors at top and/or
bottom, depending on the device configuration, while U-Boot supports
uniform sector layout only.
The spansion_erase_non_uniform() erases overlaid 4KB sectors,
non-overlaid portion of normal sector, and
From: Pratyush Yadav
On devices with non-uniform sector sizes like Spansion S25 or S28 family
of flashes the sector under erase does not necessarily have to be
mtd->erasesize bytes long. For example, on S28 flashes the first 128 KiB
region is composed of 32 4 KiB sectors, then a 128 KiB sector,
From: Pratyush Yadav
The SPI NOR core will get new functions in following commits. This has
presented a significant challenge of keeping the SPL size in check on
the x530 platform.
On a previous iteration of the series, adding a set of compile-time
switches got the build working. But rebasing
From: Takahiro Kuwano
Fixes mode clocks for SPINOR_OP_READ_FAST_4B in tiny.
Signed-off-by: Takahiro Kuwano
---
Changes in v8:
- No change
Changes in v7:
- No change
Changes in v6:
- Remove spansion_quad_enable_volatile() per comment in
> Il giorno 3 mag 2021, alle ore 20:21, Fabio Estevam ha
> scritto:
>
> On Mon, May 3, 2021 at 2:52 PM Giulio Benetti
> wrote:
>
>> Ok, is it ok if it even repeats the first line? Because I don’t know what
>> write more than that.
>
> Yes, that would be fine.
Ok thank you. This was a
- gcc-11.0 proper is coming soon to kernel.org, use this snapshot for
now to see what fails.
- grub-2.04 does not build with gcc-11.0 due to -Werror, grub-2.06-rc1
fails on riscv32-linux as seen here:
https://www.mail-archive.com/grub-devel@gnu.org/msg30736.html
Cc: Heinrich Schuchardt
When we do not have bootstage enabled, rather than include an empty
dummy function, we just don't reference it. This saves us space in some
tight builds. This also shows a few cases where show_boot_progress was
incorrectly guarded before.
Cc: Simon Glass
Signed-off-by: Tom Rini
---
Moving to
Based on 5c45de21a2223, 44720996e2d79 and 5a76021c2eff7 in Linux
Signed-off-by: Tom Rini
---
Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index 404977efa527..aaa9a0495e69 100644
--- a/Makefile
+++ b/Makefile
@@ -687,6 +687,10 @@ KBUILD_CFLAGS += $(call
The board code here references the display_width / display_height
variables set in the video driver, declare these as externs as gcc-11
will notice and lead to a multiple definition error.
Signed-off-by: Tom Rini
---
board/BuS/eb_cpu5282/eb_cpu5282.c | 4 ++--
1 file changed, 2 insertions(+), 2
On Mon, May 3, 2021 at 9:09 AM Stefan Roese wrote:
>
> From: Marcin Wojtas
>
> Until now the mvpp2 driver used an extra 'phy-speed'
> DT property in order to differentiate between the
> SGMII and SGMII @2.5GHz. As there is a dedicated
> PHY_INTERFACE_MODE_SGMII_2500 flag to mark the latter
>
On Mon, May 3, 2021 at 9:08 AM Stefan Roese wrote:
>
> From: Stefan Chulski
>
> Signed-off-by: Stefan Chulski
> Signed-off-by: Stefan Roese
> ---
>
> (no changes since v1)
>
> drivers/net/mvpp2.c | 117 ++--
> 1 file changed, 112 insertions(+), 5
On Mon, May 3, 2021 at 9:09 AM Stefan Roese wrote:
>
> From: Ben Peled
>
> Signed-off-by: Ben Peled
> Reviewed-by: Stefan Chulski
> Reviewed-by: Kostya Porotchkin
> Signed-off-by: Stefan Roese
> ---
>
> (no changes since v1)
>
> drivers/net/mvpp2.c | 3 ---
> 1 file changed, 3 deletions(-)
On Mon, May 3, 2021 at 9:08 AM Stefan Roese wrote:
>
> From: Marcin Wojtas
>
> Because the mvpp2 driver now relies on the PHYLIB and
> the external MDIO driver, configuring low level
> SMI bus settings is redundant.
>
> Signed-off-by: Marcin Wojtas
> Reviewed-by: Kostya Porotchkin
>
On Mon, May 3, 2021 at 9:09 AM Stefan Roese wrote:
>
> From: Ben Peled
>
> Signed-off-by: Ben Peled
> Reviewed-by: Stefan Chulski
> Reviewed-by: Kostya Porotchkin
> Signed-off-by: Stefan Roese
> ---
>
> (no changes since v1)
>
> drivers/net/mvpp2.c | 2 ++
> 1 file changed, 2 insertions(+)
In some board cpld.h files the definition of the cpld_data struct
not-quite makes a typedef for cpld_data_t. This problem is caught with
gcc-11 as a multiple definition error. As there are no users of this
non-typedef, fix this by not declaring it one to begin with.
Cc: Priyanka Jain
Cc:
With gcc-11 we get a multiple errors here as the declarations for
mscc_pinctrl_ops and mscc_gpio_ops are missing an extern.
CC: Gregory CLEMENT
Cc: Lars Povlsen
Cc: Horatiu Vultur
Signed-off-by: Tom Rini
---
drivers/pinctrl/mscc/mscc-common.h | 4 ++--
1 file changed, 2 insertions(+), 2
With gcc-11 we see:
drivers/ddr/marvell/a38x/ddr3_debug.c:672:47: error: argument 2 of type
'u32[5]' {aka 'unsigned int[5]'} with mismatched bound
[-Werror=array-parameter=]
672 | int ddr3_tip_read_adll_value(u32 dev_num, u32
pup_values[MAX_INTERFACE_NUM * MAX_BUS_NUM],
|
Hey all,
This series does most of the work required to move to using GCC-11.0 to
build in CI. The first thing is I realized I forgot to update buildman
to know to where to fetch gcc-11 from, but I'll take care of that later.
Next, this ends up using the last gcc-11 snapshot as the gcc-11.0
From: Takahiro Kuwano
For dual/quad die package devices from Spansion/Cypress, the device's
status needs to be checked by reading status registers in all dies, by
using Read Any Register command. To support this, a Flash specific hook
that can overwrite the legacy status check is needed.
From: Takahiro Kuwano
Some of Spansion/Cypress chips support volatile version of configuration
registers and it is recommended to update volatile registers in the field
application due to a risk of the non-volatile registers corruption by
power interrupt. This patch adds a function to set Quad
From: Takahiro Kuwano
Some of Spansion/Cypress chips support Read/Write Any Register commands.
These commands are mainly used to write volatile registers and access to
the registers in second and subsequent die for multi-die package parts.
The Read Any Register instruction (65h) is followed by
From: Takahiro Kuwano
The nor->ready() and spansion_sr_ready() introduced earlier in this
series are used for multi-die package parts.
The nor->quad_enable() sets the volatile QE bit on each die.
The nor->erase() is hooked if the device is not configured to uniform
sectors, assuming it has 32
From: Takahiro Kuwano
This patch adds Cypress manufacturer ID (34h) definition.
Signed-off-by: Takahiro Kuwano
Reviewed-by: Pratyush Yadav
---
include/linux/mtd/spi-nor.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index
From: Takahiro Kuwano
The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI.
https://www.cypress.com/file/424146/download (256Mb/512Mb/1Gb, single die)
https://www.cypress.com/file/499246/download (2Gb/4Gb, dual/quad die)
The full version can be found in the following links
From: Takahiro Kuwano
The spansion_sr_ready() reads status register 1 by Read Any Register
commnad. This function is called from Flash specific hook with die address
and dummy cycles to support multi-die package parts from Spansion/Cypress.
Signed-off-by: Takahiro Kuwano
Reviewed-by: Pratyush
From: Takahiro Kuwano
Cypress chips support SPINOR_OP_EN4B(B7h) to enable 4-byte addressing mode.
Cypress chips support B8h to disable 4-byte addressing mode instead of
SPINOR_OP_EX4B(E9h).
This patch defines new opcode and updates set_4byte() to support
enable/disable 4-byte addressing mode
Hi Marek
On 5/3/21 1:31 PM, Marek Vasut wrote:
> Currently the code sets eth1addr only if /ethernet1 alias exists in DT,
> the node pointed to by the alias has "micrel,ks8851-mll" compatible
> string, and the KSZ8851 CCR register read indicates programmed EEPROM
> is not connected.
>
> This is
Hi Gabio,
> Il giorno 3 mag 2021, alle ore 16:01, Fabio Estevam ha
> scritto:
>
> Hi Giulio,
>
>> On Wed, Apr 7, 2021 at 4:03 PM Giulio Benetti
>> wrote:
>>
>> Signed-off-by: Giulio Benetti
>> ---
>> arch/arm/dts/imxrt1020.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
The gzip API uses the u64 type in it, which is not available in the host
build. This makes it impossible to include the header file.
We could make this type available, but it seems unnecessary. Limiting the
compression size to that of the 'unsigned long' type seems good enough. On
32-bit machines
Add a host Kconfigs for IMAGE_ENABLE_ENCRYPT. With this we can use
CONFIG_IS_ENABLED() directly in the host build, so drop the unnecessary
indirections IMAGE_IMAGE_ENABLE_ENCRYPT and IMAGE_IMAGE_ENABLE_DECRYPT.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-cipher.c | 6
This file has a lot of conditional code and much of it is unnecessary.
Clean this up to reduce the number of build combinations.
Signed-off-by: Simon Glass
---
(no changes since v1)
include/image.h| 40 --
include/u-boot/hash-checksum.h | 5
Adjust this function so that preprocessor macros are not needed. With
this, the host build uses more of the same header files as the target
build.
Rather than definining CONFIG_SYS_MALLOC_LEN, add a CONSERVE_MEMORY
define, since that is the purpose of the value.
This appears to have no impact on
Tidy up the warnings.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-board.c | 142 ++-
1 file changed, 72 insertions(+), 70 deletions(-)
diff --git a/common/image-board.c b/common/image-board.c
index 0c4e32e14e4..5d3eafb5245 100644
Use boolean variables to deal with the strange #ifdef logic of this
function, so we can remove the #ifdefs.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-board.c | 139 ++-
1 file changed, 72 insertions(+), 67 deletions(-)
diff
At present we must separately test for the host build for many options,
since we force them to be enabled. For example, CONFIG_FIT is always
enabled in the host tools, even if CONFIG_FIT is not enabled by the
board itself.
It would be more convenient if we could use, for example,
Drop the ENABLE and SUPPORT parts of this, which are redundant.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/Kconfig.boot | 2 +-
common/image-sig.c | 4 ++--
configs/bcm963158_ram_defconfig | 2 +-
configs/sandbox_defconfig | 2 +-
Rather than adding an #ifdef and open-coding this calculation, add a
helper function to handle it. Use this in the image code.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image.c | 33 +++--
include/relocate.h | 24 +++-
2
I have created an emmc.img in Buildroot 2020.11 and flashed an emmc
modul with that image.
The emmc.img file has two partitions with cramfs filesystem.(but i only
have to load one) I tried to load the cramfs partition from the emmc
into the RAM with the *cramfsls* - command and Iam very sure
Use Linux style u32 instead of uint32_t.
Signed-off-by: Dave Gerlach
---
drivers/ram/k3-j721e/lpddr4_ctl_regs.h | 3028
1 file changed, 1514 insertions(+), 1514 deletions(-)
diff --git a/drivers/ram/k3-j721e/lpddr4_ctl_regs.h
b/drivers/ram/k3-j721e/lpddr4_ctl_regs.h
Fix the indentation for certain macros to be consistent with the other
macros in the file, as the existing indentation does not make sense in
many places.
Signed-off-by: Dave Gerlach
---
.../k3-j721e/lpddr4_address_slice_0_macros.h | 334 +-
1 file changed, 167 insertions(+),
This patch series updates the existing k3-j721e driver to a common driver
to support both j721e and the new am642 SoC. It renames drivers/ram/k3-j721e
to drivers/ram/k3-ddrss and then introduces a refactored common driver with
the existing j721e support moved to files named with 32bit and am64
Rename the k3-j721e folder under drivers/ram to k3-ddrss in preparation
of introducing additional support for other platforms to the same
driver.
Signed-off-by: Dave Gerlach
---
drivers/ram/Makefile| 2 +-
drivers/ram/{k3-j721e => k3-ddrss}/Makefile
Create a new CONFIG_K3_DDRSS option to select the common parts of the
k3-ddrss driver. Also introduce a choice that depends on the top level
option to select CONFIG_K3_J721E_DDRSS for j721e support, and update
corresponding Kconfig as required.
Signed-off-by: Dave Gerlach
---
From: Lokesh Vutla
Attempt to get and enable a vtt regulator if one is provided from the
dts. If we do not find one, continue as not all platforms have this.
Signed-off-by: Nishanth Menon
Signed-off-by: Lokesh Vutla
Signed-off-by: Dave Gerlach
---
drivers/ram/k3-ddrss/k3-ddrss.c | 14
Update the k3-ddrss DT binding document to include compatible
for k3,am64-ddrss.
Signed-off-by: Dave Gerlach
---
doc/device-tree-bindings/memory-controller/k3-j721e-ddrss.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Make use of the host Kconfig for FIT. With this we can use
CONFIG_IS_ENABLED(FIT) directly in the host build, so drop the unnecessary
indirection.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/arm/mach-imx/hab.c | 2 +-
common/bootm.c | 10 +-
Add a host Kconfig for OF_LIBFDT. With this we can use
CONFIG_IS_ENABLED(OF_LIBFDT) directly in the host build, so drop the
unnecessary indirection.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/arc/lib/bootm.c| 2 +-
arch/arm/lib/bootm.c| 4 ++--
Add a macro to handle manually relocating a pointer. Update the iamge code
to use this to avoid needing #ifdefs.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-sig.c | 43 ---
include/relocate.h | 6 ++
2 files changed, 30
Move the variables declarations to where they are needed, to reduce the
number of #ifdefs needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-board.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/common/image-board.c
This is not needed with Kconfig, since we can use IS_ENABLED() easily
enough. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fdt.c | 4 ++--
include/image.h| 6 --
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/common/image-fdt.c
This is not needed with Kconfig, since we can use IS_ENABLED() easily
enough. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fdt.c | 2 +-
include/image.h| 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/common/image-fdt.c
Drop the _SUPPORT suffix so we can use CONFIG_IS_ENABLED() with this
option.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/spl/Kconfig | 2 +-
include/image.h| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index
On 2021/5/4 上午7:10, Simon Glass wrote:
Use the common function to avoid code duplication.
Signed-off-by: Simon Glass
Acked-by: Qu Wenruo
Thanks,
Qu
---
(no changes since v1)
fs/btrfs/compression.c | 51 +-
1 file changed, 5 insertions(+), 46
On Mon, 3 May 2021 17:10:51 -0600
Simon Glass wrote:
> Use the common function to avoid code duplication.
>
> Signed-off-by: Simon Glass
Is this tested? Why only zstd?
marek
The existing zstd API requires the same sequence of calls to perform its
task. Create a helper for U-Boot, to avoid code duplication, as is done
with other compression algorithms. Make use of of this from the image
code.
Note that the zstd code lacks a test in test/compression.c and this should
At present this function is full of preprocessor macros. Adjust it to
check for an unsupported algorithm after the switch(). This will allow
us to drop the macros.
Fix up the return-value path and an extra blank line while we are here.
Signed-off-by: Simon Glass
---
(no changes since v1)
The zstd implementation prints the error in image_decomp() which is
incorrect and does not match other algorithms. Drop this and let the
caller report the error.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Use the common function to avoid code duplication.
Signed-off-by: Simon Glass
---
(no changes since v1)
fs/btrfs/compression.c | 51 +-
1 file changed, 5 insertions(+), 46 deletions(-)
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index
Add a host Kconfig for FIT_RSASSA_PSS. With this we can use
CONFIG_IS_ENABLED(FIT_RSASSA_PSS) directly in the host build, so drop the
forcing of this in the image.h header.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-sig.c | 4 ++--
include/image.h | 3 ---
We can use the __maybe_unused attribute to avoid some of the #ifdefs in
this file. Update the functions accordingly.
Note: The actual hashing interface is still a mess, with four separate
combinations and lots of #ifdefs. This should really use a driver
approach, e.g. as is done with partition
These option are named inconsistently with other SPL options, thus making
them incompatible with the CONFIG_IS_ENABLED() macro. Rename them.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/spl/Kconfig | 8
include/image.h| 8
2 files changed, 8 insertions(+),
On Mon, May 3, 2021 at 9:08 PM Neil Armstrong wrote:
>
> On 22/04/2021 11:11, Green Wan wrote:
> > Add pcie driver for SiFive fu740, the driver depends on
> > fu740 gpio, clk and reset driver to do init. Force running at Gen1
> > for better capatible enumeration.
> >
> > Several devices are
This function is far too long. Before trying to remove #ifdefs, split out
the code that deals with selecting the FDT into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fdt.c | 319 -
1 file changed, 173
Use boolean variables to deal with the strange #ifdef logic of this
function, so we can remove the #ifdefs. Also drop one from its caller,
boot_get_fdt()
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fdt.c | 201 ++---
1 file
We already have a host Kconfig for SHA1. Use CONFIG_IS_ENABLED(SHA1)
directly in the code shared with the host build, so we can drop the
unnecessary indirection.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fit.c | 2 +-
include/image.h| 11 ---
2 files
Drop the #ifdefs which are easy to remove without refactoring.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/Kconfig.boot| 10 ++
common/image-fit-sig.c | 8 ++--
common/image-fit.c | 7 ---
3 files changed, 16 insertions(+), 9 deletions(-)
diff --git
This is not needed with Kconfig, since we can use IS_ENABLED() easily
enough. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fit.c | 2 +-
include/image.h| 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/common/image-fit.c
Much of the image-handling code predates the introduction of Kconfig and
has quite a few #ifdefs in it. It also uses its own IMAGE_... defines to
help reduce the #ifdefs, which is unnecessary now that we can use
IS_ENABLED() et al.
The image code is also where quite a bit of code is shared with
When passing a data buffer back from a function, it is not always clear
who owns the buffer, i.e. who is responsible for freeing the memory used.
An example of this is where multiple files are decompressed from the
firmware image, using a temporary buffer for reading (since the
compressed data has
This function should have a comment explaining what it does. Add one.
Signed-off-by: Simon Glass
---
(no changes since v1)
include/compiler.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/compiler.h b/include/compiler.h
index 27b9843497a..ec0d600e71a 100644
---
This function is far too long. Before trying to remove #ifdefs, split out
the code that deals with selecting the ramdisk into a separate function.
Leave the code indented as it was for easier review. The next patch cleans
this up along with checkpatch violations.
Signed-off-by: Simon Glass
---
Drop some more ifdefs in image-board.c and also the FPGA part of bootm.c
which calls into it.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/bootm.c | 16
common/image-board.c | 11 +++
2 files changed, 11 insertions(+), 16 deletions(-)
diff --git
We can use the new host_build() function for this, so drop it.
Signed-off-by: Simon Glass
---
(no changes since v1)
common/image-fit.c | 2 +-
include/image.h| 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/common/image-fit.c b/common/image-fit.c
index
At present when building host tools, we force CONFIG_SHA1 to be enabled
regardless of the board Kconfig setting. This is done in the image.h
header file.
Clean this up by adding new Kconfig options to enable hashing on the host,
relying on CONFIG_IS_ENABLED() to deal with the different builds.
1 - 100 of 129 matches
Mail list logo