Re: [PATCH] configs: ls2088aqds: fix synchronous exception

2021-05-20 Thread Bin Meng
On Fri, May 21, 2021 at 12:16 PM Biwen Li wrote: > > From: Biwen Li > > IFC NOR flash base address of ls2088a is 0x85000, beyond 4GiB? > and env crc offset size is 0x50, so fix the macro > CONFIG_ENV_ADDR to fix synchronous exception(access illegal address) > > Fixes: 59071804c1

[PATCH] configs: ls2088aqds: fix synchronous exception

2021-05-20 Thread Biwen Li
From: Biwen Li IFC NOR flash base address of ls2088a is 0x85000, and env crc offset size is 0x50, so fix the macro CONFIG_ENV_ADDR to fix synchronous exception(access illegal address) Fixes: 59071804c1 ("configs: ls2080a: Correct ENV_ADDR value") Signed-off-by: Biwen Li ---

Re: [PATCH 06/18] image: Drop IMAGE_ENABLE_SHA1

2021-05-20 Thread Simon Glass
Hi Alex, On Thu, 20 May 2021 at 17:13, Alex G. wrote: > > > > On 5/20/21 12:52 PM, Simon Glass wrote: > > Hi Alex, > > > > On Wed, 19 May 2021 at 20:41, Alex G. wrote: > >> > >> > >> > >> On 5/19/21 4:55 PM, Simon Glass wrote: > >>> Hi Alex, > >>> > >>> On Wed, 19 May 2021 at 11:44, Alex G

Re: [PATCH 06/18] image: Drop IMAGE_ENABLE_SHA1

2021-05-20 Thread Alex G.
On 5/20/21 12:52 PM, Simon Glass wrote: Hi Alex, On Wed, 19 May 2021 at 20:41, Alex G. wrote: On 5/19/21 4:55 PM, Simon Glass wrote: Hi Alex, On Wed, 19 May 2021 at 11:44, Alex G wrote: On 5/19/21 11:36 AM, Simon Glass wrote: Hi Alexandru, On Mon, 17 May 2021 at 10:38,

Re: [PATCH 06/18] image: Drop IMAGE_ENABLE_SHA1

2021-05-20 Thread Alex G.
On 5/20/21 6:17 PM, Simon Glass wrote: Hi Alex, On Thu, 20 May 2021 at 17:13, Alex G. wrote: On 5/20/21 12:52 PM, Simon Glass wrote: Hi Alex, On Wed, 19 May 2021 at 20:41, Alex G. wrote: On 5/19/21 4:55 PM, Simon Glass wrote: Hi Alex, On Wed, 19 May 2021 at 11:44, Alex G

Re: [PATCH v11 6/8] riscv: dts: add SiFive Unmatched board support

2021-05-20 Thread Bin Meng
On Thu, May 20, 2021 at 3:41 PM Green Wan wrote: > > Add dts files for SiFive Unmatched board. > > Signed-off-by: Green Wan > Reviewed-by: Rick Chen > --- > arch/riscv/dts/Makefile |1 + > .../dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 + >

Re: [PATCH 0/4] vpl: Introduce a verifying program loader

2021-05-20 Thread Michal Simek
Hi Simon, On 5/20/21 12:17 AM, Simon Glass wrote: > Hi Michal, > > On Wed, 19 May 2021 at 01:16, Michal Simek wrote: >> >> Hi Simon, >> >> On 5/8/21 12:37 AM, Simon Glass wrote: >>> U-Boot provides a verified-boot feature based around FIT, but there is >>> no standard way of implementing it for

Re: [PATCH v10 9/9] riscv: sifive: unmatched: Switch to use binman to generate u-boot.itb

2021-05-20 Thread Green Wan
On Thu, May 20, 2021 at 11:27 AM Bin Meng wrote: > Hi Green, > > On Thu, May 20, 2021 at 11:10 AM Green Wan wrote: > > > > Hi Bin, > > > > Thanks for the comment. Originally, I wanted to keep the binman change > tracked separately. I'll give it a try and create the new patch if it > doesn't. >

[PATCH v11 0/8] Add FU740 chip and HiFive Unmatched board support

2021-05-20 Thread Green Wan
This patch set is to add SiFive fu740 chip and HiFive Unmatched board support. Patches are split into several parts: - [PATCH v11 1/8] support for fu740 cpu - [PATCH v11 2/8] support for fu740 clk driver - [PATCH v11 3/8] rename and support for fu740 ram driver - [PATCH v11 4/8] add pcie

[PATCH v11 1/8] riscv: cpu: fu740: Add support for cpu fu740

2021-05-20 Thread Green Wan
Add SiFive fu740 cpu to support RISC-V arch Signed-off-by: Green Wan Reviewed-by: Bin Meng --- arch/riscv/Kconfig| 1 + arch/riscv/cpu/fu740/Kconfig | 37 +++ arch/riscv/cpu/fu740/Makefile | 12 + arch/riscv/cpu/fu740/cache.c

[PATCH v11 3/8] drivers: ram: sifive: rename fu540_ddr and add fu740 support

2021-05-20 Thread Green Wan
Rename fu540_ddr.c to sifive_ddr.c and add fu740 support Signed-off-by: Green Wan Reviewed-by: Bin Meng --- drivers/ram/sifive/Kconfig| 8 +- drivers/ram/sifive/Makefile | 2 +- .../ram/sifive/{fu540_ddr.c => sifive_ddr.c} | 89 ++- 3

[PATCH v11 4/8] drivers: pci: add pcie support for fu740

2021-05-20 Thread Green Wan
Add pcie driver for SiFive fu740, the driver depends on fu740 gpio, clk and reset driver to do init. Force running at Gen1 for better capatible enumeration. Several devices are tested: a) M.2 NVMe SSD b) USB-to-PCI adapter c) Ethernet adapter (E1000 compatible) Signed-off-by: Green Wan

[PATCH v11 2/8] drivers: clk: add fu740 support

2021-05-20 Thread Green Wan
Add fu740 support. One abstract layer is added for supporting multiple chips such as fu540 and fu740. Signed-off-by: Green Wan --- arch/riscv/cpu/fu540/Kconfig | 2 +- drivers/clk/sifive/Kconfig | 8 +- drivers/clk/sifive/Makefile | 4 +- drivers/clk/sifive/fu540-prci.c |

[PATCH v11 8/8] riscv: cpu: fu740: clear feature disable CSR

2021-05-20 Thread Green Wan
Clear feature disable CSR to turn on all features of hart. The detail is specified at section, 'SiFive Feature Disable CSR', in user manual https://sifive.cdn.prismic.io/sifive/aee0dd4c-d156-496e-a6c4-db0cf54bbe68_sifive_U74MC_rtl_full_20G1.03.00_manual.pdf Signed-off-by: Green Wan Reviewed-by:

[PATCH v11 5/8] riscv: dts: add fu740 support

2021-05-20 Thread Green Wan
Add dts support for fu740. The HiFive Unmatched support is based on fu740 cpu and drivers in following patch set. Signed-off-by: Green Wan [greentime.hu: set fu740 speed to 1.2GHz] Signed-off-by: Greentime Hu Reviewed-by: Bin Meng Reviewed-by: Rick Chen ---

[PATCH v11 7/8] board: sifive: add HiFive Unmatched board support

2021-05-20 Thread Green Wan
Add defconfig and board support for HiFive Unmatched. Signed-off-by: Green Wan Reviewed-by: Bin Meng Reviewed-by: Rick Chen --- arch/riscv/Kconfig | 4 + board/sifive/unleashed/Kconfig | 1 + board/sifive/unmatched/Kconfig | 51 +++

[PATCH v11 6/8] riscv: dts: add SiFive Unmatched board support

2021-05-20 Thread Green Wan
Add dts files for SiFive Unmatched board. Signed-off-by: Green Wan Reviewed-by: Rick Chen --- arch/riscv/dts/Makefile |1 + .../dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 + .../dts/hifive-unmatched-a00-u-boot.dtsi | 41 +

Re: [EXT] [PATCH] mtd: mxs_nand: default to legacy bch and rename to modern bch option

2021-05-20 Thread Sean Nyekjaer
On 13/05/2021 22.02, han.xu wrote: > On 21/05/11 07:08AM, Sean Nyekjaer wrote: >> Caution: EXT Email >> >> On 11/05/2021 04.49, han.xu wrote: >>> On 21/05/10 12:00PM, Sean Nyekjaer wrote: Caution: EXT Email Linux kernel defaults to use legacy bch setting, this was creating a

[PATCH] fixdep: remove leftover handling of IS_BUILTIN/IS_MODULE

2021-05-20 Thread Rasmus Villemoes
I removed CONFIG_IS_BUILTIN and CONFIG_IS_MODULE in commit 7d78a4547d ("linux/kconfig.h: remove unused helper macros"), but fixdep.c still looks for those. It's harmless, but also pointless and possibly confusing to a future reader. Fixes: 7d78a4547d ("linux/kconfig.h: remove unused helper

[PATCH 0/5] assorted printf-related patches

2021-05-20 Thread Rasmus Villemoes
The first patch ensures that vsnprintf() never returns a negative value. Finding (indirect) callers and having them all handle that would be a whack-a-mole game for no real gain. Even if the callers don't directly use the return value, they might rely on vsnprintf() always producing a

Re: [PATCH] fs/squashfs: fix reading of fragmented files

2021-05-20 Thread Richard Genoud
Le 17/05/2021 à 23:20, Joao Marcos Costa a écrit : The fragmented files were not correctly read because of two issues: - The squashfs_file_info struct has a field named 'comp', which tells if the file's fragment is compressed or not. This field was always set to 'true' in sqfs_get_regfile_info

[PATCH 5/5] common/log.c: use vscnprintf() in log_dispatch()

2021-05-20 Thread Rasmus Villemoes
We have to use the *printf variant which returns the strlen() of the resulting string, not the how-much-would-have-been-printed-given-enough-space, in order to use that value to inspect the last character in the string. Signed-off-by: Rasmus Villemoes --- common/log.c | 2 +- 1 file changed, 1

[PATCH 2/5] lib/vsprintf.c: implement printf() in terms of vprintf()

2021-05-20 Thread Rasmus Villemoes
This saves some code, both in terms of #LOC and .text size, and it is also the normal convention that foo(...) is implemented in terms of vfoo(). Signed-off-by: Rasmus Villemoes --- lib/vsprintf.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/vsprintf.c

[PATCH 3/5] lib/vsprintf.c: remove stale comment

2021-05-20 Thread Rasmus Villemoes
U-Boot doesn't support %pS/%pF or any other kind of kallsyms-like lookups. Remove the comment. Signed-off-by: Rasmus Villemoes --- lib/vsprintf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index e3bec7489b..65d985982d 100644 --- a/lib/vsprintf.c +++

[PATCH 1/5] lib/vsprintf.c: make sure vsnprintf() never returns a negative value

2021-05-20 Thread Rasmus Villemoes
Most callers (or callers of callers, etc.) of vsnprintf() are not prepared for it to return a negative value. The only case where that can currently happen is %pD, and it's IMO more user-friendly to produce some output that clearly shows that some "impossible" thing happened instead of having the

[PATCH 4/5] lib/vsprintf.c: remove unused ip6_addr_string()

2021-05-20 Thread Rasmus Villemoes
There's currently no user of %p[iI]6, so including ip6_addr_string() in the image is a waste of bytes. It's easy enough to have the compiler elide it without removing the code completely. The closest I can find to anybody "handling" ipv6 in U-Boot currently is in efi_net.c which does if

[PATCH u-boot v4 18/36] sandbox: make LTO available

2021-05-20 Thread Marek Behún
Make LTO available for sandbox architecture. Signed-off-by: Marek Behún Reviewed-by: Bin Meng --- arch/Kconfig | 1 + arch/sandbox/config.mk | 4 2 files changed, 5 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 6c4b81a486..c5c03d438c 100644 --- a/arch/Kconfig +++

[PATCH u-boot v4 10/36] efi_selftest: compiler flags for efi_selftest_miniapp_exception.o

2021-05-20 Thread Marek Behún
Add $(CFLAGS_EFI) and remove $(CFLAGS_NON_EFI) for efi_selftest_miniapp_exception.o. The removal is needed when compiling with LTO - this object file needs to be compiled without -flto. The adding is for consistency with other miniapps. Signed-off-by: Marek Behún Reviewed-by: Heinrich

[PATCH u-boot v4 08/36] efi_loader: add Sphinx doc for __efi_runtime and __efi_runtime_data

2021-05-20 Thread Marek Behún
Document the macros __efi_runtime and __efi_runtime_data in Sphinx style. Signed-off-by: Marek Behún Reviewed-by: Heinrich Schuchardt --- include/efi_loader.h | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/include/efi_loader.h

[PATCH u-boot v4 15/36] build: link with --build-id=none

2021-05-20 Thread Marek Behún
Some toolchains are compiled so that they pass a --build-id=something parameter to the linker implicitly. This causes U-Boot LTO linking to fail with something like: ld: section .note.gnu.build-id LMA ... overlaps section .text LMA ... because U-Boot's link scripts do not currently handle

[PATCH u-boot v4 21/36] ARM: make gd a function call for LTO and set via set_gd()

2021-05-20 Thread Marek Behún
On ARM, the gd pointer is stored in registers r9 / x18. For this the -ffixed-r9 / -ffixed-x18 flag is used when compiling, but using global register variables causes errors when building with LTO, and these errors are very difficult to overcome. Richard Biener says [1]: Note that global

[PATCH u-boot v4 25/36] ARM: fix LTO for keystone

2021-05-20 Thread Marek Behún
When building keystone with LTO the compiler complains: Error: selected processor does not support `smc #0' in Thumb mode Fix this by removing -flto for the file implementing these SMC calls. Signed-off-by: Marek Behún --- arch/arm/mach-keystone/Makefile | 1 + 1 file changed, 1 insertion(+)

[PATCH u-boot v4 23/36] ARM: fix LTO for imx28_xea

2021-05-20 Thread Marek Behún
When imx28_xea_defconfig is built with LTO, the compiler complains about the two different declarations of _start: include/asm-generic/sections.has extern void _start(void); arch/arm/cpu/arm926ejs/mxs/mxs.c as extern uint32_t _start; Fix this. Signed-off-by: Marek Behún

[PATCH u-boot v4 20/36] ARM: global_data: make set_gd() work for armv5 and armv6

2021-05-20 Thread Marek Behún
The Thumb instruction `ldr` is able to move high registers only from armv7. For armv5 and armv6 we have to use `mov`. Signed-off-by: Marek Behún --- arch/arm/include/asm/global_data.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/include/asm/global_data.h

[PATCH u-boot v4 19/36] sandbox: enable LTO by default

2021-05-20 Thread Marek Behún
Build sandbox targets with LTO by default. Signed-off-by: Marek Behún Reviewed-by: Bin Meng --- arch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/Kconfig b/arch/Kconfig index c5c03d438c..8fd39e36b4 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -125,6 +125,7 @@ config

[PATCH u-boot v4 16/36] sandbox: errno: avoid conflict with libc's errno

2021-05-20 Thread Marek Behún
When building with LTO, the system libc's `errno` variable used in arch/sandbox/cpu/os.c conflicts with U-Boot's `errno` (defined in lib/errno.c) with the following error: .../ld: errno@@GLIBC_PRIVATE: TLS definition in /lib64/libc.so.6 section .tbss mismatches non-TLS reference in

[PATCH u-boot v4 22/36] ARM: fix LTO build for some thumb-interwork cases

2021-05-20 Thread Marek Behún
Fix LTO build for some thumb-interwork usecases (such as for da850evm_defconfig), where inline assmebly such as mrc p15,0,r2,c1,c0,0 causes the compiler to fail during LTO linking with Error: selected processor does not support `mrc p15,0,r2,c1,c0,0' in Thumb mode Signed-off-by:

[PATCH u-boot v4 30/36] ARM: omap3: fix LTO for DM3730 (and possibly other omap3 boards)

2021-05-20 Thread Marek Behún
Adam Ford says that DM3730 needs board.c compiled without LTO flags. Signed-off-by: Marek Behún Tested-by: Adam Ford --- arch/arm/mach-omap2/omap3/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/omap3/Makefile b/arch/arm/mach-omap2/omap3/Makefile index

[PATCH u-boot v4 26/36] ARM: kona: fix clk_bsc_enable() type mismatch for LTO

2021-05-20 Thread Marek Behún
When building with LTO, the compiler complains about type mismatch of function clk_bsc_enable() in file: arch/arm/cpu/armv7/kona-common/clk-stubs.c vs other files that define or use this function: warning: type of ‘clk_bsc_enable’ does not match original declaration. Change the type of this

[PATCH u-boot v4 32/36] ata: ahci: fix ahci_link_up() type mismatch for LTO

2021-05-20 Thread Marek Behún
When building highbank_defconfig with LTO, the compiler complains about type mismatch of function ahci_link_up(). The third parameter of this function is of type u8 in drivers/ata/ahci.c, but of type int in board/highbank/ahci.c. There is no reason in using u8, and the code using this function

[PATCH u-boot v4 29/36] ARM: fix LTO for rockchip and samsung

2021-05-20 Thread Marek Behún
When building with LTO, the compiler complains about type mismatch of function usb_gadget_handle_interrupts(). This function is defined without parameters in files arch/arm/mach-rockchip/board.c board/samsung/common/exynos5-dt.c but it should have one parameter, int index. Fix this.

[PATCH u-boot v4 27/36] ARM: imx8m: fix imx_eqos_txclk_set_rate() type mismatch for LTO

2021-05-20 Thread Marek Behún
When building imx8mp_evk_defconfig with LTO, the compiler complains about type mismatch of function imx_eqos_txclk_set_rate() in file drivers/net/dwc_eth_qos.c:845:12 which contains a weak definition of this function, vs file arch/arm/mach-imx/imx8m/clock_imx8mm.c which contains an

[PATCH u-boot v4 28/36] ARM: fix LTO for seaboard

2021-05-20 Thread Marek Behún
When seaboard_defconfig is compiled with LTO, the compiler complains about some instructions not being supported in ARM mode. This is caused by arch/arm/mach-tegra/tegra20/warmboot_avp.c having different CFLAGS declared in Makefile. This file needs to be compiled without LTO. Fix this by

[PATCH u-boot v4 11/36] lib: crc32: put the crc_table variable into efi_runtime_rodata section

2021-05-20 Thread Marek Behún
When compiling with LTO, the compiler fails with an error saying that `crc_table` causes a section type conflict with `efi_var_buf`. This is because both are declared to be in the same section (via macro `__efi_runtime_data`), but one is const while the other is not. Put this variable into the

[PATCH] spl: Kconfig: Use tabs instead of space for alignment

2021-05-20 Thread Michal Simek
A lot of entries were using spaces instead of tab for alignment that's why it is good to fix it to use the same style everywhere. Signed-off-by: Michal Simek --- common/spl/Kconfig | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/common/spl/Kconfig

[PATCH u-boot v4 01/36] regmap: fix a serious pointer casting bug

2021-05-20 Thread Marek Behún
There is a serious bug in regmap_read() and regmap_write() functions where an uint pointer is cast to (void *) which is then cast to (u8 *), (u16 *), (u32 *) or (u64 *), depending on register width of the map. For example given a regmap with 16-bit register width the code int val =

[PATCH u-boot v4 00/36] U-Boot LTO (Sandbox + Some ARM boards)

2021-05-20 Thread Marek Behún
Hello, this is version 4 of patches adding support for LTO to U-Boot. This series is being tested by Github/Azure CI at https://github.com/u-boot/u-boot/pull/57 There is a problem with sandbox_clang test scenario, which I was unable to resolve yet, or even determine correctly whether the

[PATCH u-boot v4 04/36] compiler.h: align the __ADDRESSABLE macro with Linux' version

2021-05-20 Thread Marek Behún
Use UNIQUE_ID in the __ADDRESSABLE macro. Signed-off-by: Marek Behún Reviewed-by: Bin Meng --- include/linux/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 82a8a4ede9..98dd3fc4cc 100644 ---

[PATCH u-boot v4 03/36] treewide: Convert macro and uses of __section(foo) to __section("foo")

2021-05-20 Thread Marek Behún
This commit does the same thing as Linux commit 33def8498fdd. Use a more generic form for __section that requires quotes to avoid complications with clang and gcc differences. Remove the quote operator # from compiler_attributes.h __section macro. Convert all unquoted __section(foo) uses to

[PATCH u-boot v4 02/36] checkpatch: require quotes around section name in the __section() macro

2021-05-20 Thread Marek Behún
This is how Linux does this now, see Linux commit 339f29d91acf. Signed-off-by: Marek Behún --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 59a714a95f..08a827535a 100755 --- a/scripts/checkpatch.pl

[PATCH u-boot v4 07/36] efi_loader: fix warning when linking with LTO

2021-05-20 Thread Marek Behún
When linking with LTO, the compiler complains about type mismatch of variables `__efi_runtime_start`, `__efi_runtime_stop`, `__efi_runtime_rel_start` and `__efi_runtime_rel_stop`: include/efi_loader.h:218:21: warning: type of ‘__efi_runtime_start’ does not

[PATCH u-boot v4 05/36] test/py: improve regular expression for ut subtest symbol matcher

2021-05-20 Thread Marek Behún
Improve the regular expression that matches unittest symbols in u-boot.sym. Currently we do not enforce no prefix in symbol string, but with the soon to come change in linker lists declaring lists and entries with the __ADDRESSABLE macro (because of LTO), the symbol file will contain for every

[PATCH u-boot v4 06/36] string: make memcpy(), memset(), memcmp() and memmove() visible for LTO

2021-05-20 Thread Marek Behún
It seems that sometimes (happening on ARM64, for example with turris_mox_defconfig) GCC, when linking with LTO, changes the symbol names of some functions, for example lib/string.c's memcpy() function to memcpy.isra.0. This is a problem however when GCC for a code such as this: struct

[PATCH u-boot v4 35/36] ARM: don't use --gc-sections with LTO when using private libgcc

2021-05-20 Thread Marek Behún
When using LTO, we can throw away the --gc-sections flag, but only if using private libgcc. When using system's libgcc, --gc-sections is still needed, otherwise linking will fail due to undefined references to libc's symbols. Signed-off-by: Marek Behún --- arch/arm/config.mk | 2 ++ 1 file

[PATCH u-boot v4 34/36] ARM: don't use -ffunction-sections/-fdata-sections with LTO build

2021-05-20 Thread Marek Behún
When building with LTO, using -ffunction-sections/-fdata-sections is not useful anymore. Signed-off-by: Marek Behún --- arch/arm/config.mk | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/config.mk b/arch/arm/config.mk index e79f0104b9..f556ee3329 100644 ---

[PATCH u-boot v4 33/36] ARM: make LTO available

2021-05-20 Thread Marek Behún
Make LTO available for ARM architecture. Signed-off-by: Marek Behún --- arch/Kconfig | 1 + arch/arm/lib/Makefile | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 8fd39e36b4..49813a4c9b 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -33,6 +33,7

[PATCH u-boot v4 31/36] armv8: SPL: discard relocation information

2021-05-20 Thread Marek Behún
For some reason when building SPL for ARMv8 with LTO, the relocation information is not discarded. Discard it explicitly in the linker script. This fixes LTO build for imx8mm_venice_defconfig. Signed-off-by: Marek Behún --- arch/arm/cpu/armv8/u-boot-spl.lds | 1 + 1 file changed, 1

[PATCH u-boot v4 36/36] ARM: enable LTO for some boards

2021-05-20 Thread Marek Behún
Enable LTO for some boards that were tested by people on U-Boot Mailing List. Signed-off-by: Marek Behún Tested-by: Adam Ford Tested-by: Pali Rohár Tested-by: Tim Harvey --- configs/am3517_evm_defconfig | 1 + configs/da850evm_defconfig| 1 +

[PATCH u-boot v4 14/36] build: support building with Link Time Optimizations

2021-05-20 Thread Marek Behún
Add plumbing for building U-Boot with Link Time Optimizations. When building with LTO, $(PLATFORM_LIBS) has to be in --whole-archive / --no-whole-archive group, otherwise some functions declared in assembly may not be resolved and linking may fail. Note: clang may throw away linker list symbols

[PATCH u-boot v4 13/36] build: use thin archives instead of incremental linking

2021-05-20 Thread Marek Behún
Currently we use incremental linking (ld -r) to link several object files from one directory into one built-in.o object file containing the linked code from that directory (and its subdirectories). Linux has, some time ago, moved to thin archives instead. Thin archives are archives (.a) that do

[PATCH u-boot v4 09/36] efi_loader: add macro for const EFI runtime data

2021-05-20 Thread Marek Behún
Add macro __efi_runtime_rodata, for const variables with similar purpose as those using __efi_runtime_data. Signed-off-by: Marek Behún Reviewed-by: Heinrich Schuchardt --- include/efi_loader.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/efi_loader.h

[PATCH u-boot v4 24/36] ARM: fix LTO for apf27

2021-05-20 Thread Marek Behún
When apf27_defconfig is built with LTO, linking complains about undefined reference to `nand_boot`. This is because it is referenced from inline assembly. Make it visible. Signed-off-by: Marek Behún --- drivers/mtd/nand/raw/mxc_nand_spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH u-boot v4 17/36] sandbox: use sections instead of symbols for getopt array boundaries

2021-05-20 Thread Marek Behún
In style of linked lists, instead of declaring symbols for boundaries of getopt options array in the linker script, declare corresponding sections and retrieve the boundaries via static inline functions. Without this clang's LTO produces binary without any getopt options, because for some reason

[PATCH u-boot v4 12/36] Makefile, Makefile.spl: cosmetic change

2021-05-20 Thread Marek Behún
Indent the linking commands so that they look cosmetically better. Signed-off-by: Marek Behún Reviewed-by: Bin Meng --- Makefile | 12 +++- scripts/Makefile.spl | 17 +++-- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile

[PATCH 4/6] ARM: dts: imxrt1050: add usbotg1, usbphy1 and usbmisc nodes

2021-05-20 Thread Giulio Benetti
Usb is now supported so add all required nodes for it in imxrt1050. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi index

[PATCH 5/6] ARM: dts: imxrt1050-evk: enable usbotg1 node as host

2021-05-20 Thread Giulio Benetti
Enable usbotg1 port node as host usb. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/imxrt1050-evk.dts b/arch/arm/dts/imxrt1050-evk.dts index 81db1a446d..324cf7af96 100644 ---

[PATCH 6/6] configs: imxrt1050-evk: enable host usb support and its command

2021-05-20 Thread Giulio Benetti
Now that usb host is supported let's enable it on this board. Signed-off-by: Giulio Benetti --- configs/imxrt1050-evk_defconfig | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configs/imxrt1050-evk_defconfig b/configs/imxrt1050-evk_defconfig index

Re: [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot

2021-05-20 Thread Sean Anderson
On 5/14/21 5:06 PM, Oleh Kravchenko wrote: The current U-Boot version has the next matches for boot partitions: mmc0boot0 to EMMC_BOOT1 mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2) This patch fixes a typo for the boot partition number. Signed-off-by: Oleh Kravchenko Cc: Pantelis

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Alper Nebi Yasak
On 17/05/2021 16:21, Heinrich Schuchardt wrote: > If you are asked for a sudo password, you have not install libguestfs. > > Please, install the missing package. This also might have ended up not in PATH like mkfs.* weren't in mine, does e.g. "guestmount --version" work from your shell?

[BUG] Re: [PATCH v2 2/2] mmc: mmc-uclass: Use dev_seq() to read aliases node's index

2021-05-20 Thread Heinrich Schuchardt
On 25.03.21 08:18, Aswath Govindraju wrote: > Use dev_seq() to read aliases node's index and pass it as device number > for creating bulk device. > > Suggested-by: Grygorii Strashko > Signed-off-by: Aswath Govindraju > Reviewed-by: Jaehoon Chung Since this patch merged as commit

Re: [BUG] Re: [PATCH v2 2/2] mmc: mmc-uclass: Use dev_seq() to read aliases node's index

2021-05-20 Thread Heinrich Schuchardt
On 20.05.21 18:32, Heinrich Schuchardt wrote: > On 25.03.21 08:18, Aswath Govindraju wrote: >> Use dev_seq() to read aliases node's index and pass it as device number >> for creating bulk device. >> >> Suggested-by: Grygorii Strashko >> Signed-off-by: Aswath Govindraju >> Reviewed-by: Jaehoon

Re: [TF-A] Proposal: TF-A to adopt hand-off blocks (HOBs) for information passing between boot stages

2021-05-20 Thread François Ozog
Le mer. 19 mai 2021 à 23:51, Jeremy Linton via TF-A < t...@lists.trustedfirmware.org> a écrit : > On 5/18/21 8:59 PM, Madhukar Pappireddy via TF-A wrote: > > Hi, > > > > I tried to summarize the discussions in the previous TF-A tech forum > regarding the proposal to adopt Hand-off Blocks (HOBs)

Re: [TF-A] Proposal: TF-A to adopt hand-off blocks (HOBs) for information passing between boot stages

2021-05-20 Thread François Ozog
Le mer. 19 mai 2021 à 03:58, Madhukar Pappireddy via TF-A < t...@lists.trustedfirmware.org> a écrit : > Hi, > > I tried to summarize the discussions in the previous TF-A tech forum > regarding the proposal to adopt Hand-off Blocks (HOBs) for passing > information along the boot chain. I am

RE: [TF-A] Proposal: TF-A to adopt hand-off blocks (HOBs) for information passing between boot stages

2021-05-20 Thread Julian Hall
Hi, My interest in boot information passing is from the perspective of a down-boot-chain consumer. From this perspective, I have the following preferences: 1) Whatever information passing mechanism is used (e.g. HOB or DT), we use a common object identification scheme that may be used with

Re: [TF-A] Proposal: TF-A to adopt hand-off blocks (HOBs) for information passing between boot stages

2021-05-20 Thread Simon Glass
Hi, Re Jeremy's comment: > Using DT to pass platform info at this level is sort of crazy on an ACPI > machine which won't have native DTs. Meaning there is an additional > level of unnecessary indirection that needs to be converted back into a > format which can be utilized by AML and other parts

Re: [PATCH 01/30] clk: renesas: Synchronize RZ/G2 tables with Linux 5.12

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:30 PM Marek Vasut wrote: > > Synchronize RZ/G2 clock tables with Linux 5.12, > commit 9f4ad9e425a1 ("Linux 5.12") . > > Signed-off-by: Marek Vasut > --- > drivers/clk/renesas/r8a774a1-cpg-mssr.c | 14 +- >

Re: [PATCH 07/30] clk: renesas: Add support for RPCD2 clock

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:30 PM Marek Vasut wrote: > > From: Hai Pham > > This supports RPCD2 clock handling. While at it, add the check point > for RPC-IF clock RPCD2 Frequency Division Ratio, since it must be odd > number > > Signed-off-by: Hai Pham >

Re: [BUG] Re: [PATCH v2 2/2] mmc: mmc-uclass: Use dev_seq() to read aliases node's index

2021-05-20 Thread Andre Przywara
On Thu, 20 May 2021 18:32:38 +0200 Heinrich Schuchardt wrote: Hi Heinrich, > On 25.03.21 08:18, Aswath Govindraju wrote: > > Use dev_seq() to read aliases node's index and pass it as device number > > for creating bulk device. > > > > Suggested-by: Grygorii Strashko > > Signed-off-by: Aswath

Re: [PATCH 05/30] clk: renesas: Fix incorrect return RPC clk_get_rate

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:31 PM Marek Vasut wrote: > > From: Hai Pham > > RPC clk_get_rate will return error code instead of expected clock rate. > Fix this. > > Signed-off-by: Hai Pham > Signed-off-by: Marek Vasut > --- >

Re: [PATCH 08/30] clk: renesas: Make reset controller modemr register offset configurable

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:32 PM Marek Vasut wrote: > > The MODEMR register offset changed on R8A779A0, make the MODEMR offset > configurable. Fill the offset in on all clock drivers. No functional > change. > > Based off "clk: renesas: Make CPG Reset MODEMR

Re: [PATCH 11/30] clk: renesas: Add register pointers into struct cpg_mssr_info

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:32 PM Marek Vasut wrote: > > From: Hai Pham > > Base on Linux v5.10-rc2, commit 8b652aa8a1fb by Yoshihiro Shimoda > To support other register layouts in the future, add register pointers > of {control,status,reset,reset_clear}_regs

Re: [PATCH 12/30] clk: renesas: Deduplicate gen3_clk_get_rate64() PLL handling

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:33 PM Marek Vasut wrote: > > Most of the PLLx, MAIN, FIXED clock handlers are calling very similar > code, which determines parent rate and then applies multiplication and > division. The only difference is whether multiplication is

Re: [PATCH 15/30] gpio: renesas: Pass struct udevice to rcar_gpio_set_direction()

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:33 PM Marek Vasut wrote: > > Pass struct udevice to rcar_gpio_set_direction() in preparation of > quirk handling in rcar_gpio_set_direction(). No functional change. > > Signed-off-by: Marek Vasut > --- > drivers/gpio/gpio-rcar.c |

Re: [PATCH 20/30] pinctrl: renesas: Implement unlock register masks

2021-05-20 Thread Lad, Prabhakar
Hi Marek, Thank you for the patch. On Wed, Apr 28, 2021 at 8:33 PM Marek Vasut wrote: > > The V3U SoC has several unlock registers, one per register group. They > reside at offset zero in each 0x200 bytes-sized block. > > To avoid adding yet another table to the PFC implementation, this > patch

Re: [PATCH u-boot v4 17/36] sandbox: use sections instead of symbols for getopt array boundaries

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > In style of linked lists, instead of declaring symbols for boundaries > of getopt options array in the linker script, declare corresponding > sections and retrieve the boundaries via static inline functions. > > Without this clang's LTO

Re: [PATCH 06/18] image: Drop IMAGE_ENABLE_SHA1

2021-05-20 Thread Simon Glass
Hi Alex, On Wed, 19 May 2021 at 20:41, Alex G. wrote: > > > > On 5/19/21 4:55 PM, Simon Glass wrote: > > Hi Alex, > > > > On Wed, 19 May 2021 at 11:44, Alex G wrote: > >> > >> > >> > >> On 5/19/21 11:36 AM, Simon Glass wrote: > >>> Hi Alexandru, > >>> > >>> On Mon, 17 May 2021 at 10:38,

Re: [PATCH u-boot v4 15/36] build: link with --build-id=none

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > Some toolchains are compiled so that they pass a --build-id=something > parameter to the linker implicitly. > > This causes U-Boot LTO linking to fail with something like: > ld: section .note.gnu.build-id LMA ... overlaps section .text LMA

Re: [PATCH u-boot v4 20/36] ARM: global_data: make set_gd() work for armv5 and armv6

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > The Thumb instruction `ldr` is able to move high registers only from > armv7. For armv5 and armv6 we have to use `mov`. > > Signed-off-by: Marek Behún > --- > arch/arm/include/asm/global_data.h | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH u-boot v4 21/36] ARM: make gd a function call for LTO and set via set_gd()

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > On ARM, the gd pointer is stored in registers r9 / x18. For this the > -ffixed-r9 / -ffixed-x18 flag is used when compiling, but using global > register variables causes errors when building with LTO, and these > errors are very difficult to

Re: [PATCH u-boot v4 06/36] string: make memcpy(), memset(), memcmp() and memmove() visible for LTO

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > It seems that sometimes (happening on ARM64, for example with > turris_mox_defconfig) GCC, when linking with LTO, changes the symbol > names of some functions, for example lib/string.c's memcpy() function to > memcpy.isra.0. > > This is a

Re: [PATCH u-boot v4 05/36] test/py: improve regular expression for ut subtest symbol matcher

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > Improve the regular expression that matches unittest symbols in > u-boot.sym. > > Currently we do not enforce no prefix in symbol string, but with the > soon to come change in linker lists declaring lists and entries with the > __ADDRESSABLE

Re: [PATCH u-boot v4 02/36] checkpatch: require quotes around section name in the __section() macro

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > This is how Linux does this now, see Linux commit 339f29d91acf. > > Signed-off-by: Marek Behún > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH u-boot v4 28/36] ARM: fix LTO for seaboard

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > When seaboard_defconfig is compiled with LTO, the compiler complains > about some instructions not being supported in ARM mode. > > This is caused by arch/arm/mach-tegra/tegra20/warmboot_avp.c having > different CFLAGS declared in Makefile.

Re: [PATCH] spl: Kconfig: Use tabs instead of space for alignment

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:08, Michal Simek wrote: > > A lot of entries were using spaces instead of tab for alignment that's why > it is good to fix it to use the same style everywhere. > > Signed-off-by: Michal Simek > --- > > common/spl/Kconfig | 24 > 1 file changed,

Re: [PATCH u-boot v4 01/36] regmap: fix a serious pointer casting bug

2021-05-20 Thread Marek Behun
> I don't see a changelog here but this is v4. Are you using patman? Changelog is in cover letter. Unfortunately I am not using patman yet. Marek

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-20 Thread Heinrich Schuchardt
Am 20. Mai 2021 21:33:42 MESZ schrieb Alper Nebi Yasak : >On 17/05/2021 16:21, Heinrich Schuchardt wrote: >> If you are asked for a sudo password, you have not install >libguestfs. >> >> Please, install the missing package. > >This also might have ended up not in PATH like mkfs.* weren't in

Re: [PATCH u-boot v4 01/36] regmap: fix a serious pointer casting bug

2021-05-20 Thread Simon Glass
Hi Marek, On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > There is a serious bug in regmap_read() and regmap_write() functions > where an uint pointer is cast to (void *) which is then cast to (u8 *), > (u16 *), (u32 *) or (u64 *), depending on register width of the map. > > For example

Re: [PATCH 1/5] lib/vsprintf.c: make sure vsnprintf() never returns a negative value

2021-05-20 Thread Simon Glass
Hi Rasmus, On Thu, 20 May 2021 at 04:05, Rasmus Villemoes wrote: > > Most callers (or callers of callers, etc.) of vsnprintf() are not > prepared for it to return a negative value. > > The only case where that can currently happen is %pD, and it's IMO > more user-friendly to produce some output

Re: [PATCH u-boot v4 22/36] ARM: fix LTO build for some thumb-interwork cases

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > Fix LTO build for some thumb-interwork usecases (such as for > da850evm_defconfig), where inline assmebly such as assembly > mrc p15,0,r2,c1,c0,0 > causes the compiler to fail during LTO linking with > Error: selected processor does not

Re: [PATCH u-boot v4 14/36] build: support building with Link Time Optimizations

2021-05-20 Thread Simon Glass
On Thu, 20 May 2021 at 05:25, Marek Behún wrote: > > Add plumbing for building U-Boot with Link Time Optimizations. > > When building with LTO, $(PLATFORM_LIBS) has to be in --whole-archive / > --no-whole-archive group, otherwise some functions declared in assembly > may not be resolved and

  1   2   >