Re: [PATCH] efi_loader: set partition GUID in device path for SIG_TYPE_GUID

2021-07-18 Thread Heinrich Schuchardt
On 15.07.21 15:31, Alfonso Sánchez-Beato wrote: > Previously, the GPT device GUID was being used instead of the partition, > which was incorrect. > > Signed-off-by: Alfonso Sánchez-Beato > Reviewed-by: Heinrich Schuchardt Building fails on some platforms with

Re: [PATCH] efi_loader: replace board_get_usable_ram_top by gd->ram_top

2021-07-18 Thread Heinrich Schuchardt
On 7/9/21 12:46 PM, Patrick Delaunay wrote: As gd->ram_top = board_get_usable_ram_top() in board_r the EFI loader don't need to call this function again and after relocation. This patch avoid issue if board assumed that this function is called only one time and before relocation. Hello

[PATCH 1/1] efi_loader: select GPT partition support

2021-07-18 Thread Heinrich Schuchardt
The UEFI specification requires support for GPT partition tables. The device path node of GPT partition uses the partition UUID. Let CONFIG_EFI_LOADER select the necessary GPT related configuration settings. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/Kconfig | 3 +++ 1 file changed,

[PATCH 1/1] efi_loader: select GPT partition support

2021-07-18 Thread Heinrich Schuchardt
The UEFI specification requires support for GPT partition tables. The device path node of GPT partition uses the partition UUID. Let CONFIG_EFI_LOADER select the necessary GPT related configuration settings. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/Kconfig | 3 +++ 1 file changed,

Pull request for efi-2021-10-rc1-2

2021-07-18 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474: Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2021-10-rc1-2 for

Re: [PATCH 06/22] Makefile: Avoid rebuilding .dtb files each time

2021-07-18 Thread Masahiro Yamada
On Sun, Jul 18, 2021 at 5:41 AM Simon Glass wrote: > > Drop the FORCE from the rule that builds .dtb files and let the normal > dependency checking do its work. This should work correctly, at least > for .dts files that don't use /include/. > > Signed-off-by: Simon Glass > --- > >

[PATCH] serial: pl011: Resend the character if FIFO is full in debug uart

2021-07-18 Thread Chen Baozi
pl01x_putc() might return -EAGAIN if there was no space in FIFO. In that case, high-level caller should wait until there is space and resend the character. Signed-off-by: Chen Baozi --- drivers/serial/serial_pl01x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] serial: pl011: Enable DEBUG_UART_PL011 in SPL

2021-07-18 Thread Chen Baozi
Commit b81406db51a6 ("arm: serial: Add debug UART capability to the pl01x driver") add supports to use pl01x as a debug UART. However, due to CONFIG_IS_ENABLED macro requires CONFIG_SPL_* prefix, the _debug_uart_init() would not choose TYPE_PL011 in SPL build. This patch fixes the bug by judging

RE: [PATCH V2 10/46] arm: imx8ulp: add container support

2021-07-18 Thread Peng Fan
Hi Stefano, > Subject: Re: [PATCH V2 10/46] arm: imx8ulp: add container support > > Hi peng, Ye, > > On 29.06.21 04:32, Peng Fan (OSS) wrote: > > From: Ye Li > > > > i.MX8ULP support using ROM API to load container image, it use same > > ROM API as i.MX8MN/MP, and use same container format as

Re: [PATCH 16/17] i2c: Rename SPL/TPL_I2C_SUPPORT to I2C

2021-07-18 Thread Heiko Schocher
Hello Simon, On 11.07.21 05:14, Simon Glass wrote: > Rename these options so that CONFIG_IS_ENABLED can be used with them. > > Signed-off-by: Simon Glass > --- > > arch/arm/cpu/armv8/fsl-layerscape/spl.c| 2 +- > arch/arm/mach-omap2/Kconfig| 6 +++--- >

Re: [PATCH 15/17] i2c: Create a new Kconfig for I2C

2021-07-18 Thread Heiko Schocher
Hello Simon, On 11.07.21 05:14, Simon Glass wrote: > At present we have CONFIG_SPL_I2C but not CONFIG_I2C. The reason > CONFIG_I2C is not strictly necessary is that: > > a) We have CONFIG_SYS_I2C_LEGACY and CONFIG_DM_I2C for the two possible >i2c stacks > b) In U-Boot proper, we always build

[PULL] u-boot-mips

2021-07-18 Thread Daniel Schwierzeck
Gitlab: https://source.denx.de/u-boot/custodians/u-boot-mips/-/pipelines/8294 Azure: https://dev.azure.com/danielschwierzeck/u-boot/_build/results?buildId=25=results The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474: Merge branch

[PATCH v2 10/10] sandbox: tpm: Support extending a PCR multiple times

2021-07-18 Thread Simon Glass
It is fairly easy to handle this case and it makes the emulator more useful, since PCRs are commonly extended several times. Add support for this, using U-Boot's sha256 support. For now sandbox only supports a single PCR, but that is enough for the tests that currently exist. Signed-off-by:

[PATCH v2 06/10] sandbox: tpm: Track whether the state is valid

2021-07-18 Thread Simon Glass
Add checking as to whether the current TPM state is valid, so we can implement reading/writing the state. Signed-off-by: Simon Glass --- (no changes since v1) drivers/tpm/tpm2_tis_sandbox.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH v2 08/10] sandbox: tpm: Support storing device state in tpm2

2021-07-18 Thread Simon Glass
At present the tpm2 emulator does not support storing the device state. Add this so we can handle the normal vboot flow through the sandbox executables (VPL->SPL etc.) with the TPM contents staying in place. Note: sandbox has not yet been converted to use livetree for the state information, since

[PATCH v2 07/10] sandbox: tpm: Support nvdata in TPM2

2021-07-18 Thread Simon Glass
Add support for this feature in the TPM2 emulator, to support Chromium OS vboot. Signed-off-by: Simon Glass --- (no changes since v1) drivers/tpm/tpm2_tis_sandbox.c | 68 ++ include/tpm-v2.h | 2 + 2 files changed, 70 insertions(+) diff --git

[PATCH v2 05/10] sandbox: tpm: Finish comments for struct sandbox_tpm2

2021-07-18 Thread Simon Glass
Tidy up the missing comments for this struct. Signed-off-by: Simon Glass --- (no changes since v1) drivers/tpm/tpm2_tis_sandbox.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm2_tis_sandbox.c index

[PATCH v2 09/10] sandbox: tpm: Correct handling of SANDBOX_TPM_PCR_NB

2021-07-18 Thread Simon Glass
This is the number of PCRs, so the current check is off by one. Also the map itself should not be checked, just the resulting pcr_index, to avoid confusing people who read the code. Fix these problems. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to correct handling of

Re: [PATCH v2 0/6] Convert MIPS Malta boards to PCI DM

2021-07-18 Thread Daniel Schwierzeck
Am Donnerstag, den 15.07.2021, 20:53 +0200 schrieb Daniel Schwierzeck: > This series converts the PCI host controller drivers used by MIPS > Malta and the board-specific PCI setup code to PCI driver model. > Because the AMD PCNET driver is already converted to ETH driver > model, simply enable

[PATCH v2 01/10] sandbox: tpm: Split out common nvdata code

2021-07-18 Thread Simon Glass
We want to support nvdata in TPM2 as well. To avoid code duplicating the associated code, move it into a common file. Drop the special-case logic for the kernel space. This can be handled by the higher-level code now, i.e. in vboot itself. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 02/10] sandbox: tpm: Tidy up reading and writing of device state

2021-07-18 Thread Simon Glass
At present this code assumes that the TPM data has been read but this may not be the case. Refactor the code to use a separate pointer so we know the current state of the data. Add error checking for the data size. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 03/10] sandbox: tpm: Support the define-space command

2021-07-18 Thread Simon Glass
Add support for this command, moving away from the previous approach of hard-coding the initial data in the driver, now that the kernel-space data has to be set up by the higher-level vboot code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/tpm/sandbox_common.c | 11

[PATCH v2 00/10] tpm: Enhance sandbox tpm2 emulation

2021-07-18 Thread Simon Glass
At present the TPM2 emulator lacks the ability to load and save the state. This means it cannot be used for verify-boot flow that includes multiple phases (e.g. VPL and SPL). It also lacks support for non-volatile data storage. This series adds these features to the TPM2 emulator, with some code

[PATCH v2 04/10] sandbox: tpm: Correct handling of get-capability

2021-07-18 Thread Simon Glass
This function current handles the kernel case incorrectly. Fix it, and use the shorter TPM_HDR_LEN while we are here. Signed-off-by: Simon Glass --- (no changes since v1) drivers/tpm/tpm_tis_sandbox.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

[PATCH v2 1/3] samsung: exynos: Convert SROMC interface to a driver

2021-07-18 Thread Simon Glass
Add a bus driver for this and use it to configure the bus parameters for the Ethernet interface. Drop the old pre-driver-model code. Switch over to use driver model for Ethernet. Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung --- (no changes since v1) arch/arm/Kconfig

Re: [PULL] u-boot-mips

2021-07-18 Thread Tom Rini
On Sun, Jul 18, 2021 at 10:04:26PM +0200, Daniel Schwierzeck wrote: > Gitlab: > https://source.denx.de/u-boot/custodians/u-boot-mips/-/pipelines/8294 > > Azure: > > https://dev.azure.com/danielschwierzeck/u-boot/_build/results?buildId=25=results > > > The following changes since commit

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

2021-07-18 Thread Tom Rini
On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich Schuchardt wrote: > On 7/18/21 10:14 PM, Simon Glass wrote: > > At present we use wide characters for unicode but this is not necessary. > > Change the code to use the 'u' literal instead. This helps to fix build > > warnings for sandbox on rpi. >

[PATCH v2 2/3] test: Fix size_t formats in strlcat test

2021-07-18 Thread Simon Glass
Some of the printf() formats do not match their types. Fix this. Reported-by: Minkyu Kang Signed-off-by: Simon Glass --- Changes in v2: - Fix some size_t warnings with recent compilers test/lib/strlcat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 3/3] snow: Enable unit tests

2021-07-18 Thread Simon Glass
It is useful to have a board with unit tests enabled, to check that this does not break. Let's choose snow, since it is not under active development and it is glorious. Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung --- (no changes since v1) configs/snow_defconfig | 2 ++ 1 file

Re: [PATCH 14/17] i2c: Drop unused CONFIG_I2C

2021-07-18 Thread Heiko Schocher
Hello Simon, On 11.07.21 05:14, Simon Glass wrote: > This actually does nothing but is defined by a few dozen boards. Drop it, > so we can define a real one. > > Signed-off-by: Simon Glass > --- > > include/configs/bur_am335x_common.h| 1 - > include/configs/siemens-am33x-common.h | 1 - >

Re: [PATCH 12/17] i2c: Rename CONFIG_SYS_I2C to CONFIG_SYS_I2C_LEGACY

2021-07-18 Thread Heiko Schocher
Hello Simon, On 11.07.21 05:14, Simon Glass wrote: > It is quite confusing that CONFIG_SYS_I2C selects the legacy I2C and > CONFIG_DM_I2C selects the current I2C. The deadline to migrate I2C is less > than a year away. > > Also we want to have a CONFIG_I2C for U-Boot proper just like we have >

Re: [PATCH 13/17] i2c: Fix the migration warning

2021-07-18 Thread Heiko Schocher
Hello Simon, On 11.07.21 05:14, Simon Glass wrote: > While there is a CONFIG_I2C it does not really mean anything and is > defined by only a few dozen boards. This should key off > CONFIG_SYS_I2C_LEGACY instead. > > Fix it. > > Signed-off-by: Simon Glass > --- > > Makefile | 2 +- > 1 file

Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-07-18 Thread Heiko Schocher
Hi Tim, Simon, On 13.07.21 22:17, Simon Glass wrote: > Hi Tim, > > On Mon, 12 Jul 2021 at 14:58, Tim Harvey wrote: >> >> On Mon, Jul 12, 2021 at 12:44 PM Simon Glass wrote: >>> >>> Hi Tim, >>> >>> On Mon, 12 Jul 2021 at 10:42, Tim Harvey wrote: On Sat, Jul 10, 2021 at 5:23 AM Heiko

[PATCH v2 0/5] Fix compiler warnings for 32-bit ARM

2021-07-18 Thread Simon Glass
These were noticed when building sandbox on a Raspberry Pi 400, which uses 32-bit linux. To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It would be nice if that were automatic, since we have the logic already in arch/sandbox/config.mk So this series adds that. It also

Re: IMX8M Mini HAB secure boot - working?

2021-07-18 Thread Heiko Schocher
Hello Tim, On 12.07.21 18:06, Tim Harvey wrote: > On Sat, Jul 10, 2021 at 5:24 AM Heiko Schocher wrote: >> >> Hi Tim, Stefano, >> >> On 10.07.21 11:14, Stefano Babic wrote: >>> Hi Tim, >>> >>> On 10.07.21 02:05, Tim Harvey wrote: Greetings, Has anyone successfully used secure boot

Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

2021-07-18 Thread Heiko Schocher
Hello Tim, On 12.07.21 18:42, Tim Harvey wrote: > On Sat, Jul 10, 2021 at 5:23 AM Heiko Schocher wrote: >> >> Hello Tim, >> >> On 09.07.21 16:47, Tim Harvey wrote: >>> On Wed, Jul 7, 2021 at 5:58 AM Teresa Remmet wrote: Factor out the common node settings for dm-spl and dm-pre-reloc

[PATCH v2 4/5] efi: Use 16-bit unicode strings

2021-07-18 Thread Simon Glass
At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt --- (no changes since v1) include/efi_loader.h

[PATCH v2 3/5] doc: sandbox: Fix up dependencies

2021-07-18 Thread Simon Glass
These are out of date. Update them and point to the existing build instructions to avoid duplication. Add a few that are missing. Signed-off-by: Simon Glass --- Changes in v2: - Add python3-pycryptodome also, for test_fit_ecdsa.py doc/arch/sandbox.rst | 6 +- doc/build/gcc.rst| 6

[PATCH v2 2/5] pci: swap_case: Allow compilation on 32-bit machines

2021-07-18 Thread Simon Glass
At present this driver assumes that ulong is 64-bits long. On 32-bit machines it is not. Use the 64-bit code only on 64-bit machines. This makes things work correctly on 32-bit machines. Signed-off-by: Simon Glass --- Changes in v2: - Update commit message to indicate that things work now

[PATCH v2 5/5] sandbox: Detect the host bit size automatically

2021-07-18 Thread Simon Glass
At present if you build sandbox on a 32-bit host a lot of errors are produced. This is because CONFIG_HOST_64BIT is enabled by default. It is quite annoying to have to change that manually before building sandbox. It is also quite confusing for new users. Add a way to detect the setting and add

[PATCH v2 1/5] checkpatch: Support wide strings

2021-07-18 Thread Simon Glass
From: Joe Perches Allow prefixing typical strings with L for wide strings and u for unicode strings. Signed-off-by: Joe Perches Signed-off-by: Simon Glass --- This was found on LKML: https://lore.kernel.org/lkml/1508280192.6530.31.ca...@perches.com/T/ It likely wasn't applied because it did

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

2021-07-18 Thread Heinrich Schuchardt
On 7/19/21 3:01 AM, Tom Rini wrote: On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich Schuchardt wrote: On 7/18/21 10:14 PM, Simon Glass wrote: At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build

[PATCH] Makefile: Remove DM_VIDEO and DM_SPI_FLASH checks

2021-07-18 Thread Tom Rini
As we have now completed the DM_VIDEO and DM_SPI_FLASH migrations we can remove the checks. Signed-off-by: Tom Rini --- Makefile | 4 1 file changed, 4 deletions(-) diff --git a/Makefile b/Makefile index 9fac1a02ca6e..ca2432c8ce9d 100644 --- a/Makefile +++ b/Makefile @@ -1125,10 +1125,6

[PATCH] lib: rsa: Extract public key from private key if keyfile argument is used

2021-07-18 Thread Chan, Donald
If the 'keyfile' (-G) argument is used, there is little value to require 'keydir' (-k) argument since the public key can also be extracted from the private key itself. Signed-off-by: Donald Chan --- lib/rsa/rsa-sign.c | 28 +--- 1 file changed, 21 insertions(+), 7

Re: Pull request for efi-2021-10-rc1-2

2021-07-18 Thread Tom Rini
On Sun, Jul 18, 2021 at 03:56:05PM +0200, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit f929ce50727bf1019323d6c199dfd3a5755c5474: > > Merge branch '2021-07-16-cleanup-image-support' (2021-07-17 11:39:50 > -0400) > > are available in the Git repository at: > >

Re: [PATCH v2 5/5] sandbox: Detect the host bit size automatically

2021-07-18 Thread Heinrich Schuchardt
On 7/18/21 10:14 PM, Simon Glass wrote: At present if you build sandbox on a 32-bit host a lot of errors are produced. This is because CONFIG_HOST_64BIT is enabled by default. It is quite annoying to have to change that manually before building sandbox. It is also quite confusing for new users.

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

2021-07-18 Thread Tom Rini
On Mon, Jul 19, 2021 at 03:07:50AM +0200, Heinrich Schuchardt wrote: > On 7/19/21 3:01 AM, Tom Rini wrote: > > On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich Schuchardt wrote: > > > On 7/18/21 10:14 PM, Simon Glass wrote: > > > > At present we use wide characters for unicode but this is not

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

2021-07-18 Thread Heinrich Schuchardt
On 7/18/21 10:14 PM, Simon Glass wrote: At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt According to

[GIT PULL] TI changes for v2021.10-rc1

2021-07-18 Thread Lokesh Vutla
Hi Tom, Please find the PR for master branch targeted for v2021.10-rc1 tag. Details about the PR are updated in the tag message. Gitlab CI report: https://source.denx.de/u-boot/custodians/u-boot-ti/-/pipelines/8254 The following changes since commit

Re: [PATCH] Nokia RX-51: Update documentation about flashing

2021-07-18 Thread Lokesh Vutla
Hi, On 18/06/21 6:59 pm, Pali Rohár wrote: > This change contains update for doc/README.nokia_rx51 documentation file > with information how to load U-Boot image to device RAM without need to > flash it and also how to flash it into OneNAND via 0x flasher. > > Signed-off-by: Pali Rohár Can